outstanding patches
Hi, I was wondering if somebody could review/commit the following patches I submitted: 1) https://issues.apache.org/jira/browse/GERONIMO-2825 2) https://issues.apache.org/jira/browse/GERONIMO-2826 3) https://issues.apache.org/jira/browse/GERONIMO-2830 4) https://issues.apache.org/jira/browse/GERONIMO-2836 5) https://issues.apache.org/jira/browse/GERONIMO-2840 Most of them are pretty small so should be easy to review. Thanks, Jarek
Re: outstanding patches
Am on it! sorry for the delay. -- dims On 2/15/07, Jarek Gawor <[EMAIL PROTECTED]> wrote: Hi, I was wondering if somebody could review/commit the following patches I submitted: 1) https://issues.apache.org/jira/browse/GERONIMO-2825 2) https://issues.apache.org/jira/browse/GERONIMO-2826 3) https://issues.apache.org/jira/browse/GERONIMO-2830 4) https://issues.apache.org/jira/browse/GERONIMO-2836 5) https://issues.apache.org/jira/browse/GERONIMO-2840 Most of them are pretty small so should be easy to review. Thanks, Jarek -- Davanum Srinivas :: http://wso2.org/ :: Oxygen for Web Services Developers
Re: outstanding patches
No problem and thanks for committing these! Jarek On 2/15/07, Davanum Srinivas <[EMAIL PROTECTED]> wrote: Am on it! sorry for the delay. -- dims On 2/15/07, Jarek Gawor <[EMAIL PROTECTED]> wrote: > Hi, > > I was wondering if somebody could review/commit the following patches > I submitted: > > 1) https://issues.apache.org/jira/browse/GERONIMO-2825 > 2) https://issues.apache.org/jira/browse/GERONIMO-2826 > 3) https://issues.apache.org/jira/browse/GERONIMO-2830 > 4) https://issues.apache.org/jira/browse/GERONIMO-2836 > 5) https://issues.apache.org/jira/browse/GERONIMO-2840 > > Most of them are pretty small so should be easy to review. > > Thanks, > Jarek > -- Davanum Srinivas :: http://wso2.org/ :: Oxygen for Web Services Developers
outstanding patches II
Hi, I would be very grateful if somebody could review/commit the following patches before Wednesday: 1) https://issues.apache.org/jira/browse/GERONIMO-2849 (app client test for ws) 2) https://issues.apache.org/jira/browse/GERONIMO-2850 (initial ejb support for ws) Thanks, Jarek
[devtools] created subproject in svn, applied outstanding patches to sandbox, and copied code into subproject
SVN repo : https://svn.apache.org/repos/asf/geronimo/devtools/trunk/modules/ eclipse-plugin I want to delete from sandbox, but will wait to see if anyone has a problem, comment or suggestion. Sachin? geir -- Geir Magnusson Jr +1-203-665-6437 [EMAIL PROTECTED]
Re: [devtools] created subproject in svn, applied outstanding patches to sandbox, and copied code into subproject
The copy to devtools looks good. Its fine with me if you delete from sandbox. Sachin Geir Magnusson Jr. wrote: SVN repo : https://svn.apache.org/repos/asf/geronimo/devtools/trunk/modules/ eclipse-plugin I want to delete from sandbox, but will wait to see if anyone has a problem, comment or suggestion. Sachin? geir
Re: [devtools] created subproject in svn, applied outstanding patches to sandbox, and copied code into subproject
Rather then throwing everything in the "eclipse-plugin" folder could we organize the contents down into the following structure? A .../trunk/modules/eclipse/plugins/ folder that contains the following projects... org.apache.geronimo.core org.apache.geronimo.ui org.apache.geronimo.deployment.model org.apache.geronimo.runtime.v1 A .../trunk/modules/eclipse/features/ folder that contains the following projects... org.apache.geronimo.feature Then the .../trunk/modules/eclipse/ folder itself would contain everything else like the top level maven.xml, the "assembly" project I'm about to submit, a project containing parent POM's, etc... What do you think? Sachin. Sachin Patel wrote: The copy to devtools looks good. Its fine with me if you delete from sandbox. Sachin Geir Magnusson Jr. wrote: SVN repo : https://svn.apache.org/repos/asf/geronimo/devtools/trunk/modules/ eclipse-plugin I want to delete from sandbox, but will wait to see if anyone has a problem, comment or suggestion. Sachin? geir
Re: [devtools] created subproject in svn, applied outstanding patches to sandbox, and copied code into subproject
Sachin Patel wrote: Rather then throwing everything in the "eclipse-plugin" folder could we organize the contents down into the following structure? A .../trunk/modules/eclipse/plugins/ folder that contains the following projects... org.apache.geronimo.core org.apache.geronimo.ui org.apache.geronimo.deployment.model org.apache.geronimo.runtime.v1 A .../trunk/modules/eclipse/features/ folder that contains the following projects... org.apache.geronimo.feature Then the .../trunk/modules/eclipse/ folder itself would contain everything else like the top level maven.xml, the "assembly" project I'm about to submit, a project containing parent POM's, etc... What do you think? Do we need to avoid confusion with other Geronimo modules (e.g. "core")? Would org.apache.geronimo.eclipse.feature org.apache.geronimo.eclipse.core be less confusing? -- Jeremy
Re: [devtools] created subproject in svn, applied outstanding patches to sandbox, and copied code into subproject
On Sep 6, 2005, at 4:51 PM, Sachin Patel wrote: Rather then throwing everything in the "eclipse-plugin" folder could we organize the contents down into the following structure? Hopefully by the end of today ;) you can do this any way you darn well please. :) A .../trunk/modules/eclipse/plugins/ folder that contains the following projects... org.apache.geronimo.core org.apache.geronimo.ui org.apache.geronimo.deployment.model org.apache.geronimo.runtime.v1 A .../trunk/modules/eclipse/features/ folder that contains the following projects... org.apache.geronimo.feature Then the .../trunk/modules/eclipse/ folder itself would contain everything else like the top level maven.xml, the "assembly" project I'm about to submit, a project containing parent POM's, etc... What do you think? Sachin. Sachin Patel wrote: The copy to devtools looks good. Its fine with me if you delete from sandbox. Sachin Geir Magnusson Jr. wrote: SVN repo : https://svn.apache.org/repos/asf/geronimo/devtools/trunk/modules/ eclipse-plugin I want to delete from sandbox, but will wait to see if anyone has a problem, comment or suggestion. Sachin? geir -- Geir Magnusson Jr +1-203-665-6437 [EMAIL PROTECTED]
Re: [devtools] created subproject in svn, applied outstanding patches to sandbox, and copied code into subproject
On Sep 6, 2005, at 4:58 PM, Jeremy Boynes wrote: Sachin Patel wrote: Rather then throwing everything in the "eclipse-plugin" folder could we organize the contents down into the following structure? A .../trunk/modules/eclipse/plugins/ folder that contains the following projects... org.apache.geronimo.core org.apache.geronimo.ui org.apache.geronimo.deployment.model org.apache.geronimo.runtime.v1 A .../trunk/modules/eclipse/features/ folder that contains the following projects... org.apache.geronimo.feature Then the .../trunk/modules/eclipse/ folder itself would contain everything else like the top level maven.xml, the "assembly" project I'm about to submit, a project containing parent POM's, etc... What do you think? Do we need to avoid confusion with other Geronimo modules (e.g. "core")? Would org.apache.geronimo.eclipse.feature org.apache.geronimo.eclipse.core be less confusing? I think that's a good idea. I don't know if we want to toss in something to represent the subproject (devtools). Helps separate the namespaces, but then also is goofy if it changes. geir -- Jeremy -- Geir Magnusson Jr +1-203-665-6437 [EMAIL PROTECTED]
Re: [devtools] created subproject in svn, applied outstanding patches to sandbox, and copied code into subproject
On Sep 6, 2005, at 1:58 PM, Jeremy Boynes wrote: Sachin Patel wrote: Rather then throwing everything in the "eclipse-plugin" folder could we organize the contents down into the following structure? A .../trunk/modules/eclipse/plugins/ folder that contains the following projects... org.apache.geronimo.core org.apache.geronimo.ui org.apache.geronimo.deployment.model org.apache.geronimo.runtime.v1 A .../trunk/modules/eclipse/features/ folder that contains the following projects... org.apache.geronimo.feature Then the .../trunk/modules/eclipse/ folder itself would contain everything else like the top level maven.xml, the "assembly" project I'm about to submit, a project containing parent POM's, etc... What do you think? Do we need to avoid confusion with other Geronimo modules (e.g. "core")? Would org.apache.geronimo.eclipse.feature org.apache.geronimo.eclipse.core be less confusing? +1 David
Re: [devtools] created subproject in svn, applied outstanding patches to sandbox, and copied code into subproject
Yes we could change the project names to distinguish. Since all the eclipse plugins start with org.eclipse.*, should we avoid using another organization name in the title?, what about org.apache.geronimo.tools.core? If having both eclipse and apache in the plugin name isn't a problem then we can go with eclipse. Or another idea would be to change the artifact's groupID to from "geronimo" to "geronimo-devtools" same as the subproject name so that they are distinusished in the repo. Sachin Jeremy Boynes wrote: Sachin Patel wrote: Rather then throwing everything in the "eclipse-plugin" folder could we organize the contents down into the following structure? A .../trunk/modules/eclipse/plugins/ folder that contains the following projects... org.apache.geronimo.core org.apache.geronimo.ui org.apache.geronimo.deployment.model org.apache.geronimo.runtime.v1 A .../trunk/modules/eclipse/features/ folder that contains the following projects... org.apache.geronimo.feature Then the .../trunk/modules/eclipse/ folder itself would contain everything else like the top level maven.xml, the "assembly" project I'm about to submit, a project containing parent POM's, etc... What do you think? Do we need to avoid confusion with other Geronimo modules (e.g. "core")? Would org.apache.geronimo.eclipse.feature org.apache.geronimo.eclipse.core be less confusing? -- Jeremy
Re: [devtools] created subproject in svn, applied outstanding patches to sandbox, and copied code into subproject
On Sep 6, 2005, at 5:29 PM, Sachin Patel wrote: Yes we could change the project names to distinguish. Since all the eclipse plugins start with org.eclipse.*, should we avoid using another organization name in the title?, what about org.apache.geronimo.tools.core? If having both eclipse and apache in the plugin name isn't a problem then we can go with eclipse. There's no problems in using eclipse in the namespace as well as apache... Or another idea would be to change the artifact's groupID to from "geronimo" to "geronimo-devtools" same as the subproject name so that they are distinusished in the repo. yes, we should certainly do that or actually help keep good practice... org.apache.geronimo.devtools Sachin Jeremy Boynes wrote: Sachin Patel wrote: Rather then throwing everything in the "eclipse-plugin" folder could we organize the contents down into the following structure? A .../trunk/modules/eclipse/plugins/ folder that contains the following projects... org.apache.geronimo.core org.apache.geronimo.ui org.apache.geronimo.deployment.model org.apache.geronimo.runtime.v1 A .../trunk/modules/eclipse/features/ folder that contains the following projects... org.apache.geronimo.feature Then the .../trunk/modules/eclipse/ folder itself would contain everything else like the top level maven.xml, the "assembly" project I'm about to submit, a project containing parent POM's, etc... What do you think? Do we need to avoid confusion with other Geronimo modules (e.g. "core")? Would org.apache.geronimo.eclipse.feature org.apache.geronimo.eclipse.core be less confusing? -- Jeremy -- Geir Magnusson Jr +1-203-665-6437 [EMAIL PROTECTED]
Re: [devtools] created subproject in svn, applied outstanding patches to sandbox, and copied code into subproject
Sachin Patel wrote: Yes we could change the project names to distinguish. Since all the eclipse plugins start with org.eclipse.*, should we avoid using another organization name in the title?, what about org.apache.geronimo.tools.core? I'd rather prefer org.apache.geronimo.eclipse.core without the tools package. I think o.a.g.devtools.eclipse seems to me unnecessary long. Sachin Jacek
Re: [devtools] created subproject in svn, applied outstanding patches to sandbox, and copied code into subproject
Thats sounds good, I'll change to *eclipse.core as well as move the artifacts out of the geronimo group. Jacek Laskowski wrote: Sachin Patel wrote: Yes we could change the project names to distinguish. Since all the eclipse plugins start with org.eclipse.*, should we avoid using another organization name in the title?, what about org.apache.geronimo.tools.core? I'd rather prefer org.apache.geronimo.eclipse.core without the tools package. I think o.a.g.devtools.eclipse seems to me unnecessary long. Sachin Jacek
Re: [devtools] created subproject in svn, applied outstanding patches to sandbox, and copied code into subproject
On Sep 7, 2005, at 7:51 AM, Jacek Laskowski wrote: Sachin Patel wrote: Yes we could change the project names to distinguish. Since all the eclipse plugins start with org.eclipse.*, should we avoid using another organization name in the title?, what about org.apache.geronimo.tools.core? I'd rather prefer org.apache.geronimo.eclipse.core without the tools package. I think o.a.g.devtools.eclipse seems to me unnecessary long. It is, but avoids the chance of a namespace collision later... geir Sachin Jacek -- Geir Magnusson Jr +1-203-665-6437 [EMAIL PROTECTED]
Re: [devtools] created subproject in svn, applied outstanding patches to sandbox, and copied code into subproject
Geir Magnusson Jr wrote: It is, but avoids the chance of a namespace collision later... You're right. In the age of IDEs, it shouldn't be a problem, either. I can't however persuade myself that o.a.g.devtools.eclipse is better than o.a.g.tools.eclipse ;) geir Jacek
Re: [devtools] created subproject in svn, applied outstanding patches to sandbox, and copied code into subproject
On Sep 7, 2005, at 8:53 AM, Jacek Laskowski wrote: Geir Magnusson Jr wrote: It is, but avoids the chance of a namespace collision later... You're right. In the age of IDEs, it shouldn't be a problem, either. I can't however persuade myself that o.a.g.devtools.eclipse is better than o.a.g.tools.eclipse ;) LOL. True, it's longer. But it does reflect the name of the subproject.. that's the only reason why I suggested it... geir Jacek -- Geir Magnusson Jr +1-203-665-6437 [EMAIL PROTECTED]
Re: [devtools] created subproject in svn, applied outstanding patches to sandbox, and copied code into subproject
I'd agree with devtools...there could be a variety of others and the grouping makes sense. - Matt Geir Magnusson Jr wrote: On Sep 6, 2005, at 5:29 PM, Sachin Patel wrote: Yes we could change the project names to distinguish. Since all the eclipse plugins start with org.eclipse.*, should we avoid using another organization name in the title?, what about org.apache.geronimo.tools.core? If having both eclipse and apache in the plugin name isn't a problem then we can go with eclipse. There's no problems in using eclipse in the namespace as well as apache... Or another idea would be to change the artifact's groupID to from "geronimo" to "geronimo-devtools" same as the subproject name so that they are distinusished in the repo. yes, we should certainly do that or actually help keep good practice... org.apache.geronimo.devtools Sachin Jeremy Boynes wrote: Sachin Patel wrote: Rather then throwing everything in the "eclipse-plugin" folder could we organize the contents down into the following structure? A .../trunk/modules/eclipse/plugins/ folder that contains the following projects... org.apache.geronimo.core org.apache.geronimo.ui org.apache.geronimo.deployment.model org.apache.geronimo.runtime.v1 A .../trunk/modules/eclipse/features/ folder that contains the following projects... org.apache.geronimo.feature Then the .../trunk/modules/eclipse/ folder itself would contain everything else like the top level maven.xml, the "assembly" project I'm about to submit, a project containing parent POM's, etc... What do you think? Do we need to avoid confusion with other Geronimo modules (e.g. "core")? Would org.apache.geronimo.eclipse.feature org.apache.geronimo.eclipse.core be less confusing? -- Jeremy
