Re: svn commit: r906902 - in /geronimo/specs/trunk: geronimo-atinject_1.0_spec/src/main/java/javax/inject/ geronimo-el_2.2_spec/src/main/java/javax/el/ geronimo-jcdi_1.0_spec/ geronimo-jcdi_1.0_spec/s

2010-10-20 Thread Ivan 
I went ahead to commit the changes of
*GERONIMO-5657https://issues.apache.org/jira/browse/GERONIMO-5657
*
If any problem, please figure it out, thanks.

2010/10/20 Ivan xhh...@gmail.com

 I found some changes have been done to the el package, From the comments,
 the changes are for jcdi and atinject, is it also required by the signature
 testing ? IMO, the changes should not be required.
 Thanks.

 2010/2/5 rickmcgu...@apache.org

 Author: rickmcguire
 Date: Fri Feb  5 11:23:22 2010
 New Revision: 906902

 URL: http://svn.apache.org/viewvc?rev=906902view=rev
 Log:
 GERONIMO-5121 Update geronimo-jcdi and geronimo-atinject to pass TCK
 Signature Tests

 Patch provided by Gurkan Erdogdu


 Modified:

  
 geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Inject.java

  
 geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Named.java

  
 geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Qualifier.java

  
 geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Scope.java

  
 geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Singleton.java

  
 geronimo/specs/trunk/geronimo-el_2.2_spec/src/main/java/javax/el/CompositeELResolver.java
geronimo/specs/trunk/geronimo-jcdi_1.0_spec/pom.xml

  
 geronimo/specs/trunk/geronimo-jcdi_1.0_spec/src/main/java/javax/enterprise/context/BusyConversationException.java

  
 geronimo/specs/trunk/geronimo-jcdi_1.0_spec/src/main/java/javax/enterprise/context/ContextException.java

  
 geronimo/specs/trunk/geronimo-jcdi_1.0_spec/src/main/java/javax/enterprise/context/ContextNotActiveException.java

  
 geronimo/specs/trunk/geronimo-jcdi_1.0_spec/src/main/java/javax/enterprise/context/NonexistentConversationException.java

  
 geronimo/specs/trunk/geronimo-jcdi_1.0_spec/src/main/java/javax/enterprise/event/ObserverException.java

  
 geronimo/specs/trunk/geronimo-jcdi_1.0_spec/src/main/java/javax/enterprise/inject/AmbiguousResolutionException.java

  
 geronimo/specs/trunk/geronimo-jcdi_1.0_spec/src/main/java/javax/enterprise/inject/CreationException.java

  
 geronimo/specs/trunk/geronimo-jcdi_1.0_spec/src/main/java/javax/enterprise/inject/IllegalProductException.java

  
 geronimo/specs/trunk/geronimo-jcdi_1.0_spec/src/main/java/javax/enterprise/inject/InjectionException.java

  
 geronimo/specs/trunk/geronimo-jcdi_1.0_spec/src/main/java/javax/enterprise/inject/ResolutionException.java

  
 geronimo/specs/trunk/geronimo-jcdi_1.0_spec/src/main/java/javax/enterprise/inject/UnproxyableResolutionException.java

  
 geronimo/specs/trunk/geronimo-jcdi_1.0_spec/src/main/java/javax/enterprise/inject/UnsatisfiedResolutionException.java

  
 geronimo/specs/trunk/geronimo-jcdi_1.0_spec/src/main/java/javax/enterprise/inject/spi/InterceptionType.java

  
 geronimo/specs/trunk/geronimo-jcdi_1.0_spec/src/main/java/javax/enterprise/inject/spi/SessionBeanType.java

 Modified:
 geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Inject.java
 URL:
 http://svn.apache.org/viewvc/geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Inject.java?rev=906902r1=906901r2=906902view=diff

 ==
 ---
 geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Inject.java
 (original)
 +++
 geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Inject.java
 Fri Feb  5 11:23:22 2010
 @@ -30,9 +30,9 @@
  import java.lang.annotation.RetentionPolicy;
  import java.lang.annotation.Target;

 -...@documented

  
 @Target(value={ElementType.METHOD,ElementType.CONSTRUCTOR,ElementType.FIELD})
  @Retention(value=RetentionPolicy.RUNTIME)
 +...@documented
  public @interface Inject
  {


 Modified:
 geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Named.java
 URL:
 http://svn.apache.org/viewvc/geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Named.java?rev=906902r1=906901r2=906902view=diff

 ==
 ---
 geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Named.java
 (original)
 +++
 geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Named.java
 Fri Feb  5 11:23:22 2010
 @@ -35,9 +35,9 @@
  * given webbeans component, its name is null.
  * /p
  */
 +...@qualifier
  @Documented
  @Retention(value=RetentionPolicy.RUNTIME)
 -...@qualifier
  public @interface Named
  {


 Modified:
 geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Qualifier.java
 URL:
 http://svn.apache.org/viewvc/geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Qualifier.java?rev=906902r1=906901r2=906902view=diff

 ==
 ---

Re: svn commit: r906902 - in /geronimo/specs/trunk: geronimo-atinject_1.0_spec/src/main/java/javax/inject/ geronimo-el_2.2_spec/src/main/java/javax/el/ geronimo-jcdi_1.0_spec/ geronimo-jcdi_1.0_spec/s

2010-10-19 Thread Ivan 
I found some changes have been done to the el package, From the comments,
the changes are for jcdi and atinject, is it also required by the signature
testing ? IMO, the changes should not be required.
Thanks.

2010/2/5 rickmcgu...@apache.org

 Author: rickmcguire
 Date: Fri Feb  5 11:23:22 2010
 New Revision: 906902

 URL: http://svn.apache.org/viewvc?rev=906902view=rev
 Log:
 GERONIMO-5121 Update geronimo-jcdi and geronimo-atinject to pass TCK
 Signature Tests

 Patch provided by Gurkan Erdogdu


 Modified:

  
 geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Inject.java

  
 geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Named.java

  
 geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Qualifier.java

  
 geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Scope.java

  
 geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Singleton.java

  
 geronimo/specs/trunk/geronimo-el_2.2_spec/src/main/java/javax/el/CompositeELResolver.java
geronimo/specs/trunk/geronimo-jcdi_1.0_spec/pom.xml

  
 geronimo/specs/trunk/geronimo-jcdi_1.0_spec/src/main/java/javax/enterprise/context/BusyConversationException.java

  
 geronimo/specs/trunk/geronimo-jcdi_1.0_spec/src/main/java/javax/enterprise/context/ContextException.java

  
 geronimo/specs/trunk/geronimo-jcdi_1.0_spec/src/main/java/javax/enterprise/context/ContextNotActiveException.java

  
 geronimo/specs/trunk/geronimo-jcdi_1.0_spec/src/main/java/javax/enterprise/context/NonexistentConversationException.java

  
 geronimo/specs/trunk/geronimo-jcdi_1.0_spec/src/main/java/javax/enterprise/event/ObserverException.java

  
 geronimo/specs/trunk/geronimo-jcdi_1.0_spec/src/main/java/javax/enterprise/inject/AmbiguousResolutionException.java

  
 geronimo/specs/trunk/geronimo-jcdi_1.0_spec/src/main/java/javax/enterprise/inject/CreationException.java

  
 geronimo/specs/trunk/geronimo-jcdi_1.0_spec/src/main/java/javax/enterprise/inject/IllegalProductException.java

  
 geronimo/specs/trunk/geronimo-jcdi_1.0_spec/src/main/java/javax/enterprise/inject/InjectionException.java

  
 geronimo/specs/trunk/geronimo-jcdi_1.0_spec/src/main/java/javax/enterprise/inject/ResolutionException.java

  
 geronimo/specs/trunk/geronimo-jcdi_1.0_spec/src/main/java/javax/enterprise/inject/UnproxyableResolutionException.java

  
 geronimo/specs/trunk/geronimo-jcdi_1.0_spec/src/main/java/javax/enterprise/inject/UnsatisfiedResolutionException.java

  
 geronimo/specs/trunk/geronimo-jcdi_1.0_spec/src/main/java/javax/enterprise/inject/spi/InterceptionType.java

  
 geronimo/specs/trunk/geronimo-jcdi_1.0_spec/src/main/java/javax/enterprise/inject/spi/SessionBeanType.java

 Modified:
 geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Inject.java
 URL:
 http://svn.apache.org/viewvc/geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Inject.java?rev=906902r1=906901r2=906902view=diff

 ==
 ---
 geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Inject.java
 (original)
 +++
 geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Inject.java
 Fri Feb  5 11:23:22 2010
 @@ -30,9 +30,9 @@
  import java.lang.annotation.RetentionPolicy;
  import java.lang.annotation.Target;

 -...@documented

  @Target(value={ElementType.METHOD,ElementType.CONSTRUCTOR,ElementType.FIELD})
  @Retention(value=RetentionPolicy.RUNTIME)
 +...@documented
  public @interface Inject
  {


 Modified:
 geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Named.java
 URL:
 http://svn.apache.org/viewvc/geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Named.java?rev=906902r1=906901r2=906902view=diff

 ==
 ---
 geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Named.java
 (original)
 +++
 geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Named.java
 Fri Feb  5 11:23:22 2010
 @@ -35,9 +35,9 @@
  * given webbeans component, its name is null.
  * /p
  */
 +...@qualifier
  @Documented
  @Retention(value=RetentionPolicy.RUNTIME)
 -...@qualifier
  public @interface Named
  {


 Modified:
 geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Qualifier.java
 URL:
 http://svn.apache.org/viewvc/geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Qualifier.java?rev=906902r1=906901r2=906902view=diff

 ==
 ---
 geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Qualifier.java
 (original)
 +++
 geronimo/specs/trunk/geronimo-atinject_1.0_spec/src/main/java/javax/inject/Qualifier.java
 Fri Feb  5 11:23:22 2010
 @@ -30,9 +30,9 @@
  import