Re: xbean-reflect changes and potential xbean 5?

[Romain Manni-Bucau]

Thanks David.

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le mar. 2 oct. 2018 à 18:23, David Blevins  a
écrit :

> I think what threw me off was seeing XBEAN-309 updated from 4.10 to 4.11.
> I suspect you moved it only because I hadn't bother to close it, which I
> should.
>
> I've updated it to 4.10 and marked it closed.
>
> -David
>
> > On Oct 2, 2018, at 12:27 AM, Romain Manni-Bucau 
> wrote:
> >
> > No worries, let's tackle this asm7 thing and we can even add other
> features ;)
> >
> > Romain Manni-Bucau
> > @rmannibucau |  Blog | Old Blog | Github | LinkedIn | Book
> >
> >
> > Le mar. 2 oct. 2018 à 00:01, David Blevins  a
> écrit :
> > Apparently I have to worry about becoming senile.  I did an svn log and
> swore I didn't see the commit in there.  It's definitely there.  I think my
> mind has been warped by working with Git too long.
> >
> > Sorry for the noise and thank for the release, sir!
> >
> >
> > --
> > David Blevins
> > http://twitter.com/dblevins
> > http://www.tomitribe.com
> >
> > > On Oct 1, 2018, at 1:10 PM, Romain Manni-Bucau 
> wrote:
> > >
> > > Seems the code is still here - see
> https://github.com/apache/geronimo-xbean/blob/trunk/xbean-reflect/src/main/java/org/apache/xbean/propertyeditor/PropertyEditorRegistry.java
> > >
> > > Le lun. 1 oct. 2018 22:04, Romain Manni-Bucau 
> a écrit :
> > > Hmm, thought i just did what was mentionned in this thread which was
> not about dropping any code but ensuring static usage was kept only for
> compatibility and moving to a not leaking impl.
> > >
> > > Do you have a failling test of the missing feature? - feel free to
> push it with @Ignore ;). I can check tomorrow I think.
> > >
> > > We will release soon the 4.11 with asm7 support - we just need to
> finish to decide if there is a blocker to do asm7 package or not (another
> thread on it).
> > >
> > > Le lun. 1 oct. 2018 20:52, David Blevins  a
> écrit :
> > > > On Aug 8, 2018, at 6:53 PM, David Blevins 
> wrote:
> > > >
> > > > I'd love to do a 4.x release of this code.
> > >
> > > Hey Romain, is there any reason you pulled this code out of the XBean
> 4.10 release?  Ideally we discuss these things as a community before
> tacking action.
> > >
> > > Would you mind if I did a 4.11 with it included?
> > >
> > >
> > >
> > > -David
> > >
> > >
> >
>
>

Re: xbean-reflect changes and potential xbean 5?

[David Blevins]

I think what threw me off was seeing XBEAN-309 updated from 4.10 to 4.11.  I 
suspect you moved it only because I hadn't bother to close it, which I should.

I've updated it to 4.10 and marked it closed.

-David

> On Oct 2, 2018, at 12:27 AM, Romain Manni-Bucau  wrote:
> 
> No worries, let's tackle this asm7 thing and we can even add other features ;)
> 
> Romain Manni-Bucau
> @rmannibucau |  Blog | Old Blog | Github | LinkedIn | Book
> 
> 
> Le mar. 2 oct. 2018 à 00:01, David Blevins  a écrit :
> Apparently I have to worry about becoming senile.  I did an svn log and swore 
> I didn't see the commit in there.  It's definitely there.  I think my mind 
> has been warped by working with Git too long.
> 
> Sorry for the noise and thank for the release, sir!
> 
> 
> --
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
> 
> > On Oct 1, 2018, at 1:10 PM, Romain Manni-Bucau  
> > wrote:
> >
> > Seems the code is still here - see 
> > https://github.com/apache/geronimo-xbean/blob/trunk/xbean-reflect/src/main/java/org/apache/xbean/propertyeditor/PropertyEditorRegistry.java
> >
> > Le lun. 1 oct. 2018 22:04, Romain Manni-Bucau  a 
> > écrit :
> > Hmm, thought i just did what was mentionned in this thread which was not 
> > about dropping any code but ensuring static usage was kept only for 
> > compatibility and moving to a not leaking impl.
> >
> > Do you have a failling test of the missing feature? - feel free to push it 
> > with @Ignore ;). I can check tomorrow I think.
> >
> > We will release soon the 4.11 with asm7 support - we just need to finish to 
> > decide if there is a blocker to do asm7 package or not (another thread on 
> > it).
> >
> > Le lun. 1 oct. 2018 20:52, David Blevins  a écrit :
> > > On Aug 8, 2018, at 6:53 PM, David Blevins  wrote:
> > >
> > > I'd love to do a 4.x release of this code.
> >
> > Hey Romain, is there any reason you pulled this code out of the XBean 4.10 
> > release?  Ideally we discuss these things as a community before tacking 
> > action.
> >
> > Would you mind if I did a 4.11 with it included?
> >
> >
> >
> > -David
> >
> >
> 



signature.asc
Description: Message signed with OpenPGP

Re: xbean-reflect changes and potential xbean 5?

[Romain Manni-Bucau]

No worries, let's tackle this asm7 thing and we can even add other features
;)

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le mar. 2 oct. 2018 à 00:01, David Blevins  a
écrit :

> Apparently I have to worry about becoming senile.  I did an svn log and
> swore I didn't see the commit in there.  It's definitely there.  I think my
> mind has been warped by working with Git too long.
>
> Sorry for the noise and thank for the release, sir!
>
>
> --
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
>
> > On Oct 1, 2018, at 1:10 PM, Romain Manni-Bucau 
> wrote:
> >
> > Seems the code is still here - see
> https://github.com/apache/geronimo-xbean/blob/trunk/xbean-reflect/src/main/java/org/apache/xbean/propertyeditor/PropertyEditorRegistry.java
> >
> > Le lun. 1 oct. 2018 22:04, Romain Manni-Bucau  a
> écrit :
> > Hmm, thought i just did what was mentionned in this thread which was not
> about dropping any code but ensuring static usage was kept only for
> compatibility and moving to a not leaking impl.
> >
> > Do you have a failling test of the missing feature? - feel free to push
> it with @Ignore ;). I can check tomorrow I think.
> >
> > We will release soon the 4.11 with asm7 support - we just need to finish
> to decide if there is a blocker to do asm7 package or not (another thread
> on it).
> >
> > Le lun. 1 oct. 2018 20:52, David Blevins  a
> écrit :
> > > On Aug 8, 2018, at 6:53 PM, David Blevins 
> wrote:
> > >
> > > I'd love to do a 4.x release of this code.
> >
> > Hey Romain, is there any reason you pulled this code out of the XBean
> 4.10 release?  Ideally we discuss these things as a community before
> tacking action.
> >
> > Would you mind if I did a 4.11 with it included?
> >
> >
> >
> > -David
> >
> >
>
>

Re: xbean-reflect changes and potential xbean 5?

[David Blevins]

Apparently I have to worry about becoming senile.  I did an svn log and swore I 
didn't see the commit in there.  It's definitely there.  I think my mind has 
been warped by working with Git too long.

Sorry for the noise and thank for the release, sir!


-- 
David Blevins
http://twitter.com/dblevins
http://www.tomitribe.com

> On Oct 1, 2018, at 1:10 PM, Romain Manni-Bucau  wrote:
> 
> Seems the code is still here - see 
> https://github.com/apache/geronimo-xbean/blob/trunk/xbean-reflect/src/main/java/org/apache/xbean/propertyeditor/PropertyEditorRegistry.java
> 
> Le lun. 1 oct. 2018 22:04, Romain Manni-Bucau  a écrit 
> :
> Hmm, thought i just did what was mentionned in this thread which was not 
> about dropping any code but ensuring static usage was kept only for 
> compatibility and moving to a not leaking impl.
> 
> Do you have a failling test of the missing feature? - feel free to push it 
> with @Ignore ;). I can check tomorrow I think.
> 
> We will release soon the 4.11 with asm7 support - we just need to finish to 
> decide if there is a blocker to do asm7 package or not (another thread on it).
> 
> Le lun. 1 oct. 2018 20:52, David Blevins  a écrit :
> > On Aug 8, 2018, at 6:53 PM, David Blevins  wrote:
> > 
> > I'd love to do a 4.x release of this code.
> 
> Hey Romain, is there any reason you pulled this code out of the XBean 4.10 
> release?  Ideally we discuss these things as a community before tacking 
> action.
> 
> Would you mind if I did a 4.11 with it included?
> 
> 
> 
> -David
> 
> 

Re: xbean-reflect changes and potential xbean 5?

[Romain Manni-Bucau]

Seems the code is still here - see
https://github.com/apache/geronimo-xbean/blob/trunk/xbean-reflect/src/main/java/org/apache/xbean/propertyeditor/PropertyEditorRegistry.java

Le lun. 1 oct. 2018 22:04, Romain Manni-Bucau  a
écrit :

> Hmm, thought i just did what was mentionned in this thread which was not
> about dropping any code but ensuring static usage was kept only for
> compatibility and moving to a not leaking impl.
>
> Do you have a failling test of the missing feature? - feel free to push it
> with @Ignore ;). I can check tomorrow I think.
>
> We will release soon the 4.11 with asm7 support - we just need to finish
> to decide if there is a blocker to do asm7 package or not (another thread
> on it).
>
> Le lun. 1 oct. 2018 20:52, David Blevins  a
> écrit :
>
>> > On Aug 8, 2018, at 6:53 PM, David Blevins 
>> wrote:
>> >
>> > I'd love to do a 4.x release of this code.
>>
>> Hey Romain, is there any reason you pulled this code out of the XBean
>> 4.10 release?  Ideally we discuss these things as a community before
>> tacking action.
>>
>> Would you mind if I did a 4.11 with it included?
>>
>>
>>
>> -David
>>
>>
>>

Re: xbean-reflect changes and potential xbean 5?

[Romain Manni-Bucau]

Hmm, thought i just did what was mentionned in this thread which was not
about dropping any code but ensuring static usage was kept only for
compatibility and moving to a not leaking impl.

Do you have a failling test of the missing feature? - feel free to push it
with @Ignore ;). I can check tomorrow I think.

We will release soon the 4.11 with asm7 support - we just need to finish to
decide if there is a blocker to do asm7 package or not (another thread on
it).

Le lun. 1 oct. 2018 20:52, David Blevins  a écrit :

> > On Aug 8, 2018, at 6:53 PM, David Blevins 
> wrote:
> >
> > I'd love to do a 4.x release of this code.
>
> Hey Romain, is there any reason you pulled this code out of the XBean 4.10
> release?  Ideally we discuss these things as a community before tacking
> action.
>
> Would you mind if I did a 4.11 with it included?
>
>
>
> -David
>
>
>

Re: xbean-reflect changes and potential xbean 5?

[David Blevins]

> On Aug 8, 2018, at 6:53 PM, David Blevins  wrote:
> 
> I'd love to do a 4.x release of this code.

Hey Romain, is there any reason you pulled this code out of the XBean 4.10 
release?  Ideally we discuss these things as a community before tacking action.

Would you mind if I did a 4.11 with it included?



-David

Re: xbean-reflect changes and potential xbean 5?

[Jean-Louis MONTEIRO]

That sounds like good improvements. Thanks for the visibility.

And also 5.x sounds better considering the changes and the removal of some
converters.

Le jeu. 9 août 2018 à 09:37, Romain Manni-Bucau  a
écrit :

> pushed
>
>
> Romain Manni-Bucau
> @rmannibucau  |  Blog
>  | Old Blog
>  | Github
>  | LinkedIn
>  | Book
> 
>
>
> Le jeu. 9 août 2018 à 07:42, Romain Manni-Bucau  a
> écrit :
>
>> If we go 5 we should probably drop the static PropertiesEditors class
>> which leads to trivial leakages in all servers and do a registry apps
>> instantiate at need with closeable support for editors. I can push that
>> today if there is no objection.
>>
>> It would also ensure we can cache the reflection needed for the jaxrs
>> style you added a enable the blueprint version upgrade directlt.
>>
>> +1 from me to go that path at once
>>
>> Le jeu. 9 août 2018 03:54, David Blevins  a
>> écrit :
>>
>>> All,
>>>
>>> I updated the converter code in xbean-reflect to add support for JAX-RS
>>> style string constructors and static factory methods.  We weren't so clever
>>> to think of this in 2006, but it definitely fits.
>>>
>>> Moreover, I don't think we need half of the built-in
>>> Converter/PropertyEditor implementations now.  Most of them can be deleted
>>> with likely a positive speed impact as part of the process of converting is
>>> looping over all the built-in Converter/PropertyEditor instances.  There's
>>> a second startup improvement as well as they are created eagerly via static
>>> initializer.
>>>
>>> I'd love to do a 4.x release of this code.  It could be nice to save the
>>> deleting of the property editors for a potential XBean 5.x.  I'm ok with
>>> one or the other or both.  I see Łukasz's work which might make for a good
>>> 5.x release, so maybe we just do that.
>>>
>>> Thoughts or preferences?
>>>
>>>
>>> -David
>>>
>>>

Re: xbean-reflect changes and potential xbean 5?

[Romain Manni-Bucau]

pushed

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le jeu. 9 août 2018 à 07:42, Romain Manni-Bucau  a
écrit :

> If we go 5 we should probably drop the static PropertiesEditors class
> which leads to trivial leakages in all servers and do a registry apps
> instantiate at need with closeable support for editors. I can push that
> today if there is no objection.
>
> It would also ensure we can cache the reflection needed for the jaxrs
> style you added a enable the blueprint version upgrade directlt.
>
> +1 from me to go that path at once
>
> Le jeu. 9 août 2018 03:54, David Blevins  a
> écrit :
>
>> All,
>>
>> I updated the converter code in xbean-reflect to add support for JAX-RS
>> style string constructors and static factory methods.  We weren't so clever
>> to think of this in 2006, but it definitely fits.
>>
>> Moreover, I don't think we need half of the built-in
>> Converter/PropertyEditor implementations now.  Most of them can be deleted
>> with likely a positive speed impact as part of the process of converting is
>> looping over all the built-in Converter/PropertyEditor instances.  There's
>> a second startup improvement as well as they are created eagerly via static
>> initializer.
>>
>> I'd love to do a 4.x release of this code.  It could be nice to save the
>> deleting of the property editors for a potential XBean 5.x.  I'm ok with
>> one or the other or both.  I see Łukasz's work which might make for a good
>> 5.x release, so maybe we just do that.
>>
>> Thoughts or preferences?
>>
>>
>> -David
>>
>>

Re: xbean-reflect changes and potential xbean 5?

[Romain Manni-Bucau]

If we go 5 we should probably drop the static PropertiesEditors class which
leads to trivial leakages in all servers and do a registry apps instantiate
at need with closeable support for editors. I can push that today if there
is no objection.

It would also ensure we can cache the reflection needed for the jaxrs style
you added a enable the blueprint version upgrade directlt.

+1 from me to go that path at once

Le jeu. 9 août 2018 03:54, David Blevins  a écrit :

> All,
>
> I updated the converter code in xbean-reflect to add support for JAX-RS
> style string constructors and static factory methods.  We weren't so clever
> to think of this in 2006, but it definitely fits.
>
> Moreover, I don't think we need half of the built-in
> Converter/PropertyEditor implementations now.  Most of them can be deleted
> with likely a positive speed impact as part of the process of converting is
> looping over all the built-in Converter/PropertyEditor instances.  There's
> a second startup improvement as well as they are created eagerly via static
> initializer.
>
> I'd love to do a 4.x release of this code.  It could be nice to save the
> deleting of the property editors for a potential XBean 5.x.  I'm ok with
> one or the other or both.  I see Łukasz's work which might make for a good
> 5.x release, so maybe we just do that.
>
> Thoughts or preferences?
>
>
> -David
>
>

xbean-reflect changes and potential xbean 5?

[David Blevins]

All,

I updated the converter code in xbean-reflect to add support for JAX-RS style 
string constructors and static factory methods.  We weren't so clever to think 
of this in 2006, but it definitely fits.

Moreover, I don't think we need half of the built-in Converter/PropertyEditor 
implementations now.  Most of them can be deleted with likely a positive speed 
impact as part of the process of converting is looping over all the built-in 
Converter/PropertyEditor instances.  There's a second startup improvement as 
well as they are created eagerly via static initializer.

I'd love to do a 4.x release of this code.  It could be nice to save the 
deleting of the property editors for a potential XBean 5.x.  I'm ok with one or 
the other or both.  I see Łukasz's work which might make for a good 5.x 
release, so maybe we just do that.

Thoughts or preferences?


-David