[jira] [Commented] (GIRAPH-1157) Allow implementations of JobProgressTrackerService to extend kill job behavior

2017-09-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GIRAPH-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157875#comment-16157875
 ] 

ASF GitHub Bot commented on GIRAPH-1157:


Github user asfgit closed the pull request at:

https://github.com/apache/giraph/pull/46


> Allow implementations of JobProgressTrackerService to extend kill job behavior
> --
>
> Key: GIRAPH-1157
> URL: https://issues.apache.org/jira/browse/GIRAPH-1157
> Project: Giraph
>  Issue Type: Improvement
>Reporter: Maja Kabiljo
>Assignee: Maja Kabiljo
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GIRAPH-1157) Allow implementations of JobProgressTrackerService to extend kill job behavior

2017-09-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GIRAPH-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157867#comment-16157867
 ] 

ASF GitHub Bot commented on GIRAPH-1157:


Github user dlogothetis commented on the issue:

https://github.com/apache/giraph/pull/46
  
Just to be clear, here you want to allow custom behavior based on the type 
of the kill (i.e. the message), right?

Looks good too me.


> Allow implementations of JobProgressTrackerService to extend kill job behavior
> --
>
> Key: GIRAPH-1157
> URL: https://issues.apache.org/jira/browse/GIRAPH-1157
> Project: Giraph
>  Issue Type: Improvement
>Reporter: Maja Kabiljo
>Assignee: Maja Kabiljo
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GIRAPH-1157) Allow implementations of JobProgressTrackerService to extend kill job behavior

2017-09-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GIRAPH-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157832#comment-16157832
 ] 

ASF GitHub Bot commented on GIRAPH-1157:


GitHub user majakabiljo opened a pull request:

https://github.com/apache/giraph/pull/46

GIRAPH-1157

Allow implementations of JobProgressTrackerService to extend kill job 
behavior

Test Plan: Ran a job with additional behavior in kill method and verified 
it's executed

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/majakabiljo/giraph giraph-1157

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/giraph/pull/46.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #46


commit daadef5be53f8722ff007245c46670128119e534
Author: Maja Kabiljo 
Date:   2017-09-07T23:05:20Z

GIRAPH-1157: Allow implementations of JobProgressTrackerService to extend 
kill job behavior

Test Plan: Ran a job with additional behavior in kill method and verified 
it's executed




> Allow implementations of JobProgressTrackerService to extend kill job behavior
> --
>
> Key: GIRAPH-1157
> URL: https://issues.apache.org/jira/browse/GIRAPH-1157
> Project: Giraph
>  Issue Type: Improvement
>Reporter: Maja Kabiljo
>Assignee: Maja Kabiljo
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (GIRAPH-1157) Allow implementations of JobProgressTrackerService to extend kill job behavior

2017-09-07 Thread Maja Kabiljo (JIRA)
Maja Kabiljo created GIRAPH-1157:


 Summary: Allow implementations of JobProgressTrackerService to 
extend kill job behavior
 Key: GIRAPH-1157
 URL: https://issues.apache.org/jira/browse/GIRAPH-1157
 Project: Giraph
  Issue Type: Improvement
Reporter: Maja Kabiljo
Assignee: Maja Kabiljo
Priority: Minor






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)