[jira] [Commented] (GIRAPH-1213) Fix issues with network requests retries and add more logging
[ https://issues.apache.org/jira/browse/GIRAPH-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16703702#comment-16703702 ] ASF GitHub Bot commented on GIRAPH-1213: GitHub user majakabiljo opened a pull request: https://github.com/apache/giraph/pull/96 GIRAPH-1213: Fix issues with network requests retries and add more logging Fixing two bugs: - When channel fails, we are currently retrying all requests towards the destination machine from the channel, instead of just ones which are happening on the concrete channel. - In practice, we've noticed BlockingOperationException can get thrown when we wait to connect on channel in which case we silently don't send the request we are trying to send, so catching this exception and retrying instead. Also added logging of channel ids to be able to debug issues related to network requests not delivering easier. You can merge this pull request into a Git repository by running: $ git pull https://github.com/majakabiljo/giraph giraph-1213 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/giraph/pull/96.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #96 commit 581dd9bbf47d02ceddf0aba2e8c97e80d7d6f44c Author: Maja Kabiljo Date: 2018-11-29T19:35:53Z GIRAPH-1213: Fix issues with network requests retries and add more logging Fixing two bugs: - When channel fails, we are currently retrying all requests towards the destination machine from the channel, instead of just ones which are happening on the concrete channel. - In practice, we've noticed BlockingOperationException can get thrown when we wait to connect on channel in which case we silently don't send the request we are trying to send, so catching this exception and retrying instead. Also added logging of channel ids to be able to debug issues related to network requests not delivering easier. > Fix issues with network requests retries and add more logging > - > > Key: GIRAPH-1213 > URL: https://issues.apache.org/jira/browse/GIRAPH-1213 > Project: Giraph > Issue Type: Bug >Reporter: Maja Kabiljo >Assignee: Maja Kabiljo >Priority: Major > > Fixing two bugs: > * When channel fails, we are currently retrying all requests towards the > destination machine from the channel, instead of just ones which are > happening on the concrete channel. > * In practice, we've noticed BlockingOperationException can get thrown when > we wait to connect on channel in which case we silently don't send the > request we are trying to send, so catching this exception and retrying > instead. > Also added logging of channel ids to be able to debug issues related to > network requests not delivering easier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] giraph pull request #96: GIRAPH-1213: Fix issues with network requests retri...
GitHub user majakabiljo opened a pull request: https://github.com/apache/giraph/pull/96 GIRAPH-1213: Fix issues with network requests retries and add more logging Fixing two bugs: - When channel fails, we are currently retrying all requests towards the destination machine from the channel, instead of just ones which are happening on the concrete channel. - In practice, we've noticed BlockingOperationException can get thrown when we wait to connect on channel in which case we silently don't send the request we are trying to send, so catching this exception and retrying instead. Also added logging of channel ids to be able to debug issues related to network requests not delivering easier. You can merge this pull request into a Git repository by running: $ git pull https://github.com/majakabiljo/giraph giraph-1213 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/giraph/pull/96.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #96 commit 581dd9bbf47d02ceddf0aba2e8c97e80d7d6f44c Author: Maja Kabiljo Date: 2018-11-29T19:35:53Z GIRAPH-1213: Fix issues with network requests retries and add more logging Fixing two bugs: - When channel fails, we are currently retrying all requests towards the destination machine from the channel, instead of just ones which are happening on the concrete channel. - In practice, we've noticed BlockingOperationException can get thrown when we wait to connect on channel in which case we silently don't send the request we are trying to send, so catching this exception and retrying instead. Also added logging of channel ids to be able to debug issues related to network requests not delivering easier. ---
[jira] [Created] (GIRAPH-1213) Fix issues with network requests retries and add more logging
Maja Kabiljo created GIRAPH-1213: Summary: Fix issues with network requests retries and add more logging Key: GIRAPH-1213 URL: https://issues.apache.org/jira/browse/GIRAPH-1213 Project: Giraph Issue Type: Bug Reporter: Maja Kabiljo Assignee: Maja Kabiljo Fixing two bugs: * When channel fails, we are currently retrying all requests towards the destination machine from the channel, instead of just ones which are happening on the concrete channel. * In practice, we've noticed BlockingOperationException can get thrown when we wait to connect on channel in which case we silently don't send the request we are trying to send, so catching this exception and retrying instead. Also added logging of channel ids to be able to debug issues related to network requests not delivering easier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
