[jira] [Work logged] (GOBBLIN-928) Bump up ORC to 1.6.0 to get more compression algorithms
[
https://issues.apache.org/jira/browse/GOBBLIN-928?focusedWorklogId=334488&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-334488
]
ASF GitHub Bot logged work on GOBBLIN-928:
--
Author: ASF GitHub Bot
Created on: 26/Oct/19 03:47
Start Date: 26/Oct/19 03:47
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2784:
[GOBBLIN-928]Craftsmanship cleaning and bumping up ORC version
URL: https://github.com/apache/incubator-gobblin/pull/2784#discussion_r339284617
##
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobLauncher.java
##
@@ -381,7 +381,8 @@ public void launchJob(@Nullable JobListener jobListener)
}
/**
- * Add a single {@link WorkUnit} (flattened).
+ * Add a single {@link WorkUnit} (flattened) to persisted storage so that
worker could fetch that based on information
Review comment:
Nit: "persisted" -> "persistent". "could" -> "can".
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 334488)
Time Spent: 0.5h (was: 20m)
> Bump up ORC to 1.6.0 to get more compression algorithms
>
>
> Key: GOBBLIN-928
> URL: https://issues.apache.org/jira/browse/GOBBLIN-928
> Project: Apache Gobblin
> Issue Type: Improvement
>Reporter: Lei Sun
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-928) Bump up ORC to 1.6.0 to get more compression algorithms
[
https://issues.apache.org/jira/browse/GOBBLIN-928?focusedWorklogId=334489&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-334489
]
ASF GitHub Bot logged work on GOBBLIN-928:
--
Author: ASF GitHub Bot
Created on: 26/Oct/19 03:47
Start Date: 26/Oct/19 03:47
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2784:
[GOBBLIN-928]Craftsmanship cleaning and bumping up ORC version
URL: https://github.com/apache/incubator-gobblin/pull/2784#discussion_r339284718
##
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/StateStoreBasedWatermarkStorage.java
##
@@ -50,7 +50,12 @@
public static final String WATERMARK_STORAGE_TYPE_KEY
="streaming.watermarkStateStore.type";
public static final String WATERMARK_STORAGE_TYPE_DEFAULT ="zk";
public static final String
WATERMARK_STORAGE_CONFIG_PREFIX="streaming.watermarkStateStore.config.";
- private static final String WATERMARK_STORAGE_PREFIX="streamingWatermarks:";
+
+ /**
+ * The prefix need to be fitting with different storage layer. e.g. some of
characters won't be allowed in URI and
Review comment:
A bit of word-smithing: "A watermark prefix that is compatible with
different watermark storage implementations. As such, this prefix should not
include any characters disallowed in a {@link URI}."
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 334489)
Time Spent: 0.5h (was: 20m)
> Bump up ORC to 1.6.0 to get more compression algorithms
>
>
> Key: GOBBLIN-928
> URL: https://issues.apache.org/jira/browse/GOBBLIN-928
> Project: Apache Gobblin
> Issue Type: Improvement
>Reporter: Lei Sun
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2784: [GOBBLIN-928]Craftsmanship cleaning and bumping up ORC version
sv2000 commented on a change in pull request #2784: [GOBBLIN-928]Craftsmanship
cleaning and bumping up ORC version
URL: https://github.com/apache/incubator-gobblin/pull/2784#discussion_r339284617
##
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobLauncher.java
##
@@ -381,7 +381,8 @@ public void launchJob(@Nullable JobListener jobListener)
}
/**
- * Add a single {@link WorkUnit} (flattened).
+ * Add a single {@link WorkUnit} (flattened) to persisted storage so that
worker could fetch that based on information
Review comment:
Nit: "persisted" -> "persistent". "could" -> "can".
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2784: [GOBBLIN-928]Craftsmanship cleaning and bumping up ORC version
sv2000 commented on a change in pull request #2784: [GOBBLIN-928]Craftsmanship
cleaning and bumping up ORC version
URL: https://github.com/apache/incubator-gobblin/pull/2784#discussion_r339284718
##
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/StateStoreBasedWatermarkStorage.java
##
@@ -50,7 +50,12 @@
public static final String WATERMARK_STORAGE_TYPE_KEY
="streaming.watermarkStateStore.type";
public static final String WATERMARK_STORAGE_TYPE_DEFAULT ="zk";
public static final String
WATERMARK_STORAGE_CONFIG_PREFIX="streaming.watermarkStateStore.config.";
- private static final String WATERMARK_STORAGE_PREFIX="streamingWatermarks:";
+
+ /**
+ * The prefix need to be fitting with different storage layer. e.g. some of
characters won't be allowed in URI and
Review comment:
A bit of word-smithing: "A watermark prefix that is compatible with
different watermark storage implementations. As such, this prefix should not
include any characters disallowed in a {@link URI}."
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Work logged] (GOBBLIN-928) Bump up ORC to 1.6.0 to get more compression algorithms
[
https://issues.apache.org/jira/browse/GOBBLIN-928?focusedWorklogId=334451&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-334451
]
ASF GitHub Bot logged work on GOBBLIN-928:
--
Author: ASF GitHub Bot
Created on: 26/Oct/19 00:14
Start Date: 26/Oct/19 00:14
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2784:
[GOBBLIN-928]Craftsmanship cleaning and bumping up ORC version
URL: https://github.com/apache/incubator-gobblin/pull/2784
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- https://issues.apache.org/jira/browse/GOBBLIN-928
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 334451)
Remaining Estimate: 0h
Time Spent: 10m
> Bump up ORC to 1.6.0 to get more compression algorithms
>
>
> Key: GOBBLIN-928
> URL: https://issues.apache.org/jira/browse/GOBBLIN-928
> Project: Apache Gobblin
> Issue Type: Improvement
>Reporter: Lei Sun
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [incubator-gobblin] autumnust commented on issue #2784: [GOBBLIN-928]Craftsmanship cleaning and bumping up ORC version
autumnust commented on issue #2784: [GOBBLIN-928]Craftsmanship cleaning and bumping up ORC version URL: https://github.com/apache/incubator-gobblin/pull/2784#issuecomment-546549579 @sv2000 can you take a look? thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (GOBBLIN-928) Bump up ORC to 1.6.0 to get more compression algorithms
[ https://issues.apache.org/jira/browse/GOBBLIN-928?focusedWorklogId=334452&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-334452 ] ASF GitHub Bot logged work on GOBBLIN-928: -- Author: ASF GitHub Bot Created on: 26/Oct/19 00:14 Start Date: 26/Oct/19 00:14 Worklog Time Spent: 10m Work Description: autumnust commented on issue #2784: [GOBBLIN-928]Craftsmanship cleaning and bumping up ORC version URL: https://github.com/apache/incubator-gobblin/pull/2784#issuecomment-546549579 @sv2000 can you take a look? thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 334452) Time Spent: 20m (was: 10m) > Bump up ORC to 1.6.0 to get more compression algorithms > > > Key: GOBBLIN-928 > URL: https://issues.apache.org/jira/browse/GOBBLIN-928 > Project: Apache Gobblin > Issue Type: Improvement >Reporter: Lei Sun >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [incubator-gobblin] autumnust opened a new pull request #2784: [GOBBLIN-928]Craftsmanship cleaning and bumping up ORC version
autumnust opened a new pull request #2784: [GOBBLIN-928]Craftsmanship cleaning
and bumping up ORC version
URL: https://github.com/apache/incubator-gobblin/pull/2784
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- https://issues.apache.org/jira/browse/GOBBLIN-928
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (GOBBLIN-928) Bump up ORC to 1.6.0 to get more compression algorithms
Lei Sun created GOBBLIN-928: --- Summary: Bump up ORC to 1.6.0 to get more compression algorithms Key: GOBBLIN-928 URL: https://issues.apache.org/jira/browse/GOBBLIN-928 Project: Apache Gobblin Issue Type: Improvement Reporter: Lei Sun -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GOBBLIN-927) config to properties fails to convert configObject to string
[
https://issues.apache.org/jira/browse/GOBBLIN-927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Sen updated GOBBLIN-927:
Description:
if you specify source.schema = \{\} then
{{ConfigUtils.configToProperties}} would fail to convert this object directly
to string.
solution is to use convert any possible objects to string.
was:
if you specify source.schema = { } then
{{ConfigUtils.configToProperties}} would fail to convert this object directly
to string.
solution is to use convert any possible objects to string.
> config to properties fails to convert configObject to string
>
>
> Key: GOBBLIN-927
> URL: https://issues.apache.org/jira/browse/GOBBLIN-927
> Project: Apache Gobblin
> Issue Type: Bug
>Reporter: Jay Sen
>Priority: Minor
>
> if you specify source.schema = \{\} then
> {{ConfigUtils.configToProperties}} would fail to convert this object directly
> to string.
> solution is to use convert any possible objects to string.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (GOBBLIN-927) config to properties fails to convert configObject to string
Jay Sen created GOBBLIN-927:
---
Summary: config to properties fails to convert configObject to
string
Key: GOBBLIN-927
URL: https://issues.apache.org/jira/browse/GOBBLIN-927
Project: Apache Gobblin
Issue Type: Bug
Reporter: Jay Sen
if you specify source.schema = { } then
{{ConfigUtils.configToProperties}} would fail to convert this object directly
to string.
solution is to use convert any possible objects to string.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (GOBBLIN-926) use typesafe config consistently everywhere
Jay Sen created GOBBLIN-926: --- Summary: use typesafe config consistently everywhere Key: GOBBLIN-926 URL: https://issues.apache.org/jira/browse/GOBBLIN-926 Project: Apache Gobblin Issue Type: Improvement Affects Versions: 0.14.0 Reporter: Jay Sen Fix For: 0.15.0 basically remove the usage and conversion to java.utils.properties. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-924) Get rid of orc.schema.literal in ORC-ingestion and registration
[ https://issues.apache.org/jira/browse/GOBBLIN-924?focusedWorklogId=334250&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-334250 ] ASF GitHub Bot logged work on GOBBLIN-924: -- Author: ASF GitHub Bot Created on: 25/Oct/19 17:45 Start Date: 25/Oct/19 17:45 Worklog Time Spent: 10m Work Description: codecov-io commented on issue #2780: [GOBBLIN-924]Get rid of orc.schema.literal in ORC-ingestion and registration URL: https://github.com/apache/incubator-gobblin/pull/2780#issuecomment-546447452 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2780?src=pr&el=h1) Report > Merging [#2780](https://codecov.io/gh/apache/incubator-gobblin/pull/2780?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/2415173b1e428848c5b1c47788a2ad0aaa8ba3bd?src=pr&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `27.63%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2780?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#2780 +/- ## - Coverage 45.34% 45.33% -0.02% - Complexity 8858 8861 +3 Files 1894 1894 Lines 7083870874 +36 Branches 7790 7795 +5 + Hits 3212432129 +5 - Misses3574835781 +33 + Partials 2966 2964 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2780?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2780/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...lin/hive/metastore/HiveMetaStoreBasedRegister.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2780/diff?src=pr&el=tree#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL21ldGFzdG9yZS9IaXZlTWV0YVN0b3JlQmFzZWRSZWdpc3Rlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...g/apache/gobblin/hive/orc/HiveOrcSerDeManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2780/diff?src=pr&el=tree#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL29yYy9IaXZlT3JjU2VyRGVNYW5hZ2VyLmphdmE=) | `63.95% <0%> (-2.72%)` | `12 <0> (ø)` | | | [...blin/service/FlowConfigV2ResourceLocalHandler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2780/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnVjJSZXNvdXJjZUxvY2FsSGFuZGxlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...service/modules/orchestration/DagManagerUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2780/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0RhZ01hbmFnZXJVdGlscy5qYXZh) | `84.81% <100%> (ø)` | `34 <0> (ø)` | :arrow_down: | | [...ro/JsonElementConversionWithAvroSchemaFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2780/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9hdnJvL0pzb25FbGVtZW50Q29udmVyc2lvbldpdGhBdnJvU2NoZW1hRmFjdG9yeS5qYXZh) | `75% <100%> (ø)` | `5 <0> (ø)` | :arrow_down: | | [...n/converter/avro/JsonElementConversionFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2780/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9hdnJvL0pzb25FbGVtZW50Q29udmVyc2lvbkZhY3RvcnkuamF2YQ==) | `81.04% <100%> (ø)` | `18 <0> (ø)` | :arrow_down: | | [.../modules/scheduler/GobblinServiceJobScheduler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2780/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9zY2hlZHVsZXIvR29iYmxpblNlcnZpY2VKb2JTY2hlZHVsZXIuamF2YQ==) | `58.28% <40%> (ø)` | `21 <0> (ø)` | :arrow_down: | | [.../java/org/apache/gobblin/runtime/api/FlowSpec.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2780/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0Zsb3dTcGVjLmphdmE=
[GitHub] [incubator-gobblin] codecov-io commented on issue #2780: [GOBBLIN-924]Get rid of orc.schema.literal in ORC-ingestion and registration
codecov-io commented on issue #2780: [GOBBLIN-924]Get rid of orc.schema.literal in ORC-ingestion and registration URL: https://github.com/apache/incubator-gobblin/pull/2780#issuecomment-546447452 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2780?src=pr&el=h1) Report > Merging [#2780](https://codecov.io/gh/apache/incubator-gobblin/pull/2780?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/2415173b1e428848c5b1c47788a2ad0aaa8ba3bd?src=pr&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `27.63%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2780?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#2780 +/- ## - Coverage 45.34% 45.33% -0.02% - Complexity 8858 8861 +3 Files 1894 1894 Lines 7083870874 +36 Branches 7790 7795 +5 + Hits 3212432129 +5 - Misses3574835781 +33 + Partials 2966 2964 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2780?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2780/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...lin/hive/metastore/HiveMetaStoreBasedRegister.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2780/diff?src=pr&el=tree#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL21ldGFzdG9yZS9IaXZlTWV0YVN0b3JlQmFzZWRSZWdpc3Rlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...g/apache/gobblin/hive/orc/HiveOrcSerDeManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2780/diff?src=pr&el=tree#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL29yYy9IaXZlT3JjU2VyRGVNYW5hZ2VyLmphdmE=) | `63.95% <0%> (-2.72%)` | `12 <0> (ø)` | | | [...blin/service/FlowConfigV2ResourceLocalHandler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2780/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnVjJSZXNvdXJjZUxvY2FsSGFuZGxlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...service/modules/orchestration/DagManagerUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2780/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0RhZ01hbmFnZXJVdGlscy5qYXZh) | `84.81% <100%> (ø)` | `34 <0> (ø)` | :arrow_down: | | [...ro/JsonElementConversionWithAvroSchemaFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2780/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9hdnJvL0pzb25FbGVtZW50Q29udmVyc2lvbldpdGhBdnJvU2NoZW1hRmFjdG9yeS5qYXZh) | `75% <100%> (ø)` | `5 <0> (ø)` | :arrow_down: | | [...n/converter/avro/JsonElementConversionFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2780/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9hdnJvL0pzb25FbGVtZW50Q29udmVyc2lvbkZhY3RvcnkuamF2YQ==) | `81.04% <100%> (ø)` | `18 <0> (ø)` | :arrow_down: | | [.../modules/scheduler/GobblinServiceJobScheduler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2780/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9zY2hlZHVsZXIvR29iYmxpblNlcnZpY2VKb2JTY2hlZHVsZXIuamF2YQ==) | `58.28% <40%> (ø)` | `21 <0> (ø)` | :arrow_down: | | [.../java/org/apache/gobblin/runtime/api/FlowSpec.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2780/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0Zsb3dTcGVjLmphdmE=) | `52.23% <50%> (ø)` | `12 <0> (ø)` | :arrow_down: | | [...dules/flowgraph/pathfinder/AbstractPathFinder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2780/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93Z3JhcGgvcGF0aGZpbmRlci9BYnN0cmFjdFBhdGhGaW5kZXIuamF2YQ==) | `90.99% <77.77%> (ø)` | `29 <0> (ø)` | :arrow_down: | | ... and [10 more](h
[jira] [Work logged] (GOBBLIN-924) Get rid of orc.schema.literal in ORC-ingestion and registration
[ https://issues.apache.org/jira/browse/GOBBLIN-924?focusedWorklogId=334235&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-334235 ] ASF GitHub Bot logged work on GOBBLIN-924: -- Author: ASF GitHub Bot Created on: 25/Oct/19 17:03 Start Date: 25/Oct/19 17:03 Worklog Time Spent: 10m Work Description: ZihanLi58 commented on issue #2780: [GOBBLIN-924]Get rid of orc.schema.literal in ORC-ingestion and registration URL: https://github.com/apache/incubator-gobblin/pull/2780#issuecomment-546433295 @autumnust I use a pull command which seems introduce all the changes which have been committed during last two days. Just select the last commit should be able to see my change. Sorry for the inconvenience ^^ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 334235) Time Spent: 1.5h (was: 1h 20m) > Get rid of orc.schema.literal in ORC-ingestion and registration > --- > > Key: GOBBLIN-924 > URL: https://issues.apache.org/jira/browse/GOBBLIN-924 > Project: Apache Gobblin > Issue Type: Task >Reporter: Zihan Li >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [incubator-gobblin] ZihanLi58 commented on issue #2780: [GOBBLIN-924]Get rid of orc.schema.literal in ORC-ingestion and registration
ZihanLi58 commented on issue #2780: [GOBBLIN-924]Get rid of orc.schema.literal in ORC-ingestion and registration URL: https://github.com/apache/incubator-gobblin/pull/2780#issuecomment-546433295 @autumnust I use a pull command which seems introduce all the changes which have been committed during last two days. Just select the last commit should be able to see my change. Sorry for the inconvenience ^^ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
