[jira] [Work logged] (GOBBLIN-945) Refactor Kafka extractor statistics tracking to allow code reuse across both batch and streaming execution modes
[ https://issues.apache.org/jira/browse/GOBBLIN-945?focusedWorklogId=339599&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-339599 ] ASF GitHub Bot logged work on GOBBLIN-945: -- Author: ASF GitHub Bot Created on: 06/Nov/19 21:32 Start Date: 06/Nov/19 21:32 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2795: GOBBLIN-945: Refactor Kafka extractor statistics tracking to allow co… URL: https://github.com/apache/incubator-gobblin/pull/2795 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 339599) Time Spent: 2h 40m (was: 2.5h) > Refactor Kafka extractor statistics tracking to allow code reuse across both > batch and streaming execution modes > > > Key: GOBBLIN-945 > URL: https://issues.apache.org/jira/browse/GOBBLIN-945 > Project: Apache Gobblin > Issue Type: Improvement > Components: gobblin-kafka >Affects Versions: 0.15.0 >Reporter: Sudarshan Vasudevan >Assignee: Shirshanka Das >Priority: Major > Fix For: 0.15.0 > > Time Spent: 2h 40m > Remaining Estimate: 0h > > Current implementation of kafka extractor stats tracking is deeply integrated > with the batch implementation of KafkaExtractor preventing it from being used > in streaming Kafka extractor implementations. In addition to code reuse, the > refactoring allows for writing unit tests for statistics tracker. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [incubator-gobblin] asfgit closed pull request #2795: GOBBLIN-945: Refactor Kafka extractor statistics tracking to allow co…
asfgit closed pull request #2795: GOBBLIN-945: Refactor Kafka extractor statistics tracking to allow co… URL: https://github.com/apache/incubator-gobblin/pull/2795 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (GOBBLIN-945) Refactor Kafka extractor statistics tracking to allow code reuse across both batch and streaming execution modes
[ https://issues.apache.org/jira/browse/GOBBLIN-945?focusedWorklogId=339586&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-339586 ] ASF GitHub Bot logged work on GOBBLIN-945: -- Author: ASF GitHub Bot Created on: 06/Nov/19 21:04 Start Date: 06/Nov/19 21:04 Worklog Time Spent: 10m Work Description: codecov-io commented on issue #2795: GOBBLIN-945: Refactor Kafka extractor statistics tracking to allow co… URL: https://github.com/apache/incubator-gobblin/pull/2795#issuecomment-549956451 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2795?src=pr&el=h1) Report > Merging [#2795](https://codecov.io/gh/apache/incubator-gobblin/pull/2795?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/94a508b38ec8bd879614f2d9bf0eeb96513ca7cf?src=pr&el=desc) will **increase** coverage by `0.13%`. > The diff coverage is `42.07%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2795?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#2795 +/- ## + Coverage 45.32% 45.45% +0.13% - Complexity 8862 8889 +27 Files 1894 1895 +1 Lines 7091070942 +32 Branches 7799 7801 +2 + Hits 3214132248 +107 + Misses3580335726 -77 - Partials 2966 2968 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2795?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...in/source/extractor/extract/kafka/KafkaSource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2795/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYVNvdXJjZS5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...he/gobblin/kafka/client/Kafka08ConsumerClient.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2795/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtMDgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4va2Fma2EvY2xpZW50L0thZmthMDhDb25zdW1lckNsaWVudC5qYXZh) | `56.05% <ø> (ø)` | `22 <0> (ø)` | :arrow_down: | | [...ce/extractor/extract/kafka/KafkaAvroExtractor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2795/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYUF2cm9FeHRyYWN0b3IuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...bblin/kafka/client/GobblinKafkaConsumerClient.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2795/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2thZmthL2NsaWVudC9Hb2JibGluS2Fma2FDb25zdW1lckNsaWVudC5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...source/extractor/extract/kafka/KafkaExtractor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2795/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYUV4dHJhY3Rvci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ctor/extract/kafka/KafkaExtractorStatsTracker.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2795/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYUV4dHJhY3RvclN0YXRzVHJhY2tlci5qYXZh) | `49.6% <49.6%> (ø)` | `19 <19> (?)` | | | [...source/extractor/extract/kafka/KafkaPartition.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2795/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYVBhcnRpdGlvbi5qYXZh) | `44.64% <85.71%> (+44.64%)` | `3 <2> (+3)` | :arrow_up: | | [...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2795/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvWm9va2VlcGVyQmFzZWRKb2JMb2NrLmphdmE=) | `63.33% <0%> (-1.12%)` | `15% <0%> (-1%)` | | | [...pache/gobblin/cluster/GobblinHelixJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2795/diff?src=pr&el=tree#diff-Z29iYmxpb
[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2795: GOBBLIN-945: Refactor Kafka extractor statistics tracking to allow co…
codecov-io edited a comment on issue #2795: GOBBLIN-945: Refactor Kafka extractor statistics tracking to allow co… URL: https://github.com/apache/incubator-gobblin/pull/2795#issuecomment-549956451 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2795?src=pr&el=h1) Report > Merging [#2795](https://codecov.io/gh/apache/incubator-gobblin/pull/2795?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/94a508b38ec8bd879614f2d9bf0eeb96513ca7cf?src=pr&el=desc) will **increase** coverage by `0.13%`. > The diff coverage is `42.07%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2795?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#2795 +/- ## + Coverage 45.32% 45.45% +0.13% - Complexity 8862 8889 +27 Files 1894 1895 +1 Lines 7091070942 +32 Branches 7799 7801 +2 + Hits 3214132248 +107 + Misses3580335726 -77 - Partials 2966 2968 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2795?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...in/source/extractor/extract/kafka/KafkaSource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2795/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYVNvdXJjZS5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...he/gobblin/kafka/client/Kafka08ConsumerClient.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2795/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtMDgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4va2Fma2EvY2xpZW50L0thZmthMDhDb25zdW1lckNsaWVudC5qYXZh) | `56.05% <ø> (ø)` | `22 <0> (ø)` | :arrow_down: | | [...ce/extractor/extract/kafka/KafkaAvroExtractor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2795/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYUF2cm9FeHRyYWN0b3IuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...bblin/kafka/client/GobblinKafkaConsumerClient.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2795/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2thZmthL2NsaWVudC9Hb2JibGluS2Fma2FDb25zdW1lckNsaWVudC5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...source/extractor/extract/kafka/KafkaExtractor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2795/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYUV4dHJhY3Rvci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ctor/extract/kafka/KafkaExtractorStatsTracker.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2795/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYUV4dHJhY3RvclN0YXRzVHJhY2tlci5qYXZh) | `49.6% <49.6%> (ø)` | `19 <19> (?)` | | | [...source/extractor/extract/kafka/KafkaPartition.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2795/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYVBhcnRpdGlvbi5qYXZh) | `44.64% <85.71%> (+44.64%)` | `3 <2> (+3)` | :arrow_up: | | [...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2795/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvWm9va2VlcGVyQmFzZWRKb2JMb2NrLmphdmE=) | `63.33% <0%> (-1.12%)` | `15% <0%> (-1%)` | | | [...pache/gobblin/cluster/GobblinHelixJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2795/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXIuamF2YQ==) | `82% <0%> (+0.18%)` | `27% <0%> (+1%)` | :arrow_up: | | ... and [4 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2795/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2795?src=pr&el=continue). >
[jira] [Created] (GOBBLIN-949) add dry run in gobblin.sh script
Jay Sen created GOBBLIN-949: --- Summary: add dry run in gobblin.sh script Key: GOBBLIN-949 URL: https://issues.apache.org/jira/browse/GOBBLIN-949 Project: Apache Gobblin Issue Type: Bug Affects Versions: 0.14.0 Reporter: Jay Sen Fix For: 0.15.0 many times we may just need to see what is going to be executed without actually executing it., i.e. dry run. which also helps testing the script itself. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-948) add hive data node and hive descriptor for gobblin service
[
https://issues.apache.org/jira/browse/GOBBLIN-948?focusedWorklogId=339530&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-339530
]
ASF GitHub Bot logged work on GOBBLIN-948:
--
Author: ASF GitHub Bot
Created on: 06/Nov/19 18:25
Start Date: 06/Nov/19 18:25
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2797: [GOBBLIN-948]
add hive data node and descriptor
URL: https://github.com/apache/incubator-gobblin/pull/2797#discussion_r343254487
##
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/dataset/HiveDatasetDescriptor.java
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.service.modules.dataset;
+
+import java.io.IOException;
+
+import com.typesafe.config.Config;
+
+import lombok.EqualsAndHashCode;
+
+
+/**
+ * As of now, {@link HiveDatasetDescriptor} has same implementation as that of
{@link SqlDatasetDescriptor}.
+ * It can have partitioning related information in the future.
+ */
+@EqualsAndHashCode (callSuper = true)
+public class HiveDatasetDescriptor extends SqlDatasetDescriptor {
+
+ public HiveDatasetDescriptor(Config config) throws IOException {
Review comment:
I think HiveDatasetDescriptor can be enhanced with some additional metadata
e.g
a field to flag if the Hive dataset is partitioned or non-partitioned, a
property to indicate partitioning type e.g. datetime and then a property to
describe datetime pattern (e.g. -MM-DD etc.).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 339530)
Time Spent: 50m (was: 40m)
> add hive data node and hive descriptor for gobblin service
> --
>
> Key: GOBBLIN-948
> URL: https://issues.apache.org/jira/browse/GOBBLIN-948
> Project: Apache Gobblin
> Issue Type: New Feature
>Reporter: Arjun Singh Bora
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2797: [GOBBLIN-948] add hive data node and descriptor
sv2000 commented on a change in pull request #2797: [GOBBLIN-948] add hive data
node and descriptor
URL: https://github.com/apache/incubator-gobblin/pull/2797#discussion_r343254487
##
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/dataset/HiveDatasetDescriptor.java
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.service.modules.dataset;
+
+import java.io.IOException;
+
+import com.typesafe.config.Config;
+
+import lombok.EqualsAndHashCode;
+
+
+/**
+ * As of now, {@link HiveDatasetDescriptor} has same implementation as that of
{@link SqlDatasetDescriptor}.
+ * It can have partitioning related information in the future.
+ */
+@EqualsAndHashCode (callSuper = true)
+public class HiveDatasetDescriptor extends SqlDatasetDescriptor {
+
+ public HiveDatasetDescriptor(Config config) throws IOException {
Review comment:
I think HiveDatasetDescriptor can be enhanced with some additional metadata
e.g
a field to flag if the Hive dataset is partitioned or non-partitioned, a
property to indicate partitioning type e.g. datetime and then a property to
describe datetime pattern (e.g. -MM-DD etc.).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2797: [GOBBLIN-948] add hive data node and descriptor
codecov-io edited a comment on issue #2797: [GOBBLIN-948] add hive data node and descriptor URL: https://github.com/apache/incubator-gobblin/pull/2797#issuecomment-550088163 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2797?src=pr&el=h1) Report > Merging [#2797](https://codecov.io/gh/apache/incubator-gobblin/pull/2797?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/bf33b58d450d1f35e5f5cc147159710815210cd0?src=pr&el=desc) will **decrease** coverage by `41.2%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2797?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #2797 +/- ## - Coverage 45.35% 4.15% -41.21% + Complexity 8871 745 -8126 Files 18941896+2 Lines 70918 70939 +21 Branches 78007804+4 - Hits 321662945-29221 - Misses35789 67679+31890 + Partials 2963 315 -2648 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2797?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../service/modules/dataset/SqlDatasetDescriptor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2797/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9kYXRhc2V0L1NxbERhdGFzZXREZXNjcmlwdG9yLmphdmE=) | `0% <ø> (-63.89%)` | `0 <0> (-7)` | | | [...modules/flowgraph/datanodes/hive/HiveDataNode.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2797/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93Z3JhcGgvZGF0YW5vZGVzL2hpdmUvSGl2ZURhdGFOb2RlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...service/modules/dataset/HiveDatasetDescriptor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2797/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9kYXRhc2V0L0hpdmVEYXRhc2V0RGVzY3JpcHRvci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...n/converter/AvroStringFieldDecryptorConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2797/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tY3J5cHRvLXByb3ZpZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9BdnJvU3RyaW5nRmllbGREZWNyeXB0b3JDb252ZXJ0ZXIuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (-2%)` | | | [...he/gobblin/cluster/TaskRunnerSuiteThreadModel.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2797/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvVGFza1J1bm5lclN1aXRlVGhyZWFkTW9kZWwuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (-5%)` | | | [...n/mapreduce/avro/AvroKeyCompactorOutputFormat.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2797/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL2F2cm8vQXZyb0tleUNvbXBhY3Rvck91dHB1dEZvcm1hdC5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (-3%)` | | | [...apache/gobblin/fork/CopyNotSupportedException.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2797/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZm9yay9Db3B5Tm90U3VwcG9ydGVkRXhjZXB0aW9uLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (-1%)` | | | [.../gobblin/kafka/writer/KafkaWriterCommonConfig.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2797/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2thZmthL3dyaXRlci9LYWZrYVdyaXRlckNvbW1vbkNvbmZpZy5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (-7%)` | | | [...ker/task/TaskLevelPolicyCheckerBuilderFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2797/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3F1YWxpdHljaGVja2VyL3Rhc2svVGFza0xldmVsUG9saWN5Q2hlY2tlckJ1aWxkZXJGYWN0b3J5LmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (-2%)` | | | [...bblin/data/management/copy/AllEqualComparator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2797/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvQWxsRXF1YWxDb21wYXJhdG9yLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (-2%)` | | | ... and [1093 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2797/diff?src=pr&el=tree-more) | | -- [Continue to revie
[jira] [Work logged] (GOBBLIN-948) add hive data node and hive descriptor for gobblin service
[ https://issues.apache.org/jira/browse/GOBBLIN-948?focusedWorklogId=339223&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-339223 ] ASF GitHub Bot logged work on GOBBLIN-948: -- Author: ASF GitHub Bot Created on: 06/Nov/19 08:36 Start Date: 06/Nov/19 08:36 Worklog Time Spent: 10m Work Description: codecov-io commented on issue #2797: [GOBBLIN-948] add hive data node and descriptor URL: https://github.com/apache/incubator-gobblin/pull/2797#issuecomment-550088163 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2797?src=pr&el=h1) Report > Merging [#2797](https://codecov.io/gh/apache/incubator-gobblin/pull/2797?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/bf33b58d450d1f35e5f5cc147159710815210cd0?src=pr&el=desc) will **decrease** coverage by `41.2%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2797?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #2797 +/- ## - Coverage 45.35% 4.15% -41.21% + Complexity 8871 745 -8126 Files 18941896+2 Lines 70918 70939 +21 Branches 78007804+4 - Hits 321662945-29221 - Misses35789 67679+31890 + Partials 2963 315 -2648 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2797?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../service/modules/dataset/SqlDatasetDescriptor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2797/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9kYXRhc2V0L1NxbERhdGFzZXREZXNjcmlwdG9yLmphdmE=) | `0% <ø> (-63.89%)` | `0 <0> (-7)` | | | [...modules/flowgraph/datanodes/hive/HiveDataNode.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2797/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93Z3JhcGgvZGF0YW5vZGVzL2hpdmUvSGl2ZURhdGFOb2RlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...service/modules/dataset/HiveDatasetDescriptor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2797/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9kYXRhc2V0L0hpdmVEYXRhc2V0RGVzY3JpcHRvci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...n/converter/AvroStringFieldDecryptorConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2797/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tY3J5cHRvLXByb3ZpZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9BdnJvU3RyaW5nRmllbGREZWNyeXB0b3JDb252ZXJ0ZXIuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (-2%)` | | | [...he/gobblin/cluster/TaskRunnerSuiteThreadModel.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2797/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvVGFza1J1bm5lclN1aXRlVGhyZWFkTW9kZWwuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (-5%)` | | | [...n/mapreduce/avro/AvroKeyCompactorOutputFormat.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2797/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL2F2cm8vQXZyb0tleUNvbXBhY3Rvck91dHB1dEZvcm1hdC5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (-3%)` | | | [...apache/gobblin/fork/CopyNotSupportedException.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2797/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZm9yay9Db3B5Tm90U3VwcG9ydGVkRXhjZXB0aW9uLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (-1%)` | | | [.../gobblin/kafka/writer/KafkaWriterCommonConfig.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2797/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2thZmthL3dyaXRlci9LYWZrYVdyaXRlckNvbW1vbkNvbmZpZy5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (-7%)` | | | [...ker/task/TaskLevelPolicyCheckerBuilderFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2797/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3F1YWxpdHljaGVja2VyL3Rhc2svVGFza0xldmVsUG9saWN5Q2hlY2tlckJ1aWxkZXJGYWN0b3J5LmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (-2%)` | | | [...bblin/data/management/copy/AllEqualComparat
