[jira] [Work logged] (GOBBLIN-1068) Clean cyclic logic in task cancellation in Gobblin Task
[ https://issues.apache.org/jira/browse/GOBBLIN-1068?focusedWorklogId=397169&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-397169 ] ASF GitHub Bot logged work on GOBBLIN-1068: --- Author: ASF GitHub Bot Created on: 04/Mar/20 01:29 Start Date: 04/Mar/20 01:29 Worklog Time Spent: 10m Work Description: autumnust commented on issue #2907: [GOBBLIN-1068]Clean up cyclic logic in task cancellation URL: https://github.com/apache/incubator-gobblin/pull/2907#issuecomment-594266598 @sv2000 Can you please take a look whenever you have time? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 397169) Time Spent: 20m (was: 10m) > Clean cyclic logic in task cancellation in Gobblin Task > --- > > Key: GOBBLIN-1068 > URL: https://issues.apache.org/jira/browse/GOBBLIN-1068 > Project: Apache Gobblin > Issue Type: Bug >Reporter: Lei Sun >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [incubator-gobblin] autumnust commented on issue #2907: [GOBBLIN-1068]Clean up cyclic logic in task cancellation
autumnust commented on issue #2907: [GOBBLIN-1068]Clean up cyclic logic in task cancellation URL: https://github.com/apache/incubator-gobblin/pull/2907#issuecomment-594266598 @sv2000 Can you please take a look whenever you have time? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (GOBBLIN-1068) Clean cyclic logic in task cancellation in Gobblin Task
[
https://issues.apache.org/jira/browse/GOBBLIN-1068?focusedWorklogId=397167&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-397167
]
ASF GitHub Bot logged work on GOBBLIN-1068:
---
Author: ASF GitHub Bot
Created on: 04/Mar/20 01:25
Start Date: 04/Mar/20 01:25
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2907:
[GOBBLIN-1068]Clean up cyclic logic in task cancellation
URL: https://github.com/apache/incubator-gobblin/pull/2907
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- https://issues.apache.org/jira/browse/GOBBLIN-1068
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
The original `cancel` method in `Task.java` has several problems:
--`Task` is an implementation of `Runable` while itself contains a reference
of `Future` which is the handler of the `Runnable` after being submitted.
The life-cycle of the `Runnable` shouldn't be controlled by itself as it looks
like right now, but should be the `TaskExecutor` or something externally.
-- Because of the existence of a `Future` object within Task, there's a
bug in the implementation: The extension of `Task`, which is `TaskIFaceWrapper`
doesn't have the constructor to initialize this variable, while one of the
public method(`completeShutdown` within `cancel`) is exposing the accessing of
this variable. This is a bug and the original fix in this
PR:https://github.com/apache/incubator-gobblin/pull/2157/files is doing wrong
thing to copy the base class's method and remove the calling of
`completeShutdown`. In fact, the future object doesn't have to be existed in
the first place.
-- Fixing some other typos, and unit test problems as well.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 397167)
Remaining Estimate: 0h
Time Spent: 10m
> Clean cyclic logic in task cancellation in Gobblin Task
> ---
>
> Key: GOBBLIN-1068
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1068
> Project: Apache Gobblin
> Issue Type: Bug
>Reporter: Lei Sun
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [incubator-gobblin] autumnust opened a new pull request #2907: [GOBBLIN-1068]Clean up cyclic logic in task cancellation
autumnust opened a new pull request #2907: [GOBBLIN-1068]Clean up cyclic logic
in task cancellation
URL: https://github.com/apache/incubator-gobblin/pull/2907
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- https://issues.apache.org/jira/browse/GOBBLIN-1068
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
The original `cancel` method in `Task.java` has several problems:
--`Task` is an implementation of `Runable` while itself contains a reference
of `Future` which is the handler of the `Runnable` after being submitted.
The life-cycle of the `Runnable` shouldn't be controlled by itself as it looks
like right now, but should be the `TaskExecutor` or something externally.
-- Because of the existence of a `Future` object within Task, there's a
bug in the implementation: The extension of `Task`, which is `TaskIFaceWrapper`
doesn't have the constructor to initialize this variable, while one of the
public method(`completeShutdown` within `cancel`) is exposing the accessing of
this variable. This is a bug and the original fix in this
PR:https://github.com/apache/incubator-gobblin/pull/2157/files is doing wrong
thing to copy the base class's method and remove the calling of
`completeShutdown`. In fact, the future object doesn't have to be existed in
the first place.
-- Fixing some other typos, and unit test problems as well.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (GOBBLIN-1068) Clean cyclic logic in task cancellation in Gobblin Task
Lei Sun created GOBBLIN-1068: Summary: Clean cyclic logic in task cancellation in Gobblin Task Key: GOBBLIN-1068 URL: https://issues.apache.org/jira/browse/GOBBLIN-1068 Project: Apache Gobblin Issue Type: Bug Reporter: Lei Sun -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-1067) Add SFTP DataNode type in Gobblin-as-a-Service (GaaS) FlowGraph
[ https://issues.apache.org/jira/browse/GOBBLIN-1067?focusedWorklogId=397045&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-397045 ] ASF GitHub Bot logged work on GOBBLIN-1067: --- Author: ASF GitHub Bot Created on: 03/Mar/20 21:09 Start Date: 03/Mar/20 21:09 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2906: GOBBLIN-1067: Add SFTP DataNode type in Gobblin-as-a-Service (GaaS) F… URL: https://github.com/apache/incubator-gobblin/pull/2906 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 397045) Time Spent: 40m (was: 0.5h) > Add SFTP DataNode type in Gobblin-as-a-Service (GaaS) FlowGraph > > > Key: GOBBLIN-1067 > URL: https://issues.apache.org/jira/browse/GOBBLIN-1067 > Project: Apache Gobblin > Issue Type: Improvement > Components: gobblin-service >Affects Versions: 0.15.0 >Reporter: Sudarshan Vasudevan >Assignee: Abhishek Tiwari >Priority: Major > Fix For: 0.15.0 > > Time Spent: 40m > Remaining Estimate: 0h > > This PR adds a new DataNode type in GaaS FlowGraph. This will allow GaaS' > MultiHop flow compiler to orchetrate jobs pulling/pushing data from/to SFTP > source/sinks. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [incubator-gobblin] asfgit closed pull request #2906: GOBBLIN-1067: Add SFTP DataNode type in Gobblin-as-a-Service (GaaS) F…
asfgit closed pull request #2906: GOBBLIN-1067: Add SFTP DataNode type in Gobblin-as-a-Service (GaaS) F… URL: https://github.com/apache/incubator-gobblin/pull/2906 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (GOBBLIN-1067) Add SFTP DataNode type in Gobblin-as-a-Service (GaaS) FlowGraph
[ https://issues.apache.org/jira/browse/GOBBLIN-1067?focusedWorklogId=396906&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-396906 ] ASF GitHub Bot logged work on GOBBLIN-1067: --- Author: ASF GitHub Bot Created on: 03/Mar/20 18:21 Start Date: 03/Mar/20 18:21 Worklog Time Spent: 10m Work Description: codecov-io commented on issue #2906: GOBBLIN-1067: Add SFTP DataNode type in Gobblin-as-a-Service (GaaS) F… URL: https://github.com/apache/incubator-gobblin/pull/2906#issuecomment-594094962 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2906?src=pr&el=h1) Report > Merging [#2906](https://codecov.io/gh/apache/incubator-gobblin/pull/2906?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/0de109b6941e636f4a35069752ef1e3c4188054d?src=pr&el=desc) will **increase** coverage by `<.01%`. > The diff coverage is `85%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2906?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#2906 +/- ## + Coverage 45.86% 45.86% +<.01% - Complexity 9170 9188 +18 Files 1932 1934 +2 Lines 7278972856 +67 Branches 8022 8032 +10 + Hits 3338633418 +32 - Misses3634236374 +32 - Partials 3061 3064 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2906?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...e/modules/flowgraph/datanodes/fs/SftpDataNode.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93Z3JhcGgvZGF0YW5vZGVzL2ZzL1NmdHBEYXRhTm9kZS5qYXZh) | `85% <85%> (ø)` | `7 <7> (?)` | | | [.../hive/filter/LookbackPartitionFilterGenerator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvaGl2ZS9maWx0ZXIvTG9va2JhY2tQYXJ0aXRpb25GaWx0ZXJHZW5lcmF0b3IuamF2YQ==) | `78.94% <0%> (-21.06%)` | `6% <0%> (+3%)` | | | [...re/ControllerUserDefinedMessageHandlerFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9jb3JlL0NvbnRyb2xsZXJVc2VyRGVmaW5lZE1lc3NhZ2VIYW5kbGVyRmFjdG9yeS5qYXZh) | `39.06% <0%> (-12.5%)` | `4% <0%> (ø)` | | | [...estli/GobblinServiceFlowConfigResourceHandler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9yZXN0bGkvR29iYmxpblNlcnZpY2VGbG93Q29uZmlnUmVzb3VyY2VIYW5kbGVyLmphdmE=) | `44.61% <0%> (-6.16%)` | `10% <0%> (-1%)` | | | [.../modules/scheduler/GobblinServiceJobScheduler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9zY2hlZHVsZXIvR29iYmxpblNlcnZpY2VKb2JTY2hlZHVsZXIuamF2YQ==) | `53.71% <0%> (-4.58%)` | `19% <0%> (-2%)` | | | [...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvWm9va2VlcGVyQmFzZWRKb2JMb2NrLmphdmE=) | `63.33% <0%> (-1.12%)` | `15% <0%> (-1%)` | | | [...rg/apache/gobblin/yarn/GobblinYarnAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5BcHBMYXVuY2hlci5qYXZh) | `21.02% <0%> (-0.16%)` | `8% <0%> (ø)` | | | [...blin/service/modules/orchestration/DagManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0RhZ01hbmFnZXIuamF2YQ==) | `76.47% <0%> (-0.08%)` | `13% <0%> (ø)` | | | [...ain/java/org/apache/gobblin/runtime/fork/Fork.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvZm9yay9Gb3JrLmphdmE=) | `75% <0%> (ø)` | `68% <0%> (ø)` | :arrow_dow
[GitHub] [incubator-gobblin] codecov-io commented on issue #2906: GOBBLIN-1067: Add SFTP DataNode type in Gobblin-as-a-Service (GaaS) F…
codecov-io commented on issue #2906: GOBBLIN-1067: Add SFTP DataNode type in Gobblin-as-a-Service (GaaS) F… URL: https://github.com/apache/incubator-gobblin/pull/2906#issuecomment-594094962 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2906?src=pr&el=h1) Report > Merging [#2906](https://codecov.io/gh/apache/incubator-gobblin/pull/2906?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/0de109b6941e636f4a35069752ef1e3c4188054d?src=pr&el=desc) will **increase** coverage by `<.01%`. > The diff coverage is `85%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2906?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#2906 +/- ## + Coverage 45.86% 45.86% +<.01% - Complexity 9170 9188 +18 Files 1932 1934 +2 Lines 7278972856 +67 Branches 8022 8032 +10 + Hits 3338633418 +32 - Misses3634236374 +32 - Partials 3061 3064 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2906?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...e/modules/flowgraph/datanodes/fs/SftpDataNode.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93Z3JhcGgvZGF0YW5vZGVzL2ZzL1NmdHBEYXRhTm9kZS5qYXZh) | `85% <85%> (ø)` | `7 <7> (?)` | | | [.../hive/filter/LookbackPartitionFilterGenerator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvaGl2ZS9maWx0ZXIvTG9va2JhY2tQYXJ0aXRpb25GaWx0ZXJHZW5lcmF0b3IuamF2YQ==) | `78.94% <0%> (-21.06%)` | `6% <0%> (+3%)` | | | [...re/ControllerUserDefinedMessageHandlerFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9jb3JlL0NvbnRyb2xsZXJVc2VyRGVmaW5lZE1lc3NhZ2VIYW5kbGVyRmFjdG9yeS5qYXZh) | `39.06% <0%> (-12.5%)` | `4% <0%> (ø)` | | | [...estli/GobblinServiceFlowConfigResourceHandler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9yZXN0bGkvR29iYmxpblNlcnZpY2VGbG93Q29uZmlnUmVzb3VyY2VIYW5kbGVyLmphdmE=) | `44.61% <0%> (-6.16%)` | `10% <0%> (-1%)` | | | [.../modules/scheduler/GobblinServiceJobScheduler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9zY2hlZHVsZXIvR29iYmxpblNlcnZpY2VKb2JTY2hlZHVsZXIuamF2YQ==) | `53.71% <0%> (-4.58%)` | `19% <0%> (-2%)` | | | [...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvWm9va2VlcGVyQmFzZWRKb2JMb2NrLmphdmE=) | `63.33% <0%> (-1.12%)` | `15% <0%> (-1%)` | | | [...rg/apache/gobblin/yarn/GobblinYarnAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5BcHBMYXVuY2hlci5qYXZh) | `21.02% <0%> (-0.16%)` | `8% <0%> (ø)` | | | [...blin/service/modules/orchestration/DagManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0RhZ01hbmFnZXIuamF2YQ==) | `76.47% <0%> (-0.08%)` | `13% <0%> (ø)` | | | [...ain/java/org/apache/gobblin/runtime/fork/Fork.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvZm9yay9Gb3JrLmphdmE=) | `75% <0%> (ø)` | `68% <0%> (ø)` | :arrow_down: | | [.../apache/gobblin/service/FlowConfigsV2Resource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnc1YyUmVzb3VyY2UuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: | | ... and [10 more](https://codeco
[jira] [Work logged] (GOBBLIN-1067) Add SFTP DataNode type in Gobblin-as-a-Service (GaaS) FlowGraph
[ https://issues.apache.org/jira/browse/GOBBLIN-1067?focusedWorklogId=396878&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-396878 ] ASF GitHub Bot logged work on GOBBLIN-1067: --- Author: ASF GitHub Bot Created on: 03/Mar/20 17:39 Start Date: 03/Mar/20 17:39 Worklog Time Spent: 10m Work Description: sv2000 commented on issue #2906: GOBBLIN-1067: Add SFTP DataNode type in Gobblin-as-a-Service (GaaS) F… URL: https://github.com/apache/incubator-gobblin/pull/2906#issuecomment-594075696 @jack-moseley Please review. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 396878) Time Spent: 20m (was: 10m) > Add SFTP DataNode type in Gobblin-as-a-Service (GaaS) FlowGraph > > > Key: GOBBLIN-1067 > URL: https://issues.apache.org/jira/browse/GOBBLIN-1067 > Project: Apache Gobblin > Issue Type: Improvement > Components: gobblin-service >Affects Versions: 0.15.0 >Reporter: Sudarshan Vasudevan >Assignee: Abhishek Tiwari >Priority: Major > Fix For: 0.15.0 > > Time Spent: 20m > Remaining Estimate: 0h > > This PR adds a new DataNode type in GaaS FlowGraph. This will allow GaaS' > MultiHop flow compiler to orchetrate jobs pulling/pushing data from/to SFTP > source/sinks. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [incubator-gobblin] sv2000 opened a new pull request #2906: GOBBLIN-1067: Add SFTP DataNode type in Gobblin-as-a-Service (GaaS) F…
sv2000 opened a new pull request #2906: GOBBLIN-1067: Add SFTP DataNode type in
Gobblin-as-a-Service (GaaS) F…
URL: https://github.com/apache/incubator-gobblin/pull/2906
…lowGraph
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1067
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
This PR adds a new DataNode type in GaaS FlowGraph. This will allow GaaS'
MultiHop flow compiler to orchetrate jobs pulling/pushing data from/to SFTP
source/sinks.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Added a unit test.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] sv2000 commented on issue #2906: GOBBLIN-1067: Add SFTP DataNode type in Gobblin-as-a-Service (GaaS) F…
sv2000 commented on issue #2906: GOBBLIN-1067: Add SFTP DataNode type in Gobblin-as-a-Service (GaaS) F… URL: https://github.com/apache/incubator-gobblin/pull/2906#issuecomment-594075696 @jack-moseley Please review. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (GOBBLIN-1067) Add SFTP DataNode type in Gobblin-as-a-Service (GaaS) FlowGraph
[
https://issues.apache.org/jira/browse/GOBBLIN-1067?focusedWorklogId=396877&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-396877
]
ASF GitHub Bot logged work on GOBBLIN-1067:
---
Author: ASF GitHub Bot
Created on: 03/Mar/20 17:38
Start Date: 03/Mar/20 17:38
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2906: GOBBLIN-1067:
Add SFTP DataNode type in Gobblin-as-a-Service (GaaS) F…
URL: https://github.com/apache/incubator-gobblin/pull/2906
…lowGraph
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1067
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
This PR adds a new DataNode type in GaaS FlowGraph. This will allow GaaS'
MultiHop flow compiler to orchetrate jobs pulling/pushing data from/to SFTP
source/sinks.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Added a unit test.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 396877)
Remaining Estimate: 0h
Time Spent: 10m
> Add SFTP DataNode type in Gobblin-as-a-Service (GaaS) FlowGraph
>
>
> Key: GOBBLIN-1067
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1067
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-service
>Affects Versions: 0.15.0
>Reporter: Sudarshan Vasudevan
>Assignee: Abhishek Tiwari
>Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This PR adds a new DataNode type in GaaS FlowGraph. This will allow GaaS'
> MultiHop flow compiler to orchetrate jobs pulling/pushing data from/to SFTP
> source/sinks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (GOBBLIN-1067) Add SFTP DataNode type in Gobblin-as-a-Service (GaaS) FlowGraph
Sudarshan Vasudevan created GOBBLIN-1067: Summary: Add SFTP DataNode type in Gobblin-as-a-Service (GaaS) FlowGraph Key: GOBBLIN-1067 URL: https://issues.apache.org/jira/browse/GOBBLIN-1067 Project: Apache Gobblin Issue Type: Improvement Components: gobblin-service Affects Versions: 0.15.0 Reporter: Sudarshan Vasudevan Assignee: Abhishek Tiwari Fix For: 0.15.0 This PR adds a new DataNode type in GaaS FlowGraph. This will allow GaaS' MultiHop flow compiler to orchetrate jobs pulling/pushing data from/to SFTP source/sinks. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-1064) Make KafkaAvroSchemaRegistry extendable
[ https://issues.apache.org/jira/browse/GOBBLIN-1064?focusedWorklogId=396839&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-396839 ] ASF GitHub Bot logged work on GOBBLIN-1064: --- Author: ASF GitHub Bot Created on: 03/Mar/20 16:18 Start Date: 03/Mar/20 16:18 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2905: [GOBBLIN-1064]Make KafkaAvroSchemaRegistry extendable URL: https://github.com/apache/incubator-gobblin/pull/2905 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 396839) Time Spent: 40m (was: 0.5h) > Make KafkaAvroSchemaRegistry extendable > --- > > Key: GOBBLIN-1064 > URL: https://issues.apache.org/jira/browse/GOBBLIN-1064 > Project: Apache Gobblin > Issue Type: Task >Reporter: Zihan Li >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [incubator-gobblin] asfgit closed pull request #2905: [GOBBLIN-1064]Make KafkaAvroSchemaRegistry extendable
asfgit closed pull request #2905: [GOBBLIN-1064]Make KafkaAvroSchemaRegistry extendable URL: https://github.com/apache/incubator-gobblin/pull/2905 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
