[
https://issues.apache.org/jira/browse/GOBBLIN-1091?focusedWorklogId=406641=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-406641
]
ASF GitHub Bot logged work on GOBBLIN-1091:
---
Author: ASF GitHub Bot
Created on: 19/Mar/20 23:31
Start Date: 19/Mar/20 23:31
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2933: GOBBLIN-1091:
Pass Yarn application id as part of AppMaster and YarnT…
URL: https://github.com/apache/incubator-gobblin/pull/2933
…askRunner's start up command
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1091
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
Currently, the application id is retrieved from the container id in Gobblin
Yarn applications. This makes it hard to isolate the source of
misconfigurations in the application work directory (i.e. Yarn vs Helix vs
Gobblin), which is generated dynamically using Yarn application name and Yarn
application id. Having the Yarn application id generated in one place (i.e.
GobblinYarnAppLauncher) and passed to all participants in the Yarn application
ensures a more explainable and debuggable behavior in how application working
directories are set.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Modified existing unit tests.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 406641)
Remaining Estimate: 0h
Time Spent: 10m
> Pass Yarn application id as part of AppMaster and YarnTaskRunner's start up
> command
> ---
>
> Key: GOBBLIN-1091
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1091
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-yarn
>Affects Versions: 0.15.0
>Reporter: Sudarshan Vasudevan
>Assignee: Abhishek Tiwari
>Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, the application id is retrieved from the container id in Gobblin
> Yarn applications. This makes it hard to isolate the source of
> misconfigurations in the application work directory (i.e. Yarn vs Helix vs
> Gobblin), which is generated dynamically using Yarn application name and Yarn
> application id. Having the Yarn application id generated in one place (i.e.
> GobblinYarnAppLauncher) and passed to all participants in the Yarn
> application ensures a more explainable and debuggable behavior in how
> application working directories are set.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
