[jira] [Work logged] (GOBBLIN-896) Clone schema or field props in AvroFieldRemover
[ https://issues.apache.org/jira/browse/GOBBLIN-896?focusedWorklogId=326592=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-326592 ] ASF GitHub Bot logged work on GOBBLIN-896: -- Author: ASF GitHub Bot Created on: 10/Oct/19 21:45 Start Date: 10/Oct/19 21:45 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2750: [GOBBLIN-896] Clone schema and field props in AvroSchemaFieldRemover URL: https://github.com/apache/incubator-gobblin/pull/2750 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 326592) Time Spent: 40m (was: 0.5h) > Clone schema or field props in AvroFieldRemover > --- > > Key: GOBBLIN-896 > URL: https://issues.apache.org/jira/browse/GOBBLIN-896 > Project: Apache Gobblin > Issue Type: Task >Reporter: Zhixiong Chen >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > Currently, `AvroFieldRemover` ignores schema and field level properties while > cloning the schema and its fields. The change is to fix it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-896) Clone schema or field props in AvroFieldRemover
[ https://issues.apache.org/jira/browse/GOBBLIN-896?focusedWorklogId=323792=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323792 ] ASF GitHub Bot logged work on GOBBLIN-896: -- Author: ASF GitHub Bot Created on: 04/Oct/19 23:16 Start Date: 04/Oct/19 23:16 Worklog Time Spent: 10m Work Description: codecov-io commented on issue #2750: [GOBBLIN-896] Clone schema and field props in AvroSchemaFieldRemover URL: https://github.com/apache/incubator-gobblin/pull/2750#issuecomment-538588874 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2750?src=pr=h1) Report > Merging [#2750](https://codecov.io/gh/apache/incubator-gobblin/pull/2750?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/5b8af8cf6e932e8031ef060c79260a4a8f47974c?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2750?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#2750 +/- ## + Coverage 45.27% 45.28% +<.01% - Complexity 8828 8832 +4 Files 1889 1889 Lines 7063470640 +6 Branches 7757 7759 +2 + Hits 3197931986 +7 Misses3570135701 + Partials 2954 2953 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2750?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...bblin/converter/filter/AvroSchemaFieldRemover.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2750/diff?src=pr=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29udmVydGVyL2ZpbHRlci9BdnJvU2NoZW1hRmllbGRSZW1vdmVyLmphdmE=) | `94.82% <100%> (+0.59%)` | `27 <0> (+2)` | :arrow_up: | | [...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2750/diff?src=pr=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=) | `70% <0%> (-2.23%)` | `13% <0%> (ø)` | | | [...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2750/diff?src=pr=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==) | `30.87% <0%> (+0.67%)` | `25% <0%> (+1%)` | :arrow_up: | | [...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2750/diff?src=pr=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh) | `62.85% <0%> (+1.42%)` | `4% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2750?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2750?src=pr=footer). Last update [5b8af8c...1a5661d](https://codecov.io/gh/apache/incubator-gobblin/pull/2750?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 323792) Time Spent: 0.5h (was: 20m) > Clone schema or field props in AvroFieldRemover > --- > > Key: GOBBLIN-896 > URL: https://issues.apache.org/jira/browse/GOBBLIN-896 > Project: Apache Gobblin > Issue Type: Task >Reporter: Zhixiong Chen >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Currently, `AvroFieldRemover` ignores schema and field level properties while > cloning the schema and its fields. The change is to fix it. -- This message was sent by Atlassian
[jira] [Work logged] (GOBBLIN-896) Clone schema or field props in AvroFieldRemover
[ https://issues.apache.org/jira/browse/GOBBLIN-896?focusedWorklogId=322949=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322949 ] ASF GitHub Bot logged work on GOBBLIN-896: -- Author: ASF GitHub Bot Created on: 03/Oct/19 20:44 Start Date: 03/Oct/19 20:44 Worklog Time Spent: 10m Work Description: zxcware commented on issue #2750: [GOBBLIN-896] Clone schema and field props in AvroSchemaFieldRemover URL: https://github.com/apache/incubator-gobblin/pull/2750#issuecomment-538120670 @htran1 please review when you get time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 322949) Time Spent: 20m (was: 10m) > Clone schema or field props in AvroFieldRemover > --- > > Key: GOBBLIN-896 > URL: https://issues.apache.org/jira/browse/GOBBLIN-896 > Project: Apache Gobblin > Issue Type: Task >Reporter: Zhixiong Chen >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Currently, `AvroFieldRemover` ignores schema and field level properties while > cloning the schema and its fields. The change is to fix it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-896) Clone schema or field props in AvroFieldRemover
[
https://issues.apache.org/jira/browse/GOBBLIN-896?focusedWorklogId=322947=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322947
]
ASF GitHub Bot logged work on GOBBLIN-896:
--
Author: ASF GitHub Bot
Created on: 03/Oct/19 20:43
Start Date: 03/Oct/19 20:43
Worklog Time Spent: 10m
Work Description: zxcware commented on pull request #2750: [GOBBLIN-896]
Clone schema and field props in AvroSchemaFieldRemover
URL: https://github.com/apache/incubator-gobblin/pull/2750
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title.
- https://issues.apache.org/jira/browse/GOBBLIN-896
### Description
- [x] Here are some details about my PR:
- Currently, `AvroSchemaFieldRemover` ignores schema and field level
properties while cloning the schema and its fields. The change is to fix it.
### Tests
- [x] My PR adds the following unit tests:
- `AvroSchemaFieldRemoverTest.testRemoveFields` covers that props of the
schema and field are cloned
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 322947)
Remaining Estimate: 0h
Time Spent: 10m
> Clone schema or field props in AvroFieldRemover
> ---
>
> Key: GOBBLIN-896
> URL: https://issues.apache.org/jira/browse/GOBBLIN-896
> Project: Apache Gobblin
> Issue Type: Task
>Reporter: Zhixiong Chen
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, `AvroFieldRemover` ignores schema and field level properties while
> cloning the schema and its fields. The change is to fix it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
