[jira] [Work logged] (GOBBLIN-938) Extend template-resolution in all JobLauncher
[ https://issues.apache.org/jira/browse/GOBBLIN-938?focusedWorklogId=336795=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-336795 ] ASF GitHub Bot logged work on GOBBLIN-938: -- Author: ASF GitHub Bot Created on: 31/Oct/19 14:21 Start Date: 31/Oct/19 14:21 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2787: [GOBBLIN-938] Make job-template resolution available in all JobLaunchers URL: https://github.com/apache/incubator-gobblin/pull/2787 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 336795) Time Spent: 0.5h (was: 20m) > Extend template-resolution in all JobLauncher > - > > Key: GOBBLIN-938 > URL: https://issues.apache.org/jira/browse/GOBBLIN-938 > Project: Apache Gobblin > Issue Type: Improvement >Reporter: Lei Sun >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-938) Extend template-resolution in all JobLauncher
[ https://issues.apache.org/jira/browse/GOBBLIN-938?focusedWorklogId=336627=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-336627 ] ASF GitHub Bot logged work on GOBBLIN-938: -- Author: ASF GitHub Bot Created on: 31/Oct/19 05:42 Start Date: 31/Oct/19 05:42 Worklog Time Spent: 10m Work Description: codecov-io commented on issue #2787: [GOBBLIN-938] Make job-template resolution available in all JobLaunchers URL: https://github.com/apache/incubator-gobblin/pull/2787#issuecomment-548224920 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2787?src=pr=h1) Report > Merging [#2787](https://codecov.io/gh/apache/incubator-gobblin/pull/2787?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/d9e4f9a39f56c845d82fceb1a0c410655bca09b0?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `84.61%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2787?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#2787 +/- ## + Coverage 45.32% 45.34% +0.01% - Complexity 8858 8863 +5 Files 1894 1894 Lines 7087470877 +3 Branches 7794 7793 -1 + Hits 3212332138 +15 + Misses3578835779 -9 + Partials 2963 2960 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2787?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pache/gobblin/cluster/GobblinHelixJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2787/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXIuamF2YQ==) | `81.81% <ø> (ø)` | `26 <0> (ø)` | :arrow_down: | | [...org/apache/gobblin/azkaban/AzkabanJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2787/diff?src=pr=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tYXprYWJhbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9hemthYmFuL0F6a2FiYW5Kb2JMYXVuY2hlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...rg/apache/gobblin/runtime/AbstractJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2787/diff?src=pr=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvQWJzdHJhY3RKb2JMYXVuY2hlci5qYXZh) | `59.13% <100%> (+1.01%)` | `33 <2> (+2)` | :arrow_up: | | [...gobblin/service/modules/spec/JobExecutionPlan.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2787/diff?src=pr=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9zcGVjL0pvYkV4ZWN1dGlvblBsYW4uamF2YQ==) | `75.8% <100%> (ø)` | `9 <0> (ø)` | :arrow_down: | | [...odules/template\_catalog/FSFlowTemplateCatalog.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2787/diff?src=pr=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy90ZW1wbGF0ZV9jYXRhbG9nL0ZTRmxvd1RlbXBsYXRlQ2F0YWxvZy5qYXZh) | `58.69% <50%> (ø)` | `8 <0> (ø)` | :arrow_down: | | [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2787/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `63.42% <0%> (-1.39%)` | `27% <0%> (-1%)` | | | [...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2787/diff?src=pr=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvWm9va2VlcGVyQmFzZWRKb2JMb2NrLmphdmE=) | `64.44% <0%> (+1.11%)` | `16% <0%> (+1%)` | :arrow_up: | | [...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2787/diff?src=pr=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=) | `72.22% <0%> (+2.22%)` | `13% <0%> (ø)` | :arrow_down: | |
[jira] [Work logged] (GOBBLIN-938) Extend template-resolution in all JobLauncher
[
https://issues.apache.org/jira/browse/GOBBLIN-938?focusedWorklogId=336538=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-336538
]
ASF GitHub Bot logged work on GOBBLIN-938:
--
Author: ASF GitHub Bot
Created on: 30/Oct/19 23:41
Start Date: 30/Oct/19 23:41
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2787:
[GOBBLIN-938] Make job-template resolution available in all JobLaunchers
URL: https://github.com/apache/incubator-gobblin/pull/2787
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] https://issues.apache.org/jira/browse/GOBBLIN-938
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
- Getting rid of duplicated `gobblin.job.templates` in GaaS code
- Making the job-template resolution available in `AbstractJobLauncher` so
that all its extensions will be able to resolve the template, including Helix
JobLauncher. Once it is being resolved and added as part of `JobContext`, the
`Source` will be added with this job properties so as passing-down to each
workunits.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason: Unit tested in `LocalJobLauncher`
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 336538)
Remaining Estimate: 0h
Time Spent: 10m
> Extend template-resolution in all JobLauncher
> -
>
> Key: GOBBLIN-938
> URL: https://issues.apache.org/jira/browse/GOBBLIN-938
> Project: Apache Gobblin
> Issue Type: Improvement
>Reporter: Lei Sun
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
