[jira] [Commented] (GORA-497) Migrate CassandraThrift to CQL
[
https://issues.apache.org/jira/browse/GORA-497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061370#comment-16061370
]
ASF GitHub Bot commented on GORA-497:
-
Github user madhawa-gunasekara commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r123820206
--- Diff:
gora-cassandra-cql/src/test/java/org/apache/gora/cassandra/store/TestCassandraStoreWithNativeSerialization.java
---
@@ -26,15 +26,20 @@ public static void setUpClass() throws Exception {
setProperties();
testDriver.setParameters(parameter);
testDriver.setUpClass();
+// This time is added since embedded cassandra service needs some time
to start up.
--- End diff --
I will try to fix this :)
> Migrate CassandraThrift to CQL
> ---
>
> Key: GORA-497
> URL: https://issues.apache.org/jira/browse/GORA-497
> Project: Apache Gora
> Issue Type: Improvement
> Components: gora-cassandra
>Reporter: Madhawa Gunasekara
>Assignee: Madhawa Gunasekara
> Labels: gsoc2017
> Fix For: 0.8
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] gora pull request #110: [WIP] GORA-497 : Rewrite Cassandra data store
Github user madhawa-gunasekara commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r123820206
--- Diff:
gora-cassandra-cql/src/test/java/org/apache/gora/cassandra/store/TestCassandraStoreWithNativeSerialization.java
---
@@ -26,15 +26,20 @@ public static void setUpClass() throws Exception {
setProperties();
testDriver.setParameters(parameter);
testDriver.setUpClass();
+// This time is added since embedded cassandra service needs some time
to start up.
--- End diff --
I will try to fix this :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (GORA-497) Migrate CassandraThrift to CQL
[
https://issues.apache.org/jira/browse/GORA-497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061368#comment-16061368
]
ASF GitHub Bot commented on GORA-497:
-
Github user madhawa-gunasekara commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r123820061
--- Diff:
gora-cassandra-cql/src/test/java/org/apache/gora/cassandra/GoraCassandraTestDriver.java
---
@@ -148,7 +156,7 @@ public void cleanupDirectoriesFailover() {
} catch (Exception e) {
// ignore exception
try {
- Thread.sleep(250);
+ Thread.sleep(2500);
--- End diff --
Yes this was for debugging.
> Migrate CassandraThrift to CQL
> ---
>
> Key: GORA-497
> URL: https://issues.apache.org/jira/browse/GORA-497
> Project: Apache Gora
> Issue Type: Improvement
> Components: gora-cassandra
>Reporter: Madhawa Gunasekara
>Assignee: Madhawa Gunasekara
> Labels: gsoc2017
> Fix For: 0.8
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] gora pull request #110: [WIP] GORA-497 : Rewrite Cassandra data store
Github user madhawa-gunasekara commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r123820061
--- Diff:
gora-cassandra-cql/src/test/java/org/apache/gora/cassandra/GoraCassandraTestDriver.java
---
@@ -148,7 +156,7 @@ public void cleanupDirectoriesFailover() {
} catch (Exception e) {
// ignore exception
try {
- Thread.sleep(250);
+ Thread.sleep(2500);
--- End diff --
Yes this was for debugging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (GORA-497) Migrate CassandraThrift to CQL
[
https://issues.apache.org/jira/browse/GORA-497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061342#comment-16061342
]
ASF GitHub Bot commented on GORA-497:
-
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r123814516
--- Diff:
gora-cassandra-cql/src/test/java/org/apache/gora/cassandra/GoraCassandraTestDriver.java
---
@@ -148,7 +156,7 @@ public void cleanupDirectoriesFailover() {
} catch (Exception e) {
// ignore exception
try {
- Thread.sleep(250);
+ Thread.sleep(2500);
--- End diff --
Why is is longer? Is this for debugging only?
> Migrate CassandraThrift to CQL
> ---
>
> Key: GORA-497
> URL: https://issues.apache.org/jira/browse/GORA-497
> Project: Apache Gora
> Issue Type: Improvement
> Components: gora-cassandra
>Reporter: Madhawa Gunasekara
>Assignee: Madhawa Gunasekara
> Labels: gsoc2017
> Fix For: 0.8
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GORA-497) Migrate CassandraThrift to CQL
[ https://issues.apache.org/jira/browse/GORA-497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061344#comment-16061344 ] ASF GitHub Bot commented on GORA-497: - Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/110#discussion_r123814041 --- Diff: gora-cassandra-cql/pom.xml --- @@ -144,12 +144,28 @@ slf4j-log4j12 +io.netty +netty-handler + + org.slf4j log4j-over-slf4j + > Key: GORA-497 > URL: https://issues.apache.org/jira/browse/GORA-497 > Project: Apache Gora > Issue Type: Improvement > Components: gora-cassandra >Reporter: Madhawa Gunasekara >Assignee: Madhawa Gunasekara > Labels: gsoc2017 > Fix For: 0.8 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GORA-497) Migrate CassandraThrift to CQL
[ https://issues.apache.org/jira/browse/GORA-497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061341#comment-16061341 ] ASF GitHub Bot commented on GORA-497: - Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/110#discussion_r123813981 --- Diff: gora-cassandra-cql/pom.xml --- @@ -49,7 +49,7 @@ -17.0 +18.0 --- End diff -- Please make sure this dependency is present in parent ```pom.xml```. It is an important dependency which is notorious for non backwards API changes. > Migrate CassandraThrift to CQL > --- > > Key: GORA-497 > URL: https://issues.apache.org/jira/browse/GORA-497 > Project: Apache Gora > Issue Type: Improvement > Components: gora-cassandra >Reporter: Madhawa Gunasekara >Assignee: Madhawa Gunasekara > Labels: gsoc2017 > Fix For: 0.8 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GORA-497) Migrate CassandraThrift to CQL
[
https://issues.apache.org/jira/browse/GORA-497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061343#comment-16061343
]
ASF GitHub Bot commented on GORA-497:
-
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r123814653
--- Diff:
gora-cassandra-cql/src/test/java/org/apache/gora/cassandra/store/TestCassandraStoreWithNativeSerialization.java
---
@@ -26,15 +26,20 @@ public static void setUpClass() throws Exception {
setProperties();
testDriver.setParameters(parameter);
testDriver.setUpClass();
+// This time is added since embedded cassandra service needs some time
to start up.
--- End diff --
ack... why so long I wonder? same as hot loading in Tomcat.
> Migrate CassandraThrift to CQL
> ---
>
> Key: GORA-497
> URL: https://issues.apache.org/jira/browse/GORA-497
> Project: Apache Gora
> Issue Type: Improvement
> Components: gora-cassandra
>Reporter: Madhawa Gunasekara
>Assignee: Madhawa Gunasekara
> Labels: gsoc2017
> Fix For: 0.8
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] gora pull request #110: [WIP] GORA-497 : Rewrite Cassandra data store
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r123814653
--- Diff:
gora-cassandra-cql/src/test/java/org/apache/gora/cassandra/store/TestCassandraStoreWithNativeSerialization.java
---
@@ -26,15 +26,20 @@ public static void setUpClass() throws Exception {
setProperties();
testDriver.setParameters(parameter);
testDriver.setUpClass();
+// This time is added since embedded cassandra service needs some time
to start up.
--- End diff --
ack... why so long I wonder? same as hot loading in Tomcat.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request #110: [WIP] GORA-497 : Rewrite Cassandra data store
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/110#discussion_r123814041 --- Diff: gora-cassandra-cql/pom.xml --- @@ -144,12 +144,28 @@ slf4j-log4j12 +io.netty +netty-handler + + org.slf4j log4j-over-slf4j +
[GitHub] gora pull request #110: [WIP] GORA-497 : Rewrite Cassandra data store
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r123814516
--- Diff:
gora-cassandra-cql/src/test/java/org/apache/gora/cassandra/GoraCassandraTestDriver.java
---
@@ -148,7 +156,7 @@ public void cleanupDirectoriesFailover() {
} catch (Exception e) {
// ignore exception
try {
- Thread.sleep(250);
+ Thread.sleep(2500);
--- End diff --
Why is is longer? Is this for debugging only?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request #110: [WIP] GORA-497 : Rewrite Cassandra data store
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/110#discussion_r123813981 --- Diff: gora-cassandra-cql/pom.xml --- @@ -49,7 +49,7 @@ -17.0 +18.0 --- End diff -- Please make sure this dependency is present in parent ```pom.xml```. It is an important dependency which is notorious for non backwards API changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
