[GitHub] gora pull request #110: [WIP] GORA-497 : Rewrite Cassandra data store
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/110#discussion_r129360462 --- Diff: gora-cassandra-cql/src/main/java/org/apache/gora/cassandra/serializers/AvroCassandraUtils.java --- @@ -0,0 +1,274 @@ +package org.apache.gora.cassandra.serializers; --- End diff -- Add license header --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] gora pull request #110: [WIP] GORA-497 : Rewrite Cassandra data store
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r129359927
--- Diff: gora-cassandra-cql/src/examples/avro/cassandraRecord.json ---
@@ -0,0 +1,106 @@
+{
+ "type": "record",
+ "name": "CassandraRecord",
+ "default": null,
+ "namespace":
"org.apache.gora.cassandra.example.generated.avroSerialization",
--- End diff --
Please do the same with this schema.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request #110: [WIP] GORA-497 : Rewrite Cassandra data store
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/110#discussion_r129360056 --- Diff: gora-cassandra-cql/src/examples/java/org/apache/gora/cassandra/example/generated/avroSerialization/CassandraKey.java --- @@ -0,0 +1,380 @@ +/** + *Licensed to the Apache Software Foundation (ASF) under one + *or more contributor license agreements. See the NOTICE file + *distributed with this work for additional information + *regarding copyright ownership. The ASF licenses this file + *to you under the Apache License, Version 2.0 (the" + *License"); you may not use this file except in compliance + *with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + *Unless required by applicable law or agreed to in writing, software + *distributed under the License is distributed on an "AS IS" BASIS, + *WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + *See the License for the specific language governing permissions and + *limitations under the License. + */ +package org.apache.gora.cassandra.example.generated.avroSerialization; --- End diff -- Please recompile these schemas with updates as described above --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] gora pull request #110: [WIP] GORA-497 : Rewrite Cassandra data store
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r129362202
--- Diff:
gora-cassandra-cql/src/main/java/org/apache/gora/cassandra/store/CassandraMappingBuilder.java
---
@@ -135,13 +137,16 @@ public CassandraMapping readMapping(String filename)
throws IOException {
}
break;
}
-map.setKeySpace(keyspace);
+cassandraMapping.setKeySpace(keyspace);
break;
}
}
}
+ else {
+throw new RuntimeException("KeySpace couldn't be able to found in
the cassandra mapping. Please configure the cassandra mapping correctly.");
--- End diff --
Please change the following statement ```KeySpace couldn't be able to found
in the cassandra mapping. Please configure the cassandra mapping correctly.```
to ```Couldn't find KeySpace in the Cassandra mapping. Please configure the
cassandra mapping correctly.```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request #110: [WIP] GORA-497 : Rewrite Cassandra data store
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r129359438
--- Diff: gora-cassandra-cql/src/examples/avro/cassandraKey.json ---
@@ -0,0 +1,21 @@
+{
+ "type": "record",
+ "name": "CassandraKey",
+ "default": null,
--- End diff --
Can you provide a 'doc' field as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (GORA-497) Migrate CassandraThrift to CQL
[
https://issues.apache.org/jira/browse/GORA-497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100342#comment-16100342
]
ASF GitHub Bot commented on GORA-497:
-
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r129359438
--- Diff: gora-cassandra-cql/src/examples/avro/cassandraKey.json ---
@@ -0,0 +1,21 @@
+{
+ "type": "record",
+ "name": "CassandraKey",
+ "default": null,
--- End diff --
Can you provide a 'doc' field as well?
> Migrate CassandraThrift to CQL
> ---
>
> Key: GORA-497
> URL: https://issues.apache.org/jira/browse/GORA-497
> Project: Apache Gora
> Issue Type: Improvement
> Components: gora-cassandra
>Reporter: Madhawa Gunasekara
>Assignee: Madhawa Gunasekara
> Labels: gsoc2017
> Fix For: 0.8
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] gora pull request #110: [WIP] GORA-497 : Rewrite Cassandra data store
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r129360422
--- Diff:
gora-cassandra-cql/src/main/java/org/apache/gora/cassandra/query/CassandraResultSet.java
---
@@ -79,4 +79,8 @@ public void addResultElement(K key, T token) {
this.persistentObject.add(token);
this.size++;
}
+
+ public void setLimit(long limit) {
--- End diff --
Can you please make sure to document all (or as many as possible) public
method you implement. This is good practice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request #110: [WIP] GORA-497 : Rewrite Cassandra data store
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r129359618
--- Diff: gora-cassandra-cql/src/examples/avro/cassandraKey.json ---
@@ -0,0 +1,21 @@
+{
+ "type": "record",
+ "name": "CassandraKey",
+ "default": null,
+ "namespace":
"org.apache.gora.cassandra.example.generated.avroSerialization",
--- End diff --
Please change ```avroSerialization``` to ```AvroSerialization```, please
also rename ```cassandraKey.json``` to ```CassandraKey.json```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (GORA-497) Migrate CassandraThrift to CQL
[
https://issues.apache.org/jira/browse/GORA-497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100344#comment-16100344
]
ASF GitHub Bot commented on GORA-497:
-
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r129359618
--- Diff: gora-cassandra-cql/src/examples/avro/cassandraKey.json ---
@@ -0,0 +1,21 @@
+{
+ "type": "record",
+ "name": "CassandraKey",
+ "default": null,
+ "namespace":
"org.apache.gora.cassandra.example.generated.avroSerialization",
--- End diff --
Please change ```avroSerialization``` to ```AvroSerialization```, please
also rename ```cassandraKey.json``` to ```CassandraKey.json```
> Migrate CassandraThrift to CQL
> ---
>
> Key: GORA-497
> URL: https://issues.apache.org/jira/browse/GORA-497
> Project: Apache Gora
> Issue Type: Improvement
> Components: gora-cassandra
>Reporter: Madhawa Gunasekara
>Assignee: Madhawa Gunasekara
> Labels: gsoc2017
> Fix For: 0.8
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GORA-497) Migrate CassandraThrift to CQL
[
https://issues.apache.org/jira/browse/GORA-497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100341#comment-16100341
]
ASF GitHub Bot commented on GORA-497:
-
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r129359927
--- Diff: gora-cassandra-cql/src/examples/avro/cassandraRecord.json ---
@@ -0,0 +1,106 @@
+{
+ "type": "record",
+ "name": "CassandraRecord",
+ "default": null,
+ "namespace":
"org.apache.gora.cassandra.example.generated.avroSerialization",
--- End diff --
Please do the same with this schema.
> Migrate CassandraThrift to CQL
> ---
>
> Key: GORA-497
> URL: https://issues.apache.org/jira/browse/GORA-497
> Project: Apache Gora
> Issue Type: Improvement
> Components: gora-cassandra
>Reporter: Madhawa Gunasekara
>Assignee: Madhawa Gunasekara
> Labels: gsoc2017
> Fix For: 0.8
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GORA-497) Migrate CassandraThrift to CQL
[ https://issues.apache.org/jira/browse/GORA-497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100343#comment-16100343 ] ASF GitHub Bot commented on GORA-497: - Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/110#discussion_r129360056 --- Diff: gora-cassandra-cql/src/examples/java/org/apache/gora/cassandra/example/generated/avroSerialization/CassandraKey.java --- @@ -0,0 +1,380 @@ +/** + *Licensed to the Apache Software Foundation (ASF) under one + *or more contributor license agreements. See the NOTICE file + *distributed with this work for additional information + *regarding copyright ownership. The ASF licenses this file + *to you under the Apache License, Version 2.0 (the" + *License"); you may not use this file except in compliance + *with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + *Unless required by applicable law or agreed to in writing, software + *distributed under the License is distributed on an "AS IS" BASIS, + *WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + *See the License for the specific language governing permissions and + *limitations under the License. + */ +package org.apache.gora.cassandra.example.generated.avroSerialization; --- End diff -- Please recompile these schemas with updates as described above > Migrate CassandraThrift to CQL > --- > > Key: GORA-497 > URL: https://issues.apache.org/jira/browse/GORA-497 > Project: Apache Gora > Issue Type: Improvement > Components: gora-cassandra >Reporter: Madhawa Gunasekara >Assignee: Madhawa Gunasekara > Labels: gsoc2017 > Fix For: 0.8 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GORA-497) Migrate CassandraThrift to CQL
[
https://issues.apache.org/jira/browse/GORA-497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100345#comment-16100345
]
ASF GitHub Bot commented on GORA-497:
-
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r129360422
--- Diff:
gora-cassandra-cql/src/main/java/org/apache/gora/cassandra/query/CassandraResultSet.java
---
@@ -79,4 +79,8 @@ public void addResultElement(K key, T token) {
this.persistentObject.add(token);
this.size++;
}
+
+ public void setLimit(long limit) {
--- End diff --
Can you please make sure to document all (or as many as possible) public
method you implement. This is good practice.
> Migrate CassandraThrift to CQL
> ---
>
> Key: GORA-497
> URL: https://issues.apache.org/jira/browse/GORA-497
> Project: Apache Gora
> Issue Type: Improvement
> Components: gora-cassandra
>Reporter: Madhawa Gunasekara
>Assignee: Madhawa Gunasekara
> Labels: gsoc2017
> Fix For: 0.8
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GORA-497) Migrate CassandraThrift to CQL
[ https://issues.apache.org/jira/browse/GORA-497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100347#comment-16100347 ] ASF GitHub Bot commented on GORA-497: - Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/110#discussion_r129360462 --- Diff: gora-cassandra-cql/src/main/java/org/apache/gora/cassandra/serializers/AvroCassandraUtils.java --- @@ -0,0 +1,274 @@ +package org.apache.gora.cassandra.serializers; --- End diff -- Add license header > Migrate CassandraThrift to CQL > --- > > Key: GORA-497 > URL: https://issues.apache.org/jira/browse/GORA-497 > Project: Apache Gora > Issue Type: Improvement > Components: gora-cassandra >Reporter: Madhawa Gunasekara >Assignee: Madhawa Gunasekara > Labels: gsoc2017 > Fix For: 0.8 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GORA-497) Migrate CassandraThrift to CQL
[
https://issues.apache.org/jira/browse/GORA-497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100346#comment-16100346
]
ASF GitHub Bot commented on GORA-497:
-
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r129362202
--- Diff:
gora-cassandra-cql/src/main/java/org/apache/gora/cassandra/store/CassandraMappingBuilder.java
---
@@ -135,13 +137,16 @@ public CassandraMapping readMapping(String filename)
throws IOException {
}
break;
}
-map.setKeySpace(keyspace);
+cassandraMapping.setKeySpace(keyspace);
break;
}
}
}
+ else {
+throw new RuntimeException("KeySpace couldn't be able to found in
the cassandra mapping. Please configure the cassandra mapping correctly.");
--- End diff --
Please change the following statement ```KeySpace couldn't be able to found
in the cassandra mapping. Please configure the cassandra mapping correctly.```
to ```Couldn't find KeySpace in the Cassandra mapping. Please configure the
cassandra mapping correctly.```
> Migrate CassandraThrift to CQL
> ---
>
> Key: GORA-497
> URL: https://issues.apache.org/jira/browse/GORA-497
> Project: Apache Gora
> Issue Type: Improvement
> Components: gora-cassandra
>Reporter: Madhawa Gunasekara
>Assignee: Madhawa Gunasekara
> Labels: gsoc2017
> Fix For: 0.8
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
