Hi.
Thanks for the update.
Some comments:
Please use constants instead of literal values here:
https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/test/java/org/apache/gora/neo4j/GoraNeo4jTestDriver.java#L37
Add javadocs in these classes:
https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/test/java/org/apache/gora/neo4j/store/Neo4jStoreTest.java
https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/test/java/org/apache/gora/neo4j/GoraNeo4jTestDriver.java
Add descriptions for the attributes of these classes:
https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/mapping/Neo4jMapping.java
https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/mapping/Property.java
Please do not forget to submit your midpoint feedback. It is due Jan. 12
4pm UTC.
Cheers,
John
El sáb, 9 ene 2021 a las 18:18, gabriela ortiz ()
escribió:
> Hi all.
>
> I wanted to inform the tasks I worked on this week: Jan 01 - Jan 08
>
> - Develop a test for XSD validations.
> - Develop methods: exists and delete in the datastore.
> - Switch to Neo4j Enterprise from Neo4j Community in the container of the
> tests.
> - Add comments and javadocs
> - Change the UNIQUE indexes for NODE KEY indexes (present in the Neo4j
> Enterprise version)
>
> My code is here: https://github.com/mgov88/gora/tree/GORA-663
>
> Regardss
> Gaby
>
> El jue, 7 de ene. de 2021 a la(s) 13:28, gabriela ortiz (
> arqgabyor...@gmail.com) escribió:
>
>> Hi John
>>
>> Thanks for your comments.
>>
>>
>> El mié, 6 de ene. de 2021 a la(s) 16:10, John Mora (jhnmora...@gmail.com)
>> escribió:
>>
>>> Hi
>>>
>>> Thanks for your report.
>>>
>>> Some comments:
>>>
>>> You are creating a UNIQUE index instead of the NODE KEY you mentioned on
>>> your design document. why?
>>>
>>>
>>> https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L141
>>>
>>>
>> I found this limitation in the Neo4j community version: "Node key
>> constraints, node property existence constraints and relationship property
>> existence constraints are only available in Neo4j Enterprise Edition".
>>
>> And, the UNIQUE indexes work in the community version. Should I seek a
>> trial version of the enterprise version or work only with the UNIQUE
>> indexes of the community version?
>>
>>
>>
>>> Also, can you write the CREATE CONSTRAINT query with Cypher-DSL?
>>>
>>>
>> I could not find a API for constraints creation in Cypher DSL. The
>> create statements that I found are only for nodes.
>>
>> Please add javadoc documentation and comments on these classes:
>>>
>>>
>>> https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jConstants.java
>>>
>>> https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jParameters.java
>>>
>>> I will add the documentation
>>
>>
>>> Please add a test for the XSD Validation
>>>
>>>
>>> https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/resources/gora-neo4j.xsd
>>>
>>> I will add a test for this.
>>
>>
>>> Cheers,
>>> John
>>>
>>> El dom, 3 ene 2021 a las 23:12, gabriela ortiz ()
>>> escribió:
>>>
Hi
I wanted to inform the tasks I worked on this week: Dec 26 - Dec 31
* Develop the Datastore methods: getSchemaName, createSchema, deleteSchema,
schemaExists
* Enable tests in Neo4jStoreTest : testCreateSchema , testSchemaExists
* Enhance the implementation of the connection to the backend.
* Write a blog about my project.
You can find my code in my branch:
https://github.com/mgov88/gora/tree/GORA-663
Best Regards,
Gaby
El mié, 30 de dic. de 2020 a la(s) 13:28, John Mora (
jhnmora...@gmail.com) escribió:
> Hi
>
> Thanks for your report.
>
> The Utils package is specific for each datastore; it is not mandatory.
> You can move some code there to improve the readability of the core
> classes
> of the datastore but it is up to you.
>
> I could not find your last changes in your branch in github, please
> make sure to push the commits, so I can review the code.
>
> Cheers,
> John
>
>
> El mar, 29 dic 2020 a las 1:03, gabriela ortiz (<
> arqgabyor...@gmail.com>) escribió:
>
>> Hi
>>
>> I wanted to inform the tasks I worked on this week: Dec 19 - Dec 25
>>
>> * I developed a GoraTestDriver for Neo4j using GenericContainer from
>> the Test Containers library
>> * I developed the initialize method from Neo4jStore to establish
>> connection to the backend (Neo4j)
>> * I developed a XSD validation file for the XML mapping
>>
>> I have a question, I realized that some Datastores have 'utils'
>> packages in the code, are they obligatory? What kind of code should go in
>> them?
>>
>> Best Regards,
>> Gaby
