Re: Outreachy 2020-2021 - Neo4j - Weekly reports.
Hi John. Thanks for the feedback I will work on your comments. Regards, Gaby El mié, 10 de feb. de 2021 a la(s) 12:04, John Mora (jhnmora...@gmail.com) escribió: > Hi Gaby > > Thanks for the update. > > BTW, I am sorry that I did not provide feedback on your code last week, I > have been busy. > > Some comments: > > Please use more descriptive variable names: > > > https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L368 > > https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L165 > > https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L171 > > https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L193 > > https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L194 > > https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L200 > > https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L206 > > https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L216 > > https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L216 > > Typo: > > https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L216 > > Avoid string concatenation: > > https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L307 > > Use an Enum instead of string literals, > > https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L129 > > > regards > John > > El lun, 8 feb 2021 a las 2:08, gabriela ortiz () > escribió: > >> Hi all. >> >> I wanted to inform the tasks I worked on this week: Jan 30 - Feb 05 . >> >> * Enhance the deleteSchema method (delete existing nodes when deleting >> the schema constraints) >> * Enhance Map, Record, Array and Bytes serialization / de-serialization >> process using Base64 encoding. >> * Activate tests: >> testPutNested >> testPutArray >> testPutBytes >> testPutMap >> testPutMixedMaps >> testGetNested >> testGet3UnionField >> testGetWithFields >> >> My code is here: https://github.com/mgov88/gora/tree/GORA-663 >> >> Regards, >> Gaby >> >> El lun, 1 de feb. de 2021 a la(s) 01:53, gabriela ortiz ( >> arqgabyor...@gmail.com) escribió: >> >>> Hi all. >>> >>> I wanted to inform the tasks I worked on this week: Jan 17 - Jan 29 . >>> >>> * Add suggested javadocs. >>> * Add suggested constants. >>> * Make EXIST constraints optional. >>> * Activate tests: >>> testNewInstance >>> testAutoCreateSchema >>> testPut >>> testBenchmarkExists >>> testGetNonExisting >>> testObjectFieldValue >>> * Write a blog (Career opportunities) >>> >>> My code is here: https://github.com/mgov88/gora/tree/GORA-663 >>> >>> Regards, >>> Gaby >>> >>> >>> El mié, 27 de ene. de 2021 a la(s) 12:00, John Mora ( >>> jhnmora...@gmail.com) escribió: >>> Hi Gaby Thanks for your report. Some comments: Please use constants instead of literal values here: https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L204 https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L224 https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L251 https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L341 https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L284 Add javadocs here: https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L278 https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L388 https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L431 https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L487 https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L500 https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L507 Regarding the EXISTS constraint: IMHO that is a good approach, but let's make
Re: Outreachy 2020-2021 - Neo4j - Weekly reports.
Hi Gaby Thanks for the update. BTW, I am sorry that I did not provide feedback on your code last week, I have been busy. Some comments: Please use more descriptive variable names: https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L368 https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L165 https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L171 https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L193 https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L194 https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L200 https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L206 https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L216 https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L216 Typo: https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L216 Avoid string concatenation: https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L307 Use an Enum instead of string literals, https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L129 regards John El lun, 8 feb 2021 a las 2:08, gabriela ortiz () escribió: > Hi all. > > I wanted to inform the tasks I worked on this week: Jan 30 - Feb 05 . > > * Enhance the deleteSchema method (delete existing nodes when deleting the > schema constraints) > * Enhance Map, Record, Array and Bytes serialization / de-serialization > process using Base64 encoding. > * Activate tests: > testPutNested > testPutArray > testPutBytes > testPutMap > testPutMixedMaps > testGetNested > testGet3UnionField > testGetWithFields > > My code is here: https://github.com/mgov88/gora/tree/GORA-663 > > Regards, > Gaby > > El lun, 1 de feb. de 2021 a la(s) 01:53, gabriela ortiz ( > arqgabyor...@gmail.com) escribió: > >> Hi all. >> >> I wanted to inform the tasks I worked on this week: Jan 17 - Jan 29 . >> >> * Add suggested javadocs. >> * Add suggested constants. >> * Make EXIST constraints optional. >> * Activate tests: >> testNewInstance >> testAutoCreateSchema >> testPut >> testBenchmarkExists >> testGetNonExisting >> testObjectFieldValue >> * Write a blog (Career opportunities) >> >> My code is here: https://github.com/mgov88/gora/tree/GORA-663 >> >> Regards, >> Gaby >> >> >> El mié, 27 de ene. de 2021 a la(s) 12:00, John Mora (jhnmora...@gmail.com) >> escribió: >> >>> Hi Gaby >>> >>> Thanks for your report. >>> >>> Some comments: >>> >>> Please use constants instead of literal values here: >>> >>> https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L204 >>> >>> https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L224 >>> >>> https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L251 >>> >>> https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L341 >>> >>> https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L284 >>> >>> Add javadocs here: >>> >>> https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L278 >>> >>> https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L388 >>> >>> https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L431 >>> >>> https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L487 >>> >>> https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L500 >>> >>> https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/main/java/org/apache/gora/neo4j/store/Neo4jStore.java#L507 >>> >>> Regarding the EXISTS constraint: IMHO that is a good approach, but let's >>> make this attribute optional in the mapping and default: false. >>> >>> Regards, >>> John >>> >>> El lun, 25 ene 2021 a las 18:32, gabriela ortiz () >>> escribió: >>> Hi all. I wanted to inform the tasks I worked on this week: Jan 16 - Jan 22 . - Add EXISTS constraints for properties. - Develop put method. -
Re: Add datastore for Elasticsearch. Outreachy Week 9 Report
Hi Maria Thanks for the update. Some comments: Please use an Enum instead of literal strings for the Authentication Method parameter. https://github.com/podorvanova/gora/blob/gora-664/gora-elasticsearch/src/main/java/org/apache/gora/elasticsearch/store/ElasticsearchStore.java#L126 Use Parameterized logging instead of string concatenation https://github.com/podorvanova/gora/blob/gora-664/gora-elasticsearch/src/main/java/org/apache/gora/elasticsearch/mapping/ElasticsearchMappingBuilder.java#L186 Use the 'scalingFactor' attribute in the XML parsing, schema creation, XSD, etc. https://github.com/podorvanova/gora/blob/gora-664/gora-elasticsearch/src/main/java/org/apache/gora/elasticsearch/mapping/ElasticsearchMappingBuilder.java#L200 https://github.com/podorvanova/gora/blob/gora-664/gora-elasticsearch/src/main/java/org/apache/gora/elasticsearch/mapping/Field.java#L133 regards, John El vie, 5 feb 2021 a las 22:45, Maria Podorvanova (< podorvanova.ma...@gmail.com>) escribió: > Hi, > > Report #9 > Period: January, 31 - February, 6 > Activities: > - Fixed NPE when getting a non-existing Elasticsearch document > - Implemented serialization/deserialization for MAP Avro data type > - Refactored serialization/deserialization to have better javadocs and > arguments > - Implemented serialization/deserialization for RECORD Avro data type > - Implemented serialization/deserialization for UNION Avro data type > - Fixed passed Schema argument for ARRAY deserialization > - Fixed BYTES deserialization for Base64 encoded String > - Ignored testGet3UnionField test > - Added javadoc descriptions to serialization and deserialization methods > - The following tests are passing now: > >1. testPutNested >2. testPutArray >3. testPutBytes >4. tetsPutMap >5. testPutMixedMaps >6. testUpdate >7. testGetRecursive >8. testGetDoubleRecursive >9. testGetNested >10. testGetWithFields >11. testGetWebPage >12. testGetWebPageDefaultFields >13. testGetNonExisting > > - Wrote a blog post #5 > > Here is the link to my code: > https://github.com/apache/gora/compare/master...podorvanova:gora-664. > Relevant commits are from February 4. > > Regards, > Maria > >
