Re: Add datastore for Elasticsearch. Outreachy Week 8 Report
Hi John, Thank you for your feedback. I am back from my small holiday and will address your comment this week. Regards, Maria On Thu, 28 Jan 2021 at 03:41, John Mora wrote: > Hi María. > > Thanks for your report. > > Some comments. > > When a Key is not found in the Datastore the get method should return > null, but currently a NullPointerException is thrown here: > > > https://github.com/podorvanova/gora/blob/gora-664/gora-elasticsearch/src/main/java/org/apache/gora/elasticsearch/store/ElasticsearchStore.java#L256 > > According to the avro documentation: "This data type is used to declare a > fixed-sized field that can be used for storing binary data.", it is similar > to the BYTES data type, but it has a size attribute. > > If Elasticsearch has a fixed-sized binary datatype you can use it. But, I > think that is not the case, so If other modules do not implement it, it is > fine to leave it that way. > > Best, > John > > El dom, 24 ene 2021 a las 8:16, Maria Podorvanova (< > podorvanova.ma...@gmail.com>) escribió: > >> Hi, >> >> Report #8 >> Period: January, 17 - January, 23 >> Activities: >> - Fix createSchema method [1] >> >>1. Added the index mappings while creating the Elasticsearch index >>2. Added getter and setter to enum Datatype >> >> - Implement serialization/deserialization for some Avro data types [2] >> >>1. Implemented serializeFieldValue and deserializeFieldValue methods >>for ARRAY BOOLEAN, BYTES and FIXED Avro data types >>2. Fixed deserialization for STRING Avro data type >>3. Added javadoc descriptions >> >> - The following tests are passing now: >> >>1. testCreateSchema, testAutoCreateSchema for createSchema method >>2. testSchemaExists >>3. testPut >>4. testGet >> >> - Wrote a blog post #4 >> >> Here are links to the commits: >> [1] >> https://github.com/podorvanova/gora/commit/6b9c21095fa4e9327328ec881b659c60c58c4941 >> [2] >> https://github.com/podorvanova/gora/commit/e459309b3f750af65a181d4904470eaee9c29a2e >> >> Question: >> I didn't quite understand what kind of type is represented by FIXED Avro >> data type. I looked through other modules and found that FIXED case is not >> being processed neither in serialization nor in deserialization, so I did >> the same for now. >> >> Regards, >> Maria >> >
Re: Add datastore for Elasticsearch. Outreachy Week 8 Report
Hi María. Thanks for your report. Some comments. When a Key is not found in the Datastore the get method should return null, but currently a NullPointerException is thrown here: https://github.com/podorvanova/gora/blob/gora-664/gora-elasticsearch/src/main/java/org/apache/gora/elasticsearch/store/ElasticsearchStore.java#L256 According to the avro documentation: "This data type is used to declare a fixed-sized field that can be used for storing binary data.", it is similar to the BYTES data type, but it has a size attribute. If Elasticsearch has a fixed-sized binary datatype you can use it. But, I think that is not the case, so If other modules do not implement it, it is fine to leave it that way. Best, John El dom, 24 ene 2021 a las 8:16, Maria Podorvanova (< podorvanova.ma...@gmail.com>) escribió: > Hi, > > Report #8 > Period: January, 17 - January, 23 > Activities: > - Fix createSchema method [1] > >1. Added the index mappings while creating the Elasticsearch index >2. Added getter and setter to enum Datatype > > - Implement serialization/deserialization for some Avro data types [2] > >1. Implemented serializeFieldValue and deserializeFieldValue methods >for ARRAY BOOLEAN, BYTES and FIXED Avro data types >2. Fixed deserialization for STRING Avro data type >3. Added javadoc descriptions > > - The following tests are passing now: > >1. testCreateSchema, testAutoCreateSchema for createSchema method >2. testSchemaExists >3. testPut >4. testGet > > - Wrote a blog post #4 > > Here are links to the commits: > [1] > https://github.com/podorvanova/gora/commit/6b9c21095fa4e9327328ec881b659c60c58c4941 > [2] > https://github.com/podorvanova/gora/commit/e459309b3f750af65a181d4904470eaee9c29a2e > > Question: > I didn't quite understand what kind of type is represented by FIXED Avro > data type. I looked through other modules and found that FIXED case is not > being processed neither in serialization nor in deserialization, so I did > the same for now. > > Regards, > Maria >
Add datastore for Elasticsearch. Outreachy Week 8 Report
Hi, Report #8 Period: January, 17 - January, 23 Activities: - Fix createSchema method [1] 1. Added the index mappings while creating the Elasticsearch index 2. Added getter and setter to enum Datatype - Implement serialization/deserialization for some Avro data types [2] 1. Implemented serializeFieldValue and deserializeFieldValue methods for ARRAY BOOLEAN, BYTES and FIXED Avro data types 2. Fixed deserialization for STRING Avro data type 3. Added javadoc descriptions - The following tests are passing now: 1. testCreateSchema, testAutoCreateSchema for createSchema method 2. testSchemaExists 3. testPut 4. testGet - Wrote a blog post #4 Here are links to the commits: [1] https://github.com/podorvanova/gora/commit/6b9c21095fa4e9327328ec881b659c60c58c4941 [2] https://github.com/podorvanova/gora/commit/e459309b3f750af65a181d4904470eaee9c29a2e Question: I didn't quite understand what kind of type is represented by FIXED Avro data type. I looked through other modules and found that FIXED case is not being processed neither in serialization nor in deserialization, so I did the same for now. Regards, Maria
