[jira] [Commented] (GRIFFIN-216) [Measure] enhance elasticsearch sink, support elasticsearch security login
[ https://issues.apache.org/jira/browse/GRIFFIN-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16706112#comment-16706112 ] ASF GitHub Bot commented on GRIFFIN-216: GitHub user justACT opened a pull request: https://github.com/apache/incubator-griffin/pull/463 Dev GRIFFIN-216 [Measure] enhance elasticsearch sink, support elasticsearch security login and HttpUtilTest for elasticsearch with user/pwd and without user/pwd. maybe this test is not easy to write, for elasticsearch just use http client and I think the " http client" have been tested by its liberary already. You can merge this pull request into a Git repository by running: $ git pull https://github.com/justACT/incubator-griffin dev Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/463.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #463 commit dd6e2ad5da050ebf3b4a368c73767d154a602790 Author: xiangrchen Date: 2018-11-27T07:26:45Z enhance elasticsearch sink, support elasticsearch security login commit 5e1afefcc02adeefe7c50a934138608975584316 Author: xiangrchen Date: 2018-11-29T13:33:23Z Merge branch 'justACT/master' into justACT/dev merge code: enhance elasticsearch sink, support elasticsearch security login commit 521c3dea157eb232b890beaad9a255bcce07edab Author: xiangrchen Date: 2018-12-01T03:28:44Z Merge branch 'master' of https://github.com/apache/incubator-griffin into dev commit f4b0be1c2bac68d5c38a9557ce47d3dd7222e2f2 Author: xiangrchen Date: 2018-12-02T05:56:26Z add HttpUtilTest, used by elasticsearch > [Measure] enhance elasticsearch sink, support elasticsearch security login > -- > > Key: GRIFFIN-216 > URL: https://issues.apache.org/jira/browse/GRIFFIN-216 > Project: Griffin (Incubating) > Issue Type: Improvement >Reporter: xiangrong,chen >Assignee: xiangrong,chen >Priority: Major > > sometimes, elasticsearch have access control if user install x-pack, so > "user" and "password" feild is needed in the config information, just like: > "sinks": [ > { > "type": "ELASTICSEARCH", > "config": { > "method": "post", > "api": "http://10.176.4.184:9200/griffin/accuracy";, > {color:#FF}"user": "elastic",{color} > {color:#FF} "password": "changeme",{color} > "connection.timeout": "1m", > "retry": 10 > } > } > ] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GRIFFIN-216) [Measure] enhance elasticsearch sink, support elasticsearch security login
[ https://issues.apache.org/jira/browse/GRIFFIN-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16706108#comment-16706108 ] ASF GitHub Bot commented on GRIFFIN-216: Github user justACT closed the pull request at: https://github.com/apache/incubator-griffin/pull/461 > [Measure] enhance elasticsearch sink, support elasticsearch security login > -- > > Key: GRIFFIN-216 > URL: https://issues.apache.org/jira/browse/GRIFFIN-216 > Project: Griffin (Incubating) > Issue Type: Improvement >Reporter: xiangrong,chen >Assignee: xiangrong,chen >Priority: Major > > sometimes, elasticsearch have access control if user install x-pack, so > "user" and "password" feild is needed in the config information, just like: > "sinks": [ > { > "type": "ELASTICSEARCH", > "config": { > "method": "post", > "api": "http://10.176.4.184:9200/griffin/accuracy";, > {color:#FF}"user": "elastic",{color} > {color:#FF} "password": "changeme",{color} > "connection.timeout": "1m", > "retry": 10 > } > } > ] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GRIFFIN-216) [Measure] enhance elasticsearch sink, support elasticsearch security login
[ https://issues.apache.org/jira/browse/GRIFFIN-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700019#comment-16700019 ] ASF GitHub Bot commented on GRIFFIN-216: GitHub user justACT opened a pull request: https://github.com/apache/incubator-griffin/pull/461 enhance elasticsearch sink, support elasticsearch security login GRIFFIN-216 [Measure] enhance elasticsearch sink, support elasticsearch security login You can merge this pull request into a Git repository by running: $ git pull https://github.com/justACT/incubator-griffin newESSink Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/461.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #461 commit dd6e2ad5da050ebf3b4a368c73767d154a602790 Author: xiangrchen Date: 2018-11-27T07:26:45Z enhance elasticsearch sink, support elasticsearch security login > [Measure] enhance elasticsearch sink, support elasticsearch security login > -- > > Key: GRIFFIN-216 > URL: https://issues.apache.org/jira/browse/GRIFFIN-216 > Project: Griffin (Incubating) > Issue Type: Improvement >Reporter: xiangrong,chen >Assignee: xiangrong,chen >Priority: Major > > sometimes, elasticsearch have access control if user install x-pack, so > "user" and "password" feild is needed in the config information, just like: > "sinks": [ > { > "type": "ELASTICSEARCH", > "config": { > "method": "post", > "api": "http://10.176.4.184:9200/griffin/accuracy";, > {color:#FF}"user": "elastic",{color} > {color:#FF} "password": "changeme",{color} > "connection.timeout": "1m", > "retry": 10 > } > } > ] -- This message was sent by Atlassian JIRA (v7.6.3#76005)