[jira] [Comment Edited] (GRIFFIN-173) [Measure] Support JDBC connection as data source

2018-07-04 Thread JIRA 


[ 
https://issues.apache.org/jira/browse/GRIFFIN-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533261#comment-16533261
 ] 

Maciej Bryński edited comment on GRIFFIN-173 at 7/5/18 5:12 AM:


Probably.
I looked into source code and I understand there is at least one class to be 
written here.
https://github.com/apache/incubator-griffin/tree/master/measure/src/main/scala/org/apache/griffin/measure/datasource/connector/batch

The easy part is Spark already support reading from JDBC :)

For me this is go or no go to use griffin as I want to do DQ on migration 
process from RDBMS to hadoop.


was (Author: maver1ck):
Probably.
I looked into source code and I understand there is at least one class to be 
written here.
https://github.com/apache/incubator-griffin/tree/master/measure/src/main/scala/org/apache/griffin/measure/datasource/connector/batch

For me this is go or no go to use griffin as I want to do DQ on migration 
process from RDBMS to hadoop.

> [Measure] Support JDBC connection as data source
> 
>
> Key: GRIFFIN-173
> URL: https://issues.apache.org/jira/browse/GRIFFIN-173
> Project: Griffin (Incubating)
>  Issue Type: Task
>Reporter: Maciej Bryński
>Assignee: William Guo
>Priority: Major
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> DoD: 
> Support JDBC connection as data source.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] incubator-griffin pull request #332: fix a bad practice

2018-07-04 Thread toyboxman 
Github user toyboxman closed the pull request at:

https://github.com/apache/incubator-griffin/pull/332


---

[GitHub] incubator-griffin issue #332: fix a bad practice

2018-07-04 Thread toyboxman 
Github user toyboxman commented on the issue:

https://github.com/apache/incubator-griffin/pull/332
  
Hi, @whhe @guoyuepeng 

I submit a new patch to revise, please review again

https://github.com/apache/incubator-griffin/pull/335


---

[GitHub] incubator-griffin pull request #335: fix a bad practice

2018-07-04 Thread toyboxman 
GitHub user toyboxman opened a pull request:

https://github.com/apache/incubator-griffin/pull/335

fix a bad practice

1.Format string should use %n rather than \n
In format strings, it is generally preferable better to use %n,
which will produce the platform-specific line separator.

2.use System.lineSeparator() instead of '\n'

3.trim up some extra long code lines

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/toyboxman/incubator-griffin bug-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-griffin/pull/335.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #335


commit 0d53fb80df3621dd61488a69d7b1f5864419cf5b
Author: Eugene 
Date:   2018-07-02T08:22:46Z

fix a bad practice

1.Format string should use %n rather than \n
In format strings, it is generally preferable better to use %n,
which will produce the platform-specific line separator.

2.use System.lineSeparator() instead of '\n'

3.trim up some extra long code lines




---

[jira] [Commented] (GRIFFIN-173) [Measure] Support JDBC connection as data source

2018-07-04 Thread William Guo (JIRA) 


[ 
https://issues.apache.org/jira/browse/GRIFFIN-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533135#comment-16533135
 ] 

William Guo commented on GRIFFIN-173:
-

hi  Maciej Bryński ,

Let's figure out how to make it, though, recently, we might not have priority 
on this feature.

Do you want to discuss and contribute for this feature?

 

Thanks,

William

> [Measure] Support JDBC connection as data source
> 
>
> Key: GRIFFIN-173
> URL: https://issues.apache.org/jira/browse/GRIFFIN-173
> Project: Griffin (Incubating)
>  Issue Type: Task
>Reporter: Maciej Bryński
>Assignee: William Guo
>Priority: Major
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> DoD: 
> Support JDBC connection as data source.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (GRIFFIN-173) [Measure] Support JDBC connection as data source

2018-07-04 Thread William Guo (JIRA) 


 [ 
https://issues.apache.org/jira/browse/GRIFFIN-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

William Guo reassigned GRIFFIN-173:
---

Assignee: William Guo  (was: Lionel Liu)

> [Measure] Support JDBC connection as data source
> 
>
> Key: GRIFFIN-173
> URL: https://issues.apache.org/jira/browse/GRIFFIN-173
> Project: Griffin (Incubating)
>  Issue Type: Task
>Reporter: Maciej Bryński
>Assignee: William Guo
>Priority: Major
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> DoD: 
> Support JDBC connection as data source.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GRIFFIN-173) [Measure] Support JDBC connection as data source

2018-07-04 Thread JIRA 


 [ 
https://issues.apache.org/jira/browse/GRIFFIN-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maciej Bryński updated GRIFFIN-173:
---
Labels:   (was: SP_6)

> [Measure] Support JDBC connection as data source
> 
>
> Key: GRIFFIN-173
> URL: https://issues.apache.org/jira/browse/GRIFFIN-173
> Project: Griffin (Incubating)
>  Issue Type: Task
>Reporter: Maciej Bryński
>Assignee: Lionel Liu
>Priority: Major
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> DoD: 
> Support JDBC connection as data source.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GRIFFIN-173) [Measure] Support JDBC connection as data source

2018-07-04 Thread JIRA 


 [ 
https://issues.apache.org/jira/browse/GRIFFIN-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maciej Bryński updated GRIFFIN-173:
---
Description: 
DoD: 

Support JDBC connection as data source.

  was:
DoD: 

Support google cloud as data source.


> [Measure] Support JDBC connection as data source
> 
>
> Key: GRIFFIN-173
> URL: https://issues.apache.org/jira/browse/GRIFFIN-173
> Project: Griffin (Incubating)
>  Issue Type: Task
>Reporter: Maciej Bryński
>Assignee: Lionel Liu
>Priority: Major
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> DoD: 
> Support JDBC connection as data source.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GRIFFIN-173) [Measure] Support JDBC connection as data source

2018-07-04 Thread JIRA 
Maciej Bryński created GRIFFIN-173:
--

 Summary: [Measure] Support JDBC connection as data source
 Key: GRIFFIN-173
 URL: https://issues.apache.org/jira/browse/GRIFFIN-173
 Project: Griffin (Incubating)
  Issue Type: Task
Reporter: Maciej Bryński
Assignee: Lionel Liu


DoD: 

Support google cloud as data source.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] incubator-griffin issue #332: fix a bad practice

2018-07-04 Thread guoyuepeng 
Github user guoyuepeng commented on the issue:

https://github.com/apache/incubator-griffin/pull/332
  
hi @toyboxman 
Yes, we might need to new patch for all '\n'

Thanks,
William


---

[GitHub] incubator-griffin issue #332: fix a bad practice

2018-07-04 Thread toyboxman 
Github user toyboxman commented on the issue:

https://github.com/apache/incubator-griffin/pull/332
  
let me check how many times '\n' was used in codes and make a new patch


---