Re: Preparing for a release

2016-02-16 Thread Paul King
I looked into what would be needed to backport GROOVY-7427 and it
turns out we'd need to bring across half of GROOVY-7087 as well. So,
while it can be done, I am kind of -1 on such a change and +1 on
getting the 2.5 beta out.

Cheers, Paul.

On Wed, Feb 17, 2016 at 8:29 AM, Cédric Champeau
 wrote:
> For Groovy Eclipse we have no choice: the Eclipse compiler is a fork of the
> Groovy compiler with Eclipse specific code. That's just how it works: new
> Groovy version, new Groovy Eclipse version.
>
> 2016-02-16 22:56 GMT+01:00 chrylis :
>>
>> > Keeping small backwards compatible enhancements out of bugfix releases
>> > is good as long as there are frequent non-bugfix releases.
>>
>> Do you consider all micros to be "bugfix releases", or are some of them
>> fixes and some of them small enhancements? In Groovy, there's a tendency
>> for
>> minor updates to require cascading changes to other components (e.g.,
>> GRECLIPSE, Spock).
>>
>>
>>
>> --
>> View this message in context:
>> http://groovy.329449.n5.nabble.com/Preparing-for-a-release-tp5731147p5731203.html
>> Sent from the Groovy Dev mailing list archive at Nabble.com.
>
>


Re: Preparing for a release

2016-02-16 Thread Cédric Champeau
For Groovy Eclipse we have no choice: the Eclipse compiler is a fork of the
Groovy compiler with Eclipse specific code. That's just how it works: new
Groovy version, new Groovy Eclipse version.

2016-02-16 22:56 GMT+01:00 chrylis :

> > Keeping small backwards compatible enhancements out of bugfix releases
> > is good as long as there are frequent non-bugfix releases.
>
> Do you consider all micros to be "bugfix releases", or are some of them
> fixes and some of them small enhancements? In Groovy, there's a tendency
> for
> minor updates to require cascading changes to other components (e.g.,
> GRECLIPSE, Spock).
>
>
>
> --
> View this message in context:
> http://groovy.329449.n5.nabble.com/Preparing-for-a-release-tp5731147p5731203.html
> Sent from the Groovy Dev mailing list archive at Nabble.com.
>


Re: Preparing for a release

2016-02-16 Thread Pascal Schumacher

Am 16.02.2016 um 22:56 schrieb chrylis:
Do you consider all micros to be "bugfix releases", or are some of 
them fixes and some of them small enhancements? In Groovy, there's a 
tendency for minor updates to require cascading changes to other 
components (e.g., GRECLIPSE, Spock). 
From 2.0 on the policy was to follow semantic versioning: 
MAJOR.MINOR.PATCH. From time to time a small enhancement sneaked into a 
patch release, but that was the exception.


Re: Preparing for a release

2016-02-16 Thread chrylis
> Keeping small backwards compatible enhancements out of bugfix releases
> is good as long as there are frequent non-bugfix releases.

Do you consider all micros to be "bugfix releases", or are some of them
fixes and some of them small enhancements? In Groovy, there's a tendency for
minor updates to require cascading changes to other components (e.g.,
GRECLIPSE, Spock).



--
View this message in context: 
http://groovy.329449.n5.nabble.com/Preparing-for-a-release-tp5731147p5731203.html
Sent from the Groovy Dev mailing list archive at Nabble.com.


Re: Preparing for a release

2016-02-16 Thread Guillaume Laforge
No objections either.

On Tue, Feb 16, 2016 at 10:04 PM, Paul King  wrote:

> Any objections to Chris' request? The Jira he referred to is a small
> backwards compatible enhancement (rather than bug fix). We'd normally
> keep this for new releases but it does open up much nicer Spring
> integration options, so I am not too worried about back-porting this
> one.
>
> Other opinions?
>
> Cheers, Paul.
>
>
> On Wed, Feb 17, 2016 at 6:02 AM, John Wagenleitner
>  wrote:
> > Hi Jim,
> >
> > I think the file you might be looking for is:
> >
> > src/main/org/codehaus/groovy/runtime/StringGroovyMethods.java
> >
> >
> > On Tue, Feb 16, 2016 at 10:36 AM, Pascal Schumacher
> >  wrote:
> >>
> >> Hi Jim,
> >>
> >> not sure what you mean by "String.metadata function"?
> >>
> >> If you like to contribute code to groovy open a jira ticket and send us
> a
> >> pull request.
> >>
> >> Cheers,
> >> Pascal
> >>
> >>
> >> Am 16.02.2016 um 10:18 schrieb jim northrop:
> >>
> >> Hi Pascal
> >> could you pls point me to where i can donate a tiny piece of
> >> String.metadata function ?
> >>
> >> thx
> >> jim
> >>
> >> On 16 February 2016 at 08:12, Pascal Schumacher <
> pascalschumac...@gmx.net>
> >> wrote:
> >>>
> >>> I fixed https://issues.apache.org/jira/browse/GROOVY-7742 by
> reverting as
> >>> Shils and John suggested in the discussion of
> >>> https://github.com/apache/groovy/pull/253
> >>>
> >>> Am 15.02.2016 um 22:12 schrieb Pascal Schumacher:
> 
>  Hi Cédric,
> 
>  great news. :)
> 
>  I think before https://issues.apache.org/jira/browse/GROOVY-7742
> should
>  be resolved, by either applying
> https://github.com/apache/groovy/pull/253 or
>  reverting
> 
> https://github.com/apache/groovy/commit/fae29119a1102393ae5d1645c3fc1e06547b0ad8
> 
>  If nobody more qualified offers his opinion on how to handle this I
>  would just revert, so we can release.
> 
>  Thanks,
>  Pascal
> 
>  Am 15.02.2016 um 10:45 schrieb Cédric Champeau:
> >
> > Hi guys,
> >
> > As promised, I will try to find some time to perform a release this
> > week. The last one is months ago already, and even if we had decided
> to
> > migrate to a smoother process, nobody managed to made the
> modifications yet.
> >
> > As such and if nobody disagrees, I will perform a release this week
> > using the "old" incubating process.
> >
> > Please backport every fix you think is worth having on the 2.4.x
> branch
> > asap.
> >
> > Thanks!
> 
> 
> >>>
> >>
> >>
> >
>



-- 
Guillaume Laforge
Apache Groovy committer & PMC member
Product Ninja & Advocate at Restlet 

Blog: http://glaforge.appspot.com/
Social: @glaforge  / Google+



Re: Preparing for a release

2016-02-16 Thread jim northrop
Hurrah ! Thank YOU John !
thx jim

On 16 February 2016 at 21:02, John Wagenleitner  wrote:

> Hi Jim,
>
> I think the file you might be looking for is:
>
> src/main/org/codehaus/groovy/runtime/StringGroovyMethods.java
>
>
> On Tue, Feb 16, 2016 at 10:36 AM, Pascal Schumacher <
> pascalschumac...@gmx.net> wrote:
>
>> Hi Jim,
>>
>> not sure what you mean by "String.metadata function"?
>>
>> If you like to contribute code to groovy open a jira ticket and send us a
>> pull request.
>>
>> Cheers,
>> Pascal
>>
>>
>> Am 16.02.2016 um 10:18 schrieb jim northrop:
>>
>> Hi Pascal
>> could you pls point me to where i can donate a tiny piece of
>> String.metadata function ?
>>
>> thx
>> ​jim
>> ​
>>
>> On 16 February 2016 at 08:12, Pascal Schumacher > > wrote:
>>
>>> I fixed https://issues.apache.org/jira/browse/GROOVY-7742 by reverting
>>> as Shils and John suggested in the discussion of
>>> https://github.com/apache/groovy/pull/253
>>>
>>> Am 15.02.2016 um 22:12 schrieb Pascal Schumacher:
>>>
 Hi Cédric,

 great news. :)

 I think before https://issues.apache.org/jira/browse/GROOVY-7742
 should be resolved, by either applying
 
 https://github.com/apache/groovy/pull/253 or reverting
 https://github.com/apache/groovy/commit/fae29119a1102393ae5d1645c3fc1e06547b0ad8

 If nobody more qualified offers his opinion on how to handle this I
 would just revert, so we can release.

 Thanks,
 Pascal

 Am 15.02.2016 um 10:45 schrieb Cédric Champeau:

> Hi guys,
>
> As promised, I will try to find some time to perform a release this
> week. The last one is months ago already, and even if we had decided to
> migrate to a smoother process, nobody managed to made the modifications 
> yet.
>
> As such and if nobody disagrees, I will perform a release this week
> using the "old" incubating process.
>
> Please backport every fix you think is worth having on the 2.4.x
> branch asap.
>
> Thanks!
>


>>>
>>
>>
>


Re: Preparing for a release

2016-02-16 Thread jim northrop
Be glad to open a JIRA - once i learn how ;-}
must do some homework !
thanx
jim

On 16 February 2016 at 19:36, Pascal Schumacher 
wrote:

> Hi Jim,
>
> not sure what you mean by "String.metadata function"?
>
> If you like to contribute code to groovy open a jira ticket and send us a
> pull request.
>
> Cheers,
> Pascal
>
> Am 16.02.2016 um 10:18 schrieb jim northrop:
>
> Hi Pascal
> could you pls point me to where i can donate a tiny piece of
> String.metadata function ?
>
> thx
> ​jim
> ​
>
> On 16 February 2016 at 08:12, Pascal Schumacher 
> wrote:
>
>> I fixed https://issues.apache.org/jira/browse/GROOVY-7742 by reverting
>> as Shils and John suggested in the discussion of
>> https://github.com/apache/groovy/pull/253
>>
>> Am 15.02.2016 um 22:12 schrieb Pascal Schumacher:
>>
>>> Hi Cédric,
>>>
>>> great news. :)
>>>
>>> I think before https://issues.apache.org/jira/browse/GROOVY-7742 should
>>> be resolved, by either applying
>>> 
>>> https://github.com/apache/groovy/pull/253 or reverting
>>> https://github.com/apache/groovy/commit/fae29119a1102393ae5d1645c3fc1e06547b0ad8
>>>
>>> If nobody more qualified offers his opinion on how to handle this I
>>> would just revert, so we can release.
>>>
>>> Thanks,
>>> Pascal
>>>
>>> Am 15.02.2016 um 10:45 schrieb Cédric Champeau:
>>>
 Hi guys,

 As promised, I will try to find some time to perform a release this
 week. The last one is months ago already, and even if we had decided to
 migrate to a smoother process, nobody managed to made the modifications 
 yet.

 As such and if nobody disagrees, I will perform a release this week
 using the "old" incubating process.

 Please backport every fix you think is worth having on the 2.4.x branch
 asap.

 Thanks!

>>>
>>>
>>
>
>


Re: Preparing for a release

2016-02-16 Thread John Wagenleitner
No objections here and I too think it would be nice to release a 2.5 beta
as well.

On Tue, Feb 16, 2016 at 1:15 PM, Pascal Schumacher  wrote:

> Keeping small backwards compatible enhancements out of bugfix releases is
> good as long as there are frequent non-bugfix releases.
>
> As I there are no frequent non-bugfix releases at the moment :(, I have no
> objections to back-porting.
>
> BTW: I think we should release 2.5-beta anyway.
>
> Cheers,
> Pascal
>
>
>
>
> Am 16.02.2016 um 22:04 schrieb Paul King:
>
>> Any objections to Chris' request? The Jira he referred to is a small
>> backwards compatible enhancement (rather than bug fix). We'd normally
>> keep this for new releases but it does open up much nicer Spring
>> integration options, so I am not too worried about back-porting this
>> one.
>>
>> Other opinions?
>>
>> Cheers, Paul.
>>
>>
>> On Wed, Feb 17, 2016 at 6:02 AM, John Wagenleitner
>>  wrote:
>>
>>> Hi Jim,
>>>
>>> I think the file you might be looking for is:
>>>
>>>  src/main/org/codehaus/groovy/runtime/StringGroovyMethods.java
>>>
>>>
>>> On Tue, Feb 16, 2016 at 10:36 AM, Pascal Schumacher
>>>  wrote:
>>>
 Hi Jim,

 not sure what you mean by "String.metadata function"?

 If you like to contribute code to groovy open a jira ticket and send us
 a
 pull request.

 Cheers,
 Pascal


 Am 16.02.2016 um 10:18 schrieb jim northrop:

 Hi Pascal
 could you pls point me to where i can donate a tiny piece of
 String.metadata function ?

 thx
 jim

 On 16 February 2016 at 08:12, Pascal Schumacher <
 pascalschumac...@gmx.net>
 wrote:

> I fixed https://issues.apache.org/jira/browse/GROOVY-7742 by
> reverting as
> Shils and John suggested in the discussion of
> https://github.com/apache/groovy/pull/253
>
> Am 15.02.2016 um 22:12 schrieb Pascal Schumacher:
>
>> Hi Cédric,
>>
>> great news. :)
>>
>> I think before https://issues.apache.org/jira/browse/GROOVY-7742
>> should
>> be resolved, by either applying
>> https://github.com/apache/groovy/pull/253 or
>> reverting
>>
>> https://github.com/apache/groovy/commit/fae29119a1102393ae5d1645c3fc1e06547b0ad8
>>
>> If nobody more qualified offers his opinion on how to handle this I
>> would just revert, so we can release.
>>
>> Thanks,
>> Pascal
>>
>> Am 15.02.2016 um 10:45 schrieb Cédric Champeau:
>>
>>> Hi guys,
>>>
>>> As promised, I will try to find some time to perform a release this
>>> week. The last one is months ago already, and even if we had decided
>>> to
>>> migrate to a smoother process, nobody managed to made the
>>> modifications yet.
>>>
>>> As such and if nobody disagrees, I will perform a release this week
>>> using the "old" incubating process.
>>>
>>> Please backport every fix you think is worth having on the 2.4.x
>>> branch
>>> asap.
>>>
>>> Thanks!
>>>
>>
>>

>


Re: Preparing for a release

2016-02-16 Thread Pascal Schumacher
Keeping small backwards compatible enhancements out of bugfix releases 
is good as long as there are frequent non-bugfix releases.


As I there are no frequent non-bugfix releases at the moment :(, I have 
no objections to back-porting.


BTW: I think we should release 2.5-beta anyway.

Cheers,
Pascal



Am 16.02.2016 um 22:04 schrieb Paul King:

Any objections to Chris' request? The Jira he referred to is a small
backwards compatible enhancement (rather than bug fix). We'd normally
keep this for new releases but it does open up much nicer Spring
integration options, so I am not too worried about back-porting this
one.

Other opinions?

Cheers, Paul.


On Wed, Feb 17, 2016 at 6:02 AM, John Wagenleitner
 wrote:

Hi Jim,

I think the file you might be looking for is:

 src/main/org/codehaus/groovy/runtime/StringGroovyMethods.java


On Tue, Feb 16, 2016 at 10:36 AM, Pascal Schumacher
 wrote:

Hi Jim,

not sure what you mean by "String.metadata function"?

If you like to contribute code to groovy open a jira ticket and send us a
pull request.

Cheers,
Pascal


Am 16.02.2016 um 10:18 schrieb jim northrop:

Hi Pascal
could you pls point me to where i can donate a tiny piece of
String.metadata function ?

thx
jim

On 16 February 2016 at 08:12, Pascal Schumacher 
wrote:

I fixed https://issues.apache.org/jira/browse/GROOVY-7742 by reverting as
Shils and John suggested in the discussion of
https://github.com/apache/groovy/pull/253

Am 15.02.2016 um 22:12 schrieb Pascal Schumacher:

Hi Cédric,

great news. :)

I think before https://issues.apache.org/jira/browse/GROOVY-7742 should
be resolved, by either applying https://github.com/apache/groovy/pull/253 or
reverting
https://github.com/apache/groovy/commit/fae29119a1102393ae5d1645c3fc1e06547b0ad8

If nobody more qualified offers his opinion on how to handle this I
would just revert, so we can release.

Thanks,
Pascal

Am 15.02.2016 um 10:45 schrieb Cédric Champeau:

Hi guys,

As promised, I will try to find some time to perform a release this
week. The last one is months ago already, and even if we had decided to
migrate to a smoother process, nobody managed to made the modifications yet.

As such and if nobody disagrees, I will perform a release this week
using the "old" incubating process.

Please backport every fix you think is worth having on the 2.4.x branch
asap.

Thanks!








Re: Preparing for a release

2016-02-16 Thread Paul King
Any objections to Chris' request? The Jira he referred to is a small
backwards compatible enhancement (rather than bug fix). We'd normally
keep this for new releases but it does open up much nicer Spring
integration options, so I am not too worried about back-porting this
one.

Other opinions?

Cheers, Paul.


On Wed, Feb 17, 2016 at 6:02 AM, John Wagenleitner
 wrote:
> Hi Jim,
>
> I think the file you might be looking for is:
>
> src/main/org/codehaus/groovy/runtime/StringGroovyMethods.java
>
>
> On Tue, Feb 16, 2016 at 10:36 AM, Pascal Schumacher
>  wrote:
>>
>> Hi Jim,
>>
>> not sure what you mean by "String.metadata function"?
>>
>> If you like to contribute code to groovy open a jira ticket and send us a
>> pull request.
>>
>> Cheers,
>> Pascal
>>
>>
>> Am 16.02.2016 um 10:18 schrieb jim northrop:
>>
>> Hi Pascal
>> could you pls point me to where i can donate a tiny piece of
>> String.metadata function ?
>>
>> thx
>> jim
>>
>> On 16 February 2016 at 08:12, Pascal Schumacher 
>> wrote:
>>>
>>> I fixed https://issues.apache.org/jira/browse/GROOVY-7742 by reverting as
>>> Shils and John suggested in the discussion of
>>> https://github.com/apache/groovy/pull/253
>>>
>>> Am 15.02.2016 um 22:12 schrieb Pascal Schumacher:

 Hi Cédric,

 great news. :)

 I think before https://issues.apache.org/jira/browse/GROOVY-7742 should
 be resolved, by either applying https://github.com/apache/groovy/pull/253 
 or
 reverting
 https://github.com/apache/groovy/commit/fae29119a1102393ae5d1645c3fc1e06547b0ad8

 If nobody more qualified offers his opinion on how to handle this I
 would just revert, so we can release.

 Thanks,
 Pascal

 Am 15.02.2016 um 10:45 schrieb Cédric Champeau:
>
> Hi guys,
>
> As promised, I will try to find some time to perform a release this
> week. The last one is months ago already, and even if we had decided to
> migrate to a smoother process, nobody managed to made the modifications 
> yet.
>
> As such and if nobody disagrees, I will perform a release this week
> using the "old" incubating process.
>
> Please backport every fix you think is worth having on the 2.4.x branch
> asap.
>
> Thanks!


>>>
>>
>>
>


Re: Preparing for a release

2016-02-16 Thread John Wagenleitner
Hi Jim,

I think the file you might be looking for is:

src/main/org/codehaus/groovy/runtime/StringGroovyMethods.java


On Tue, Feb 16, 2016 at 10:36 AM, Pascal Schumacher <
pascalschumac...@gmx.net> wrote:

> Hi Jim,
>
> not sure what you mean by "String.metadata function"?
>
> If you like to contribute code to groovy open a jira ticket and send us a
> pull request.
>
> Cheers,
> Pascal
>
>
> Am 16.02.2016 um 10:18 schrieb jim northrop:
>
> Hi Pascal
> could you pls point me to where i can donate a tiny piece of
> String.metadata function ?
>
> thx
> ​jim
> ​
>
> On 16 February 2016 at 08:12, Pascal Schumacher 
> wrote:
>
>> I fixed https://issues.apache.org/jira/browse/GROOVY-7742 by reverting
>> as Shils and John suggested in the discussion of
>> https://github.com/apache/groovy/pull/253
>>
>> Am 15.02.2016 um 22:12 schrieb Pascal Schumacher:
>>
>>> Hi Cédric,
>>>
>>> great news. :)
>>>
>>> I think before https://issues.apache.org/jira/browse/GROOVY-7742 should
>>> be resolved, by either applying
>>> 
>>> https://github.com/apache/groovy/pull/253 or reverting
>>> https://github.com/apache/groovy/commit/fae29119a1102393ae5d1645c3fc1e06547b0ad8
>>>
>>> If nobody more qualified offers his opinion on how to handle this I
>>> would just revert, so we can release.
>>>
>>> Thanks,
>>> Pascal
>>>
>>> Am 15.02.2016 um 10:45 schrieb Cédric Champeau:
>>>
 Hi guys,

 As promised, I will try to find some time to perform a release this
 week. The last one is months ago already, and even if we had decided to
 migrate to a smoother process, nobody managed to made the modifications 
 yet.

 As such and if nobody disagrees, I will perform a release this week
 using the "old" incubating process.

 Please backport every fix you think is worth having on the 2.4.x branch
 asap.

 Thanks!

>>>
>>>
>>
>
>


Re: Preparing for a release

2016-02-16 Thread chrylis
>Please backport every fix you think is worth having on the 2.4.x branch
asap.

If Paul has the bandwidth for the backport, it would be very helpful to me
to have the enhancement to @TupleConstructor in
https://issues.apache.org/jira/browse/GROOVY-7427 for 2.4.6.



--
View this message in context: 
http://groovy.329449.n5.nabble.com/Preparing-for-a-release-tp5731147p5731192.html
Sent from the Groovy Dev mailing list archive at Nabble.com.


Re: Preparing for a release

2016-02-16 Thread Pascal Schumacher

Hi Jim,

not sure what you mean by "String.metadata function"?

If you like to contribute code to groovy open a jira ticket and send us 
a pull request.


Cheers,
Pascal

Am 16.02.2016 um 10:18 schrieb jim northrop:

Hi Pascal
could you pls point me to where i can donate a tiny piece of 
String.metadata function ?


thx
​jim
​

On 16 February 2016 at 08:12, Pascal Schumacher 
mailto:pascalschumac...@gmx.net>> wrote:


I fixed https://issues.apache.org/jira/browse/GROOVY-7742 by
reverting as Shils and John suggested in the discussion of
https://github.com/apache/groovy/pull/253

Am 15.02.2016 um 22:12 schrieb Pascal Schumacher:

Hi Cédric,

great news. :)

I think before
https://issues.apache.org/jira/browse/GROOVY-7742 should be
resolved, by either applying
https://github.com/apache/groovy/pull/253 or reverting

https://github.com/apache/groovy/commit/fae29119a1102393ae5d1645c3fc1e06547b0ad8

If nobody more qualified offers his opinion on how to handle
this I would just revert, so we can release.

Thanks,
Pascal

Am 15.02.2016 um 10:45 schrieb Cédric Champeau:

Hi guys,

As promised, I will try to find some time to perform a
release this week. The last one is months ago already, and
even if we had decided to migrate to a smoother process,
nobody managed to made the modifications yet.

As such and if nobody disagrees, I will perform a release
this week using the "old" incubating process.

Please backport every fix you think is worth having on the
2.4.x branch asap.

Thanks!








Re: Preparing for a release

2016-02-16 Thread jim northrop
Hi Pascal
could you pls point me to where i can donate a tiny piece of
String.metadata function ?

thx
​jim
​

On 16 February 2016 at 08:12, Pascal Schumacher 
wrote:

> I fixed https://issues.apache.org/jira/browse/GROOVY-7742 by reverting as
> Shils and John suggested in the discussion of
> https://github.com/apache/groovy/pull/253
>
> Am 15.02.2016 um 22:12 schrieb Pascal Schumacher:
>
>> Hi Cédric,
>>
>> great news. :)
>>
>> I think before https://issues.apache.org/jira/browse/GROOVY-7742 should
>> be resolved, by either applying https://github.com/apache/groovy/pull/253
>> or reverting
>> https://github.com/apache/groovy/commit/fae29119a1102393ae5d1645c3fc1e06547b0ad8
>>
>> If nobody more qualified offers his opinion on how to handle this I would
>> just revert, so we can release.
>>
>> Thanks,
>> Pascal
>>
>> Am 15.02.2016 um 10:45 schrieb Cédric Champeau:
>>
>>> Hi guys,
>>>
>>> As promised, I will try to find some time to perform a release this
>>> week. The last one is months ago already, and even if we had decided to
>>> migrate to a smoother process, nobody managed to made the modifications yet.
>>>
>>> As such and if nobody disagrees, I will perform a release this week
>>> using the "old" incubating process.
>>>
>>> Please backport every fix you think is worth having on the 2.4.x branch
>>> asap.
>>>
>>> Thanks!
>>>
>>
>>
>