Re: Welcome John Wagenleitner to the Groovy PMC

2017-04-02 Thread Shil Sinha
Congratulations John!
On Sun, Apr 2, 2017 at 8:35 AM Cédric Champeau 
wrote:

> Congrats and welcome, John!
>
> 2017-04-02 12:49 GMT+02:00 jim northrop :
>
> Welcome aboard John! 
>
> Sent from my iPad
>
> > On 2 Apr 2017, at 11:11, Daniel Sun  wrote:
> >
> > Congratulations to John :)
> >
> > Cheers,
> > Daniel.Sun
> >
> >
> >
> > --
> > View this message in context:
> http://groovy.329449.n5.nabble.com/Welcome-John-Wagenleitner-to-the-Groovy-PMC-tp5739577p5739582.html
> > Sent from the Groovy Dev mailing list archive at Nabble.com.
>
>
>


Re: Welcome John Wagenleitner to the Groovy PMC

2017-04-02 Thread Cédric Champeau
Congrats and welcome, John!

2017-04-02 12:49 GMT+02:00 jim northrop :

> Welcome aboard John! 
>
> Sent from my iPad
>
> > On 2 Apr 2017, at 11:11, Daniel Sun  wrote:
> >
> > Congratulations to John :)
> >
> > Cheers,
> > Daniel.Sun
> >
> >
> >
> > --
> > View this message in context: http://groovy.329449.n5.
> nabble.com/Welcome-John-Wagenleitner-to-the-Groovy-
> PMC-tp5739577p5739582.html
> > Sent from the Groovy Dev mailing list archive at Nabble.com.
>


Re: Trying to determine if a change in 2.4.8 was deliberate...

2017-04-02 Thread John Wagenleitner
I created https://issues.apache.org/jira/browse/GROOVY-8140 for this and
will remove the method.

On Sat, Apr 1, 2017 at 2:14 PM, Jochen Theodorou  wrote:

> On 01.04.2017 20:04, John Wagenleitner wrote:
>
>> I remember looking at this and seeing that the commit that originally
>> introduced the check was 2f077109 [1].  Subsequent commits switched to
>> CachedClass and later back to Class for the argument type to that method
>> but things got out of sync between MethodIndexAction and the local
>> MOPIter class leaving the method unused which looked like a regression
>> (albeit way back in 1.8) and not intentional.
>>
>> I can revert the commit or maybe just remove the skipClass method
>> altogether from MOPIter.
>>
>> [1]
>> https://github.com/apache/groovy/commit/2f077109#diff-c1354c
>> 0d7df171ad8cafcb3d1bf63857R223
>>
>
> It is very possible that changes back then introduced something that was
> not intended. But we did built on top of it. I think removing the skipClass
> method would be best.
>
> bye Jochen
>


Re: Welcome John Wagenleitner to the Groovy PMC

2017-04-02 Thread jim northrop
Welcome aboard John! 

Sent from my iPad

> On 2 Apr 2017, at 11:11, Daniel Sun  wrote:
> 
> Congratulations to John :)
> 
> Cheers,
> Daniel.Sun
> 
> 
> 
> --
> View this message in context: 
> http://groovy.329449.n5.nabble.com/Welcome-John-Wagenleitner-to-the-Groovy-PMC-tp5739577p5739582.html
> Sent from the Groovy Dev mailing list archive at Nabble.com.


Re: Welcome John Wagenleitner to the Groovy PMC

2017-04-02 Thread Guillaume Laforge
Welcome John!

On Sun, Apr 2, 2017 at 9:20 AM, Paul King  wrote:

> The Groovy PMC welcomes John Wagenleitner as its latest member. Many
> of you will already know John - he has been a very valuable member of
> the Groovy community for
> numerous years with many commits as well as an active contribution
> within the various mailing lists, the issue tracker and forums. He has
> been particularly active in recent times with I believe the second
> most number of commits over the last 12 months. He has always taken a
> very community oriented stance and we welcome him as the latest member
> of the Groovy PMC. Welcome John!
>
> Cheers, Paul.
>



-- 
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform

Blog: http://glaforge.appspot.com/
Social: @glaforge  / Google+



Re: Welcome John Wagenleitner to the Groovy PMC

2017-04-02 Thread Daniel Sun
Congratulations to John :)

Cheers,
Daniel.Sun



--
View this message in context: 
http://groovy.329449.n5.nabble.com/Welcome-John-Wagenleitner-to-the-Groovy-PMC-tp5739577p5739582.html
Sent from the Groovy Dev mailing list archive at Nabble.com.


[RESULT][VOTE] Release Apache Groovy 2.5.0-alpha-1 (take 3)

2017-04-02 Thread Paul King
The vote has passed with 3 binding votes:
Paul King
Guillaume Laforge
John Wagenleitner

There was also 3 non-binding votes and additional votes cast during
earlier candidates.

I'll proceed with deploying the release.

Cheers, Paul.

On Thu, Mar 30, 2017 at 3:49 PM, Paul King  wrote:
> Dear community,
>
> I am happy to start the VOTE thread for a Groovy 2.5.0-alpha-1 release!
>
> This release includes 165 bug fixes/improvements as outlined in the changelog:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123=12338913
>
> Tag: 
> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_5_0_ALPHA_1
> Tag commit id: d25391516078e97ea20404d8e8b5cfe8e2391a1f
>
> The artifacts to be voted on are located as follows (r18966).
> Source release:
> https://dist.apache.org/repos/dist/dev/groovy/2.5.0-alpha-1/sources
> Convenience binaries:
> https://dist.apache.org/repos/dist/dev/groovy/2.5.0-alpha-1/distribution
>
> Release artifacts are signed with a key from the following file:
> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>
> Please vote on releasing this package as Apache Groovy 2.5.0-alpha-1.
>
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 PMC votes are cast.
>
> [ ] +1 Release Apache Groovy 2.5.0-alpha-1
> [ ]  0 I don't have a strong opinion about this, but I assume it's ok
> [ ] -1 Do not release Apache Groovy 2.5.0-alpha-1 because...
>
> Here is my vote:
>
> +1 (binding)