[GitHub] guacamole-manual pull request #92: GUACAMOLE-470: Document new color-scheme ...

2018-08-21 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/guacamole-manual/pull/92


---


[GitHub] guacamole-manual pull request #92: GUACAMOLE-470: Document new color-scheme ...

2018-08-20 Thread darchons
Github user darchons commented on a diff in the pull request:

https://github.com/apache/guacamole-manual/pull/92#discussion_r211480118
  
--- Diff: src/chapters/configuring.xml ---
@@ -3009,13 +3009,102 @@ ed272546-87bd-4db9-acba-e36e1a9ca20a
 SSH
 color 
scheme
 The color scheme to 
use for the terminal
-emulator used by SSH connections. 
Each color scheme dictates
-the default foreground and 
background color for the
-terminal. Programs which specify 
colors when printing text
-will override these 
defaults.
-This parameter is optional. By 
default, Guacamole will
-render text as gray over a black 
background.
-Possible values are:
+emulator used by SSH connections. 
It consists of a
+semicolon-separated series of 
name-value pairs, separated by
+a colon, that assign default 
values to colors in the
+terminal emulator palette. Note 
that programs that specify
+colors when printing text can 
still override these defaults.
+For example, to use blue text on 
white background by
+default, and change the default 
red color to a purple shade,
+you would specify:
+
+foreground: 
rgb:00/00/ff;
+background: rgb:ff/ff/ff;
+color9: rgb:80/00/80
+
+This format is similar to the 
color configuration format
+used by Xterm, so Xterm color 
configurations can be easily
+adapted for Guacamole. This 
parameter is optional. If not
--- End diff --

It goes from something like

xterm*color9: rgb:cf/61/71
xterm*color10: rgb:7c/bc/8c

to

color9: rgb:cf/61/71;
color10: rgb:7c/bc/8c;

I only mentioned it as a hint that users can look for premade color schemes 
from xterm configs. I think the conversion process is straightforward and 
obvious enough that it's unnecessary to include more details/examples.


---


[GitHub] guacamole-manual pull request #92: GUACAMOLE-470: Document new color-scheme ...

2018-08-20 Thread darchons
Github user darchons commented on a diff in the pull request:

https://github.com/apache/guacamole-manual/pull/92#discussion_r211479001
  
--- Diff: src/chapters/configuring.xml ---
@@ -3009,13 +3009,102 @@ ed272546-87bd-4db9-acba-e36e1a9ca20a
 SSH
 color 
scheme
 The color scheme to 
use for the terminal
-emulator used by SSH connections. 
Each color scheme dictates
-the default foreground and 
background color for the
-terminal. Programs which specify 
colors when printing text
-will override these 
defaults.
-This parameter is optional. By 
default, Guacamole will
-render text as gray over a black 
background.
-Possible values are:
+emulator used by SSH connections. 
It consists of a
+semicolon-separated series of 
name-value pairs, separated by
+a colon, that assign default 
values to colors in the
+terminal emulator palette. Note 
that programs that specify
+colors when printing text can 
still override these defaults.
--- End diff --

Yeah that was language left over from the current manual. Re-reading it, I 
don't think it adds much value to the section, so I decided to delete that 
sentence altogether.


---


[GitHub] guacamole-manual pull request #92: GUACAMOLE-470: Document new color-scheme ...

2018-08-20 Thread darchons
Github user darchons commented on a diff in the pull request:

https://github.com/apache/guacamole-manual/pull/92#discussion_r211478836
  
--- Diff: src/chapters/configuring.xml ---
@@ -3009,13 +3009,102 @@ ed272546-87bd-4db9-acba-e36e1a9ca20a
 SSH
 color 
scheme
 The color scheme to 
use for the terminal
-emulator used by SSH connections. 
Each color scheme dictates
-the default foreground and 
background color for the
-terminal. Programs which specify 
colors when printing text
-will override these 
defaults.
-This parameter is optional. By 
default, Guacamole will
-render text as gray over a black 
background.
-Possible values are:
+emulator used by SSH connections. 
It consists of a
+semicolon-separated series of 
name-value pairs, separated by
--- End diff --

Fixed


---


[GitHub] guacamole-manual pull request #92: GUACAMOLE-470: Document new color-scheme ...

2018-08-20 Thread darchons
Github user darchons commented on a diff in the pull request:

https://github.com/apache/guacamole-manual/pull/92#discussion_r211478821
  
--- Diff: src/chapters/configuring.xml ---
@@ -3009,13 +3009,102 @@ ed272546-87bd-4db9-acba-e36e1a9ca20a
 SSH
 color 
scheme
 The color scheme to 
use for the terminal
-emulator used by SSH connections. 
Each color scheme dictates
-the default foreground and 
background color for the
-terminal. Programs which specify 
colors when printing text
-will override these 
defaults.
-This parameter is optional. By 
default, Guacamole will
-render text as gray over a black 
background.
-Possible values are:
+emulator used by SSH connections. 
It consists of a
+semicolon-separated series of 
name-value pairs, separated by
+a colon, that assign default 
values to colors in the
+terminal emulator palette. Note 
that programs that specify
+colors when printing text can 
still override these defaults.
+For example, to use blue text on 
white background by
+default, and change the default 
red color to a purple shade,
+you would specify:
+
+foreground: 
rgb:00/00/ff;
+background: rgb:ff/ff/ff;
+color9: rgb:80/00/80
+
+This format is similar to the 
color configuration format
+used by Xterm, so Xterm color 
configurations can be easily
+adapted for Guacamole. This 
parameter is optional. If not
+specified, Guacamole will render 
text as gray over a black
+background.
+Possible color names are:
+
+
+
foreground
+
+Set the default 
foreground color.
+
+
+
+
background
+
+Set the default 
background color.
+
+
+
+
colorn
+
+Set the default 
color at index n
+ on the Xterm 
256-color palette. For
+example, 
color9 refers to the
+default red 
color.
+
+
+
+Possible color values are:
+
+
+
rgb:R/G/B
+
+Use a 12-bit color 
specified in hexadecimal.
+The color value is 
zero-padded to 24 bits. For
+example, 
rgb:f/0/0 specifies the
+color red.
+
+
+
+
rgb:RR/GG/BB
+
+Use the 24-bit color 
specified in hexadecimal.
+ 

[GitHub] guacamole-manual pull request #92: GUACAMOLE-470: Document new color-scheme ...

2018-08-16 Thread necouchman
Github user necouchman commented on a diff in the pull request:

https://github.com/apache/guacamole-manual/pull/92#discussion_r210518500
  
--- Diff: src/chapters/configuring.xml ---
@@ -3009,13 +3009,102 @@ ed272546-87bd-4db9-acba-e36e1a9ca20a
 SSH
 color 
scheme
 The color scheme to 
use for the terminal
-emulator used by SSH connections. 
Each color scheme dictates
-the default foreground and 
background color for the
-terminal. Programs which specify 
colors when printing text
-will override these 
defaults.
-This parameter is optional. By 
default, Guacamole will
-render text as gray over a black 
background.
-Possible values are:
+emulator used by SSH connections. 
It consists of a
+semicolon-separated series of 
name-value pairs, separated by
+a colon, that assign default 
values to colors in the
+terminal emulator palette. Note 
that programs that specify
+colors when printing text can 
still override these defaults.
+For example, to use blue text on 
white background by
+default, and change the default 
red color to a purple shade,
+you would specify:
+
+foreground: 
rgb:00/00/ff;
+background: rgb:ff/ff/ff;
+color9: rgb:80/00/80
+
+This format is similar to the 
color configuration format
+used by Xterm, so Xterm color 
configurations can be easily
+adapted for Guacamole. This 
parameter is optional. If not
+specified, Guacamole will render 
text as gray over a black
+background.
+Possible color names are:
+
+
+
foreground
+
+Set the default 
foreground color.
+
+
+
+
background
+
+Set the default 
background color.
+
+
+
+
colorn
+
+Set the default 
color at index n
+ on the Xterm 
256-color palette. For
+example, 
color9 refers to the
+default red 
color.
+
+
+
+Possible color values are:
+
+
+
rgb:R/G/B
+
+Use a 12-bit color 
specified in hexadecimal.
+The color value is 
zero-padded to 24 bits. For
+example, 
rgb:f/0/0 specifies the
+color red.
+
+
+
+
rgb:RR/GG/BB
+
+Use the 24-bit color 
specified in hexadecimal.
+   

[GitHub] guacamole-manual pull request #92: GUACAMOLE-470: Document new color-scheme ...

2018-08-16 Thread necouchman
Github user necouchman commented on a diff in the pull request:

https://github.com/apache/guacamole-manual/pull/92#discussion_r210521399
  
--- Diff: src/chapters/configuring.xml ---
@@ -3009,13 +3009,102 @@ ed272546-87bd-4db9-acba-e36e1a9ca20a
 SSH
 color 
scheme
 The color scheme to 
use for the terminal
-emulator used by SSH connections. 
Each color scheme dictates
-the default foreground and 
background color for the
-terminal. Programs which specify 
colors when printing text
-will override these 
defaults.
-This parameter is optional. By 
default, Guacamole will
-render text as gray over a black 
background.
-Possible values are:
+emulator used by SSH connections. 
It consists of a
+semicolon-separated series of 
name-value pairs, separated by
+a colon, that assign default 
values to colors in the
+terminal emulator palette. Note 
that programs that specify
+colors when printing text can 
still override these defaults.
+For example, to use blue text on 
white background by
+default, and change the default 
red color to a purple shade,
+you would specify:
+
+foreground: 
rgb:00/00/ff;
+background: rgb:ff/ff/ff;
+color9: rgb:80/00/80
+
+This format is similar to the 
color configuration format
+used by Xterm, so Xterm color 
configurations can be easily
+adapted for Guacamole. This 
parameter is optional. If not
--- End diff --

How does that "adaption" work?  Is there anything special that needs to be 
done when translating from Xterm color configurations to Guacamole?  If so, 
might make sense to put another `` block in right here.


---


[GitHub] guacamole-manual pull request #92: GUACAMOLE-470: Document new color-scheme ...

2018-08-15 Thread darchons
GitHub user darchons opened a pull request:

https://github.com/apache/guacamole-manual/pull/92

GUACAMOLE-470: Document new color-scheme parameter format for SSH and Telnet

Document the new format of the color-scheme parameter with some examples, 
for SSH and Telnet connections.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/darchons/guacamole-manual 
guac-470-configurable-terminal-colors

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/guacamole-manual/pull/92.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #92


commit 9eec92c346ebd4152925c4fd7213d3aeb6e647e1
Author: Jim Chen 
Date:   2018-08-16T03:38:53Z

GUACAMOLE-470: Document new color-scheme parameter format for SSH and Telnet

Document the new format of the color-scheme parameter with some
examples, for SSH and Telnet connections.




---