[GitHub] guacamole-server pull request #199: GUACAMOLE-649: Add support for setting L...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/guacamole-server/pull/199


---

[GitHub] guacamole-server pull request #199: GUACAMOLE-649: Add support for setting L...

[mike-jumper]

Github user mike-jumper commented on a diff in the pull request:

https://github.com/apache/guacamole-server/pull/199#discussion_r232133763
  
--- Diff: src/protocols/ssh/ssh.c ---
@@ -320,6 +320,17 @@ void* ssh_client_thread(void* data) {
 return NULL;
 }
 
+/* Forward specified locale */
+if (settings->locale != NULL) {
+if (libssh2_channel_setenv(ssh_client->term_channel, "LANG",
+settings->locale)) {
+guac_client_abort(client, GUAC_PROTOCOL_STATUS_UPSTREAM_ERROR,
--- End diff --

Good point. I'll switch this to a warning.


---

[GitHub] guacamole-server pull request #199: GUACAMOLE-649: Add support for setting L...

[necouchman]

Github user necouchman commented on a diff in the pull request:

https://github.com/apache/guacamole-server/pull/199#discussion_r231131516
  
--- Diff: src/protocols/ssh/ssh.c ---
@@ -320,6 +320,17 @@ void* ssh_client_thread(void* data) {
 return NULL;
 }
 
+/* Forward specified locale */
+if (settings->locale != NULL) {
+if (libssh2_channel_setenv(ssh_client->term_channel, "LANG",
+settings->locale)) {
+guac_client_abort(client, GUAC_PROTOCOL_STATUS_UPSTREAM_ERROR,
--- End diff --

Should this really be a fatal error in terms of the overall connection?  I 
ask because in general this is not fatal in terms of other SSH clients - for 
example, if you use the "ssh" command on pretty much any platform and ask to 
forward a variable that the server does not allow, it is simply silently 
ignored and does not abort the connection.


---

[GitHub] guacamole-server pull request #199: GUACAMOLE-649: Add support for setting L...

[mike-jumper]

GitHub user mike-jumper opened a pull request:

https://github.com/apache/guacamole-server/pull/199

GUACAMOLE-649: Add support for setting LANG environment variable via SSH.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mike-jumper/guacamole-server ssh-lang

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/guacamole-server/pull/199.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #199


commit 454682979e057b88a1f75fc60c47af4ba59b73f0
Author: Michael Jumper 
Date:   2018-10-22T06:30:53Z

GUACAMOLE-649: Add support for setting LANG environment variable via SSH.




---