[GitHub] incubator-guacamole-server pull request #56: GUACAMOLE-148: Fix handling of ...

[mike-jumper]

GitHub user mike-jumper opened a pull request:

https://github.com/apache/incubator-guacamole-server/pull/56

GUACAMOLE-148: Fix handling of terminal scroll.

Terminal emulators maintain the scrolling region and the bounds of the 
terminal separately. Console codes which allow the scrolling region to be 
redefined facilitate utilities like top, tmux, or screen which must maintain 
control of what scrolls and what doesn't.

Guacamole handles scrolling improperly, automatically scrolling whenever 
the cursor exceeds the bounds of the scroll region. This is only correct 
behavior when the cursor is within the scrolling region. The terminal should 
not be scrolled *at all* when the cursor is outside the scrolling region. If 
outside the scrolling region, the cursor should simply be kept within terminal 
bounds.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mike-jumper/incubator-guacamole-server 
fix-terminal-scroll

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-guacamole-server/pull/56.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #56


commit 073fbe684d7706a97720ac347feace12854bd899
Author: Michael Jumper 
Date:   2017-01-29T05:24:06Z

GUACAMOLE-148: Scroll automatically only when cursor is within scrolling 
region.

commit 6c1eeb96b0f3feba38ad74b30f933b91f915045a
Author: Michael Jumper 
Date:   2017-01-29T06:48:45Z

GUACAMOLE-148: Move cursor bounds checking to common location (where 
necessary).

commit b796b2c9339c90f828e5ace129576e12f45ad30e
Author: Michael Jumper 
Date:   2017-01-29T06:51:21Z

GUACAMOLE-148: Clarify that the cursor is expected to potentially exceed 
the terminal bounds.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-server pull request #55: GUACAMOLE-135: Add Swiss-French...

[mike-jumper]

Github user mike-jumper commented on a diff in the pull request:


https://github.com/apache/incubator-guacamole-server/pull/55#discussion_r98340988
  
--- Diff: src/protocols/rdp/keymaps/fr_ch_qwertz.keymap ---
@@ -0,0 +1,59 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+parent  "base"
+name"fr-ch-qwertz"
+freerdp "KBD_SWISS_FRENCH"
+
+#
+# Basic keys
+#
+
+map -altgr -shift 0x29 0x02..0x0C  ~ "§1234567890'"
+map -altgr -shift  0x10..0x1A  ~ "qwertzuiopè"
+map -altgr -shift  0x1E..0x28 0x2B ~ "asdfghjkléà$"
+map -altgr -shift 0x56 0x2C..0x35  ~ "YXCVBNM;:_"
+
+#
+# Keys requiring AltGr
+#
+
+map +altgr -shift 0x02..0x04 ~ "¦@#"
+map +altgr -shift 0x06..0x08 ~ "¬|¢"
--- End diff --

Ah, but the number keys are already known-good and mapped earlier in the 
keymap, and they share these scancodes.

You're right. `0x07..0x09` has to be correct.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-server pull request #55: GUACAMOLE-135: Add Swiss-French...

[jmroth]

Github user jmroth commented on a diff in the pull request:


https://github.com/apache/incubator-guacamole-server/pull/55#discussion_r98340721
  
--- Diff: src/protocols/rdp/keymaps/fr_ch_qwertz.keymap ---
@@ -0,0 +1,59 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+parent  "base"
+name"fr-ch-qwertz"
+freerdp "KBD_SWISS_FRENCH"
+
+#
+# Basic keys
+#
+
+map -altgr -shift 0x29 0x02..0x0C  ~ "§1234567890'"
+map -altgr -shift  0x10..0x1A  ~ "qwertzuiopè"
+map -altgr -shift  0x1E..0x28 0x2B ~ "asdfghjkléà$"
+map -altgr -shift 0x56 0x2C..0x35  ~ "YXCVBNM;:_"
+
+#
+# Keys requiring AltGr
+#
+
+map +altgr -shift 0x02..0x04 ~ "¦@#"
+map +altgr -shift 0x06..0x08 ~ "¬|¢"
--- End diff --

0x06..0x08 is wrong... look for example at 
https://upload.wikimedia.org/wikipedia/commons/thumb/4/4f/KB_Swiss.svg/900px-KB_Swiss.svg.png.
 You see that there are two keys between the hash and the next alt-gr key to 
the right. So if you skip 0x05 and 0x06, the next key you get is 0x07.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-manual pull request #31: GUACAMOLE-135: Document Swiss-F...

[mike-jumper]

GitHub user mike-jumper opened a pull request:

https://github.com/apache/incubator-guacamole-manual/pull/31

GUACAMOLE-135: Document Swiss-French keyboard option for RDP.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mike-jumper/incubator-guacamole-manual 
swiss-french-keymap

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-guacamole-manual/pull/31.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #31


commit 7088dc943607a513dbea3ea5ec5a9d1204a2976e
Author: Michael Jumper 
Date:   2017-01-28T21:46:34Z

GUACAMOLE-135: Document Swiss-French keyboard option for RDP.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-client pull request #117: GUACAMOLE-135: Add Swiss-Frenc...

[mike-jumper]

GitHub user mike-jumper opened a pull request:

https://github.com/apache/incubator-guacamole-client/pull/117

GUACAMOLE-135: Add Swiss-French keyboard layout option for RDP.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mike-jumper/incubator-guacamole-client 
swiss-french-keymap

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-guacamole-client/pull/117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #117


commit 946816363e97567719c9acac780084e26dd6466a
Author: Michael Jumper 
Date:   2017-01-28T21:46:11Z

GUACAMOLE-135: Add Swiss-French keyboard layout option for RDP.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-client pull request #115: GUACAMOLE-129: Set "Content-Di...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-guacamole-client/pull/115


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-server pull request #54: GUACAMOLE-135: Add Swiss-French...

[mike-jumper]

Github user mike-jumper commented on a diff in the pull request:


https://github.com/apache/incubator-guacamole-server/pull/54#discussion_r98337848
  
--- Diff: src/protocols/rdp/keymaps/fr_ch_qwertz.keymap ---
@@ -0,0 +1,45 @@
+parent  "base"
--- End diff --

The license which applies to this file needs to be explicitly stated. See 
the other keymaps:


https://github.com/jmroth/incubator-guacamole-server/blob/219ce42c3338357dd4fff9dda2944edbdf98af73/src/protocols/rdp/keymaps/de_de_qwertz.keymap#L1-L19


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-client pull request #109: GUACAMOLE-47: Get client hostn...

[mike-jumper]

Github user mike-jumper commented on a diff in the pull request:


https://github.com/apache/incubator-guacamole-client/pull/109#discussion_r98336745
  
--- Diff: guacamole/src/main/java/org/apache/guacamole/rest/APIRequest.java 
---
@@ -42,6 +42,16 @@
 private final Map parameters;
 
 /**
+ * The remote hostname that initiated the request.
+ */
+private final String remoteHost;
+
+/**
+ * The remote ip address that initiated the request.
--- End diff --

Perhaps a bit of a semantic nitpick, but this is not the IP address that 
initiated the request, because IP addresses can't do things. It's the IP 
address of the client that initiated the request. Same thing for the hostname 
above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-client pull request #109: GUACAMOLE-47: Get client hostn...

[mike-jumper]

Github user mike-jumper commented on a diff in the pull request:


https://github.com/apache/incubator-guacamole-client/pull/109#discussion_r98336104
  
--- Diff: guacamole/src/main/java/org/apache/guacamole/rest/APIRequest.java 
---
@@ -58,6 +68,18 @@ public APIRequest(HttpServletRequest request,
 
 super(request);
 
+// Grab the remote host info.
+if (request.getRemoteHost() != null && 
!request.getRemoteHost().isEmpty())
--- End diff --

Is it necessary to sanity check `getRemoteHost()` and `getRemoteAddr()` 
against `isEmpty()`, given that their return values are guaranteed by the 
standard? Assuming that the empty string, if it ever does occur, is a 
legitimate value, doesn't this boil down to:

if (request.getRemoteHost() != null)
this.remoteHost = request.getRemoteHost();
else
this.remoteHost = null;

and thus could simply be:

this.remoteAddr = request.getRemoteAddr();


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-server pull request #53: GUACAMOLE-135: Add Swiss-French...

[jmroth]

Github user jmroth closed the pull request at:

https://github.com/apache/incubator-guacamole-server/pull/53


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-server pull request #52: GUACAMOLE-135: Add Swiss-French...

[jmroth]

Github user jmroth closed the pull request at:

https://github.com/apache/incubator-guacamole-server/pull/52


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-server pull request #52: GUACAMOLE-135: Add Swiss-French...

[jmroth]

GitHub user jmroth opened a pull request:

https://github.com/apache/incubator-guacamole-server/pull/52

GUACAMOLE-135: Add Swiss-French keymap for RDP

Add Swiss-French keymap for RDP

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jmroth/incubator-guacamole-server 
GUACAMOLE-135

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-guacamole-server/pull/52.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #52


commit 648d0200229cd19b1fd88b7ab8c64c16e5a7ddb9
Author: jmroth 
Date:   2017-01-28T15:19:56Z

Add files via upload

commit f9645a178a28c11f165061c8e8f74cb965e81619
Author: jmroth 
Date:   2017-01-28T15:21:07Z

Update Makefile.am




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-server pull request #51: GUACAMOLE-94: Use readdir() ins...

[mike-jumper]

GitHub user mike-jumper opened a pull request:

https://github.com/apache/incubator-guacamole-server/pull/51

GUACAMOLE-94: Use readdir() instead of readdir_r().

glibc has taken it upon themselves to flag `readdir_r()` as deprecated in 
advance of any official change to POSIX. This breaks the guacamole-server build 
for any environment with a sufficiently-recent glibc.

It should be safe to use `readdir()` as multiple threads will not be 
accessing the same directory stream. From the glibc manpage for `readdir_r()`:

> In the current POSIX.1 specification (POSIX.1-2008), readdir(3) is not 
required to be thread-safe. However, in modern implementations (including the 
glibc implementation), concurrent calls to readdir(3) that specify different 
directory streams are thread-safe. Therefore, the use of readdir_r() is 
generally unnecessary in multithreaded programs.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mike-jumper/incubator-guacamole-server 
use-readdir

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-guacamole-server/pull/51.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #51


commit dc6cae46ca40ca1af04901faf73dac6003c70e61
Author: Michael Jumper 
Date:   2017-01-28T08:11:59Z

GUACAMOLE-94: Use readdir() instead of readdir_r(). Multiple threads will 
not be accessing the same directory stream.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---