[GitHub] incubator-guacamole-client pull request #47: GUACAMOLE-5: Add support for ma...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-guacamole-client/pull/47


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-client pull request #47: GUACAMOLE-5: Add support for ma...

[jmuehlner]

Github user jmuehlner commented on a diff in the pull request:


https://github.com/apache/incubator-guacamole-client/pull/47#discussion_r73638190
  
--- Diff: 
guacamole/src/main/webapp/app/manage/controllers/manageUserController.js ---
@@ -918,6 +961,28 @@ 
angular.module('manage').controller('manageUserController', ['$scope', '$injecto
 else
 removeConnectionGroupPermission(identifier);
 
+},
+
+/**
+ * Notifies the controller that a change has been made to the given
+ * sharing profile permission for the user being edited. This only
+ * applies to READ permissions.
+ *
+ * @param {String} identifier
+ * The identifier of the sharing profile affected by the 
changed
+ * permission.
+ */
+sharingProfilePermissionChanged : function 
sharingProfilePermissionChanged(identifier) {
+
+// Determine current permission setting
+var value = 
$scope.permissionFlags.sharingProfilePermissions.READ[identifier];
--- End diff --

That seems much better to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-client pull request #47: GUACAMOLE-5: Add support for ma...

[mike-jumper]

Github user mike-jumper commented on a diff in the pull request:


https://github.com/apache/incubator-guacamole-client/pull/47#discussion_r73638131
  
--- Diff: 
guacamole/src/main/webapp/app/manage/controllers/manageUserController.js ---
@@ -918,6 +961,28 @@ 
angular.module('manage').controller('manageUserController', ['$scope', '$injecto
 else
 removeConnectionGroupPermission(identifier);
 
+},
+
+/**
+ * Notifies the controller that a change has been made to the given
+ * sharing profile permission for the user being edited. This only
+ * applies to READ permissions.
+ *
+ * @param {String} identifier
+ * The identifier of the sharing profile affected by the 
changed
+ * permission.
+ */
+sharingProfilePermissionChanged : function 
sharingProfilePermissionChanged(identifier) {
+
+// Determine current permission setting
+var value = 
$scope.permissionFlags.sharingProfilePermissions.READ[identifier];
--- End diff --

Yes, mostly. It will be true if the permission is granted, and false or 
undefined otherwise. The `PermissionFlagSet` definition states (copied from the 
diff of this PR):

>
> ```
 + * The granted state of each permission for each sharing profile, 
as a
 + * map of object permission type string to permission map. The
 + * permission map is, in turn, a map of sharing profile 
identifier to
 + * boolean value. A particular permission is granted if its
 + * corresponding boolean value is set to true. Valid permission 
type
 + * strings are defined within PermissionSet.ObjectPermissionType.
 + * Permissions which are not granted may be set to false, but 
this is
 + * not required.
> ```
>

How would you feel about `granted` instead?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-client pull request #47: GUACAMOLE-5: Add support for ma...

[jmuehlner]

Github user jmuehlner commented on a diff in the pull request:


https://github.com/apache/incubator-guacamole-client/pull/47#discussion_r73637665
  
--- Diff: 
guacamole/src/main/webapp/app/manage/controllers/manageUserController.js ---
@@ -918,6 +961,28 @@ 
angular.module('manage').controller('manageUserController', ['$scope', '$injecto
 else
 removeConnectionGroupPermission(identifier);
 
+},
+
+/**
+ * Notifies the controller that a change has been made to the given
+ * sharing profile permission for the user being edited. This only
+ * applies to READ permissions.
+ *
+ * @param {String} identifier
+ * The identifier of the sharing profile affected by the 
changed
+ * permission.
+ */
+sharingProfilePermissionChanged : function 
sharingProfilePermissionChanged(identifier) {
+
+// Determine current permission setting
+var value = 
$scope.permissionFlags.sharingProfilePermissions.READ[identifier];
--- End diff --

Small quibble, but "value" is not a very meaningful variable name here (to 
me). Are the expected values true/false?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-client pull request #47: GUACAMOLE-5: Add support for ma...

[mike-jumper]

GitHub user mike-jumper opened a pull request:

https://github.com/apache/incubator-guacamole-client/pull/47

GUACAMOLE-5: Add support for managing sharing profile permissions.

Though previous changes did add support within the REST API for management 
of sharing profile permissions, such support remained absent in the admin 
interface.

This change adds support for managing sharing profile permissions on a 
per-user basis, as well as granting/revoking the system-level permission for 
creating sharing profiles. Management of sharing profile permissions is handled 
within the same hierarchical tree previously used only for connections and 
connection groups, handling the sharing profiles associated with a connection 
as if they were the connections within a group:


![sharing-profile-permission-management](https://cloud.githubusercontent.com/assets/4632905/17424702/65bae26c-5a7b-11e6-96ac-e3830e13bead.png)

To make the tree more readable, I altered the rendering of the tree lines 
such that they have the traditional right-angle bends and terminate at the 
rough midpoint of each list item. This style is inherited by the other parts of 
the interface which use the `guacGroupList` directive, including the home 
screen and the location chooser (the dropdown used within the management 
interface for selecting a parent connection group).

These changes also required altering the connection group tree REST 
resource such that it includes sharing profiles within the tree.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mike-jumper/incubator-guacamole-client 
share-profile-perms

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-guacamole-client/pull/47.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #47


commit 60152e38411e40fc9d059dda9bf9f8c33eb91773
Author: Michael Jumper 
Date:   2016-08-04T21:05:32Z

GUACAMOLE-5: Include sharing profiles within connection tree.

commit da9ddf7683d3cbeb24fae5bdeb87258298467764
Author: Michael Jumper 
Date:   2016-08-05T00:28:26Z

GUACAMOLE-5: Add support for sharing profiles to the guacGroupList 
directive.

commit 85f15b7cd1378ff4572e05567c1b09d87e1a0331
Author: Michael Jumper 
Date:   2016-08-05T00:50:33Z

GUACAMOLE-5: Correct and simply guacGroupList styling/structure.

commit 8a8ae8496cee67f055266d63d64eae2c5d24f9e0
Author: Michael Jumper 
Date:   2016-08-05T01:15:28Z

GUACAMOLE-5: Add support for sharing profile permissions to JavaScript 
implementations of REST API objects.

commit e3db19d633c1123ec0e071c8a998a7dca6ad54d3
Author: Michael Jumper 
Date:   2016-08-05T01:21:32Z

GUACAMOLE-5: Implement management interface for sharing profile permissions.

commit f4ad97e73286b972ef33b9fa4f3a761daeb74061
Author: Michael Jumper 
Date:   2016-08-05T01:54:17Z

GUACAMOLE-5: Switch to nice rendering of connection tree lines.

commit 031763af05508c95556ae07b2d39b6b09fe247ab
Author: Michael Jumper 
Date:   2016-08-05T02:18:30Z

GUACAMOLE-5: Fix CSS selector match of open/closed groups.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---