[GitHub] incubator-guacamole-client pull request #54: GUACAMOLE-75: Do not insert dup...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-guacamole-client/pull/54


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-client pull request #54: GUACAMOLE-75: Do not insert dup...

[mike-jumper]

GitHub user mike-jumper opened a pull request:

https://github.com/apache/incubator-guacamole-client/pull/54

GUACAMOLE-75: Do not insert duplicate permissions.

While the MySQL permission inserts use `INSERT IGNORE` to ignore any 
violations of the table-wide unique constraint, the corresponding PostgreSQL 
inserts do not. PostgreSQL actually does not have such an option, at least not 
until recently via `ON CONFLICT UPDATE`.

This change rewrites the permission inserts for PostgreSQL such that only 
non-duplicate tuples are inserted.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mike-jumper/incubator-guacamole-client 
fix-user-clone

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-guacamole-client/pull/54.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #54


commit e71145285a3efc15081ee74b6fd4876ca0b3bb11
Author: Michael Jumper 
Date:   2016-08-12T18:04:06Z

GUACAMOLE-75: Do not insert duplicate permissions.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---