[GitHub] incubator-guacamole-client pull request #89: GUACAMOLE-133: Document all dep...

2016-12-02 Thread mike-jumper 
Github user mike-jumper commented on a diff in the pull request:


https://github.com/apache/incubator-guacamole-client/pull/89#discussion_r90750039
  
--- Diff: guacamole/src/licenses/dependencies/jsr250-api-1.0/CDDLv1.0.txt 
---
@@ -0,0 +1,119 @@
+COMMON DEVELOPMENT AND DISTRIBUTION LICENSE (CDDL) Version 1.0
+
+1. Definitions.
+
+1.1. Contributor means each individual or entity that creates or 
contributes to the creation of Modifications.
+
+1.2. Contributor Version means the combination of the Original Software, 
prior Modifications used by a Contributor (if any), and the Modifications made 
by that particular Contributor.
+
+1.3. Covered Software means (a) the Original Software, or (b) 
Modifications, or (c) the combination of files containing Original Software 
with files containing Modifications, in each case including portions thereof.
+
+1.4. Executable means the Covered Software in any form other than Source 
Code.
+
+1.5. Initial Developer means the individual or entity that first makes 
Original Software available under this License.
+
+1.6. Larger Work means a work which combines Covered Software or portions 
thereof with code not governed by the terms of this License.
+
+1.7. License means this document.
+
+1.8. Licensable means having the right to grant, to the maximum extent 
possible, whether at the time of the initial grant or subsequently acquired, 
any and all of the rights conveyed herein.
+
+1.9. Modifications means the Source Code and Executable form of any of the 
following:
+
+A. Any file that results from an addition to, deletion from or 
modification of the contents of a file containing Original Software or previous 
Modifications;
+
+B. Any new file that contains any part of the Original Software or 
previous Modification; or
+
+C. Any new file that is contributed or otherwise made available under the 
terms of this License.
+
+1.10. Original Software means the Source Code and Executable form of 
computer software code that is originally released under this License.
+
+1.11. Patent Claims means any patent claim(s), now owned or hereafter 
acquired, including without limitation, method, process, and apparatus claims, 
in any patent Licensable by grantor.
+
+1.12. Source Code means (a) the common form of computer software code in 
which modifications are made and (b) associated documentation included in or 
with such code.
+
+1.13. You (or Your) means an individual or a legal entity exercising 
rights under, and complying with all of the terms of, this License. For legal 
entities, You includes any entity which controls, is controlled by, or is under 
common control with You. For purposes of this definition, control means 
(a)�the power, direct or indirect, to cause the direction or management of 
such entity, whether by contract or otherwise, or (b)�ownership of more than 
fifty percent (50%) of the outstanding shares or beneficial ownership of such 
entity.
--- End diff --

The document appears to be encoded in [ISO 
8859-1](https://en.wikipedia.org/wiki/ISO/IEC_8859-1). Those characters are 
0xA0, the ISO 8859-1 character for a non-breaking space.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-client pull request #89: GUACAMOLE-133: Document all dep...

2016-12-02 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-guacamole-client/pull/89


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-client pull request #89: GUACAMOLE-133: Document all dep...

2016-12-02 Thread jmuehlner 
Github user jmuehlner commented on a diff in the pull request:


https://github.com/apache/incubator-guacamole-client/pull/89#discussion_r90749865
  
--- Diff: guacamole/src/licenses/dependencies/jsr250-api-1.0/CDDLv1.0.txt 
---
@@ -0,0 +1,119 @@
+COMMON DEVELOPMENT AND DISTRIBUTION LICENSE (CDDL) Version 1.0
+
+1. Definitions.
+
+1.1. Contributor means each individual or entity that creates or 
contributes to the creation of Modifications.
+
+1.2. Contributor Version means the combination of the Original Software, 
prior Modifications used by a Contributor (if any), and the Modifications made 
by that particular Contributor.
+
+1.3. Covered Software means (a) the Original Software, or (b) 
Modifications, or (c) the combination of files containing Original Software 
with files containing Modifications, in each case including portions thereof.
+
+1.4. Executable means the Covered Software in any form other than Source 
Code.
+
+1.5. Initial Developer means the individual or entity that first makes 
Original Software available under this License.
+
+1.6. Larger Work means a work which combines Covered Software or portions 
thereof with code not governed by the terms of this License.
+
+1.7. License means this document.
+
+1.8. Licensable means having the right to grant, to the maximum extent 
possible, whether at the time of the initial grant or subsequently acquired, 
any and all of the rights conveyed herein.
+
+1.9. Modifications means the Source Code and Executable form of any of the 
following:
+
+A. Any file that results from an addition to, deletion from or 
modification of the contents of a file containing Original Software or previous 
Modifications;
+
+B. Any new file that contains any part of the Original Software or 
previous Modification; or
+
+C. Any new file that is contributed or otherwise made available under the 
terms of this License.
+
+1.10. Original Software means the Source Code and Executable form of 
computer software code that is originally released under this License.
+
+1.11. Patent Claims means any patent claim(s), now owned or hereafter 
acquired, including without limitation, method, process, and apparatus claims, 
in any patent Licensable by grantor.
+
+1.12. Source Code means (a) the common form of computer software code in 
which modifications are made and (b) associated documentation included in or 
with such code.
+
+1.13. You (or Your) means an individual or a legal entity exercising 
rights under, and complying with all of the terms of, this License. For legal 
entities, You includes any entity which controls, is controlled by, or is under 
common control with You. For purposes of this definition, control means 
(a)�the power, direct or indirect, to cause the direction or management of 
such entity, whether by contract or otherwise, or (b)�ownership of more than 
fifty percent (50%) of the outstanding shares or beneficial ownership of such 
entity.
--- End diff --

I'm not sure what's with all the "�" characters in this diff, but they 
don't appear in the raw source, so I'm not worried about it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-client pull request #89: GUACAMOLE-133: Document all dep...

2016-12-02 Thread mike-jumper 
GitHub user mike-jumper opened a pull request:

https://github.com/apache/incubator-guacamole-client/pull/89

GUACAMOLE-133: Document all dependencies of Guacamole within LICENSE.

Note that there are **two versions of `LICENSE`**:

1. `LICENSE` (in the top-level directory) which covers the source, and thus 
describes only the dependencies bundled with the source.
2. `guacamole/src/licenses/LICENSE` which is added to the Guacamole .war 
file during the build, and describes all dependencies which are bundled with 
the .war ... of which there are a fair few.

Within the each of the above `LICENSE` files, *bundled* dependencies and 
their licenses are listed is in alphabetical order using the following rough 
format:

Some Dependency (http://url.for.project/if/known/)
--

Version: A.B.C
From: 'Carl P. Wrightholder' (http://url.for.author/if/known)
License(s):
LICENSE1 
(guacamole/src/dependencies/some-dependency-A.B.C/License1.txt)
LICENSE2 
(guacamole/src/dependencies/some-dependency-A.B.C/License2.txt)

Full text of license(s), if not too large to include.

I've kept the license filenames identical to the upstream source (if they 
included the license text at all). If the project instead included a URL to the 
license instead, I downloaded the license and used the filename from the URL. 
Some projects have multiple licenses. Depending on how the project represents 
their licenses, multiple licenses may be within in the same `LICENSE` / 
`LICENSE.txt` / `License.txt` / `COPYING` / `MITBSDCDDPLv1.3.27.text` file.

See also: http://www.apache.org/dev/licensing-howto.html

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mike-jumper/incubator-guacamole-client 
guac-license

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-guacamole-client/pull/89.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #89


commit 110ebf64e22723880e6b13abda721508f0bb1d60
Author: Michael Jumper 
Date:   2016-12-02T22:41:43Z

GUACAMOLE-133: Document all dependencies of Guacamole within LICENSE.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---