[GitHub] incubator-guacamole-server pull request #51: GUACAMOLE-94: Use readdir() ins...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-guacamole-server/pull/51


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-server pull request #51: GUACAMOLE-94: Use readdir() ins...

[mike-jumper]

GitHub user mike-jumper opened a pull request:

https://github.com/apache/incubator-guacamole-server/pull/51

GUACAMOLE-94: Use readdir() instead of readdir_r().

glibc has taken it upon themselves to flag `readdir_r()` as deprecated in 
advance of any official change to POSIX. This breaks the guacamole-server build 
for any environment with a sufficiently-recent glibc.

It should be safe to use `readdir()` as multiple threads will not be 
accessing the same directory stream. From the glibc manpage for `readdir_r()`:

> In the current POSIX.1 specification (POSIX.1-2008), readdir(3) is not 
required to be thread-safe. However, in modern implementations (including the 
glibc implementation), concurrent calls to readdir(3) that specify different 
directory streams are thread-safe. Therefore, the use of readdir_r() is 
generally unnecessary in multithreaded programs.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mike-jumper/incubator-guacamole-server 
use-readdir

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-guacamole-server/pull/51.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #51


commit dc6cae46ca40ca1af04901faf73dac6003c70e61
Author: Michael Jumper 
Date:   2017-01-28T08:11:59Z

GUACAMOLE-94: Use readdir() instead of readdir_r(). Multiple threads will 
not be accessing the same directory stream.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---