Re: [VOTE] First release candidate for HBase 1.1.4 (RC0) is available

2016-03-23 Thread Nick Dimiduk
For my own review:

- verified tarballs vs public key in p.a.o/keys/committers/ndimiduk.asc.
- extracted bin tgz:
  - inspect structure. look good.
  - run LoadTestTool against standalone bin tgz with FAST_DIFF block
encoder and ROWCOL blooms. No issues, logs look good.
  - poked around webUI. looks good.
  - verified version in MasterUI matches git tag sha
  - load the site, browsed book and API docs.
  - installed phoenix 4.7.0, simple test loading and querying. No issues,
logs look good.
- extracted src tgz:
  - inspect structure. look good.
  - run LoadTestTool against standalone built from src tgz with GZ
compression and ROWCOL blooms. No issues, logs look good (modulo the usual
GZ codec spew on this platform).
  - poked around webUI. looks good.
- inspected compatibility report. Issues look acceptable as per our
policies.

+1

On Wed, Mar 16, 2016 at 10:13 PM, Nick Dimiduk  wrote:

> I'm happy to announce the first release candidate of HBase 1.1.4 (HBase-
> 1.1.4RC0) is available for download at
> https://dist.apache.org/repos/dist/dev/hbase/hbase-1.1.4RC0/
>
> Maven artifacts are also available in the staging repository
> https://repository.apache.org/content/repositories/orgapachehbase-1131/
>
> Artifacts are signed with my code signing subkey 0xAD9039071C3489BD,
> available in the Apache keys directory
> https://people.apache.org/keys/committer/ndimiduk.asc
>
> There's also a signed tag for this release at
> https://git-wip-us.apache.org/repos/asf?p=hbase.git;a=tag;h=70a38529e6d9b24d4b0ab9937b86d0623d037c12
>
> The detailed source and binary compatibility report vs 1.1.3 has been
> published for your review, at 
> *http://home.apache.org/~ndimiduk/1.1.3_1.1.4RC0_compat_report.html
> *
>
> HBase 1.1.4 is the fourth patch release in the HBase 1.1 line, continuing
> on the theme of bringing a stable, reliable database to the Hadoop and
> NoSQL communities. This release includes over 40 bug fixes since the 1.1.3
> release. Notable correctness fixes
> include HBASE-15100, HBASE-15218, HBASE-15252, HBASE-15198, HBASE-15214, 
> HBASE-15221, HBASE-15322, HBASE-15378,
> and HBASE-15430.
>
> The full list of fixes included in this release is available at
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310753=12333671
>  and in the CHANGES.txt file included in the distribution.
>
> Please try out this candidate and vote +/-1 by 23:59 Pacific time on
> Sunday, 2016-03-20 as to whether we should release these artifacts as HBase
> 1.1.4.
>
> Thanks,
> Nick
>


[jira] [Created] (HBASE-15525) Fix OutOfMemory that could occur when using BoundedByteBufferPool during RPC bursts

2016-03-23 Thread deepankar (JIRA)
deepankar created HBASE-15525:
-

 Summary: Fix OutOfMemory that could occur when using 
BoundedByteBufferPool during RPC bursts
 Key: HBASE-15525
 URL: https://issues.apache.org/jira/browse/HBASE-15525
 Project: HBase
  Issue Type: Bug
  Components: IPC/RPC
Reporter: deepankar


After HBASE-13819 the system some times run out of direct memory whenever there 
is some network congestion or some client side issues.
This was because of pending RPCs in the RPCServer$Connection.responseQueue and 
since all the responses in this queue hold a buffer for cellblock from 
BoundedByteBufferPool this could takeup a lot of memory if the 
BoundedByteBufferPool's moving average settles down towards a higher value 

See the discussion here 
https://issues.apache.org/jira/browse/HBASE-13819?focusedCommentId=15207822=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15207822




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Please help check our RCs

2016-03-23 Thread Sean Busbey
I got 1.1.4 done today, should have time for 0.98.18 tomorrow. That
gets us pretty close to enough votes, I think?

For folks who aren't in the PMC, this is a great way to "act like a
PMC member" even if your vote isn't binding (yet).

On Tue, Mar 22, 2016 at 11:37 PM, Andrew Purtell  wrote:
> Your assistance in checking our current crop of release candidates would be
> most appreciated. We have 1.1.4 (closing Wednesday) and 0.98.18 (closing
> Friday) on deck.
>
> --
> Best regards,
>
>- Andy
>
> Problems worthy of attack prove their worth by hitting back. - Piet Hein
> (via Tom White)


Re: [VOTE] First release candidate for HBase 1.1.4 (RC0) is available

2016-03-23 Thread Sean Busbey
+1

* checked signatures / sums[1]
* spot checked LICENSE/NOTICE
* spot checked file header compliance using apache-rat plugin on clean
source unpack
* build from source[2]
* source matches commit 14c0e77956f9bb4c6edf0378474264843e4a82c3
(which the signed tag pointed to when I checked)


[1]: ASF policy requires that each file hosted in the project dist
space have a file with _just_ the MD5 sum in a file named after the
original with ".md5" as a suffix. (Having an additional file with all
the checksums is a good practice, IMO.) AFAICT we haven't been doing
this in the 0.98, 1.0, or 1.1 lines, so I don't want to hold up this
vote for it. I think we can just fix in the future and retroactively
make appropriate files for old releases from the MD5 contained in the
mds files.

relevant policy:
http://www.apache.org/dev/release-distribution.html#sigs-and-sums

[2]: I couldn't get a clean `mvn verify` run, but all the test
failures look like environment/timing issues, so I'm not concerned.

On Thu, Mar 17, 2016 at 12:13 AM, Nick Dimiduk  wrote:
> I'm happy to announce the first release candidate of HBase 1.1.4 (HBase-1.1.
> 4RC0) is available for download at
> https://dist.apache.org/repos/dist/dev/hbase/hbase-1.1.4RC0/
>
> Maven artifacts are also available in the staging repository
> https://repository.apache.org/content/repositories/orgapachehbase-1131/
>
> Artifacts are signed with my code signing subkey 0xAD9039071C3489BD,
> available in the Apache keys directory
> https://people.apache.org/keys/committer/ndimiduk.asc
>
> There's also a signed tag for this release at
> https://git-wip-us.apache.org/repos/asf?p=hbase.git;a=tag;h=70a38529e6d9b24d4b0ab9937b86d0623d037c12
>
> The detailed source and binary compatibility report vs 1.1.3 has been
> published for your review, at
> *http://home.apache.org/~ndimiduk/1.1.3_1.1.4RC0_compat_report.html
> *
>
> HBase 1.1.4 is the fourth patch release in the HBase 1.1 line, continuing
> on the theme of bringing a stable, reliable database to the Hadoop and
> NoSQL communities. This release includes over 40 bug fixes since the 1.1.3
> release. Notable correctness fixes
> include HBASE-15100, HBASE-15218, HBASE-15252, HBASE-15198,
> HBASE-15214, HBASE-15221, HBASE-15322, HBASE-15378,
> and HBASE-15430.
>
> The full list of fixes included in this release is available at
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310753=12333671
>  and in the CHANGES.txt file included in the distribution.
>
> Please try out this candidate and vote +/-1 by 23:59 Pacific time on
> Sunday, 2016-03-20 as to whether we should release these artifacts as HBase
> 1.1.4.
>
> Thanks,
> Nick


[jira] [Reopened] (HBASE-15523) enhance hbase-daemon.sh to enable autorestart.

2016-03-23 Thread Jerry He (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-15523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jerry He reopened HBASE-15523:
--

Could you provide a patch, [~easyliangjob]?

> enhance hbase-daemon.sh to enable autorestart.
> --
>
> Key: HBASE-15523
> URL: https://issues.apache.org/jira/browse/HBASE-15523
> Project: HBase
>  Issue Type: Improvement
>Reporter: yi liang
>Assignee: yi liang
>Priority: Minor
>
> enhance hbase-daemon.sh to enable autorestart.
> component(like master, region server) will auto-start when terminated/killed 
> abnormally if 
>(a) Add a new env variable $HBASE_AUTORESTART to hbase-env.sh i.e. 
>  export HBASE_AUTORESTART=true
>   (b) Then add the following 3 simple lines(59-61) to  
> /bin/hbase-daemon.sh
>  
>  51 # get arguments
>  52 startStop=$1
>  53 shift
>  54
>  55 command=$1
>  56 shift
>  57
>  58 #make sure the auto-restart are default settings
>  59 if [ "$HBASE_AUTORESTART" == "true" ] && [ "$startStop" == "start" ]; 
> then 
>  60   startStop="autorestart" 
>  61 fi



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HBASE-15524) Fix NPE in client-side metrics

2016-03-23 Thread Mikhail Antonov (JIRA)
Mikhail Antonov created HBASE-15524:
---

 Summary: Fix NPE in client-side metrics
 Key: HBASE-15524
 URL: https://issues.apache.org/jira/browse/HBASE-15524
 Project: HBase
  Issue Type: Bug
  Components: Client, metrics
Affects Versions: 1.3.0
Reporter: Mikhail Antonov
Assignee: Mikhail Antonov
Priority: Critical
 Fix For: 1.3.0






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HBASE-15523) enhance hbase-daemon.sh to enable autorestart.

2016-03-23 Thread yi liang (JIRA)
yi liang created HBASE-15523:


 Summary: enhance hbase-daemon.sh to enable autorestart.
 Key: HBASE-15523
 URL: https://issues.apache.org/jira/browse/HBASE-15523
 Project: HBase
  Issue Type: Improvement
Reporter: yi liang
Assignee: yi liang
Priority: Minor


enhance hbase-daemon.sh to enable autorestart.

component(like master, region server) will auto-start when terminated/killed 
abnormally if 
   (a) Add a new env variable $HBASE_AUTORESTART to hbase-env.sh i.e.   
   export HBASE_AUTORESTART=true
  (b) Then add the following 3 simple lines(59-61) to  
/bin/hbase-daemon.sh
 
 51 # get arguments
 52 startStop=$1
 53 shift
 54
 55 command=$1
 56 shift
 57
 58 #make sure the auto-restart are default settings
 59 if [ "$HBASE_AUTORESTART" == "true" ] && [ "$startStop" == "start" ]; 
then 
 60   startStop="autorestart" 
 61 fi



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (HBASE-15523) enhance hbase-daemon.sh to enable autorestart.

2016-03-23 Thread yi liang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-15523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

yi liang resolved HBASE-15523.
--
Resolution: Fixed

> enhance hbase-daemon.sh to enable autorestart.
> --
>
> Key: HBASE-15523
> URL: https://issues.apache.org/jira/browse/HBASE-15523
> Project: HBase
>  Issue Type: Improvement
>Reporter: yi liang
>Assignee: yi liang
>Priority: Minor
>
> enhance hbase-daemon.sh to enable autorestart.
> component(like master, region server) will auto-start when terminated/killed 
> abnormally if 
>(a) Add a new env variable $HBASE_AUTORESTART to hbase-env.sh i.e. 
>  export HBASE_AUTORESTART=true
>   (b) Then add the following 3 simple lines(59-61) to  
> /bin/hbase-daemon.sh
>  
>  51 # get arguments
>  52 startStop=$1
>  53 shift
>  54
>  55 command=$1
>  56 shift
>  57
>  58 #make sure the auto-restart are default settings
>  59 if [ "$HBASE_AUTORESTART" == "true" ] && [ "$startStop" == "start" ]; 
> then 
>  60   startStop="autorestart" 
>  61 fi



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (HBASE-14678) Experiment: Temporarily disable balancer and a few others to see if root of crashed/timedout JVMs

2016-03-23 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-14678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack resolved HBASE-14678.
---
Resolution: Fixed

Resolving after moving outstanding subtask to be its own standalone issue 
(Thanks @busbey and [~yangzhe1991])

> Experiment: Temporarily disable balancer and a few others to see if root of 
> crashed/timedout JVMs
> -
>
> Key: HBASE-14678
> URL: https://issues.apache.org/jira/browse/HBASE-14678
> Project: HBase
>  Issue Type: Task
>  Components: test
>Reporter: stack
>Assignee: Phil Yang
>Priority: Critical
> Fix For: 2.0.0, 1.3.0, 1.2.1
>
>
> Looking at recent builds of 1.2, I see a few of the runs finishing with kills 
> and notice that a JVM exited without reporting back state. Running the 
> hanging test finder, I can see at least that in one case that the balancer 
> tests seem to be outstanding; looking in test output, seems to be still going 
> on A few others are reported as hung but they look like they have just 
> started running and are just killed by surefire.
> This issue is about trying to disable a few of the problematics like balancer 
> tests to see if our overall stability improves. If so, I can concentrate on 
> stabilizing these few tests. Else will just undo the experiment and put the 
> tests back on line.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [VOTE] First release candidate for HBase 1.1.4 (RC0) is available

2016-03-23 Thread Jean-Marc Spaggiari
Checked the signatures => Passed
Looked at different random text and documentation files => Passed
RAT => Passed
Test suite => Failed. Have not been able to get a full success one. But
will retry. I think it's because of my environment.
Tried puts, gets, flushs, alters, etc. => All passed.


+1 for me so far. I will try to run the test suite again if I have time,
but last run crashed after 3 hours. So not sure.

The only thing is that after the test suite crashed I had those processes
hanging on my session...

jmspagg+ 31863 1  0 15:37 ?00:00:00 /bin/bash -c
/usr/java/jdk1.7.0_75//bin/java
-Dlog4j.configuration=container-log4j.properties
-Dyarn.app.container.log.dir=/stock/hbase-test/hbase-1.1.4-src/hbase-server/target/MiniMRCluster_2057692392/MiniMRCluster_2057692392-logDir-nm-0_2/application_1458761812937_0001/container_1458761812937_0001_01_01
-Dyarn.app.container.log.filesize=0 -Dhadoop.root.logger=INFO,CLA
-Xmx1024m org.apache.hadoop.mapreduce.v2.app.MRAppMaster
1>/stock/hbase-test/hbase-1.1.4-src/hbase-server/target/MiniMRCluster_2057692392/MiniMRCluster_2057692392-logDir-nm-0_2/application_1458761812937_0001/container_1458761812937_0001_01_01/stdout
2>/stock/hbase-test/hbase-1.1.4-src/hbase-server/target/MiniMRCluster_2057692392/MiniMRCluster_2057692392-logDir-nm-0_2/application_1458761812937_0001/container_1458761812937_0001_01_01/stderr

jmspagg+ 31895 31863  0 15:37 ?00:00:26
/usr/java/jdk1.7.0_75//bin/java
-Dlog4j.configuration=container-log4j.properties
-Dyarn.app.container.log.dir=/stock/hbase-test/hbase-1.1.4-src/hbase-server/target/MiniMRCluster_2057692392/MiniMRCluster_2057692392-logDir-nm-0_2/application_1458761812937_0001/container_1458761812937_0001_01_01
-Dyarn.app.container.log.filesize=0 -Dhadoop.root.logger=INFO,CLA -Xmx1024m
org.apache.hadoop.mapreduce.v2.app.MRAppMaster

JMS


2016-03-23 8:03 GMT-04:00 Jean-Marc Spaggiari :

> Checking it locally. Will report later today.
>
> Andrew, RAT passed for me on the sources. How are you running it?
>
> [INFO]
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache HBase ... SUCCESS [
> 0.999 s]
> [INFO] Apache HBase - Checkstyle .. SUCCESS [
> 0.045 s]
> [INFO] Apache HBase - Resource Bundle . SUCCESS [
> 0.046 s]
> [INFO] Apache HBase - Annotations . SUCCESS [
> 0.057 s]
> [INFO] Apache HBase - Protocol  SUCCESS [
> 0.081 s]
> [INFO] Apache HBase - Common .. SUCCESS [
> 0.176 s]
> [INFO] Apache HBase - Procedure ... SUCCESS [
> 0.051 s]
> [INFO] Apache HBase - Client .. SUCCESS [
> 0.334 s]
> [INFO] Apache HBase - Hadoop Compatibility  SUCCESS [
> 0.068 s]
> [INFO] Apache HBase - Hadoop Two Compatibility  SUCCESS [
> 0.096 s]
> [INFO] Apache HBase - Prefix Tree . SUCCESS [
> 0.091 s]
> [INFO] Apache HBase - Server .. SUCCESS [
> 0.692 s]
> [INFO] Apache HBase - Testing Util  SUCCESS [
> 0.031 s]
> [INFO] Apache HBase - Thrift .. SUCCESS [
> 0.044 s]
> [INFO] Apache HBase - Rest  SUCCESS [
> 0.061 s]
> [INFO] Apache HBase - Shell ... SUCCESS [
> 0.061 s]
> [INFO] Apache HBase - Integration Tests ... SUCCESS [
> 0.060 s]
> [INFO] Apache HBase - Examples  SUCCESS [
> 0.074 s]
> [INFO] Apache HBase - Assembly  SUCCESS [
> 0.035 s]
> [INFO] Apache HBase - Shaded .. SUCCESS [
> 0.022 s]
> [INFO] Apache HBase - Shaded - Client . SUCCESS [
> 0.022 s]
> [INFO] Apache HBase - Shaded - Server . SUCCESS [
> 0.020 s]
> [INFO]
> 
> [INFO] BUILD SUCCESS
> [INFO]
> 
> [INFO] Total time: 5.454 s
> [INFO] Finished at: 2016-03-23T08:02:31-04:00
> [INFO] Final Memory: 40M/684M
> [INFO]
> 
>
>
> 2016-03-23 0:37 GMT-04:00 Andrew Purtell :
>
>> +1
>>
>> Checked sums and signatures, ok
>> Built from source with release audit checks enabled (-Prelease), build
>> passed with one nit[1] (7u79)
>> Unit tests pass (7u79)
>> Loaded 1M rows with LTT (20% update), all keys verified, no errors or
>> unusual messages in the logs, latency measurements within ballpark.
>> Loaded 10M rows with PE (10 clients randomWrite, 10 clients randomRead),
>> no
>> errors or unusual messages in the logs, latency measurements within
>> ballpark.
>>
>> [1] RAT check failed in 

[jira] [Created] (HBASE-15522) Document how to set up a Kerberos enabled Thrift proxy

2016-03-23 Thread Misty Stanley-Jones (JIRA)
Misty Stanley-Jones created HBASE-15522:
---

 Summary: Document how to set up a Kerberos enabled Thrift proxy
 Key: HBASE-15522
 URL: https://issues.apache.org/jira/browse/HBASE-15522
 Project: HBase
  Issue Type: Task
  Components: documentation, security
Reporter: Misty Stanley-Jones
Assignee: Misty Stanley-Jones
 Fix For: 2.0.0






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [VOTE] The 1st HBase 0.98.18 release candidate (RC0) is available

2016-03-23 Thread larsh
+1
- built from source- tested with latest Phoenix 4.x-0.98 code- locally loaded 
100m rows (400m Cells)- briefly tested for perf and correctness.- nothing undue 
in the logs
-- Lars

  From: Andrew Purtell 
 To: "dev@hbase.apache.org"  
 Sent: Saturday, March 19, 2016 12:20 AM
 Subject: [VOTE] The 1st HBase 0.98.18 release candidate (RC0) is available
   
The 1st HBase 0.98.18 release candidate (RC0) is available for download at
https://dist.apache.org/repos/dist/dev/hbase/hbase-0.98.18RC0/ and Maven
artifacts are also available in the temporary repository
https://repository.apache.org/content/repositories/orgapachehbase-1132/ .

The detailed source and binary compatibility report for this release with
respect to the previous is available for your review at
https://dist.apache.org/repos/dist/dev/hbase/hbase-0.98.18RC0/0.98.17_0.98.18RC0_compat_report.html​​
. There are no reported problems or warnings.

The 46 issues resolved in this release can be found at
https://s.apache.org/cOY3 .

I have made the following preliminary assessments of this candidate:
- Build with source artifact with RAT and enforcers enabled (-Prelease)
completes successfully
- Unit test suite passes (7u79)
- Loaded 1M rows with LTT, no errors or unexpected messages observed, all
keys verified, latencies within expected range.
- Loaded 10M rows with PE (randomWrite, 10 threads) while concurrently
reading (randomRead, 10 threads), no errors or unexpected messages
observed, reported latencies within expected range.
- Built and ran unit tests with head of Apache Phoenix 4.x-HBase-0.98
branch, all pass (7u79)
- Poked around the UI, seems ok

Signed with my code signing key 4B6D7DF3.

​Please try out the candidate and vote +1/0/-1. This vote will be open for
at least 72 hours. Unless objection I will try to close it Friday March 25,
2016 if we have sufficient votes. Three +1 votes from PMC will be required
to release.​

-- 
Best regards,

  - Andy

Problems worthy of attack prove their worth by hitting back. - Piet Hein
(via Tom White)

  

[jira] [Created] (HBASE-15521) Procedure V2 - RestoreSnapshot and CloneSnapshot

2016-03-23 Thread Stephen Yuan Jiang (JIRA)
Stephen Yuan Jiang created HBASE-15521:
--

 Summary: Procedure V2 - RestoreSnapshot and CloneSnapshot
 Key: HBASE-15521
 URL: https://issues.apache.org/jira/browse/HBASE-15521
 Project: HBase
  Issue Type: Sub-task
  Components: master, proc-v2
Affects Versions: 2.0.0
Reporter: Stephen Yuan Jiang
Assignee: Stephen Yuan Jiang


Implement procedure-v2 based restore snapshot and clone snapshot (both server 
and client side change).  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Successful: HBase Generate Website

2016-03-23 Thread Apache Jenkins Server
Build status: Successful

If successful, the website and docs have been generated. If failed, skip to the 
bottom of this email.

Use the following commands to download the patch and apply it to a clean branch 
based on origin/asf-site. If you prefer to keep the hbase-site repo around 
permanently, you can skip the clone step.

  git clone https://git-wip-us.apache.org/repos/asf/hbase-site.git

  cd hbase-site
  wget -O- 
https://builds.apache.org/job/hbase_generate_website/176/artifact/website.patch.zip
 | funzip > cadfb21f4bb465d1e305db2a159b8574282c8150.patch
  git fetch
  git checkout -b asf-site-cadfb21f4bb465d1e305db2a159b8574282c8150 
origin/asf-site
  git am cadfb21f4bb465d1e305db2a159b8574282c8150.patch

At this point, you can preview the changes by opening index.html or any of the 
other HTML pages in your local 
asf-site-cadfb21f4bb465d1e305db2a159b8574282c8150 branch, and you can review 
the differences by running:

  git diff origin/asf-site

There are lots of spurious changes, such as timestamps and CSS styles in 
tables. To see a list of files that have been added, deleted, renamed, changed 
type, or are otherwise interesting, use the following command:

  git diff --name-status --diff-filter=ADCRTXUB origin/asf-site

To see only files that had 100 or more lines changed:

  git diff --stat origin/asf-site | grep -E '[1-9][0-9]{2,}'

When you are satisfied, publish your changes to origin/asf-site using this 
command:

  git push origin asf-site-cadfb21f4bb465d1e305db2a159b8574282c8150:asf-site

Changes take a couple of minutes to be propagated. You can then remove your 
asf-site-cadfb21f4bb465d1e305db2a159b8574282c8150 branch:

  git checkout asf-site && git branch -d 
asf-site-cadfb21f4bb465d1e305db2a159b8574282c8150



If failed, see https://builds.apache.org/job/hbase_generate_website/176/console

[jira] [Resolved] (HBASE-15064) BufferUnderflowException after last Cell fetched from an HFile Block served from L2 offheap cache

2016-03-23 Thread Anoop Sam John (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-15064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anoop Sam John resolved HBASE-15064.

Resolution: Fixed

Thanks for reporting it [~dvdreddy]

> BufferUnderflowException after last Cell fetched from an HFile Block served 
> from L2 offheap cache
> -
>
> Key: HBASE-15064
> URL: https://issues.apache.org/jira/browse/HBASE-15064
> Project: HBase
>  Issue Type: Bug
>  Components: io
>Affects Versions: 2.0.0
>Reporter: deepankar
>Assignee: Anoop Sam John
>Priority: Critical
> Fix For: 2.0.0
>
> Attachments: HBASE-15064-addendum.patch, HBASE-15064-addendum.patch, 
> HBASE-15064.patch, MBB_hasRemaining.patch
>
>
> While running the newer patches on our production system, I saw this error 
> come couple of times 
> {noformat}
> ipc.RpcServer: Unexpected throwable object 
> 2016-01-01 16:42:56,090 ERROR 
> [B.defaultRpcServer.handler=20,queue=20,port=60020] ipc.RpcServer: Unexpected 
> throwable object 
> java.nio.BufferUnderflowException
> at java.nio.Buffer.nextGetIndex(Buffer.java:500)
> at java.nio.DirectByteBuffer.get(DirectByteBuffer.java:249)
> at org.apache.hadoop.hbase.nio.MultiByteBuff.get(MultiByteBuff.java:494)
> at 
> org.apache.hadoop.hbase.io.encoding.FastDiffDeltaEncoder$1.decode(FastDiffDeltaEncoder.java:402)
>  
> at 
> org.apache.hadoop.hbase.io.encoding.FastDiffDeltaEncoder$1.decodeNext(FastDiffDeltaEncoder.java:517)
>  
> at 
> org.apache.hadoop.hbase.io.encoding.BufferedDataBlockEncoder$BufferedEncodedSeeker.next(BufferedDataBlockEncoder.java:815)
> at 
> org.apache.hadoop.hbase.regionserver.StoreFileScanner.next(StoreFileScanner.java:138)
> {noformat}
> Looking at the get code 
> {code}
> if (this.curItem.remaining() == 0) {
>   if (items.length - 1 == this.curItemIndex) {
> // means cur item is the last one and we wont be able to read a long. 
> Throw exception
> throw new BufferUnderflowException();
>   }
>   this.curItemIndex++;
>   this.curItem = this.items[this.curItemIndex];
> }
> return this.curItem.get();
> {code}
> Can the new currentItem have zero elements (position == limit), does it make 
> sense to change the {{if}} to {{while}} ? {{while (this.curItem.remaining() 
> == 0)}}. This logic is repeated may make sense abstract to a new function if 
> we plan to change to  {{if}} to {{while}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Reopened] (HBASE-15513) hbase.hregion.memstore.chunkpool.maxsize is 0.0 by default

2016-03-23 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-15513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack reopened HBASE-15513:
---

Reopen. You make a good point.  Let's do the work to figure if this should be 
always on

> hbase.hregion.memstore.chunkpool.maxsize is 0.0 by default
> --
>
> Key: HBASE-15513
> URL: https://issues.apache.org/jira/browse/HBASE-15513
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 2.0.0
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Fix For: 2.0.0
>
>
> That results in excessive MemStoreLAB chunk allocations because we can not 
> reuse them. Not sure, why it has been disabled, by default. May be the code 
> has not been tested well?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)