[jira] [Resolved] (HBASE-10965) Automate detection of presence of Filter#filterRow()
[
https://issues.apache.org/jira/browse/HBASE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu resolved HBASE-10965.
Resolution: Won't Fix
> Automate detection of presence of Filter#filterRow()
>
>
> Key: HBASE-10965
> URL: https://issues.apache.org/jira/browse/HBASE-10965
> Project: HBase
> Issue Type: Task
> Components: Filters
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 10965-v1.txt, 10965-v2.txt, 10965-v3.txt, 10965-v4.txt,
> 10965-v6.txt, 10965-v7.txt
>
>
> There is potential inconsistency between the return value of
> Filter#hasFilterRow() and presence of Filter#filterRow().
> Filters may override Filter#filterRow() while leaving return value of
> Filter#hasFilterRow() being false (inherited from FilterBase).
> Downside to purely depending on hasFilterRow() telling us whether custom
> filter overrides filterRow(List) or filterRow() is that the check below may
> be rendered ineffective:
> {code}
> if (nextKv == KV_LIMIT) {
> if (this.filter != null && filter.hasFilterRow()) {
> throw new IncompatibleFilterException(
> "Filter whose hasFilterRow() returns true is incompatible
> with scan with limit!");
> }
> {code}
> When user forgets to override hasFilterRow(), the above check becomes not
> useful.
> Another limitation is that we cannot optimize FilterList#filterRow() through
> short circuit when FilterList#hasFilterRow() turns false.
> See
> https://issues.apache.org/jira/browse/HBASE-11093?focusedCommentId=13985149&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13985149
> This JIRA aims to remove the inconsistency by automatically detecting the
> presence of overridden Filter#filterRow(). For FilterBase-derived classes, if
> filterRow() is implemented and not inherited from FilterBase, it is
> equivalent to having hasFilterRow() return true.
> With precise detection of presence of Filter#filterRow(), the following code
> from HRegion is no longer needed while backward compatibility is kept.
> {code}
> return filter != null && (!filter.hasFilterRow())
> && filter.filterRow();
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Resolved] (HBASE-11132) Create tool that facilitates diagnosis of integration test failures
[ https://issues.apache.org/jira/browse/HBASE-11132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu resolved HBASE-11132. Resolution: Later > Create tool that facilitates diagnosis of integration test failures > --- > > Key: HBASE-11132 > URL: https://issues.apache.org/jira/browse/HBASE-11132 > Project: HBase > Issue Type: Task >Reporter: Ted Yu > > When integration test (especially in the presence of ChaosMonkey) fails, > developer often browses through master / region server logs, along with > namenode log. > Correlation of region(s) across these log files is not trivial. > This issue is to introduce a tool that facilitates the analysis of the log > files. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Re: Moving 2.0 forward
Stack wrote: On Tue, Mar 7, 2017 at 1:51 PM, Josh Elser wrote: Thanks for pulling in the FS Quotas work, Stack. I'm trying to cross the last T's and dot the last I's. The biggest thing I know I need to do still is to write a new chapter to the book. After that, I'd start entertaining larger reviews/discussions to merge the feature into master. Anyone with free time (giggles) is more than welcome to start perusing :) Out of interest, this could come in after 2.0 Josh? Any 2.0 specific needs to make this work? Meantime, updated the 2.0 doc 1. Thanks Josh, St.Ack 1. https://docs.google.com/document/d/1WCsVlnHjJeKUcl7wHwqb4z9iEu_ktczrlKHK8N4SZzs/edit# Nope, no need to block 2.0 on this one (given the other, related chatter). Would be nice to get it in, but I completely understand if it slips :) Thanks for updating the doc for me!
Re: [VOTE] First release candidate for HBase 1.2.5 is available
+1 (non-binding) * xsums/sigs OK * Compat report looks OK for a patch release * Spot-checked source release and ran apache-rat:check * Can build from source (and run a subset of tests) * KEYS has the signing key * Commit is in source repository Sean Busbey wrote: The first release candidate for HBase 1.2.5 is available for download at: https://dist.apache.org/repos/dist/dev/hbase/hbase-1.2.5RC0/ Maven artifacts are also available in a staging repository at: https://repository.apache.org/content/repositories/orgapachehbase-1164/ Artifacts are signed with my key (0D80DB7C) published in our KEYS file at http://www.apache.org/dist/hbase/KEYS The RC corresponds to the signed tag 1.2.5RC0, which currently points to commit ref d7b05f79dee10e0ada614765bb354b93d615a157 The detailed source and binary compatibility report vs 1.2.4 has been published for your review, at: https://dist.apache.org/repos/dist/dev/hbase/hbase-1.2.5RC0/1.2.4_1.2.5RC0_compat_report.html Note that this report calls out the issue discussed in HBASE-17725. HBase 1.2.5 is the fifth maintenance release in the HBase 1.2 line, continuing on the theme of bringing a stable, reliable database to the Hadoop and NoSQL communities. This release includes over 50 bug fixes since 1.2.4. Critical fixes include: * HBASE-17069 RegionServer writes invalid META entries for split daughters in some circumstances * HBASE-17044 Fix merge failed before creating merged region leaves meta inconsistent * HBASE-17206 FSHLog may roll a new writer successfully with unflushed entries * HBASE-16765 New SteppingRegionSplitPolicy, avoid too aggressive spread of regions for small tables. The full list of fixes included in this release is available at: https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12338339&projectId=12310753 and in the CHANGES.txt file included in the distribution. Please try out this candidate and vote +1/-1 on whether we should release these artifacts as HBase 1.2.5. The VOTE will remain open for atleast 72 hours. Given sufficient votes I would like to close it on March 17th, 2017. thanks!
Successful: HBase Generate Website
Build status: Successful
If successful, the website and docs have been generated. To update the live
site, follow the instructions below. If failed, skip to the bottom of this
email.
Use the following commands to download the patch and apply it to a clean branch
based on origin/asf-site. If you prefer to keep the hbase-site repo around
permanently, you can skip the clone step.
git clone https://git-wip-us.apache.org/repos/asf/hbase-site.git
cd hbase-site
wget -O-
https://builds.apache.org/job/hbase_generate_website/513/artifact/website.patch.zip
| funzip > 4b541d63804e752f536560f7d96e222c0ffd877c.patch
git fetch
git checkout -b asf-site-4b541d63804e752f536560f7d96e222c0ffd877c
origin/asf-site
git am --whitespace=fix 4b541d63804e752f536560f7d96e222c0ffd877c.patch
At this point, you can preview the changes by opening index.html or any of the
other HTML pages in your local
asf-site-4b541d63804e752f536560f7d96e222c0ffd877c branch.
There are lots of spurious changes, such as timestamps and CSS styles in
tables, so a generic git diff is not very useful. To see a list of files that
have been added, deleted, renamed, changed type, or are otherwise interesting,
use the following command:
git diff --name-status --diff-filter=ADCRTXUB origin/asf-site
To see only files that had 100 or more lines changed:
git diff --stat origin/asf-site | grep -E '[1-9][0-9]{2,}'
When you are satisfied, publish your changes to origin/asf-site using these
commands:
git commit --allow-empty -m "Empty commit" # to work around a current ASF
INFRA bug
git push origin asf-site-4b541d63804e752f536560f7d96e222c0ffd877c:asf-site
git checkout asf-site
git branch -D asf-site-4b541d63804e752f536560f7d96e222c0ffd877c
Changes take a couple of minutes to be propagated. You can verify whether they
have been propagated by looking at the Last Published date at the bottom of
http://hbase.apache.org/. It should match the date in the index.html on the
asf-site branch in Git.
As a courtesy- reply-all to this email to let other committers know you pushed
the site.
If failed, see https://builds.apache.org/job/hbase_generate_website/513/console
[jira] [Created] (HBASE-17773) VerifyReplication tool wrongly emits warning "ERROR: Invalid argument '--recomparesleep=xx'"
Tomu Tsuruhara created HBASE-17773:
--
Summary: VerifyReplication tool wrongly emits warning "ERROR:
Invalid argument '--recomparesleep=xx'"
Key: HBASE-17773
URL: https://issues.apache.org/jira/browse/HBASE-17773
Project: HBase
Issue Type: Bug
Affects Versions: 2.0.0
Reporter: Tomu Tsuruhara
Priority: Trivial
Even though it's completely valid, VerifyReplication tool says "Invalid
argument" when specifying {{\-\-recomparesleep}} or {{\-\-delimiter}} option.
{noformat}
$ bin/hbase org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication
--recomparesleep=5 1 foo
ERROR: Invalid argument '--recomparesleep=5'
Usage: verifyrep [--starttime=X] [--endtime=Y] [--families=A]
[--row-prefixes=B] [--delimiter=] [--recomparesleep=] [--verbose]
Options:
starttimebeginning of the time range
without endtime means from starttime to forever
endtime end of the time range
versions number of cell versions to verify
raw includes raw scan if given in options
families comma-separated list of families to copy
row-prefixes comma-separated list of row key prefixes to filter on
delimiterthe delimiter used in display around rowkey
recomparesleep milliseconds to sleep before recompare row, default value is
0 which disables the recompare.
verbose logs row keys of good rows
Args:
peerid Id of the peer used for verification, must match the one given
for replication
tablenameName of the table to verify
Examples:
To verify the data replicated from TestTable for a 1 hour window with peer #5
$ hbase org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication
--starttime=1265875194289 --endtime=1265878794289 5 TestTable
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
