Re: [DISCUSS] More Shading

[Stack]

On Thu, Apr 13, 2017 at 4:46 PM, Josh Elser  wrote:

> ...
>
> I think pushing this part forward with some code is the next logical step.
> Seems to be consensus about taking our known internal dependencies and
> performing this shade magic.
>
>
I opened HBASE-18240 "Add hbase-auxillary, a project with hbase utility
including an hbase-shaded-thirdparty module with guava, netty, etc."

It has a tarball attached that bundles the outline of an hbase-auxillary
project (groupId:org.apache.hbase.auxillary). This project is intended to
be standalone, in its own repository, publishing its own artifacts under
the aegis of this project's PMC.

It includes the first instance of an auxillary utility, a module named
hbase-thirdparty-shaded (artifactId:hbase-thirdparty-shaded). Herein we'll
pull down 3rd party libs and republish at an offset; e.g.
com.google.common.* from guava will be at
org.apache.hbase.thirdparty.shaded.com.google.common.*. Currently it builds
a jar that includes a relocated guava 22.0.

I then messed around making hbase-common use it (You have to build the
hbase-auxillary into your local repo). I put up a patch on the issue.
Mostly its mass find-and-replace w/ some clean up of transitive includes of
guava from hadoop-common and some small fixup of methods renamed between
guava 12.0 and 22.0.

Unless objection, I was going to press on. Sean offered to help set up new
repo. We can always undo and delete it if this project fails.

When done, the hope is we are on a modern version of guava and our netty
and protobuf 3 will be be relocated, 'hidden' from downstream (and won't
clash w/ upstream). I hope to also purge the pre-build we have in our
modules that do protobuf moving this hackery out and under
hbase-thirdparty-shaded.

St.Ack




> Don't want to stomp on your worries, Nick. I think your worries are more
> about the presentation to downstream and we're in agreement about isolating
> our internal deps with the described approach?
>
>
> Thanks,
>> St.Ack
>>
>>
>>
>> We (The HBase PMC) will have to make releases of this new artifact and
>>> vote
>>>
 on them. I think it will be a relatively rare event.

 I'd be up for doing the first cut if folks are game.

 St.Ack


 1. URL via Sean but for committers to view only:
 https://reporeq.apache.org/


 [2] https://maven.apache.org/plugins/maven-shade-plugin/shade-
>>> mojo.html#createSourcesJar
>>> [3] https://maven.apache.org/plugins/maven-shade-plugin/shade-
>>> mojo.html#shadeSourcesContent
>>>
>>>
>>

Re: join hbase slack

[Karan Mehta]

I want an invite too.

Thanks,
Karan
ᐧ

On Mon, Jun 19, 2017 at 6:31 PM, 刘超  wrote:

> HI，please send me an invite,I want to join hbase slack,thanks

Re: [ANNOUNCE] New HBase committer Huaxiang Sun

[Anoop John]

Congratulations Huaxiang

-Anoop-

On Tue, Jun 20, 2017 at 9:36 AM, ramkrishna vasudevan
 wrote:
> Congratulations !!!
>
> On Tue, Jun 20, 2017 at 9:32 AM, Yu Li  wrote:
>
>> Congratulations and welcome, Huaxiang!
>>
>> Best Regards,
>> Yu
>>
>> On 20 June 2017 at 11:03, Allan Yang  wrote:
>>
>> > Congratulations and welcome, Huaxiang!
>> >
>> > Best Regards
>> > Allan Yang
>> >
>> > 2017-06-20 10:32 GMT+08:00 Pankaj kr :
>> >
>> > > Congratulations Huaxiang..!!
>> > >
>> > > Thanks & Regards,
>> > > Pankaj
>> > >
>> > > HUAWEI TECHNOLOGIES CO.LTD.
>> > > Huawei Tecnologies India Pvt. Ltd.
>> > > Near EPIP Industrial Area, Kundalahalli Village
>> > > Whitefield, Bangalore-560066
>> > > www.huawei.com
>> > > 
>> > > -
>> > > This e-mail and its attachments contain confidential information from
>> > > HUAWEI, which
>> > > is intended only for the person or entity whose address is listed
>> above.
>> > > Any use of the
>> > > information contained herein in any way (including, but not limited to,
>> > > total or partial
>> > > disclosure, reproduction, or dissemination) by persons other than the
>> > > intended
>> > > recipient(s) is prohibited. If you receive this e-mail in error, please
>> > > notify the sender by
>> > > phone or email immediately and delete it!
>> > >
>> > >
>> > > -Original Message-
>> > > From: Sean Busbey [mailto:bus...@apache.org]
>> > > Sent: Tuesday, June 20, 2017 3:31 AM
>> > > To: dev; u...@hbase.apache.org
>> > > Subject: [ANNOUNCE] New HBase committer Huaxiang Sun
>> > >
>> > > On behalf of the Apache HBase PMC, I am pleased to announce that
>> Huaxiang
>> > > Sun has accepted the PMC's invitation to become a committer on the
>> > project.
>> > > We appreciate all of Huaxiang's great work thus far and look forward to
>> > > continued involvement.
>> > >
>> > > Please join me in congratulating Huaxiang!
>> > >
>> >
>>

Re: [ANNOUNCE] New HBase committer Huaxiang Sun

[ramkrishna vasudevan]

Congratulations !!!

On Tue, Jun 20, 2017 at 9:32 AM, Yu Li  wrote:

> Congratulations and welcome, Huaxiang!
>
> Best Regards,
> Yu
>
> On 20 June 2017 at 11:03, Allan Yang  wrote:
>
> > Congratulations and welcome, Huaxiang!
> >
> > Best Regards
> > Allan Yang
> >
> > 2017-06-20 10:32 GMT+08:00 Pankaj kr :
> >
> > > Congratulations Huaxiang..!!
> > >
> > > Thanks & Regards,
> > > Pankaj
> > >
> > > HUAWEI TECHNOLOGIES CO.LTD.
> > > Huawei Tecnologies India Pvt. Ltd.
> > > Near EPIP Industrial Area, Kundalahalli Village
> > > Whitefield, Bangalore-560066
> > > www.huawei.com
> > > 
> > > -
> > > This e-mail and its attachments contain confidential information from
> > > HUAWEI, which
> > > is intended only for the person or entity whose address is listed
> above.
> > > Any use of the
> > > information contained herein in any way (including, but not limited to,
> > > total or partial
> > > disclosure, reproduction, or dissemination) by persons other than the
> > > intended
> > > recipient(s) is prohibited. If you receive this e-mail in error, please
> > > notify the sender by
> > > phone or email immediately and delete it!
> > >
> > >
> > > -Original Message-
> > > From: Sean Busbey [mailto:bus...@apache.org]
> > > Sent: Tuesday, June 20, 2017 3:31 AM
> > > To: dev; u...@hbase.apache.org
> > > Subject: [ANNOUNCE] New HBase committer Huaxiang Sun
> > >
> > > On behalf of the Apache HBase PMC, I am pleased to announce that
> Huaxiang
> > > Sun has accepted the PMC's invitation to become a committer on the
> > project.
> > > We appreciate all of Huaxiang's great work thus far and look forward to
> > > continued involvement.
> > >
> > > Please join me in congratulating Huaxiang!
> > >
> >
>

Re: [ANNOUNCE] New HBase committer Huaxiang Sun

[Yu Li]

Congratulations and welcome, Huaxiang!

Best Regards,
Yu

On 20 June 2017 at 11:03, Allan Yang  wrote:

> Congratulations and welcome, Huaxiang!
>
> Best Regards
> Allan Yang
>
> 2017-06-20 10:32 GMT+08:00 Pankaj kr :
>
> > Congratulations Huaxiang..!!
> >
> > Thanks & Regards,
> > Pankaj
> >
> > HUAWEI TECHNOLOGIES CO.LTD.
> > Huawei Tecnologies India Pvt. Ltd.
> > Near EPIP Industrial Area, Kundalahalli Village
> > Whitefield, Bangalore-560066
> > www.huawei.com
> > 
> > -
> > This e-mail and its attachments contain confidential information from
> > HUAWEI, which
> > is intended only for the person or entity whose address is listed above.
> > Any use of the
> > information contained herein in any way (including, but not limited to,
> > total or partial
> > disclosure, reproduction, or dissemination) by persons other than the
> > intended
> > recipient(s) is prohibited. If you receive this e-mail in error, please
> > notify the sender by
> > phone or email immediately and delete it!
> >
> >
> > -Original Message-
> > From: Sean Busbey [mailto:bus...@apache.org]
> > Sent: Tuesday, June 20, 2017 3:31 AM
> > To: dev; u...@hbase.apache.org
> > Subject: [ANNOUNCE] New HBase committer Huaxiang Sun
> >
> > On behalf of the Apache HBase PMC, I am pleased to announce that Huaxiang
> > Sun has accepted the PMC's invitation to become a committer on the
> project.
> > We appreciate all of Huaxiang's great work thus far and look forward to
> > continued involvement.
> >
> > Please join me in congratulating Huaxiang!
> >
>

[jira] [Created] (HBASE-18241) Change client.Table and client.Admin to not use HTableDescriptor

[Biju Nair (JIRA)]

Biju Nair created HBASE-18241:
-

 Summary: Change client.Table and client.Admin to not use 
HTableDescriptor
 Key: HBASE-18241
 URL: https://issues.apache.org/jira/browse/HBASE-18241
 Project: HBase
  Issue Type: Bug
Reporter: Biju Nair
Priority: Minor


{{HTableDescriptor}} is deprecated and scheduled to be removed in 3.0. But 
[client.Table|https://github.com/apache/hbase/blob/a66d491892514fd4a188d6ca87d6260d8ae46184/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java#L69]
 and 
[client.Admin|https://github.com/apache/hbase/blob/a66d491892514fd4a188d6ca87d6260d8ae46184/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java#L198]
 method {{getTableDescriptor}} returns {{HTableDescriptor}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

join hbase slack

[刘超]

HI，please send me an invite,I want to join hbase slack,thanks

Re: [ANNOUNCE] New HBase committer Huaxiang Sun

[Allan Yang]

Congratulations and welcome, Huaxiang!

Best Regards
Allan Yang

2017-06-20 10:32 GMT+08:00 Pankaj kr :

> Congratulations Huaxiang..!!
>
> Thanks & Regards,
> Pankaj
>
> HUAWEI TECHNOLOGIES CO.LTD.
> Huawei Tecnologies India Pvt. Ltd.
> Near EPIP Industrial Area, Kundalahalli Village
> Whitefield, Bangalore-560066
> www.huawei.com
> 
> -
> This e-mail and its attachments contain confidential information from
> HUAWEI, which
> is intended only for the person or entity whose address is listed above.
> Any use of the
> information contained herein in any way (including, but not limited to,
> total or partial
> disclosure, reproduction, or dissemination) by persons other than the
> intended
> recipient(s) is prohibited. If you receive this e-mail in error, please
> notify the sender by
> phone or email immediately and delete it!
>
>
> -Original Message-
> From: Sean Busbey [mailto:bus...@apache.org]
> Sent: Tuesday, June 20, 2017 3:31 AM
> To: dev; u...@hbase.apache.org
> Subject: [ANNOUNCE] New HBase committer Huaxiang Sun
>
> On behalf of the Apache HBase PMC, I am pleased to announce that Huaxiang
> Sun has accepted the PMC's invitation to become a committer on the project.
> We appreciate all of Huaxiang's great work thus far and look forward to
> continued involvement.
>
> Please join me in congratulating Huaxiang!
>

Re: [DISCUSS] IntelliJ Code Analysis + Code Style

[Mike Drob]

I don't have a hard rule about it.

Maybe things that affect block indentation are too much change. One line
changes are probably ok, like replacing explicit types with the diamond
operator.

Consolidating catch blocks is probably good because it makes the code more
clear and easier to maintain/understand in the future.

Now that I've started writing this out, I think that's a good metric - when
it makes the code more readable and understandable then it's a good idea,
regardless of number of lines changed.

When the Java 8 was young and lambdas and method references were this brand
new thing, then maybe they were less readable because they were unfamiliar
and developers were uncertain how to treat them, Now that we're come years
in, I wonder if developers are more fluent in these new language features.

By this logic, the Java 5 and 7 changes are almost certainly good
candidates for inclusion since they've been around for a very long time
now. Is the community familiar enough with how to read a lambda expression?
It took me a while to understand them well, and now I find them quite
clear, but I won't claim that my experience is universal.

Food for thought,


Mike

On Mon, Jun 19, 2017 at 4:40 PM, Ted Yu  wrote:

> bq. we can apply them to both branch-1 and branch-2
>
> Many bug fixes are still targeting 1.x releases. If the stylistic fixes go
> to branch-1, would that make porting between 1.x releases and branch-1 more
> cumbersome ?
>
> What is the amount of changes for the stylistic fixes you deem applicable ?
>
> Cheers
>
> On Mon, Jun 19, 2017 at 2:30 PM, Mike Drob  wrote:
>
> > Hi Devs,
> >
> > I recently ran the IntelliJ code analysis on the hbase project and saw
> that
> > it had some interesting suggestions.
> >
> > A lot of them don't point to bugs, but really end up being more of a
> > stylistic issues. The ones I want to discuss specifically are the ones it
> > categorizes as java version issues. Here's the list:
> >
> > Java 5:
> > * 'for' loop replaceable with 'foreach'
> > * Unnecessary unboxing
> > Java 7:
> > * Explicit type can be replaced with <>
> > * Identical 'catch' branch in 'try' statements
> > * Possible heap pollution from vararg type
> > Java 8:
> > * Anonymous type can be replaced with lambda
> > * Anonymous type can be replaced with method reference
> > * Lambda can be replaced with method reference
> > * Statement lambda can be replaced with expression lambda
> >
> > I think I read somewhere once that 'foreach' is not great for garbage
> > collection because it creates an extra iterator, so we can maybe ignore
> > that one. And I personally prefer statement lambdas (with curly braces)
> to
> > expression lambdas (without) especially for long lines, so ignore that
> one
> > too. But maybe address the rest?
> >
> > If we focus on only the Java 5/7 issues, then we can apply them to both
> > branch-1 and branch-2. Not sure how much value that provides, as I don't
> > have the historical context to estimate how long branch-1 will continue
> to
> > live once branch-2 is out.
> >
> > The IDE can do the code changes automatically, but it will still be a lot
> > of time to review, hence the discussion before I cavalierly go and file
> an
> > issue and attach a patch. Also, I have no idea how to turn these into
> > automated checks once we fix any of them, and that seems kind of
> important.
> >
> > IntelliJ has other checks that we can look at as well, but these were the
> > ones that caught my eye first as easiest to fix and least likely to false
> > positive.
> >
> > Thoughts?
> >
> > Mike
> >
>

RE: [ANNOUNCE] New HBase committer Huaxiang Sun

[Pankaj kr]

Congratulations Huaxiang..!!   

Thanks & Regards,
Pankaj

HUAWEI TECHNOLOGIES CO.LTD.
Huawei Tecnologies India Pvt. Ltd.
Near EPIP Industrial Area, Kundalahalli Village
Whitefield, Bangalore-560066
www.huawei.com
-
This e-mail and its attachments contain confidential information from HUAWEI, 
which 
is intended only for the person or entity whose address is listed above. Any 
use of the 
information contained herein in any way (including, but not limited to, total 
or partial 
disclosure, reproduction, or dissemination) by persons other than the intended 
recipient(s) is prohibited. If you receive this e-mail in error, please notify 
the sender by 
phone or email immediately and delete it!


-Original Message-
From: Sean Busbey [mailto:bus...@apache.org] 
Sent: Tuesday, June 20, 2017 3:31 AM
To: dev; u...@hbase.apache.org
Subject: [ANNOUNCE] New HBase committer Huaxiang Sun

On behalf of the Apache HBase PMC, I am pleased to announce that Huaxiang Sun 
has accepted the PMC's invitation to become a committer on the project. We 
appreciate all of Huaxiang's great work thus far and look forward to continued 
involvement.

Please join me in congratulating Huaxiang!

Re: [ANNOUNCE] New HBase committer Huaxiang Sun

[Phil Yang]

Congratulations!

Thanks,
Phil


2017-06-20 3:30 GMT+08:00 Sean Busbey :

> On behalf of the Apache HBase PMC, I am pleased to announce that
> Huaxiang Sun has accepted the PMC's invitation to become a committer
> on the project. We appreciate all of Huaxiang's great work thus far
> and look forward to continued involvement.
>
> Please join me in congratulating Huaxiang!
>

Re: Re: [ANNOUNCE] New HBase committer Huaxiang Sun

[Jingcheng Du]

Congratulations, Huaxiang!

2017-06-20 9:38 GMT+08:00 Chunhui Shen :

> Congrats， Huaxiang！
>
>
>
>
>
>
> Chunhui
>
> At 2017-06-20 09:21:24, "Guanghao Zhang"  wrote:
> >Congratulations and welcome, Huaxiang!
> >
> >2017-06-20 8:15 GMT+08:00 Jimmy Xiang :
> >
> >> Congrats!
> >>
> >> On Mon, Jun 19, 2017 at 5:02 PM, Stephen Jiang  >
> >> wrote:
> >> > Congrats and welcome to the team!
> >> >
> >> > Stephen
> >> >
> >> > On Mon, Jun 19, 2017 at 1:43 PM, Mike Drob  wrote:
> >> >
> >> >> Great work, Huaxiang!
> >> >>
> >> >> On Mon, Jun 19, 2017 at 2:30 PM, Sean Busbey 
> wrote:
> >> >>
> >> >> > On behalf of the Apache HBase PMC, I am pleased to announce that
> >> >> > Huaxiang Sun has accepted the PMC's invitation to become a
> committer
> >> >> > on the project. We appreciate all of Huaxiang's great work thus far
> >> >> > and look forward to continued involvement.
> >> >> >
> >> >> > Please join me in congratulating Huaxiang!
> >> >> >
> >> >>
> >>
>

Re:Re: [ANNOUNCE] New HBase committer Huaxiang Sun

[Chunhui Shen]

Congrats， Huaxiang！






Chunhui

At 2017-06-20 09:21:24, "Guanghao Zhang"  wrote:
>Congratulations and welcome, Huaxiang!
>
>2017-06-20 8:15 GMT+08:00 Jimmy Xiang :
>
>> Congrats!
>>
>> On Mon, Jun 19, 2017 at 5:02 PM, Stephen Jiang 
>> wrote:
>> > Congrats and welcome to the team!
>> >
>> > Stephen
>> >
>> > On Mon, Jun 19, 2017 at 1:43 PM, Mike Drob  wrote:
>> >
>> >> Great work, Huaxiang!
>> >>
>> >> On Mon, Jun 19, 2017 at 2:30 PM, Sean Busbey  wrote:
>> >>
>> >> > On behalf of the Apache HBase PMC, I am pleased to announce that
>> >> > Huaxiang Sun has accepted the PMC's invitation to become a committer
>> >> > on the project. We appreciate all of Huaxiang's great work thus far
>> >> > and look forward to continued involvement.
>> >> >
>> >> > Please join me in congratulating Huaxiang!
>> >> >
>> >>
>>

Re: [ANNOUNCE] New HBase committer Huaxiang Sun

[Guanghao Zhang]

Congratulations and welcome, Huaxiang!

2017-06-20 8:15 GMT+08:00 Jimmy Xiang :

> Congrats!
>
> On Mon, Jun 19, 2017 at 5:02 PM, Stephen Jiang 
> wrote:
> > Congrats and welcome to the team!
> >
> > Stephen
> >
> > On Mon, Jun 19, 2017 at 1:43 PM, Mike Drob  wrote:
> >
> >> Great work, Huaxiang!
> >>
> >> On Mon, Jun 19, 2017 at 2:30 PM, Sean Busbey  wrote:
> >>
> >> > On behalf of the Apache HBase PMC, I am pleased to announce that
> >> > Huaxiang Sun has accepted the PMC's invitation to become a committer
> >> > on the project. We appreciate all of Huaxiang's great work thus far
> >> > and look forward to continued involvement.
> >> >
> >> > Please join me in congratulating Huaxiang!
> >> >
> >>
>

[jira] [Created] (HBASE-18240) Add hbase-auxillary, a project with hbase utility including an hbase-shaded-thirdparty module with guava, netty, etc.

[stack (JIRA)]

stack created HBASE-18240:
-

 Summary: Add hbase-auxillary, a project with hbase utility 
including an hbase-shaded-thirdparty module with guava, netty, etc.
 Key: HBASE-18240
 URL: https://issues.apache.org/jira/browse/HBASE-18240
 Project: HBase
  Issue Type: Sub-task
Reporter: stack


This issue is about adding a new related project to host hbase auxillary 
utility. In this new project, the first thing we'd add is a module to host 
shaded versions of third party libraries.

This task comes of discussion held here 
http://apache-hbase.679495.n3.nabble.com/DISCUSS-More-Shading-td4083025.html 
where one conclusion of the DISCUSSION was "... pushing this part forward with 
some code is the next logical step. Seems to be consensus about taking our 
known internal dependencies and performing this shade magic."



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [ANNOUNCE] New HBase committer Huaxiang Sun

[Jimmy Xiang]

Congrats!

On Mon, Jun 19, 2017 at 5:02 PM, Stephen Jiang  wrote:
> Congrats and welcome to the team!
>
> Stephen
>
> On Mon, Jun 19, 2017 at 1:43 PM, Mike Drob  wrote:
>
>> Great work, Huaxiang!
>>
>> On Mon, Jun 19, 2017 at 2:30 PM, Sean Busbey  wrote:
>>
>> > On behalf of the Apache HBase PMC, I am pleased to announce that
>> > Huaxiang Sun has accepted the PMC's invitation to become a committer
>> > on the project. We appreciate all of Huaxiang's great work thus far
>> > and look forward to continued involvement.
>> >
>> > Please join me in congratulating Huaxiang!
>> >
>>

Re: [ANNOUNCE] New HBase committer Huaxiang Sun

[Stephen Jiang]

Congrats and welcome to the team!

Stephen

On Mon, Jun 19, 2017 at 1:43 PM, Mike Drob  wrote:

> Great work, Huaxiang!
>
> On Mon, Jun 19, 2017 at 2:30 PM, Sean Busbey  wrote:
>
> > On behalf of the Apache HBase PMC, I am pleased to announce that
> > Huaxiang Sun has accepted the PMC's invitation to become a committer
> > on the project. We appreciate all of Huaxiang's great work thus far
> > and look forward to continued involvement.
> >
> > Please join me in congratulating Huaxiang!
> >
>

Re: [DISCUSS] IntelliJ Code Analysis + Code Style

[Ted Yu]

bq. we can apply them to both branch-1 and branch-2

Many bug fixes are still targeting 1.x releases. If the stylistic fixes go
to branch-1, would that make porting between 1.x releases and branch-1 more
cumbersome ?

What is the amount of changes for the stylistic fixes you deem applicable ?

Cheers

On Mon, Jun 19, 2017 at 2:30 PM, Mike Drob  wrote:

> Hi Devs,
>
> I recently ran the IntelliJ code analysis on the hbase project and saw that
> it had some interesting suggestions.
>
> A lot of them don't point to bugs, but really end up being more of a
> stylistic issues. The ones I want to discuss specifically are the ones it
> categorizes as java version issues. Here's the list:
>
> Java 5:
> * 'for' loop replaceable with 'foreach'
> * Unnecessary unboxing
> Java 7:
> * Explicit type can be replaced with <>
> * Identical 'catch' branch in 'try' statements
> * Possible heap pollution from vararg type
> Java 8:
> * Anonymous type can be replaced with lambda
> * Anonymous type can be replaced with method reference
> * Lambda can be replaced with method reference
> * Statement lambda can be replaced with expression lambda
>
> I think I read somewhere once that 'foreach' is not great for garbage
> collection because it creates an extra iterator, so we can maybe ignore
> that one. And I personally prefer statement lambdas (with curly braces) to
> expression lambdas (without) especially for long lines, so ignore that one
> too. But maybe address the rest?
>
> If we focus on only the Java 5/7 issues, then we can apply them to both
> branch-1 and branch-2. Not sure how much value that provides, as I don't
> have the historical context to estimate how long branch-1 will continue to
> live once branch-2 is out.
>
> The IDE can do the code changes automatically, but it will still be a lot
> of time to review, hence the discussion before I cavalierly go and file an
> issue and attach a patch. Also, I have no idea how to turn these into
> automated checks once we fix any of them, and that seems kind of important.
>
> IntelliJ has other checks that we can look at as well, but these were the
> ones that caught my eye first as easiest to fix and least likely to false
> positive.
>
> Thoughts?
>
> Mike
>

[DISCUSS] IntelliJ Code Analysis + Code Style

[Mike Drob]

Hi Devs,

I recently ran the IntelliJ code analysis on the hbase project and saw that
it had some interesting suggestions.

A lot of them don't point to bugs, but really end up being more of a
stylistic issues. The ones I want to discuss specifically are the ones it
categorizes as java version issues. Here's the list:

Java 5:
* 'for' loop replaceable with 'foreach'
* Unnecessary unboxing
Java 7:
* Explicit type can be replaced with <>
* Identical 'catch' branch in 'try' statements
* Possible heap pollution from vararg type
Java 8:
* Anonymous type can be replaced with lambda
* Anonymous type can be replaced with method reference
* Lambda can be replaced with method reference
* Statement lambda can be replaced with expression lambda

I think I read somewhere once that 'foreach' is not great for garbage
collection because it creates an extra iterator, so we can maybe ignore
that one. And I personally prefer statement lambdas (with curly braces) to
expression lambdas (without) especially for long lines, so ignore that one
too. But maybe address the rest?

If we focus on only the Java 5/7 issues, then we can apply them to both
branch-1 and branch-2. Not sure how much value that provides, as I don't
have the historical context to estimate how long branch-1 will continue to
live once branch-2 is out.

The IDE can do the code changes automatically, but it will still be a lot
of time to review, hence the discussion before I cavalierly go and file an
issue and attach a patch. Also, I have no idea how to turn these into
automated checks once we fix any of them, and that seems kind of important.

IntelliJ has other checks that we can look at as well, but these were the
ones that caught my eye first as easiest to fix and least likely to false
positive.

Thoughts?

Mike

[jira] [Resolved] (HBASE-16246) Ensure avro version in hbase-spark matches that shipped in our default hadoop profile

[Sean Busbey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-16246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey resolved HBASE-16246.
-
   Resolution: Duplicate
Fix Version/s: (was: 2.0.0)

closing this out as a dup of HBASE-16242, since that forces the same version 
everywhere.

> Ensure avro version in hbase-spark matches that shipped in our default hadoop 
> profile
> -
>
> Key: HBASE-16246
> URL: https://issues.apache.org/jira/browse/HBASE-16246
> Project: HBase
>  Issue Type: Bug
>  Components: spark
>Affects Versions: 2.0.0
>Reporter: Sean Busbey
>Priority: Blocker
>
> currently, the hbase-spark module pulls in avro 1.7.6. We should keep this 
> matching the version in our default hadoop to keep things consistent (as of 
> Hadoop 2.7.1 that's avro 1.7.4).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (HBASE-18238) Address ruby static analysis for bin directory

[Mike Drob (JIRA)]

Mike Drob created HBASE-18238:
-

 Summary: Address ruby static analysis for bin directory
 Key: HBASE-18238
 URL: https://issues.apache.org/jira/browse/HBASE-18238
 Project: HBase
  Issue Type: Sub-task
Reporter: Mike Drob






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (HBASE-18239) Address ruby static analysis for shell module

[Mike Drob (JIRA)]

Mike Drob created HBASE-18239:
-

 Summary: Address ruby static analysis for shell module
 Key: HBASE-18239
 URL: https://issues.apache.org/jira/browse/HBASE-18239
 Project: HBase
  Issue Type: Sub-task
Reporter: Mike Drob






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (HBASE-18237) Address ruby static analysis reports

[Mike Drob (JIRA)]

Mike Drob created HBASE-18237:
-

 Summary: Address ruby static analysis reports
 Key: HBASE-18237
 URL: https://issues.apache.org/jira/browse/HBASE-18237
 Project: HBase
  Issue Type: Improvement
Reporter: Mike Drob
 Fix For: 2.0.0


Parent issue for addressing the static analysis findings for our ruby sources.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (HBASE-18236) [C++] Add batching and reporting to simple-client

[Enis Soztutar (JIRA)]

Enis Soztutar created HBASE-18236:
-

 Summary: [C++] Add batching and reporting to simple-client
 Key: HBASE-18236
 URL: https://issues.apache.org/jira/browse/HBASE-18236
 Project: HBase
  Issue Type: Sub-task
Reporter: Enis Soztutar
Assignee: Enis Soztutar
 Fix For: HBASE-14850


Simple change to add some batching configuration to simple-client to help 
testing multi-get and multi-puts with large number of rows. 





--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [ANNOUNCE] New HBase committer Huaxiang Sun

[Mike Drob]

Great work, Huaxiang!

On Mon, Jun 19, 2017 at 2:30 PM, Sean Busbey  wrote:

> On behalf of the Apache HBase PMC, I am pleased to announce that
> Huaxiang Sun has accepted the PMC's invitation to become a committer
> on the project. We appreciate all of Huaxiang's great work thus far
> and look forward to continued involvement.
>
> Please join me in congratulating Huaxiang!
>

Re: [ANNOUNCE] New HBase committer Huaxiang Sun

[Esteban Gutierrez]

Congratulations and well deserved, Huaxiang!

esteban.

--
Cloudera, Inc.


On Mon, Jun 19, 2017 at 1:21 PM, Karan Mehta  wrote:

> Congratulations Huaxiang!!
>
> Karan Mehta
> ᐧ
>
> On Mon, Jun 19, 2017 at 1:18 PM, Alexander Leblang <
> alex.lebl...@cloudera.com> wrote:
>
> > Congratulations Huaxiang!
> >
> > On Mon, Jun 19, 2017 at 12:30 PM, Sean Busbey  wrote:
> >
> > > On behalf of the Apache HBase PMC, I am pleased to announce that
> > > Huaxiang Sun has accepted the PMC's invitation to become a committer
> > > on the project. We appreciate all of Huaxiang's great work thus far
> > > and look forward to continued involvement.
> > >
> > > Please join me in congratulating Huaxiang!
> > >
> >
>

Re: [ANNOUNCE] New HBase committer Huaxiang Sun

[Karan Mehta]

Congratulations Huaxiang!!

Karan Mehta
ᐧ

On Mon, Jun 19, 2017 at 1:18 PM, Alexander Leblang <
alex.lebl...@cloudera.com> wrote:

> Congratulations Huaxiang!
>
> On Mon, Jun 19, 2017 at 12:30 PM, Sean Busbey  wrote:
>
> > On behalf of the Apache HBase PMC, I am pleased to announce that
> > Huaxiang Sun has accepted the PMC's invitation to become a committer
> > on the project. We appreciate all of Huaxiang's great work thus far
> > and look forward to continued involvement.
> >
> > Please join me in congratulating Huaxiang!
> >
>

Re: [ANNOUNCE] New HBase committer Huaxiang Sun

[Alexander Leblang]

Congratulations Huaxiang!

On Mon, Jun 19, 2017 at 12:30 PM, Sean Busbey  wrote:

> On behalf of the Apache HBase PMC, I am pleased to announce that
> Huaxiang Sun has accepted the PMC's invitation to become a committer
> on the project. We appreciate all of Huaxiang's great work thus far
> and look forward to continued involvement.
>
> Please join me in congratulating Huaxiang!
>

Re: [ANNOUNCE] New HBase committer Huaxiang Sun

[Andrew Purtell]

Congratulations and welcome, Huaxiang! 

> On Jun 19, 2017, at 12:30 PM, Sean Busbey  wrote:
> 
> On behalf of the Apache HBase PMC, I am pleased to announce that
> Huaxiang Sun has accepted the PMC's invitation to become a committer
> on the project. We appreciate all of Huaxiang's great work thus far
> and look forward to continued involvement.
> 
> Please join me in congratulating Huaxiang!

Re: [ANNOUNCE] New Apache HBase committer Ashu Pachauri

[Ashu Pachauri]

Thank you guys!

Best,
Ashu Pachauri

On Sun, Jun 18, 2017 at 8:26 PM, 宾莉金（binlijin）  wrote:

> Congratulations, Ashu !
>
> 2017-06-17 7:27 GMT+08:00 Gary Helmling :
>
> > On behalf of the Apache HBase PMC, I am pleased to announce that Ashu
> > Pachauri has accepted the PMC's invitation to become a committer on the
> > project.  We appreciate all of Ashu's generous contributions thus far and
> > look forward to his continued involvement.
> >
> > Congratulations and welcome, Ashu!
> >
>
>
>
> --
> *Best Regards,*
>  lijin bin
>

Re: [ANNOUNCE] New HBase committer Huaxiang Sun

[Umesh Agashe]

yay! Congratulations Huaxiang!

On Mon, Jun 19, 2017 at 12:30 PM, Sean Busbey  wrote:

> On behalf of the Apache HBase PMC, I am pleased to announce that
> Huaxiang Sun has accepted the PMC's invitation to become a committer
> on the project. We appreciate all of Huaxiang's great work thus far
> and look forward to continued involvement.
>
> Please join me in congratulating Huaxiang!
>

Re: [ANNOUNCE] New HBase committer Huaxiang Sun

[Ted Yu]

Congratulations, Huaxiang.

On Mon, Jun 19, 2017 at 12:30 PM, Sean Busbey  wrote:

> On behalf of the Apache HBase PMC, I am pleased to announce that
> Huaxiang Sun has accepted the PMC's invitation to become a committer
> on the project. We appreciate all of Huaxiang's great work thus far
> and look forward to continued involvement.
>
> Please join me in congratulating Huaxiang!
>

[ANNOUNCE] New HBase committer Huaxiang Sun

[Sean Busbey]

On behalf of the Apache HBase PMC, I am pleased to announce that
Huaxiang Sun has accepted the PMC's invitation to become a committer
on the project. We appreciate all of Huaxiang's great work thus far
and look forward to continued involvement.

Please join me in congratulating Huaxiang!

[jira] [Resolved] (HBASE-18178) [C++] Retrying meta location lookup and zookeeper connection

[Enis Soztutar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Enis Soztutar resolved HBASE-18178.
---
   Resolution: Fixed
Fix Version/s: HBASE-14850

Pushed this to the branch. 

> [C++] Retrying meta location lookup and zookeeper connection 
> -
>
> Key: HBASE-18178
> URL: https://issues.apache.org/jira/browse/HBASE-18178
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
> Fix For: HBASE-14850
>
> Attachments: hbase-18178-v1.patch
>
>
> Currently location-cache can only do a single lookup to meta. If meta 
> location changes or we have zookeeper connection problems, we never retry. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[RESULT][VOTE] First release candidate for HBase 1.1.11 (RC0) is available

[Nick Dimiduk]

With 5 binding votes cast +1 and no other votes recorded, this measure
passes. I will promote RC0 as 1.1.11.

Thanks to everyone who took the time.
-n

On Mon, Jun 19, 2017 at 4:38 AM, Anoop John  wrote:

> +1
>
> Signature ok
> Built from src and looks good
> UT pass
> Started a single node cluster and run some commands from shell. Looks ok
>
> Loaded  1GB data and some random reads . Looks ok
>
> -Anoop-
>
>
> On Fri, Jun 16, 2017 at 7:34 AM, Yu Li  wrote:
> > +1
> >
> > Checked sums and signatures: ok
> > Built from source: ok (7u79)
> > RAT check: ok (7u79)
> > Compatibility check: ok (7u79), ran check_compatibility.sh locally, 100%
> > compatible with 1.1.10 (both binary and source)
> > Unit tests pass: ok (8u101)
> > - Passed with -Dsurefire.rerunFailingTestsCount=2
> > Shell commands: ok (8u101), ran DDL/flush/compact/split commands,
> > everything looks good
> > Loaded 1M rows with LTT: ok (8u101), all keys verified, latency and logs
> > looks good
> >
> > Best Regards,
> > Yu
> >
> > On 16 June 2017 at 01:35, Josh Elser  wrote:
> >
> >> +1 (binding)
> >>
> >> * No unexpected binaries in source release
> >> * L look good
> >> * Could build from source
> >> * Could run bin-tarball as-is
> >> * Checked compat report (thanks for publishing)
> >> * xsum/sigs OK
> >> * Ran a PE randomwritetest
> >>
> >>
> >> On 6/10/17 7:40 PM, Nick Dimiduk wrote:
> >>
> >>> I'm happy to announce the first release candidate of HBase 1.1.11
> >>> (HBase-1.1.11RC0) is available for download at
> >>> https://dist.apache.org/repos/dist/dev/hbase/hbase-1.1.11RC0/
> >>>
> >>> Maven artifacts are also available in the staging repository
> >>> https://repository.apache.org/content/repositories/
> orgapachehbase-1170/
> >>>
> >>> Artifacts are signed with my code signing subkey 0xAD9039071C3489BD,
> >>> available in the Apache keys directory
> >>> https://people.apache.org/keys/committer/ndimiduk.asc and in our KEYS
> >>> file
> >>> http://www-us.apache.org/dist/hbase/KEYS.
> >>>
> >>> There's also a signed tag for this release at
> >>> https://git-wip-us.apache.org/repos/asf?p=hbase.git;a=tag;h=
> >>> d318fbeef0990e53efb313c1a459cce73ed4edb8
> >>>
> >>> The detailed source and binary compatibility report vs 1.1.10 has been
> >>> published for your review, at
> >>> https://home.apache.org/~ndimiduk/1.1.10_1.1.11RC0_compat_report.html
> >>>
> >>> HBase 1.1.11 is the eleventh patch release in the HBase 1.1 line,
> >>> continuing on the theme of bringing a stable, reliable database to the
> >>> Hadoop and NoSQL communities. This release includes nearly 20 bug fixes
> >>> since the 1.1.10 release. Notable correctness fixes include
> >>> HBASE-17937, HBASE-18036, HBASE-18081, HBASE-18093, HBASE-16011, and
> >>> HBASE-18066.
> >>>
> >>> The full list of fixes included in this release is available at
> >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
> >>> ctId=12310753=12340375
> >>> and and in the CHANGES.txt file included in the distribution.
> >>>
> >>> Let's leave this vote up an extra couple days since HBaseCon is this
> week.
> >>> Please try out this candidate and vote +/-1 by 23:59 Pacific time on
> >>> Sunday, 2017-06-18 as to whether we should release these artifacts as
> >>> HBase
> >>> 1.1.11.
> >>>
> >>> Thanks,
> >>> Nick
> >>>
> >>>
>

[jira] [Created] (HBASE-18235) LoadBalancer.BOGUS_SERVER_NAME should not have a bogus hostname

[Francis Liu (JIRA)]

Francis Liu created HBASE-18235:
---

 Summary: LoadBalancer.BOGUS_SERVER_NAME should not have a bogus 
hostname
 Key: HBASE-18235
 URL: https://issues.apache.org/jira/browse/HBASE-18235
 Project: HBase
  Issue Type: Bug
Reporter: Francis Liu
Assignee: Francis Liu


The original patch used localhost to have assignment fail fast. Avoiding 
misleading DNS exceptions, delays due to dns lookup, etc. 

Was wondering what the reason was for changing it?




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Difference between peerData and configuration in ReplicationPeerConfig

[Enis Söztutar]

Indeed, config and data are very similar for the purpose of carrying custom
information / metadata for the replication peer. Configuration is String ->
String, versus data is String -> binary. This is similar to how we handle
these in HTD etc.

Enis

On Sun, Jun 18, 2017 at 7:38 AM, Guanghao Zhang  wrote:

> We have a ReplicationEndpoint implementation which replicate data to a
> streaming system(similar to kafka). And only use the configuration for the
> endpoint. I don't know the difference between DATA and CONFIG. I thought
> use CONFIG is enough for most cases.
>
> 2017-06-18 22:01 GMT+08:00 Jan Kunigk :
>
> > Hi, I am aware this might be pretty much a newbie question but I struggle
> > to see any docs on the what peerData and or configuration in
> > ReplicationPeerConfig should be used for...
> >
> >   private final Map peerData;
> >   private final Map configuration;
> >
> > I would like to use them in a way that I feel apt to support a JIRA I am
> > working on, but I want to make sure I do not miss the understanding of a
> > different designated use. The configuration field seems to be quite clear
> > from the context, but what about peerData?
> >
> > src/main/ruby/shell/commands/add_peer.rb clarifies the syntax but not
> the
> > semantics...
> >  hbase> add_peer '9', ENDPOINT_CLASSNAME =>
> > 'org.apache.hadoop.hbase.MyReplicationEndpoint',
> > DATA => { "key1" => 1 }, CONFIG => { "config1" => "value1", "config2"
> > => "value2" },
> >
> > Again, I hope I am not missing something obvious and would appreciate any
> > pointer.
> >
> >
> > Best, J
> >
>

Re: TimeBoundedRequestsWithRegionReplicas with unbalance monkey

[Enis Söztutar]

Hey,

I don't know whether you are familiar with the different policies that the
named chaos monkeys implement. The test is testing backup RPCs when you
kill the servers. The unbalance monkey is a very specific one that does
unbalance + rolling kill all the servers. If you read the comments for the
test, it needs the meta server to not be killed because it assumes that you
are deploying without the meta replicas (I think the test has been
developed before the meta replicas were there).

I think you CAN run the test with the unbalance, but the intention for it
was to be run with the server killing one. I would look into why you need
to increase the timeout (maybe meta recovers under 15 secs?).

Enis


On Mon, Jun 19, 2017 at 2:19 AM, Balazs Meszaros <
balazs.mesza...@cloudera.com> wrote:

> Hi Enis,
>
> We run IntegrationTestTimeBoundedRequestsWithRegionReplicas integration
> test in our test infrastructure with unbalance chaos monkey. According to
> the comment on the class, this test works only with serverKilling monkey.
> With unbalance monkey it also works if I increase get_timeout_ms to 15
> seconds instead of the default 5 seconds timeout.
>
> 1. Are there any reasons why should we only test it with serverKilling
> monkey?
> 2. Is it okay for the unbalance monkey if we increase the timeout to 15
> seconds or should it also work for 5 seconds timeout?
>
> Thanks,
> Balazs
>

[jira] [Created] (HBASE-18234) Revisit the async admin apit

[Guanghao Zhang (JIRA)]

Guanghao Zhang created HBASE-18234:
--

 Summary: Revisit the async admin apit
 Key: HBASE-18234
 URL: https://issues.apache.org/jira/browse/HBASE-18234
 Project: HBase
  Issue Type: Sub-task
Reporter: Guanghao Zhang


1. Update the balance method name. 
balancer -> balance
setBalancerRunning -> setBalancerOn
isBalancerEnabled -> isBalancerOn
2. Use HRegionLocation instead of Pair
3. Remove the closeRegionWithEncodedRegionName method. Because all other api 
can handle region name or encoded region name both. So don't need a method for 
encoded name.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [VOTE] First release candidate for HBase 1.1.11 (RC0) is available

[Anoop John]

+1

Signature ok
Built from src and looks good
UT pass
Started a single node cluster and run some commands from shell. Looks ok

Loaded  1GB data and some random reads . Looks ok

-Anoop-


On Fri, Jun 16, 2017 at 7:34 AM, Yu Li  wrote:
> +1
>
> Checked sums and signatures: ok
> Built from source: ok (7u79)
> RAT check: ok (7u79)
> Compatibility check: ok (7u79), ran check_compatibility.sh locally, 100%
> compatible with 1.1.10 (both binary and source)
> Unit tests pass: ok (8u101)
> - Passed with -Dsurefire.rerunFailingTestsCount=2
> Shell commands: ok (8u101), ran DDL/flush/compact/split commands,
> everything looks good
> Loaded 1M rows with LTT: ok (8u101), all keys verified, latency and logs
> looks good
>
> Best Regards,
> Yu
>
> On 16 June 2017 at 01:35, Josh Elser  wrote:
>
>> +1 (binding)
>>
>> * No unexpected binaries in source release
>> * L look good
>> * Could build from source
>> * Could run bin-tarball as-is
>> * Checked compat report (thanks for publishing)
>> * xsum/sigs OK
>> * Ran a PE randomwritetest
>>
>>
>> On 6/10/17 7:40 PM, Nick Dimiduk wrote:
>>
>>> I'm happy to announce the first release candidate of HBase 1.1.11
>>> (HBase-1.1.11RC0) is available for download at
>>> https://dist.apache.org/repos/dist/dev/hbase/hbase-1.1.11RC0/
>>>
>>> Maven artifacts are also available in the staging repository
>>> https://repository.apache.org/content/repositories/orgapachehbase-1170/
>>>
>>> Artifacts are signed with my code signing subkey 0xAD9039071C3489BD,
>>> available in the Apache keys directory
>>> https://people.apache.org/keys/committer/ndimiduk.asc and in our KEYS
>>> file
>>> http://www-us.apache.org/dist/hbase/KEYS.
>>>
>>> There's also a signed tag for this release at
>>> https://git-wip-us.apache.org/repos/asf?p=hbase.git;a=tag;h=
>>> d318fbeef0990e53efb313c1a459cce73ed4edb8
>>>
>>> The detailed source and binary compatibility report vs 1.1.10 has been
>>> published for your review, at
>>> https://home.apache.org/~ndimiduk/1.1.10_1.1.11RC0_compat_report.html
>>>
>>> HBase 1.1.11 is the eleventh patch release in the HBase 1.1 line,
>>> continuing on the theme of bringing a stable, reliable database to the
>>> Hadoop and NoSQL communities. This release includes nearly 20 bug fixes
>>> since the 1.1.10 release. Notable correctness fixes include
>>> HBASE-17937, HBASE-18036, HBASE-18081, HBASE-18093, HBASE-16011, and
>>> HBASE-18066.
>>>
>>> The full list of fixes included in this release is available at
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
>>> ctId=12310753=12340375
>>> and and in the CHANGES.txt file included in the distribution.
>>>
>>> Let's leave this vote up an extra couple days since HBaseCon is this week.
>>> Please try out this candidate and vote +/-1 by 23:59 Pacific time on
>>> Sunday, 2017-06-18 as to whether we should release these artifacts as
>>> HBase
>>> 1.1.11.
>>>
>>> Thanks,
>>> Nick
>>>
>>>

TimeBoundedRequestsWithRegionReplicas with unbalance monkey

[Balazs Meszaros]

Hi Enis,

We run IntegrationTestTimeBoundedRequestsWithRegionReplicas integration
test in our test infrastructure with unbalance chaos monkey. According to
the comment on the class, this test works only with serverKilling monkey.
With unbalance monkey it also works if I increase get_timeout_ms to 15
seconds instead of the default 5 seconds timeout.

1. Are there any reasons why should we only test it with serverKilling
monkey?
2. Is it okay for the unbalance monkey if we increase the timeout to 15
seconds or should it also work for 5 seconds timeout?

Thanks,
Balazs