[jira] [Resolved] (HBASE-23585) MetricsRegionServerWrapperImpl.getL1CacheHitCount always returns 200
[ https://issues.apache.org/jira/browse/HBASE-23585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-23585. --- Fix Version/s: 1.6.1 Hadoop Flags: Reviewed Resolution: Fixed Pushed to branch-1. It seems to be a problem on this branch only (correct me if I am wrong [~DeanZ]). Thanks to reviewers [~binlijin] and [~janh] > MetricsRegionServerWrapperImpl.getL1CacheHitCount always returns 200 > > > Key: HBASE-23585 > URL: https://issues.apache.org/jira/browse/HBASE-23585 > Project: HBase > Issue Type: Bug > Components: metrics >Affects Versions: 1.4.12 >Reporter: Baiqiang Zhao >Assignee: Baiqiang Zhao >Priority: Major > Fix For: 1.6.1 > > > Looks like it was copied from a UT class and forgot to change it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-23632) DeadServer cleanup
[ https://issues.apache.org/jira/browse/HBASE-23632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-23632. --- Fix Version/s: 2.3.0 3.0.0 Hadoop Flags: Reviewed Resolution: Fixed Pushed to branch-2+ (Applied it to branch-2.2 but then reverted because it just an improvement and logging is changed mildly). > DeadServer cleanup > -- > > Key: HBASE-23632 > URL: https://issues.apache.org/jira/browse/HBASE-23632 > Project: HBase > Issue Type: Improvement >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Minor > Fix For: 3.0.0, 2.3.0 > > > Cleanup of DeadServer class shutting down access, undoing duplication, adding > doc., and removing unused code. > One change is that we do not remove a server from 'processing' list when we > 'remove' deadservers; we let SCP do it since it owns processing list (Saw > issue where on fast restart of a server, the server was removed from > deadserver and from processing list though the SCP for the dead server was > still running -- no repercussions that I could see but a little confusing). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-23596) HBCKServerCrashProcedure can double assign
[
https://issues.apache.org/jira/browse/HBASE-23596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack resolved HBASE-23596.
---
Fix Version/s: (was: 2.2.4)
2.2.3
Hadoop Flags: Reviewed
Release Note:
Makes it so the recently added HBCKServerCrashProcedure -- the SCP that gets
invoked when an operator schedules an SCP via hbck2 scheduleRecoveries command
-- now works the same as SCP EXCEPT if master knows nothing of the scheduled
servername. In this latter case, HBCKSCP will do a full scan of hbase:meta
looking for instances of the passed servername. If any found it will attempt
cleanup of hbase:meta references by reassigning any found OPEN or OPENING and
by closing any in CLOSING state.
Used to fix instances of what the 'HBCK Report' page shows as 'Unknown Servers'.
Resolution: Fixed
Merged to branch-2.2+
> HBCKServerCrashProcedure can double assign
> --
>
> Key: HBASE-23596
> URL: https://issues.apache.org/jira/browse/HBASE-23596
> Project: HBase
> Issue Type: Bug
> Components: proc-v2
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.3
>
>
> The new SCP that does SCP plus cleanup 'Unknown Servers' with mentions in
> hbase:meta added by the below can make for double assignments.
> {code}
> commit c238891a26734e1e4276b6b1677a58cf83de5dc4
> Author: stack
> Date: Wed Nov 13 22:36:26 2019 -0800
> HBASE-23282 HBCKServerCrashProcedure for 'Unknown Servers'
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (HBASE-23628) Remove Apache Commons Digest Base64
[ https://issues.apache.org/jira/browse/HBASE-23628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-23628. --- Fix Version/s: 3.0.0 Release Note: >From the PR: "Yes. The two create the same output... I just wrote a small test suite to increase my confidence on that. I generated many tens of millions of random byte patterns and compared the output of the two algorithms. They came back identical every time. "Just in case any inquiring minds would like to know, there is no longer an encoding required when generating the strings. The JDK implementation specifically specifies that strings returned are StandardCharsets.ISO_8859_1. This does not change anything because UTF8 and ISO_8859 overlap for the limited character set (64 characters) the encoding uses." Resolution: Fixed Thanks for the patch [~belugabehr] and the work done to verify the change. > Remove Apache Commons Digest Base64 > --- > > Key: HBASE-23628 > URL: https://issues.apache.org/jira/browse/HBASE-23628 > Project: HBase > Issue Type: Improvement >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > Fix For: 3.0.0 > > > Use the native JDK Base64 implementation instead. Most places are using the > JDK version, but a couple of spots were missed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23632) DeadServer cleanup
Michael Stack created HBASE-23632: - Summary: DeadServer cleanup Key: HBASE-23632 URL: https://issues.apache.org/jira/browse/HBASE-23632 Project: HBase Issue Type: Improvement Reporter: Michael Stack Assignee: Michael Stack -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23631) Backport HBASE-23066, HBASE-23588, HBASE-23350 to branch-1
Viraj Jasani created HBASE-23631: Summary: Backport HBASE-23066, HBASE-23588, HBASE-23350 to branch-1 Key: HBASE-23631 URL: https://issues.apache.org/jira/browse/HBASE-23631 Project: HBase Issue Type: Sub-task Affects Versions: 1.6.0 Reporter: Viraj Jasani Assignee: Viraj Jasani Backport HBASE-23066 and all relevant subtasks to branch-1: HBASE-23066: Create a config that forces to cache blocks on compaction HBASE-23588: Cache index blocks and bloom blocks on write if CacheCompactedBlocksOnWrite is enabled HBASE-23350: Make compaction files cacheonWrite configurable based on threshold -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23630) synchronizedXxx-related defects
Roman Leventov created HBASE-23630:
--
Summary: synchronizedXxx-related defects
Key: HBASE-23630
URL: https://issues.apache.org/jira/browse/HBASE-23630
Project: HBase
Issue Type: Bug
Reporter: Roman Leventov
1. org.apache.hadoop.hbase.rest.client.Cluster: {{nodes}} could be iterated in
{{toString()}} in parallel with modification. The body of the {{toString()}}
method should be wrapped with {{synchronized(nodes) {}}}.
2. org.apache.hadoop.hbase.util.HBaseFsck: {{orphanHdfsDirs}} could be iterated
in {{adoptHdfsOrphans()}} in parallel with modification. The body of the
{{adoptHdfOrphans()}} should be wrapped with {{synchronized (orphanHdfsDirs)
{}}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
