[jira] [Created] (HBASE-23707) Add IntelliJ check style plugin configuration
Nick Dimiduk created HBASE-23707: Summary: Add IntelliJ check style plugin configuration Key: HBASE-23707 URL: https://issues.apache.org/jira/browse/HBASE-23707 Project: HBase Issue Type: Sub-task Components: build Reporter: Nick Dimiduk IntelliJ defines project configuration across a number of files, specifically so that some configurations can be committed with the source repository. The checkstyle plugin configuration is one such config file; add it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-23700) Upgrade checkstyle and plugin versions
[ https://issues.apache.org/jira/browse/HBASE-23700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-23700. -- Resolution: Fixed Applied to master and branch-2. Tried branch-1, but the new version of the plugin doesn't work on java7. {{noformat}} [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (default-cli) on project hbase: Execution default-cli of goal org.apache.maven.plugins:maven-checkstyle-plugin:3 .1.0:check failed: Unable to load the mojo 'check' in the plugin 'org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0' due to an API incompatibility: org.codehaus.plexus.component.repository.exception. ComponentLookupException: org/apache/maven/plugins/checkstyle/CheckstyleViolationCheckMojo : Unsupported major.minor version 52.0 {{noformat}} > Upgrade checkstyle and plugin versions > -- > > Key: HBASE-23700 > URL: https://issues.apache.org/jira/browse/HBASE-23700 > Project: HBase > Issue Type: Task > Components: build >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Minor > Fix For: 3.0.0, 2.3.0 > > > Our checkstyle version is pretty antiquated. Update it, and pull in the > latest version of the maven plugin as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-23706) Update checkstyle plugin (and update checkstyle.xml to match)
[ https://issues.apache.org/jira/browse/HBASE-23706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-23706. --- Resolution: Duplicate Resolving as duplicate of HBASE-23700 (Thanks [~bharathv]) > Update checkstyle plugin (and update checkstyle.xml to match) > - > > Key: HBASE-23706 > URL: https://issues.apache.org/jira/browse/HBASE-23706 > Project: HBase > Issue Type: Sub-task >Reporter: Michael Stack >Priority: Major > > In parent issue, its suggested we update our checkstyle plugin to match of > intellij plugin default at least. Will need checkstyle.xml changes else it > fails parse (See notes in parent by [~bharathv] on what needs doing). > For extra points, do the [~ndimiduk] suggestion: "...It would be nice also if > we could commit the .idea/checkstyle-idea.xml file with the checkstyle > version used buy the plugin pinned to the same version as we're using in > maven." -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-23676) Address feedback on HBASE-23055 Alter hbase:meta.
[ https://issues.apache.org/jira/browse/HBASE-23676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-23676. --- Resolution: Won't Fix The parent HBASE-23055 was recast. This issue no longer relevant (The feedback was addressed up in new patch attached on HBASE-23055) > Address feedback on HBASE-23055 Alter hbase:meta. > - > > Key: HBASE-23676 > URL: https://issues.apache.org/jira/browse/HBASE-23676 > Project: HBase > Issue Type: Bug > Components: meta >Affects Versions: 2.3.0 >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 3.0.0, 2.3.0 > > > Good feedback on HBASE-23055 came in after merge from [~zhangduo]. Opening > this issue to address it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-18326) Fix and reenable TestMasterProcedureWalLease
[ https://issues.apache.org/jira/browse/HBASE-18326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-18326. --- Assignee: Szabolcs Bukros Resolution: Fixed Resolving because test was removed. Thanks [~bszabolcs]. Assigned ticket to you as you did research. > Fix and reenable TestMasterProcedureWalLease > > > Key: HBASE-18326 > URL: https://issues.apache.org/jira/browse/HBASE-18326 > Project: HBase > Issue Type: Sub-task > Components: test >Reporter: Michael Stack >Assignee: Szabolcs Bukros >Priority: Blocker > Fix For: 3.0.0, 2.3.0 > > > Fix and reenable flakey important test. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-23612) Update pom.xml to use another 2.5.0 protoc as external protobuf
[ https://issues.apache.org/jira/browse/HBASE-23612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-23612. --- Fix Version/s: 3.0.0 Hadoop Flags: Reviewed Assignee: zhao bo Resolution: Fixed Merged. Thanks for the patch [~bzhaoopenstack] > Update pom.xml to use another 2.5.0 protoc as external protobuf > --- > > Key: HBASE-23612 > URL: https://issues.apache.org/jira/browse/HBASE-23612 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: zhao bo >Assignee: zhao bo >Priority: Major > Fix For: 3.0.0 > > > Currently, there is no protoc 2.5.0 for release [1]. So we can make a new one > for ARM specific. For make sure that could work on ARM. > We will introduce a new ARM artifact for protoc, group_id is > org.openlabtesting.protobuf .. This is just used for protobuf-maven-plugin to > compile .proto files. As the 3.X version of protoc support ARM already. So > this won't affect the internal protoc usage, which is 3.5.1-1 now. > > [1][https://github.com/protocolbuffers/protobuf/issues/3844#issuecomment-343355946] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-23690) Checkstyle plugin complains about our checkstyle.xml format; doc how to resolve mismatched version
[ https://issues.apache.org/jira/browse/HBASE-23690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-23690. --- Fix Version/s: 3.0.0 Assignee: Michael Stack Resolution: Fixed Resolving. Made subissue to address the update of the checkstyle plugin and to do the Nick nice suggestion above. Thanks for reviews. > Checkstyle plugin complains about our checkstyle.xml format; doc how to > resolve mismatched version > -- > > Key: HBASE-23690 > URL: https://issues.apache.org/jira/browse/HBASE-23690 > Project: HBase > Issue Type: Bug >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Trivial > Fix For: 3.0.0 > > > Trying to add the checkstyle.xml to the intellij checkstyle plugin after > reading HBASE-23688, it complains with the following when it reads in the > config file: > {code} > com.puppycrawl.tools.checkstyle.api.CheckstyleException: cannot initialize > module TreeWalker - TreeWalker is not allowed as a parent of LineLength > Please review 'Parent Module' section for this Check in web documentation if > Check is standard. > at com.puppycrawl.tools.checkstyle.Checker.setupChild(Checker.java:473) > at > com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure(AutomaticBean.java:198) > at > org.infernus.idea.checkstyle.service.cmd.OpCreateChecker.execute(OpCreateChecker.java:61) > at > org.infernus.idea.checkstyle.service.cmd.OpCreateChecker.execute(OpCreateChecker.java:26) > at > org.infernus.idea.checkstyle.service.CheckstyleActionsImpl.executeCommand(CheckstyleActionsImpl.java:130) > at > org.infernus.idea.checkstyle.service.CheckstyleActionsImpl.createChecker(CheckstyleActionsImpl.java:60) > at > org.infernus.idea.checkstyle.service.CheckstyleActionsImpl.createChecker(CheckstyleActionsImpl.java:51) > at > org.infernus.idea.checkstyle.checker.CheckerFactoryWorker.run(CheckerFactoryWorker.java:46) > Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: > TreeWalker is not allowed as a parent of LineLength Please review 'Parent > Module' section for this Check in web documentation if Check is standard. > at > com.puppycrawl.tools.checkstyle.TreeWalker.setupChild(TreeWalker.java:147) > at > com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure(AutomaticBean.java:198) > at com.puppycrawl.tools.checkstyle.Checker.setupChild(Checker.java:468) > ... 7 more > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23706) Update checkstyle plugin (and update checkstyle.xml to match)
Michael Stack created HBASE-23706: - Summary: Update checkstyle plugin (and update checkstyle.xml to match) Key: HBASE-23706 URL: https://issues.apache.org/jira/browse/HBASE-23706 Project: HBase Issue Type: Sub-task Reporter: Michael Stack In parent issue, its suggested we update our checkstyle plugin to match of intellij plugin default at least. Will need checkstyle.xml changes else it fails parse (See notes in parent by [~bharathv] on what needs doing). For extra points, do the [~ndimiduk] suggestion: "...It would be nice also if we could commit the .idea/checkstyle-idea.xml file with the checkstyle version used buy the plugin pinned to the same version as we're using in maven." -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23705) Add CellComparator to HFileContext
Michael Stack created HBASE-23705: - Summary: Add CellComparator to HFileContext Key: HBASE-23705 URL: https://issues.apache.org/jira/browse/HBASE-23705 Project: HBase Issue Type: Sub-task Components: io Reporter: Michael Stack Assignee: Michael Stack Fix For: 3.0.0, 2.3.0 The HFileContext is present when reading and writing files. It is populated at read time using HFile trailer content and file metadata. At write time, we create it up front. Interesting is that though CellComparator is written to the HFile trailer, and parse of the Trailer creates an HFileInfo which builds the HFileContext at read time, the HFileContext does not expose what CellComparator to use decoding and seeking. Around the codebase there are various compensations made for this lack with decoders that actually have a decoding context (with a reference to the hfilecontext), hard-coding use of the default CellComparator. StoreFileInfo will use default if not passed a comparator (even though we'd just read the trailer) and HFile itself is similar. Let me fix this situation removing ambiguity. It will also fix bugs in parent issue where UTs are failing because wrong CellComparator is being used. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: [VOTE] Move stable pointer to the latest 2.2.x release
FWIW I don't think we need a VOTE on this; consensus has been shown across several discussion threads. all the same, +1 from me. On Fri, Jan 17, 2020 at 8:42 AM Duo Zhang wrote: > We have discussed this several times in the past, this is the most recent > one > > > https://lists.apache.org/thread.html/f9ae2bf212d4d1c48eecf3d1d26edb0dd3d1d3bb8096bf6740839dbe%40%3Cdev.hbase.apache.org%3E > > > And seems the consensus is to move the stable pointer to 2.2.x. > > So here I want to call a vote, to officially move the stable pointer to > 2.2.3, and create a new stable-1 pointer to point to 1.4.11. > > The vote will last for at least 72 hours. > > Please vote > > [+1] Agree > [-1] Disagree (please include actionable feedback) > > Thanks. >
Re: Rolling upgrade from 1.x to 2.x for cluster with Dynamic coprocessors on table
The path to the dynamic coprocessor jars is something you can configure in hbase-site.xml. maintain different path configs for the RS that are still 1.y compared to those that are 2.y. On Fri, Jan 17, 2020 at 10:31 AM kanaka wrote: > Hi Team, > > I am analyzing Rolling Upgrade support from HBase 1.3 to 2.2.2. > We have some tables uses dynamic co-processor jars > > As I understand code from > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost only one jar > from > the HDFS path is loaded. There is no provision to provide alternative HDFS > paths to handle the RS which is not upgraded yet. > > For example if jars are upgraded in HDFS path, 1.x RS yet to be upgraded > fails to load CP class (if restarted due to crash). Otherway if jars are > not > upgraded, 2.x RS fails. > > Please help me find if there is any mechanism to handle this problem. > > > > > Regards, > Kanaka > > > > -- > Sent from: > http://apache-hbase.679495.n3.nabble.com/HBase-Developer-f679493.html >
[jira] [Resolved] (HBASE-23701) Make sure HBaseClassTestRule doesn't suffer same issue as HBaseClassTestRuleChecker
[ https://issues.apache.org/jira/browse/HBASE-23701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser resolved HBASE-23701. Hadoop Flags: Reviewed Resolution: Fixed Thanks for the reviews, Bharath and Viraj! > Make sure HBaseClassTestRule doesn't suffer same issue as > HBaseClassTestRuleChecker > --- > > Key: HBASE-23701 > URL: https://issues.apache.org/jira/browse/HBASE-23701 > Project: HBase > Issue Type: Bug >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.2.3, 2.1.9 > > > [~bharathv] pointed out on HBASE-23695 > ([https://github.com/apache/hbase/pull/1052]) that HBaseClassTestRule suffers > the same potential bug that I fixed in HBASE-23695 for > HBaseClassTestRuleChecker. Make sure the fix is in both places. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-23665) Split unit tests from TestTableName into a separate test only class
[ https://issues.apache.org/jira/browse/HBASE-23665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-23665. -- Resolution: Fixed Thanks for the cleanup [~bharathv]. > Split unit tests from TestTableName into a separate test only class > --- > > Key: HBASE-23665 > URL: https://issues.apache.org/jira/browse/HBASE-23665 > Project: HBase > Issue Type: Test > Components: test >Reporter: Nick Dimiduk >Assignee: Bharath Vissapragada >Priority: Minor > Fix For: 3.0.0, 2.3.0, 1.6.0 > > > The class {{TestTableName}} in hbase-common is both a unit test for the > {{TableName}} class, and a junit {{TestRule}}. This double-duty is strange; > the Rule functionality is not discoverable at all. Split the Rule out into a > separate class, maybe {{TableNameRule}} or some such. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Rolling upgrade from 1.x to 2.x for cluster with Dynamic coprocessors on table
Hi Team, I am analyzing Rolling Upgrade support from HBase 1.3 to 2.2.2. We have some tables uses dynamic co-processor jars As I understand code from org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost only one jar from the HDFS path is loaded. There is no provision to provide alternative HDFS paths to handle the RS which is not upgraded yet. For example if jars are upgraded in HDFS path, 1.x RS yet to be upgraded fails to load CP class (if restarted due to crash). Otherway if jars are not upgraded, 2.x RS fails. Please help me find if there is any mechanism to handle this problem. Regards, Kanaka -- Sent from: http://apache-hbase.679495.n3.nabble.com/HBase-Developer-f679493.html
[jira] [Resolved] (HBASE-23703) Add HBase 2.2.3 documentation to website
[ https://issues.apache.org/jira/browse/HBASE-23703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi resolved HBASE-23703. --- Fix Version/s: 3.0.0 Resolution: Fixed Pushed to master. > Add HBase 2.2.3 documentation to website > > > Key: HBASE-23703 > URL: https://issues.apache.org/jira/browse/HBASE-23703 > Project: HBase > Issue Type: Improvement > Components: documentation, website >Affects Versions: 2.2.3 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Major > Fix For: 3.0.0 > > > The website does not have documentation of HBase 2.2 release. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (HBASE-23653) Expose content of meta table in web ui
[ https://issues.apache.org/jira/browse/HBASE-23653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi reopened HBASE-23653: --- Reopen for error prone fix. > Expose content of meta table in web ui > -- > > Key: HBASE-23653 > URL: https://issues.apache.org/jira/browse/HBASE-23653 > Project: HBase > Issue Type: New Feature > Components: master, Operability, UI >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Minor > Fix For: 3.0.0, 2.3.0 > > Attachments: 23653.0.png, 23653.1.png > > > While testing improvements to hbck2, breaking and fixing a cluster's region > assignments, we've found that quite a few questions can only be answered by > dropping into a shell and scanning meta. This is in contrast to the nice web > view we have on procedures and their locks. It would be nice to have a > similar view into the content of meta. I've put together and extension to the > existing {{table.jsp}} that does this. It's had a couple rounds of operator > feedback. Will post up some screenshots along with the PR. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-13365) Fix errors from new errorProne version
[ https://issues.apache.org/jira/browse/HBASE-13365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi resolved HBASE-13365. --- Resolution: Cannot Reproduce There are no errorProne problems now. > Fix errors from new errorProne version > -- > > Key: HBASE-13365 > URL: https://issues.apache.org/jira/browse/HBASE-13365 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Elliott Neil Clark >Priority: Major > > HBASE-13364 updated the error prone version. With that came new errors that > break the build if using the errorProne profile. Lets fix those. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[VOTE] Move stable pointer to the latest 2.2.x release
We have discussed this several times in the past, this is the most recent one https://lists.apache.org/thread.html/f9ae2bf212d4d1c48eecf3d1d26edb0dd3d1d3bb8096bf6740839dbe%40%3Cdev.hbase.apache.org%3E And seems the consensus is to move the stable pointer to 2.2.x. So here I want to call a vote, to officially move the stable pointer to 2.2.3, and create a new stable-1 pointer to point to 1.4.11. The vote will last for at least 72 hours. Please vote [+1] Agree [-1] Disagree (please include actionable feedback) Thanks.
[jira] [Resolved] (HBASE-23698) Switch central repo to https on branch-1
[ https://issues.apache.org/jira/browse/HBASE-23698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi resolved HBASE-23698. --- Fix Version/s: 1.4.13 1.3.7 Resolution: Fixed > Switch central repo to https on branch-1 > > > Key: HBASE-23698 > URL: https://issues.apache.org/jira/browse/HBASE-23698 > Project: HBase > Issue Type: Bug > Components: tooling >Affects Versions: 1.6.0 >Reporter: Bharath Vissapragada >Assignee: Bharath Vissapragada >Priority: Blocker > Labels: broken-build > Fix For: 1.6.0, 1.3.7, 1.4.13 > > > Maven central started enforcing https [1] today and branch-1 builds are > failing presumably due to an older maven version. > Maven 3.2.3 [2] and later already switched the defaults, so not every one > might run into this problem, depending on what mvn they are using. Jenkins > jobs are hitting this, so they are likely using an older version. > [1] https://blog.sonatype.com/central-repository-moving-to-https > [2] https://issues.apache.org/jira/browse/MNG-5672 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (HBASE-23698) Switch central repo to https on branch-1
[ https://issues.apache.org/jira/browse/HBASE-23698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi reopened HBASE-23698: --- Reopening to backport to branch-1.4 and branch-1.3 > Switch central repo to https on branch-1 > > > Key: HBASE-23698 > URL: https://issues.apache.org/jira/browse/HBASE-23698 > Project: HBase > Issue Type: Bug > Components: tooling >Affects Versions: 1.6.0 >Reporter: Bharath Vissapragada >Assignee: Bharath Vissapragada >Priority: Blocker > Labels: broken-build > Fix For: 1.6.0 > > > Maven central started enforcing https [1] today and branch-1 builds are > failing presumably due to an older maven version. > Maven 3.2.3 [2] and later already switched the defaults, so not every one > might run into this problem, depending on what mvn they are using. Jenkins > jobs are hitting this, so they are likely using an older version. > [1] https://blog.sonatype.com/central-repository-moving-to-https > [2] https://issues.apache.org/jira/browse/MNG-5672 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23704) Use errorProne profile for pre commit verification
Peter Somogyi created HBASE-23704: - Summary: Use errorProne profile for pre commit verification Key: HBASE-23704 URL: https://issues.apache.org/jira/browse/HBASE-23704 Project: HBase Issue Type: Improvement Components: build Reporter: Peter Somogyi Assignee: Peter Somogyi Many times we ran into the problem that the pre-commit verification was successful but after the commit landed on the branch errorProne failed in the Nightly builds. We should already use errorProne profile during the pre-commit builds to prevent similar build failures. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (HBASE-23347) Pluggable RPC authentication
[ https://issues.apache.org/jira/browse/HBASE-23347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi reopened HBASE-23347: --- Reopening to fix errorprone issue. > Pluggable RPC authentication > > > Key: HBASE-23347 > URL: https://issues.apache.org/jira/browse/HBASE-23347 > Project: HBase > Issue Type: Improvement > Components: rpc, security >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > Fix For: 3.0.0, 2.3.0 > > > Today in HBase, we rely on SASL to implement Kerberos and delegation token > authentication. The RPC client and server logic is very tightly coupled to > our three authentication mechanism (the previously two mentioned plus simple > auth'n) for no good reason (other than "that's how it was built", best as I > can tell). > SASL's function is to decouple the "application" from how a request is being > authenticated, which means that, to support a variety of other authentication > approaches, we just need to be a little more flexible in letting developers > create their own authentication mechanism for HBase. > This is less for the "average joe" user to write their own authentication > plugin (eek), but more to allow us HBase developers to start iterating, see > what is possible. > I'll attach a full write-up on what I have today as to how I think we can add > these abstractions, as well as an initial implementation of this idea, with a > unit test that shows an end-to-end authentication solution against HBase. > cc/ [~wchevreuil] as he's been working with me behind the scenes, giving lots > of great feedback and support. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23703) Add HBase 2.2.3 documentation to website
Peter Somogyi created HBASE-23703: - Summary: Add HBase 2.2.3 documentation to website Key: HBASE-23703 URL: https://issues.apache.org/jira/browse/HBASE-23703 Project: HBase Issue Type: Improvement Components: documentation, website Affects Versions: 2.2.3 Reporter: Peter Somogyi Assignee: Peter Somogyi The website does not have documentation of HBase 2.2 release. -- This message was sent by Atlassian Jira (v8.3.4#803005)