[jira] [Resolved] (HBASE-25195) [branch-1] getNumOpenConnections is not effective

[Reid Chan (Jira)]

 [ 
https://issues.apache.org/jira/browse/HBASE-25195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-25195.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> [branch-1] getNumOpenConnections is not effective
> -
>
> Key: HBASE-25195
> URL: https://issues.apache.org/jira/browse/HBASE-25195
> Project: HBase
>  Issue Type: Improvement
>  Components: metrics
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
> Fix For: 1.7.0
>
>
> In MetricsHBaseServerWrapperImpl
> {code}
>   @Override
>   public int getNumOpenConnections() {
> if (!isServerStarted() || this.server.connectionList == null) {
>   return 0;
> }
> return server.connectionList.size();
>   }
> {code}
> But connectionList is created by Collections.synchronizedList(new 
> LinkedList());
> So each connectionList.size() will compete for the mutex, we can easily 
> replace it with another parameter *numConnections*, as for metrics, it is 
> enough.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (HBASE-25202) Compress the surefire report for flaky tests jenkins job

[Duo Zhang (Jira)]

Duo Zhang created HBASE-25202:
-

 Summary: Compress the surefire report for flaky tests jenkins job
 Key: HBASE-25202
 URL: https://issues.apache.org/jira/browse/HBASE-25202
 Project: HBase
  Issue Type: Sub-task
  Components: flakies, jenkins
Reporter: Duo Zhang


There is a TODO in it for compressing the report.

Let's address it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (HBASE-25093) the RSGroupBasedLoadBalancer#retainAssignment throws NPE

[niuyulin (Jira)]

 [ 
https://issues.apache.org/jira/browse/HBASE-25093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

niuyulin resolved HBASE-25093.
--
Resolution: Fixed

> the RSGroupBasedLoadBalancer#retainAssignment throws NPE
> 
>
> Key: HBASE-25093
> URL: https://issues.apache.org/jira/browse/HBASE-25093
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 3.0.0-alpha-1, 2.3.1, 2.2.3
>Reporter: Bo Cui
>Assignee: niuyulin
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.3, 2.4.0, 2.2.7
>
>
> when BaseLoadBalancer#
> https://github.com/apache/hbase/blob/8bfa2cb2eedcf050b26a28961e1b77dbf3cd8c95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java#L1433
> If the result of the BaseLoadBalancer#retainAssignment is null, the 
> RSGroupBasedLoadBalancer#retainAssignment will throw NPE.
> https://github.com/apache/hbase/blob/8bfa2cb2eedcf050b26a28961e1b77dbf3cd8c95/hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java#L206



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (HBASE-25201) YouAreDeadException should be moved to hbase-server module

[niuyulin (Jira)]

niuyulin created HBASE-25201:


 Summary: YouAreDeadException should be moved to hbase-server module
 Key: HBASE-25201
 URL: https://issues.apache.org/jira/browse/HBASE-25201
 Project: HBase
  Issue Type: Improvement
  Components: Client
Reporter: niuyulin
Assignee: niuyulin






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (HBASE-25200) Try enlarge the flaky test timeout for branch-2.2

[Guanghao Zhang (Jira)]

Guanghao Zhang created HBASE-25200:
--

 Summary: Try enlarge the flaky test timeout for branch-2.2
 Key: HBASE-25200
 URL: https://issues.apache.org/jira/browse/HBASE-25200
 Project: HBase
  Issue Type: Bug
Reporter: Guanghao Zhang


Now there are too many flaky tests to run. And the flaky test job cannot 
finished. Then these tests will be marked to flaky again.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (HBASE-25199) Remove HStore#getStoreHomedir

[Jan Hentschel (Jira)]

Jan Hentschel created HBASE-25199:
-

 Summary: Remove HStore#getStoreHomedir
 Key: HBASE-25199
 URL: https://issues.apache.org/jira/browse/HBASE-25199
 Project: HBase
  Issue Type: Sub-task
Affects Versions: 3.0.0-alpha-1
Reporter: Jan Hentschel
Assignee: Jan Hentschel
 Fix For: 3.0.0-alpha-1


The {{getStoreHomedir}} methods from {{HStore}} were deprecated way back and 
should get removed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (HBASE-25198) Remove RpcSchedulerFactory#create(Configuration, PriorityFunction)

[Jan Hentschel (Jira)]

Jan Hentschel created HBASE-25198:
-

 Summary: Remove RpcSchedulerFactory#create(Configuration, 
PriorityFunction)
 Key: HBASE-25198
 URL: https://issues.apache.org/jira/browse/HBASE-25198
 Project: HBase
  Issue Type: Sub-task
Affects Versions: 3.0.0-alpha-1
Reporter: Jan Hentschel
Assignee: Jan Hentschel
 Fix For: 3.0.0-alpha-1


The {{create(Configuration, PriorityFunction)}} method in 
{{RpcSchedulerFactory}} was deprecated a while ago. As it is not used anymore, 
even in implementing classes, we should be able to safely remove the method.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (HBASE-25197) Remove SingletonCoprocessorService

[Jan Hentschel (Jira)]

Jan Hentschel created HBASE-25197:
-

 Summary: Remove SingletonCoprocessorService
 Key: HBASE-25197
 URL: https://issues.apache.org/jira/browse/HBASE-25197
 Project: HBase
  Issue Type: Sub-task
Affects Versions: 3.0.0-alpha-1
Reporter: Jan Hentschel
Assignee: Jan Hentschel
 Fix For: 3.0.0-alpha-1


SingletonCoprocessorService is targeted for removal in 3.0.0. It seems that we 
don't depend on it anymore, so let's remove it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (HBASE-25196) Document deprecation of HConstants#REPLICATION_DROP_ON_DELETED_TABLE_KEY

[Jan Hentschel (Jira)]

Jan Hentschel created HBASE-25196:
-

 Summary: Document deprecation of 
HConstants#REPLICATION_DROP_ON_DELETED_TABLE_KEY
 Key: HBASE-25196
 URL: https://issues.apache.org/jira/browse/HBASE-25196
 Project: HBase
  Issue Type: Task
Affects Versions: 3.0.0-alpha-1
Reporter: Jan Hentschel
Assignee: Jan Hentschel
 Fix For: 3.0.0-alpha-1


HBASE-24359 deprecated HConstants#REPLICATION_DROP_ON_DELETED_TABLE_KEY. It 
should also be noted down in Javadoc when it was deprecated and when it is 
expected to be removed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: request for invitation to Slack channel

[Jan Hentschel]

Hi Semen,

Invite was sent. Please check your inbox.

Best, Jan

From: Семён Комиссаров 
Reply-To: "dev@hbase.apache.org" 
Date: Sunday, October 18, 2020 at 5:25 PM
To: "dev@hbase.apache.org" 
Subject: request for invitation to Slack channel

Hello, could you invite me to dev Slack channel please. I've made some
small contributions so far, thats my github profile:
https://github.com/semensanyok

request for invitation to Slack channel

[Семён Комиссаров]

Hello, could you invite me to dev Slack channel please. I've made some
small contributions so far, thats my github profile:
https://github.com/semensanyok

Re: [DISCUSS] the IA annotation on hbase client exceptions

[Duo Zhang]

I think IA.Public maybe over killed here for some exceptions.
For example, the DoNotRetryIOException, we just want users to catch this
exception, but usually we do not expect users to create this exeption by
their own?
But IA.Public means we can not change the public methods of the class, so
we can not even remove constructors of the exception?

Maybe special IA.LimitedPrivate(Exception)? Which means you are free to
catch and propagate the exception, but you should not create it by
yourselves? Or use the special methods of the exception?

Sean Busbey  于2020年10月18日周日 下午9:46写道：

> My guess would be IA.Public is needed if the client can take action based
> on the specific exception. So like the do not retry exception should be
> public so folks know those IOExceptions that it's not worth baking off and
> retrying.
>
> What's the specific list of public vs not? Why do you want the non public
> ones to be public? What limitations are we putting on clients by keeping
> them private?
>
> On Sun, Oct 18, 2020, 07:45 Yulin Niu  wrote:
>
> > Hi, guys:
> >
> > There are IA.Public and also IA.Private under the hbase-client
> exceptions
> > package, whether the IA.Private exceptions should be IA.Public?
> > e.g.MasterRegistryFetchException, OutOfOrderScannerNextException
> > ,RegionMovedException,RegionOpeningException
> > And any others thing about the IA annotation on exceptions?
> > FYI 2538 
> >
> > Thanks
> >
>

Re: [DISCUSS] the IA annotation on hbase client exceptions

[Sean Busbey]

My guess would be IA.Public is needed if the client can take action based
on the specific exception. So like the do not retry exception should be
public so folks know those IOExceptions that it's not worth baking off and
retrying.

What's the specific list of public vs not? Why do you want the non public
ones to be public? What limitations are we putting on clients by keeping
them private?

On Sun, Oct 18, 2020, 07:45 Yulin Niu  wrote:

> Hi, guys:
>
> There are IA.Public and also IA.Private under the hbase-client  exceptions
> package, whether the IA.Private exceptions should be IA.Public?
> e.g.MasterRegistryFetchException, OutOfOrderScannerNextException
> ,RegionMovedException,RegionOpeningException
> And any others thing about the IA annotation on exceptions?
> FYI 2538 
>
> Thanks
>

[DISCUSS] the IA annotation on hbase client exceptions

[Yulin Niu]

Hi, guys:

There are IA.Public and also IA.Private under the hbase-client  exceptions
package, whether the IA.Private exceptions should be IA.Public?
e.g.MasterRegistryFetchException, OutOfOrderScannerNextException
,RegionMovedException,RegionOpeningException
And any others thing about the IA annotation on exceptions?
FYI 2538 

Thanks

[jira] [Created] (HBASE-25195) [branch-1] getNumOpenConnections is not effective

[Reid Chan (Jira)]

Reid Chan created HBASE-25195:
-

 Summary: [branch-1] getNumOpenConnections is not effective
 Key: HBASE-25195
 URL: https://issues.apache.org/jira/browse/HBASE-25195
 Project: HBase
  Issue Type: Improvement
  Components: metrics
 Environment: In MetricsHBaseServerWrapperImpl
{code}
  @Override
  public int getNumOpenConnections() {
if (!isServerStarted() || this.server.connectionList == null) {
  return 0;
}
return server.connectionList.size();
  }
{code}
But connectionList is created by Collections.synchronizedList(new 
LinkedList());
So each connectionList.size() will compete for the mutex, we can easily replace 
it with another parameter *numConnections*, as for metrics, it is enough.
Reporter: Reid Chan
Assignee: Reid Chan
 Fix For: 1.7.0






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (HBASE-25194) Do not publish workspace in flaky find job

[Duo Zhang (Jira)]

Duo Zhang created HBASE-25194:
-

 Summary: Do not publish workspace in flaky find job
 Key: HBASE-25194
 URL: https://issues.apache.org/jira/browse/HBASE-25194
 Project: HBase
  Issue Type: Sub-task
  Components: jenkins
Reporter: Duo Zhang
Assignee: Duo Zhang






--
This message was sent by Atlassian Jira
(v8.3.4#803005)