[jira] [Resolved] (HBASE-28055) Performance improvement for scan over several stores.

2023-09-06 Thread Tak-Lon (Stephen) Wu (Jira) 


 [ 
https://issues.apache.org/jira/browse/HBASE-28055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tak-Lon (Stephen) Wu resolved HBASE-28055.
--
Resolution: Fixed

pushed to master/4.0.0-alpha-1, branch-3, branch-2, branch-2.5, branch-2.4, 
resolving it.

> Performance improvement for scan over several stores. 
> --
>
> Key: HBASE-28055
> URL: https://issues.apache.org/jira/browse/HBASE-28055
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 3.0.0-alpha-4, 2.5.5
>Reporter: Sergey Soldatov
>Assignee: Sergey Soldatov
>Priority: Major
> Fix For: 2.6.0, 2.4.18, 2.5.6, 3.0.0-beta-1, 4.0.0-alpha-1
>
>
> During the fix of HBASE-19863, an additional check for fake cells that 
> trigger reseek was added.  It comes that this check produces unnecessary 
> reseeks because
> matcher.compareKeyForNextColumn should be used only with indexed keys. Later  
> [~larsh] suggested doing a simple check for OLD_TIMESTAMP and it looks like a 
> better solution.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (HBASE-28066) Move TestShellRSGroups.java inside /src/test/java

2023-09-06 Thread Nihal Jain (Jira) 
Nihal Jain created HBASE-28066:
--

 Summary: Move TestShellRSGroups.java inside /src/test/java
 Key: HBASE-28066
 URL: https://issues.apache.org/jira/browse/HBASE-28066
 Project: HBase
  Issue Type: Test
Reporter: Nihal Jain
Assignee: Nihal Jain


Just noticed that {{TestShellRSGroups.java}} is at 
{{hbase-shell/src/test/rsgroup/org/apache/hadoop/hbase/client/rsgroup/TestShellRSGroups.java,}}
 but ideally it should be at 
{{hbase-shell/src/test/java/org/apache/hadoop/hbase/client/rsgroup/TestShellRSGroups.java}}
 instead.
Also because of same misplacement spotless skipped this file. Also need to run 
spotless for the same.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (HBASE-28065) Corrupt HFile data is mishandled in several cases

2023-09-06 Thread Nick Dimiduk (Jira) 
Nick Dimiduk created HBASE-28065:


 Summary: Corrupt HFile data is mishandled in several cases
 Key: HBASE-28065
 URL: https://issues.apache.org/jira/browse/HBASE-28065
 Project: HBase
  Issue Type: Bug
  Components: HFile
Affects Versions: 2.5.2
Reporter: Nick Dimiduk


While riding over a spat of HDFS data corruption issues, we've observed several 
places in the read path that do not fall back to HDFS checksum appropriately. 
These failures manifest during client reads and during compactions. Sometimes 
failure is detected by the fallback {{verifyOnDiskSizeMatchesHeader}}, 
sometimes we attempt to allocate a buffer with a negative size, and sometimes 
we read through to a failure from block decompression.

After code study, I think that all three cases arise from using a block header 
that was read without checksum validation.

Will post up the stack traces in the comments. Now sure if we'll want a single 
patch or multiple.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)