[jira] [Created] (HBASE-28190) Add slow sync log rolling test in TestAsyncLogRolling

2023-11-06 Thread zhuyaogai (Jira)
zhuyaogai created HBASE-28190:
-

 Summary: Add slow sync log rolling test in TestAsyncLogRolling
 Key: HBASE-28190
 URL: https://issues.apache.org/jira/browse/HBASE-28190
 Project: HBase
  Issue Type: Improvement
Reporter: zhuyaogai
Assignee: zhuyaogai


There is a test for slow sync log rolling in `TestLogRolling`, but not in 
`TestAsyncLogRolling`, so add it in `TestAsyncLogRolling`.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (HBASE-28189) Fix the miss count in one of CombinedBlockCache getBlock implementations

2023-11-06 Thread Wellington Chevreuil (Jira)
Wellington Chevreuil created HBASE-28189:


 Summary: Fix the miss count in one of CombinedBlockCache getBlock 
implementations
 Key: HBASE-28189
 URL: https://issues.apache.org/jira/browse/HBASE-28189
 Project: HBase
  Issue Type: Bug
Reporter: Wellington Chevreuil
Assignee: Wellington Chevreuil


In one of the 
CombinedBlockCache.getBlock(getBlock(cacheKey,cachingrepeat,updateCacheMetrics) 
we always compute a miss in L1 if the passed block is of type DATA. We should 
compute the miss in one of the caches only, not both.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (HBASE-28185) Alter table to set TTL using hbase shell failed when ttl string is not match format

2023-11-06 Thread Duo Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-28185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang resolved HBASE-28185.
---
Fix Version/s: 2.6.0
   2.4.18
   3.0.0-beta-1
   2.5.7
 Hadoop Flags: Reviewed
   Resolution: Fixed

Pushed to all active branches.

Thanks [~chaijunjie] for contributing!

> Alter table to set TTL using hbase shell failed when ttl string is not match 
> format
> ---
>
> Key: HBASE-28185
> URL: https://issues.apache.org/jira/browse/HBASE-28185
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 2.4.14
>Reporter: chaijunjie
>Assignee: chaijunjie
>Priority: Minor
> Fix For: 2.6.0, 2.4.18, 3.0.0-beta-1, 2.5.7
>
>
> create 'test','f1'
> alter 'test',\{NAME=>'f1',TTL=>'111x'}
>  
> {code:java}
> hbase:001:0> alter 'test',{NAME=>'f1',TTL=>'111x'}
> ERROR: org.apache.hadoop.hbase.DoNotRetryIOException: TTL for column family 
> f1 must be positive. Set hbase.table.sanity.checks to false at conf or table 
> descriptor if you want to bypass sanity checks
>     at 
> org.apache.hadoop.hbase.util.TableDescriptorChecker.warnOrThrowExceptionForFailure(TableDescriptorChecker.java:321)
>     at 
> org.apache.hadoop.hbase.util.TableDescriptorChecker.sanityCheck(TableDescriptorChecker.java:165)
>     at org.apache.hadoop.hbase.master.HMaster$14.run(HMaster.java:2666)
>     at 
> org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:132)
>     at org.apache.hadoop.hbase.master.HMaster.modifyTable(HMaster.java:2660)
>     at org.apache.hadoop.hbase.master.HMaster.modifyTable(HMaster.java:2698)
>     at 
> org.apache.hadoop.hbase.master.MasterRpcServices.modifyTable(MasterRpcServices.java:1554)
>     at 
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
>     at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:477)
>     at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123)
>     at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:369)
>     at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:349)For 
> usage try 'help "alter"'{code}
> it is misleading..
>  
> we need tell user wether theire command is wrong..
> some times we copy some string which may have some invisible characters, we 
> need let user to check it



--
This message was sent by Atlassian Jira
(v8.20.10#820010)