[jira] [Created] (HBASE-28275) Flaky test: Fix 'list decommissioned regionservers' in admin2_test.rb

2023-12-20 Thread Nihal Jain (Jira)
Nihal Jain created HBASE-28275:
--

 Summary: Flaky test: Fix 'list decommissioned regionservers' in 
admin2_test.rb
 Key: HBASE-28275
 URL: https://issues.apache.org/jira/browse/HBASE-28275
 Project: HBase
  Issue Type: Bug
Reporter: Nihal Jain
Assignee: Nihal Jain






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [VOTE] The first release candidate for 2.5.7 (RC0) is available

2023-12-20 Thread Andrew Purtell
Please file or promote an existing JIRA for this test issue (I seem to
recall some have been opened and closed over the previous months) so we can
track them. If you set a fix version of 2.5.8 it will be an effective
reminder.

On Wed, Dec 20, 2023 at 9:59 AM Andrew Purtell  wrote:

> This test is a known flake. It has been flaky from the time it was
> introduced. I cannot claim there is definitively no real issue here but I
> am certain the test should be rewritten.
>
> It is certainly no reason to stop this release.
>
> On Wed, Dec 20, 2023 at 5:45 AM 张铎(Duo Zhang) 
> wrote:
>
>> Run UTs locally, TestBasicWALEntryStreamAsyncFSWAL failed for me several
>> times.
>>
>> Checked flaky dashboard
>>
>>
>> https://nightlies.apache.org/hbase/HBase-Find-Flaky-Tests/branch-2.5/837/output/dashboard.html
>>
>> TestBasicWALEntryStreamAsyncFSWAL and TestBasicWALEntryStreamFSHLog
>> fails nearly 100% of times.
>>
>> I think we need to find out whether this is just a test issue, if not
>> we need to find out the root cause and fix it.
>>
>> Thanks.
>>
>> Andrew Purtell  于2023年12月19日周二 05:38写道:
>> >
>> > Please vote on this Apache HBase release candidate, 2.5.7RC0
>> >
>> > The VOTE will remain open for at least 72 hours.
>> >
>> > [ ] +1 Release this package as Apache HBase 2.5.7
>> > [ ] -1 Do not release this package because ...
>> >
>> > The tag to be voted on is 2.5.7RC0:
>> >
>> >   https://github.com/apache/hbase/tree/2.5.7RC0
>> >
>> > This tag currently points to git reference
>> >
>> >   6788f98356dd70b4a7ff766ea7a8298e022e7b95
>> >
>> > The release files, including signatures, digests, as well as CHANGES.md
>> > and RELEASENOTES.md included in this RC can be found at:
>> >
>> >   https://dist.apache.org/repos/dist/dev/hbase/2.5.7RC0/
>> >
>> > The API compatibility report comparing this RC to the previous release
>> > can be found at:
>> >
>> >
>> >
>> https://dist.apache.org/repos/dist/dev/hbase/2.5.7RC0/api_compare_2.5.6_to_2.5.7RC0.html
>> >
>> > As explained in the recent email to dev@ titled '[NOTICE] Recent
>> changes
>> > to ZooKeeper dependencies due to CVE issues has a compatibility impact',
>> > due to a recent upgrade of our ZooKeeper dependencies via HBASE-28153
>> > there has been an allowable and expected impact to the shaded jars we
>> > distribute for the convenience of our downstream users. Naturally
>> because
>> > the version of ZooKeeper shaded into these jars has changed, so has the
>> > compatibility of the included classes with earlier releases.
>> >
>> > There is also a source only compatibility impact to the Public annotated
>> > Admin API because of HBASE-25549, which has this release note:
>> >
>> >New APIs are added to Admin, AsyncAdmin, and hbase shell to allow
>> >modifying a table without reopening all regions...
>> >
>> > Maven artifacts are available in a staging repository at:
>> >
>> >
>> https://repository.apache.org/content/repositories/orgapachehbase-1529/
>> >
>> > Maven artifacts for hadoop3 are available in a staging repository at:
>> >
>> >
>> https://repository.apache.org/content/repositories/orgapachehbase-1530/
>> >
>> > Artifacts were signed with the 0xD5365CCD key which can be found in:
>> >
>> >   https://downloads.apache.org/hbase/KEYS
>> >
>> > To learn more about Apache HBase, please see
>> >
>> >   http://hbase.apache.org/
>> >
>> > Thanks,
>> > Your HBase Release Manager
>>
>
>
> --
> Best regards,
> Andrew
>
> Unrest, ignorance distilled, nihilistic imbeciles -
> It's what we’ve earned
> Welcome, apocalypse, what’s taken you so long?
> Bring us the fitting end that we’ve been counting on
>- A23, Welcome, Apocalypse
>


-- 
Best regards,
Andrew

Unrest, ignorance distilled, nihilistic imbeciles -
It's what we’ve earned
Welcome, apocalypse, what’s taken you so long?
Bring us the fitting end that we’ve been counting on
   - A23, Welcome, Apocalypse


Re: [VOTE] The first release candidate for 2.5.7 (RC0) is available

2023-12-20 Thread Andrew Purtell
Please file JIRAs for the test issues found so we can track them. If you
set a fix version of 2.5.8 it will be an effective reminder.

On Wed, Dec 20, 2023 at 5:48 AM Nick Dimiduk  wrote:

> +1
>
> * Signature: ok
> * Checksum : ok
> * Rat check (17.0.9): ok
>  - mvn clean apache-rat:check -D hadoop.profile=3.0
> * Built from source (17.0.9): ok
>  - mvn clean install -D hadoop.profile=3.0 -DskipTests
> * Unit tests pass (17.0.9): ok
>  - mvn clean package -P runSmallTests -D hadoop.profile=3.0
> -Dsurefire.rerunFailingTestsCount=3
>* nightlies are a little unstable (ok)
>  - o.a.h.h.regionserver.wal.TestLogRolling reliably times out ; ran
> several times locally and it reliably completes in ~330s
>  - TestTableShell/table_test.rb is hitting an intermittent
> off-by-one failure
>
>
>
> On Mon, Dec 18, 2023 at 10:38 PM Andrew Purtell 
> wrote:
>
> > Please vote on this Apache HBase release candidate, 2.5.7RC0
> >
> > The VOTE will remain open for at least 72 hours.
> >
> > [ ] +1 Release this package as Apache HBase 2.5.7
> > [ ] -1 Do not release this package because ...
> >
> > The tag to be voted on is 2.5.7RC0:
> >
> >   https://github.com/apache/hbase/tree/2.5.7RC0
> >
> > This tag currently points to git reference
> >
> >   6788f98356dd70b4a7ff766ea7a8298e022e7b95
> >
> > The release files, including signatures, digests, as well as CHANGES.md
> > and RELEASENOTES.md included in this RC can be found at:
> >
> >   https://dist.apache.org/repos/dist/dev/hbase/2.5.7RC0/
> >
> > The API compatibility report comparing this RC to the previous release
> > can be found at:
> >
> >
> >
> >
> https://dist.apache.org/repos/dist/dev/hbase/2.5.7RC0/api_compare_2.5.6_to_2.5.7RC0.html
> >
> > As explained in the recent email to dev@ titled '[NOTICE] Recent changes
> > to ZooKeeper dependencies due to CVE issues has a compatibility impact',
> > due to a recent upgrade of our ZooKeeper dependencies via HBASE-28153
> > there has been an allowable and expected impact to the shaded jars we
> > distribute for the convenience of our downstream users. Naturally because
> > the version of ZooKeeper shaded into these jars has changed, so has the
> > compatibility of the included classes with earlier releases.
> >
> > There is also a source only compatibility impact to the Public annotated
> > Admin API because of HBASE-25549, which has this release note:
> >
> >New APIs are added to Admin, AsyncAdmin, and hbase shell to allow
> >modifying a table without reopening all regions...
> >
> > Maven artifacts are available in a staging repository at:
> >
> >
> https://repository.apache.org/content/repositories/orgapachehbase-1529/
> >
> > Maven artifacts for hadoop3 are available in a staging repository at:
> >
> >
> https://repository.apache.org/content/repositories/orgapachehbase-1530/
> >
> > Artifacts were signed with the 0xD5365CCD key which can be found in:
> >
> >   https://downloads.apache.org/hbase/KEYS
> >
> > To learn more about Apache HBase, please see
> >
> >   http://hbase.apache.org/
> >
> > Thanks,
> > Your HBase Release Manager
> >
>


-- 
Best regards,
Andrew

Unrest, ignorance distilled, nihilistic imbeciles -
It's what we’ve earned
Welcome, apocalypse, what’s taken you so long?
Bring us the fitting end that we’ve been counting on
   - A23, Welcome, Apocalypse


Re: [VOTE] The first release candidate for 2.5.7 (RC0) is available

2023-12-20 Thread Andrew Purtell
This test is a known flake. It has been flaky from the time it was
introduced. I cannot claim there is definitively no real issue here but I
am certain the test should be rewritten.

It is certainly no reason to stop this release.

On Wed, Dec 20, 2023 at 5:45 AM 张铎(Duo Zhang)  wrote:

> Run UTs locally, TestBasicWALEntryStreamAsyncFSWAL failed for me several
> times.
>
> Checked flaky dashboard
>
>
> https://nightlies.apache.org/hbase/HBase-Find-Flaky-Tests/branch-2.5/837/output/dashboard.html
>
> TestBasicWALEntryStreamAsyncFSWAL and TestBasicWALEntryStreamFSHLog
> fails nearly 100% of times.
>
> I think we need to find out whether this is just a test issue, if not
> we need to find out the root cause and fix it.
>
> Thanks.
>
> Andrew Purtell  于2023年12月19日周二 05:38写道:
> >
> > Please vote on this Apache HBase release candidate, 2.5.7RC0
> >
> > The VOTE will remain open for at least 72 hours.
> >
> > [ ] +1 Release this package as Apache HBase 2.5.7
> > [ ] -1 Do not release this package because ...
> >
> > The tag to be voted on is 2.5.7RC0:
> >
> >   https://github.com/apache/hbase/tree/2.5.7RC0
> >
> > This tag currently points to git reference
> >
> >   6788f98356dd70b4a7ff766ea7a8298e022e7b95
> >
> > The release files, including signatures, digests, as well as CHANGES.md
> > and RELEASENOTES.md included in this RC can be found at:
> >
> >   https://dist.apache.org/repos/dist/dev/hbase/2.5.7RC0/
> >
> > The API compatibility report comparing this RC to the previous release
> > can be found at:
> >
> >
> >
> https://dist.apache.org/repos/dist/dev/hbase/2.5.7RC0/api_compare_2.5.6_to_2.5.7RC0.html
> >
> > As explained in the recent email to dev@ titled '[NOTICE] Recent changes
> > to ZooKeeper dependencies due to CVE issues has a compatibility impact',
> > due to a recent upgrade of our ZooKeeper dependencies via HBASE-28153
> > there has been an allowable and expected impact to the shaded jars we
> > distribute for the convenience of our downstream users. Naturally because
> > the version of ZooKeeper shaded into these jars has changed, so has the
> > compatibility of the included classes with earlier releases.
> >
> > There is also a source only compatibility impact to the Public annotated
> > Admin API because of HBASE-25549, which has this release note:
> >
> >New APIs are added to Admin, AsyncAdmin, and hbase shell to allow
> >modifying a table without reopening all regions...
> >
> > Maven artifacts are available in a staging repository at:
> >
> >
> https://repository.apache.org/content/repositories/orgapachehbase-1529/
> >
> > Maven artifacts for hadoop3 are available in a staging repository at:
> >
> >
> https://repository.apache.org/content/repositories/orgapachehbase-1530/
> >
> > Artifacts were signed with the 0xD5365CCD key which can be found in:
> >
> >   https://downloads.apache.org/hbase/KEYS
> >
> > To learn more about Apache HBase, please see
> >
> >   http://hbase.apache.org/
> >
> > Thanks,
> > Your HBase Release Manager
>


-- 
Best regards,
Andrew

Unrest, ignorance distilled, nihilistic imbeciles -
It's what we’ve earned
Welcome, apocalypse, what’s taken you so long?
Bring us the fitting end that we’ve been counting on
   - A23, Welcome, Apocalypse


[jira] [Created] (HBASE-28274) Flaky test: TestFanOutOneBlockAsyncDFSOutput (Part 2)

2023-12-20 Thread Andor Molnar (Jira)
Andor Molnar created HBASE-28274:


 Summary: Flaky test: TestFanOutOneBlockAsyncDFSOutput (Part 2)
 Key: HBASE-28274
 URL: https://issues.apache.org/jira/browse/HBASE-28274
 Project: HBase
  Issue Type: Test
  Components: flakies, integration tests, test
Reporter: Andor Molnar
Assignee: Andor Molnar


The following test sometimes fails for me when running locally with Maven:

TestFanOutOneBlockAsyncDFSOutput.testRecover()

I can't really figure out the reason, but it's probably a side effect of the 
preceding test: testConnectToDatanodeFailed(). This test also restarts one of 
the datanodes in the MiniDFS cluster just like testRecover() and it somehow 
causes the failure.
{noformat}
java.lang.AssertionError: flush should fail
at org.junit.Assert.fail(Assert.java:89)
at 
org.apache.hadoop.hbase.io.asyncfs.TestFanOutOneBlockAsyncDFSOutput.testRecover(TestFanOutOneBlockAsyncDFSOutput.java:154)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method){noformat}
The flush() call is testRecover() should fail, because we restart one of the DN 
in the DFS cluster which is expected to brake connection. It succeeds though if 
the preceding test already restarted a DN. No matter which DN we restart, even 
if they're different, the error occurs.

I also tried to add CLUSTER.waitDatanodeFullyStarted() at the end of 
testConnectToDatanodeFailed(), looks like it made the tests slightly more 
stable, but didn't help fully.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [VOTE] The first release candidate for 2.5.7 (RC0) is available

2023-12-20 Thread Nick Dimiduk
+1

* Signature: ok
* Checksum : ok
* Rat check (17.0.9): ok
 - mvn clean apache-rat:check -D hadoop.profile=3.0
* Built from source (17.0.9): ok
 - mvn clean install -D hadoop.profile=3.0 -DskipTests
* Unit tests pass (17.0.9): ok
 - mvn clean package -P runSmallTests -D hadoop.profile=3.0
-Dsurefire.rerunFailingTestsCount=3
   * nightlies are a little unstable (ok)
 - o.a.h.h.regionserver.wal.TestLogRolling reliably times out ; ran
several times locally and it reliably completes in ~330s
 - TestTableShell/table_test.rb is hitting an intermittent
off-by-one failure



On Mon, Dec 18, 2023 at 10:38 PM Andrew Purtell  wrote:

> Please vote on this Apache HBase release candidate, 2.5.7RC0
>
> The VOTE will remain open for at least 72 hours.
>
> [ ] +1 Release this package as Apache HBase 2.5.7
> [ ] -1 Do not release this package because ...
>
> The tag to be voted on is 2.5.7RC0:
>
>   https://github.com/apache/hbase/tree/2.5.7RC0
>
> This tag currently points to git reference
>
>   6788f98356dd70b4a7ff766ea7a8298e022e7b95
>
> The release files, including signatures, digests, as well as CHANGES.md
> and RELEASENOTES.md included in this RC can be found at:
>
>   https://dist.apache.org/repos/dist/dev/hbase/2.5.7RC0/
>
> The API compatibility report comparing this RC to the previous release
> can be found at:
>
>
>
> https://dist.apache.org/repos/dist/dev/hbase/2.5.7RC0/api_compare_2.5.6_to_2.5.7RC0.html
>
> As explained in the recent email to dev@ titled '[NOTICE] Recent changes
> to ZooKeeper dependencies due to CVE issues has a compatibility impact',
> due to a recent upgrade of our ZooKeeper dependencies via HBASE-28153
> there has been an allowable and expected impact to the shaded jars we
> distribute for the convenience of our downstream users. Naturally because
> the version of ZooKeeper shaded into these jars has changed, so has the
> compatibility of the included classes with earlier releases.
>
> There is also a source only compatibility impact to the Public annotated
> Admin API because of HBASE-25549, which has this release note:
>
>New APIs are added to Admin, AsyncAdmin, and hbase shell to allow
>modifying a table without reopening all regions...
>
> Maven artifacts are available in a staging repository at:
>
>   https://repository.apache.org/content/repositories/orgapachehbase-1529/
>
> Maven artifacts for hadoop3 are available in a staging repository at:
>
>   https://repository.apache.org/content/repositories/orgapachehbase-1530/
>
> Artifacts were signed with the 0xD5365CCD key which can be found in:
>
>   https://downloads.apache.org/hbase/KEYS
>
> To learn more about Apache HBase, please see
>
>   http://hbase.apache.org/
>
> Thanks,
> Your HBase Release Manager
>


Re: [VOTE] The first release candidate for 2.5.7 (RC0) is available

2023-12-20 Thread Duo Zhang
Run UTs locally, TestBasicWALEntryStreamAsyncFSWAL failed for me several times.

Checked flaky dashboard

https://nightlies.apache.org/hbase/HBase-Find-Flaky-Tests/branch-2.5/837/output/dashboard.html

TestBasicWALEntryStreamAsyncFSWAL and TestBasicWALEntryStreamFSHLog
fails nearly 100% of times.

I think we need to find out whether this is just a test issue, if not
we need to find out the root cause and fix it.

Thanks.

Andrew Purtell  于2023年12月19日周二 05:38写道:
>
> Please vote on this Apache HBase release candidate, 2.5.7RC0
>
> The VOTE will remain open for at least 72 hours.
>
> [ ] +1 Release this package as Apache HBase 2.5.7
> [ ] -1 Do not release this package because ...
>
> The tag to be voted on is 2.5.7RC0:
>
>   https://github.com/apache/hbase/tree/2.5.7RC0
>
> This tag currently points to git reference
>
>   6788f98356dd70b4a7ff766ea7a8298e022e7b95
>
> The release files, including signatures, digests, as well as CHANGES.md
> and RELEASENOTES.md included in this RC can be found at:
>
>   https://dist.apache.org/repos/dist/dev/hbase/2.5.7RC0/
>
> The API compatibility report comparing this RC to the previous release
> can be found at:
>
>
> https://dist.apache.org/repos/dist/dev/hbase/2.5.7RC0/api_compare_2.5.6_to_2.5.7RC0.html
>
> As explained in the recent email to dev@ titled '[NOTICE] Recent changes
> to ZooKeeper dependencies due to CVE issues has a compatibility impact',
> due to a recent upgrade of our ZooKeeper dependencies via HBASE-28153
> there has been an allowable and expected impact to the shaded jars we
> distribute for the convenience of our downstream users. Naturally because
> the version of ZooKeeper shaded into these jars has changed, so has the
> compatibility of the included classes with earlier releases.
>
> There is also a source only compatibility impact to the Public annotated
> Admin API because of HBASE-25549, which has this release note:
>
>New APIs are added to Admin, AsyncAdmin, and hbase shell to allow
>modifying a table without reopening all regions...
>
> Maven artifacts are available in a staging repository at:
>
>   https://repository.apache.org/content/repositories/orgapachehbase-1529/
>
> Maven artifacts for hadoop3 are available in a staging repository at:
>
>   https://repository.apache.org/content/repositories/orgapachehbase-1530/
>
> Artifacts were signed with the 0xD5365CCD key which can be found in:
>
>   https://downloads.apache.org/hbase/KEYS
>
> To learn more about Apache HBase, please see
>
>   http://hbase.apache.org/
>
> Thanks,
> Your HBase Release Manager


[jira] [Resolved] (HBASE-28270) Remove the xml-maven-plugin in root pom on branch-3

2023-12-20 Thread Duo Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-28270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang resolved HBASE-28270.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

Merged to branch-3.

Thanks [~nihaljain.cs] for reviewing!

> Remove the xml-maven-plugin in root pom on branch-3
> ---
>
> Key: HBASE-28270
> URL: https://issues.apache.org/jira/browse/HBASE-28270
> Project: HBase
>  Issue Type: Bug
>  Components: build, pom
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Blocker
> Fix For: 3.0.0-beta-1
>
>
> We only generate ref guide on master branch, so we have already deleted 
> related resources on other branches.
> But on branch-3, we still have xml=maven-plugin for including 
> hbase-default.xml in ref guide so it will fail the build.
> Let's remove this plugin.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)