Re: [VOTE] The first release candidate for hbase 2.4.18 is available

2024-05-23 Thread Tak Lon (Stephen) Wu
   +1 (binding)

* verified CHANGES.md
* Signature: ok
* Checksum : ok
* Rat check (1.8.0_412): ok
 - mvn clean apache-rat:check
* Built from source (1.8.0_412): ok
 - mvn clean install  -DskipTests
* Unit tests pass (1.8.0_412): failed
 - mvn clean package -P runAllTests
 -Dsurefire.rerunFailingTestsCount=3

TestBasicWALEntryStreamAsyncFSWAL failed but it passed when I ran it
separately.

-Stephen

On Wed, May 22, 2024 at 11:35 AM Andrew Purtell  wrote:

> +1 (binding)
>
> * Signature: ok
> * Checksum : ok
> * Rat check (1.8.0_382): ok
>  - mvn clean apache-rat:check
> * Built from source (1.8.0_382): ok
>  - mvn clean install  -DskipTests
> * Unit tests pass (1.8.0_382): failed
>  - mvn clean package -P runAllTests
>  -Dsurefire.rerunFailingTestsCount=3
>
> The test failure is TestBasicWALEntryStreamFSHLog, which is known to be
> flaky in versions < 2.6.
>
> On Tue, May 21, 2024 at 8:10 AM Duo Zhang  wrote:
>
> > Please vote on this Apache hbase release candidate,
> > hbase-2.4.18RC0
> >
> > The VOTE will remain open for at least 72 hours.
> >
> > [ ] +1 Release this package as Apache hbase 2.4.18
> > [ ] -1 Do not release this package because ...
> >
> > The tag to be voted on is 2.4.18RC0:
> >
> >   https://github.com/apache/hbase/tree/2.4.18RC0
> >
> > This tag currently points to git reference
> >
> >   a1767f4d76859c0068720a6c1e5cb78282ebfe1e
> >
> > The release files, including signatures, digests, as well as CHANGES.md
> > and RELEASENOTES.md included in this RC can be found at:
> >
> >   https://dist.apache.org/repos/dist/dev/hbase/2.4.18RC0/
> >
> > Maven artifacts are available in a staging repository at:
> >
> >
> https://repository.apache.org/content/repositories/orgapachehbase-1545/
> >
> > Artifacts were signed with the 0x9AD2AE49 key which can be found in:
> >
> >   https://downloads.apache.org/hbase/KEYS
> >
> > 2.4.18 will be the last patch release for the 2.4.x release line.
> > Users on this release line are encouraged to upgrade to our current
> > stable release line 2.5.x if you want more official support time, or
> > try our newest minor release line 2.6.x if you want to try the new
> > features like TLS.
> >
> > To learn more about Apache hbase, please see
> >
> >   http://hbase.apache.org/
> >
> > Thanks,
> > Your HBase Release Manager
> >
>
>
> --
> Best regards,
> Andrew
>
> Unrest, ignorance distilled, nihilistic imbeciles -
> It's what we’ve earned
> Welcome, apocalypse, what’s taken you so long?
> Bring us the fitting end that we’ve been counting on
>- A23, Welcome, Apocalypse
>


[jira] [Created] (HBASE-28614) Introduce a field to display whether the snapshot is expired

2024-05-23 Thread guluo (Jira)
guluo created HBASE-28614:
-

 Summary: Introduce a field to display whether the snapshot is 
expired
 Key: HBASE-28614
 URL: https://issues.apache.org/jira/browse/HBASE-28614
 Project: HBase
  Issue Type: Improvement
  Components: shell, snapshots, UI
 Environment: hbase master
Reporter: guluo


HBase supports to create snapshot with TTL, and expired snapshots will be 
periodically deleted.

This period is 30 min by default, as follow.
{code:java}
private static final String SNAPSHOT_CLEANER_INTERVAL = 
"hbase.master.cleaner.snapshot.interval";
private static final int SNAPSHOT_CLEANER_DEFAULT_INTERVAL = 1800 * 1000; // 
Default 30 min {code}
 

Therefore, the following situation may occur: 
The expired snapshot would still exist for a period of time on hbase cluster, 
and would not be deleted until the next operation of the periodic thread.
So, Sometimes, we may use the expired snapshot because we donot know whether 
the snapshot is expired.

 

So, I think we can introduce a expired field for this situation in HBase UI.
And on hbase shell ,adding snapshot TTL info and displaying expired if the 
snaphost has already expired.

Or any better suggestions? Thanks a lot!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (HBASE-28605) Add ErrorProne ban on Hadoop shaded thirdparty jars

2024-05-23 Thread Nick Dimiduk (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-28605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Dimiduk resolved HBASE-28605.
--
Fix Version/s: 2.7.0
   3.0.0-beta-2
   2.6.1
   2.5.9
   Resolution: Fixed

Pushed to branch-2.5+. Thanks for the quick reviews.

> Add ErrorProne ban on Hadoop shaded thirdparty jars
> ---
>
> Key: HBASE-28605
> URL: https://issues.apache.org/jira/browse/HBASE-28605
> Project: HBase
>  Issue Type: Task
>  Components: build
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.7.0, 3.0.0-beta-2, 2.6.1, 2.5.9
>
>
> Over on HBASE-28568 we got tripped up because we pulled in the shaded Guava 
> provided by Hadoop. This wasn't noticed until the backport to branch-2, which 
> builds against hadoop-2. We should make this a compile time failure.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (HBASE-28613) Use streaming when marshalling protobuf REST output

2024-05-23 Thread Istvan Toth (Jira)
Istvan Toth created HBASE-28613:
---

 Summary: Use streaming when marshalling protobuf REST output
 Key: HBASE-28613
 URL: https://issues.apache.org/jira/browse/HBASE-28613
 Project: HBase
  Issue Type: Improvement
  Components: REST
Reporter: Istvan Toth
Assignee: Istvan Toth


We are currently marshalling protobuf into a byte array, and then send that to 
the client.
This is both slow and memory intensive.

Using streaming instead results in huge perf improvements. In my bechnmark, 
both the wall clock time was almost halved, while the REST server CPU usage was 
reduced by 40%.

wall clock: 120s ->65s
Total REST CPU: 300s -> 180s




--
This message was sent by Atlassian Jira
(v8.20.10#820010)