[jira] [Resolved] (HBASE-27625) Bump commons-lang3 to 3.12.0, surefire to 3.0.0 and dependency manage reload4j to 1.2.25 to support jdk11

2023-08-03 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-27625.
---
Fix Version/s: hbase-connectors-1.0.1
 Hadoop Flags: Reviewed
   Resolution: Fixed

> Bump commons-lang3 to 3.12.0, surefire to 3.0.0 and dependency manage 
> reload4j to 1.2.25 to support jdk11
> -
>
> Key: HBASE-27625
> URL: https://issues.apache.org/jira/browse/HBASE-27625
> Project: HBase
>  Issue Type: Improvement
>  Components: hbase-connectors, spark
>Affects Versions: connector-1.0.0
>Reporter: Istvan Toth
>Assignee: Subrat Mishra
>Priority: Major
> Fix For: hbase-connectors-1.0.1
>
>
> When trying to run the tests with Java 11, I get:
> {noformat}
> [ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.733 
> s <<< FAILURE! - in org.apache.hadoop.hbase.spark.TestJavaHBaseContext
> [ERROR] org.apache.hadoop.hbase.spark.TestJavaHBaseContext  Time elapsed: 
> 0.721 s  <<< ERROR!
> java.lang.ExceptionInInitializerError
>     at 
> org.apache.hadoop.hbase.spark.TestJavaHBaseContext.setUpBeforeClass(TestJavaHBaseContext.java:86)
> Caused by: java.lang.NullPointerException
>     at 
> org.apache.hadoop.hbase.spark.TestJavaHBaseContext.setUpBeforeClass(TestJavaHBaseContext.java:86)[ERROR]
>  org.apache.hadoop.hbase.spark.TestJavaHBaseContext  Time elapsed: 0.721 s  
> <<< ERROR!
> java.lang.NullPointerException
>     at 
> org.apache.hadoop.hbase.spark.TestJavaHBaseContext.tearDownAfterClass(TestJavaHBaseContext.java:106)
> {noformat}
> The same test runs fine with Java 8.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (HBASE-26863) Rowkey pushdown does not work with complex conditions

2023-08-03 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-26863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-26863.
---
Fix Version/s: hbase-connectors-1.0.1
 Hadoop Flags: Reviewed
   Resolution: Fixed

> Rowkey pushdown does not work with complex conditions
> -
>
> Key: HBASE-26863
> URL: https://issues.apache.org/jira/browse/HBASE-26863
> Project: HBase
>  Issue Type: Bug
>  Components: hbase-connectors
>Affects Versions: connector-1.0.0
>Reporter: Yohei Kishimoto
>Priority: Major
> Fix For: hbase-connectors-1.0.1
>
>
> When using pushdown column filter feature of hbase-spark-connector, issuing 
> complex query containing rowkey conditions does not get expected rowkey 
> pushdown.
> {code:java}
> {
>   "table":{"namespace":"default", "name":"t1"},
>   "rowkey":"key",
>   "columns":{
> "KEY_FIELD":{"cf":"rowkey", "col":"key", "type":"string"},
> "A_FIELD":{"cf":"c", "col":"a", "type":"string"},
> "B_FIELD":{"cf":"c", "col":"b", "type":"string"}
>   }
> }
> {code}
> For example, given the catalog, a query `spark.sql("SELECT * FROM table WHERE 
> KEY_FIELD >= 'get1' AND KEY_FIELD <= 'get3' AND A_FIELD IS NOT NULL")` gets 
> incomplete rowkey pushdown 
> (ScanRange:(upperBound:get3,isUpperBoundEqualTo:true,lowerBound:,isLowerBoundEqualTo:true)).
> If a query is `spark.sql("SELECT * FROM table WHERE KEY_FIELD >= 'get1' AND 
> KEY_FIELD <= 'get3'")`, we get normal rowkey pushdown 
> (ScanRange:(upperBound:get3,isUpperBoundEqualTo:true,lowerBound:,isLowerBoundEqualTo:true)).
> I found that ScanRange#getOverlapScanRange and ScanRange#mergeIntersect 
> return incorrect results if the range from the arguments is wider than the 
> instance (or  scanRange.getOverlapScanRange(scanRange) where 
> scanRange1⊂scanRange2). Depending on the order of the Filters that the Spark 
> optimization results produce, the order of the scan ranges that these methods 
> receive could be the one that causes such a problem.
> I will create a PR later.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (HBASE-27488) [hbase-connectors] Duplicate result when searching HBase by Spark

2023-08-02 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-27488.
---
Fix Version/s: hbase-connectors-1.0.1
 Hadoop Flags: Reviewed
   Resolution: Fixed

> [hbase-connectors] Duplicate result when searching HBase by Spark
> -
>
> Key: HBASE-27488
> URL: https://issues.apache.org/jira/browse/HBASE-27488
> Project: HBase
>  Issue Type: Bug
>  Components: hbase-connectors
>Reporter: ZheHu
>Assignee: ZheHu
>Priority: Major
> Fix For: hbase-connectors-1.0.1
>
>
> I've used hbase-connector for querying HBase table by Spark, and the 
> following issue is what I've encountered recently:
> When I run SQL:
> {code:java}
> select * from hbase_tabe where rowkey in ('r1', 'r2') or rowkey='r1'
> {code}
> I've got duplicate row "r1" in results.
> In HBaseTableScanRdd, buildGets method forms two duplicate GET request for 
> rowkey "r1". I think we might need a Set to make sure duplicate rowkey won't 
> be request.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (HBASE-27656) Make sure the close method of the SmartSonnection is called

2023-08-02 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-27656.
---
Fix Version/s: hbase-connectors-1.0.1
 Hadoop Flags: Reviewed
   Resolution: Fixed

> Make sure the close method of the  SmartSonnection is called
> 
>
> Key: HBASE-27656
> URL: https://issues.apache.org/jira/browse/HBASE-27656
> Project: HBase
>  Issue Type: Bug
>  Components: spark
>Reporter: Zhen Wang
>Priority: Major
> Fix For: hbase-connectors-1.0.1
>
>
> The close method of SmartSonnection may not be called when an exception 
> occurs in the hbaseForeachPartition or hbaseMapPartition methods of 
> HBaseContext. We should use try-finally to ensure that the close method is 
> called.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (HBASE-27176) [hbase-connectors] Fail to build hbase-connectors because of checkstyle error

2023-08-02 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-27176.
---
Fix Version/s: hbase-connectors-1.0.1
 Hadoop Flags: Reviewed
   Resolution: Fixed

> [hbase-connectors] Fail to build hbase-connectors because of checkstyle error
> -
>
> Key: HBASE-27176
> URL: https://issues.apache.org/jira/browse/HBASE-27176
> Project: HBase
>  Issue Type: Bug
>  Components: build, hbase-connectors
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: hbase-connectors-1.0.1
>
>
> We set failOnViolation to true but in pre commit, we will use 
> "-Dcheckstyle.skip=true" when running mvninstall so we can not find the 
> problem in pre commit, but when we run 'mvn install' locally, the build will 
> fail.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (HBASE-27705) Respect SparkContext hadoop configuration

2023-08-02 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-27705.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> Respect SparkContext hadoop configuration
> -
>
> Key: HBASE-27705
> URL: https://issues.apache.org/jira/browse/HBASE-27705
> Project: HBase
>  Issue Type: Improvement
>  Components: spark
> Environment: spark: 3.1.1
> hbase-connector: 1.0.1-SNAPSHOT
>Reporter: Zhen Wang
>Priority: Major
> Fix For: hbase-connectors-1.0.1
>
>
> In our environment, the hbase clusters are independent of spark computing 
> cluster, I want to set hbase configuration through `spark.hadoop.hbase.XXX`, 
> so I hope hbase-spark can respect `sparkContext.hadoopConfiguration`.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (HBASE-27557) [JDK17] Update shade plugin version

2023-01-19 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-27557.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> [JDK17] Update shade plugin version
> ---
>
> Key: HBASE-27557
> URL: https://issues.apache.org/jira/browse/HBASE-27557
> Project: HBase
>  Issue Type: Sub-task
>Reporter: tianhang tang
>Assignee: tianhang tang
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.4.16, 2.5.3
>
> Attachments: image-2023-01-06-18-54-09-703.png
>
>
> maven-shade-plugin:3.2.4 cannot support JDK17, if build HBase with 
> releaseTarget=17 will meet this error:
> !image-2023-01-06-18-54-09-703.png!
> So need to update it's version.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (HBASE-26435) [branch-1] The log rolling request maybe canceled immediately in LogRoller due to a race

2022-03-03 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-26435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-26435.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> [branch-1] The log rolling request maybe canceled immediately in LogRoller 
> due to a race 
> -
>
> Key: HBASE-26435
> URL: https://issues.apache.org/jira/browse/HBASE-26435
> Project: HBase
>  Issue Type: Sub-task
>  Components: wal
>Affects Versions: 1.6.0
>Reporter: Rushabh Shah
>Assignee: Rushabh Shah
>Priority: Major
> Fix For: 1.7.2
>
>
> Saw this issue in our internal 1.6 branch.
> All the writes to this RS were getting failing since the underlying hdfs file 
> was corrupt. This healed after 1 hour (equivalent to 
> hbase.regionserver.logroll.period conf key). 
> The WAL  was rolled but the new WAL file was not writable and it logged the 
> following error also. 
> {noformat}
> 2021-11-03 19:20:19,503 WARN  [.168:60020.logRoller] hdfs.DFSClient - Error 
> while syncing
> java.io.IOException: Could not get block locations. Source file 
> "/hbase/WALs/,60020,1635567166484/%2C60020%2C1635567166484.1635967219389"
>  - Aborting...
> at 
> org.apache.hadoop.hdfs.DataStreamer.setupPipelineForAppendOrRecovery(DataStreamer.java:1466)
> at 
> org.apache.hadoop.hdfs.DataStreamer.processDatanodeError(DataStreamer.java:1251)
> at org.apache.hadoop.hdfs.DataStreamer.run(DataStreamer.java:670)
> 2021-11-03 19:20:19,507 WARN  [.168:60020.logRoller] wal.FSHLog - pre-sync 
> failed but an optimization so keep going
> java.io.IOException: Could not get block locations. Source file 
> "/hbase/WALs/,60020,1635567166484/%2C60020%2C1635567166484.1635967219389"
>  - Aborting...
> at 
> org.apache.hadoop.hdfs.DataStreamer.setupPipelineForAppendOrRecovery(DataStreamer.java:1466)
> at 
> org.apache.hadoop.hdfs.DataStreamer.processDatanodeError(DataStreamer.java:1251)
> at org.apache.hadoop.hdfs.DataStreamer.run(DataStreamer.java:670)
> {noformat}
> Since the new WAL file was not writable, appends to that file started failing 
> immediately it was rolled.
> {noformat}
> 2021-11-03 19:20:19,677 INFO  [.168:60020.logRoller] wal.FSHLog - Rolled WAL 
> /hbase/WALs/,60020,1635567166484/%2C60020%2C1635567166484.1635965392022
>  with entries=253234, filesize=425.67 MB; new WAL 
> /hbase/WALs/,60020,1635567166484/%2C60020%2C1635567166484.1635967219389
> 2021-11-03 19:20:19,690 WARN  [020.append-pool17-t1] wal.FSHLog - Append 
> sequenceId=1962661783, requesting roll of WAL
> java.io.IOException: Could not get block locations. Source file 
> "/hbase/WALs/,60020,1635567166484/%2C60020%2C1635567166484.1635967219389"
>  - Aborting...
> at 
> org.apache.hadoop.hdfs.DataStreamer.setupPipelineForAppendOrRecovery(DataStreamer.java:1466)
> at 
> org.apache.hadoop.hdfs.DataStreamer.processDatanodeError(DataStreamer.java:1251)
> at org.apache.hadoop.hdfs.DataStreamer.run(DataStreamer.java:670)
> 2021-11-03 19:20:19,690 INFO  [.168:60020.logRoller] wal.FSHLog - Archiving 
> hdfs://prod-EMPTY-hbase2a/hbase/WALs/,60020,1635567166484/%2C60020%2C1635567166484.1635960792837
>  to 
> hdfs://prod-EMPTY-hbase2a/hbase/oldWALs/hbase2a-dnds1-232-ukb.ops.sfdc.net%2C60020%2C1635567166484.1635960792837
> {noformat}
> We always reset the rollLog flag within LogRoller thread after the rollWal 
> call is complete.
> Within FSHLog#rollWriter method, it does many things, like replacing the 
> writer and archiving old logs. If append thread fails to write to new file 
> while logRoller thread is cleaning old logs, we will miss the rollLog flag 
> since LogRoller will reset the flag to false while the previous rollWriter 
> call is going on.
> Relevant code: 
> https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/LogRoller.java#L183-L203
> We need to reset rollLog flag before we start rolling the wal. 
> This is fixed in branch-2 and master via HBASE-22684 but we didn't fix it in 
> branch-1
> Also branch-2 has multi wal implementation so it can apply cleanly in 
> branch-1.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Resolved] (HBASE-26678) Backport HBASE-26579 to branch-1

2022-01-17 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-26678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-26678.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> Backport HBASE-26579 to branch-1
> 
>
> Key: HBASE-26678
> URL: https://issues.apache.org/jira/browse/HBASE-26678
> Project: HBase
>  Issue Type: Task
>Reporter: Yutong Xiao
>Assignee: Yutong Xiao
>Priority: Major
> Fix For: 1.7.2
>
>
> Our branch-1 cluster also met the storage policy problem in usage. Backport 
> the path to branch-1.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Resolved] (HBASE-26551) Add FastPath feature to HBase RWQueueRpcExecutor

2022-01-17 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-26551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-26551.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> Add FastPath feature to HBase RWQueueRpcExecutor
> 
>
> Key: HBASE-26551
> URL: https://issues.apache.org/jira/browse/HBASE-26551
> Project: HBase
>  Issue Type: Task
>  Components: rpc, Scheduler
>Reporter: Yutong Xiao
>Assignee: Yutong Xiao
>Priority: Major
> Fix For: 2.5.0, 1.7.2, 2.6.0, 3.0.0-alpha-3
>
> Attachments: QueueTimeComparison.png, QueueTimeComparisonWithMax.png
>
>
> In ticket [HBASE-17808|https://issues.apache.org/jira/browse/HBASE-17808], 
> the author introduced a fastpath implementation for RWQueueRpcExecutor. It 
> aggregated 3 different independent RpcExecutor to implement the mechanism. 
> This redundancy costed more memory and from its own performance test, it 
> cannot outperform the original implementation. This time, I directly extended 
> RWQueueRpcExecutor to implement the fast path mechanism. From my test result, 
> it has a better queue time performance than before.
> YCSB Test:
> Constant Configurations:
> hbase.regionserver.handler.count: 1000
> hbase.ipc.server.callqueue.read.ratio: 0.5
> hbase.ipc.server.callqueue.handler.factor: 0.2
> Test Workload:
> YCSB: 50% Write, 25% Get, 25% Scan. Max Scan length: 1000.
> Client Threads: 100
> ||FastPathRWQueueRpcExecutor||RWQueueRpcExecutor||
> |[OVERALL], RunTime(ms), 909365
> [OVERALL], Throughput(ops/sec), 5498.3422498116815
> [TOTAL_GCS_PS_Scavenge], Count, 1208
> [TOTAL_GC_TIME_PS_Scavenge], Time(ms), 8006
> [TOTAL_GC_TIME_%_PS_Scavenge], Time(%), 0.8803945610398465
> [TOTAL_GCS_PS_MarkSweep], Count, 2
> [TOTAL_GC_TIME_PS_MarkSweep], Time(ms), 96
> [TOTAL_GC_TIME_%_PS_MarkSweep], Time(%), 0.010556817119638429
> [TOTAL_GCs], Count, 1210
> [TOTAL_GC_TIME], Time(ms), 8102
> [TOTAL_GC_TIME_%], Time(%), 0.8909513781594849
> [READ], Operations, 1248885
> [READ], AverageLatency(us), 14080.154160711354
> [READ], MinLatency(us), 269
> [READ], MaxLatency(us), 180735
> [READ], 95thPercentileLatency(us), 29775
> [READ], 99thPercentileLatency(us), 39391
> [READ], Return=OK, 1248885
> [CLEANUP], Operations, 200
> [CLEANUP], AverageLatency(us), 311.78
> [CLEANUP], MinLatency(us), 1
> [CLEANUP], MaxLatency(us), 59647
> [CLEANUP], 95thPercentileLatency(us), 26
> [CLEANUP], 99thPercentileLatency(us), 173
> [INSERT], Operations, 1251067
> [INSERT], AverageLatency(us), 14235.898240461942
> [INSERT], MinLatency(us), 393
> [INSERT], MaxLatency(us), 204159
> [INSERT], 95thPercentileLatency(us), 29919
> [INSERT], 99thPercentileLatency(us), 39647
> [INSERT], Return=OK, 1251067
> [UPDATE], Operations, 1249582
> [UPDATE], AverageLatency(us), 14166.923049467741
> [UPDATE], MinLatency(us), 321
> [UPDATE], MaxLatency(us), 203647
> [UPDATE], 95thPercentileLatency(us), 29855
> [UPDATE], 99thPercentileLatency(us), 39551
> [UPDATE], Return=OK, 1249582
> [SCAN], Operations, 1250466
> [SCAN], AverageLatency(us), 30056.68854251135
> [SCAN], MinLatency(us), 787
> [SCAN], MaxLatency(us), 509183
> [SCAN], 95thPercentileLatency(us), 57823
> [SCAN], 99thPercentileLatency(us), 74751
> [SCAN], Return=OK, 1250466|[OVERALL], RunTime(ms), 958763
> [OVERALL], Throughput(ops/sec), 5215.053146606617
> [TOTAL_GCS_PS_Scavenge], Count, 1264
> [TOTAL_GC_TIME_PS_Scavenge], Time(ms), 8680
> [TOTAL_GC_TIME_%_PS_Scavenge], Time(%), 0.9053332262509086
> [TOTAL_GCS_PS_MarkSweep], Count, 1
> [TOTAL_GC_TIME_PS_MarkSweep], Time(ms), 38
> [TOTAL_GC_TIME_%_PS_MarkSweep], Time(%), 0.00396344039142103
> [TOTAL_GCs], Count, 1265
> [TOTAL_GC_TIME], Time(ms), 8718
> [TOTAL_GC_TIME_%], Time(%), 0.909296423298
> [READ], Operations, 1250961
> [READ], AverageLatency(us), 14663.084518222391
> [READ], MinLatency(us), 320
> [READ], MaxLatency(us), 204415
> [READ], 95thPercentileLatency(us), 30815
> [READ], 99thPercentileLatency(us), 43071
> [READ], Return=OK, 1250961
> [CLEANUP], Operations, 200
> [CLEANUP], AverageLatency(us), 366.845
> [CLEANUP], MinLatency(us), 1
> [CLEANUP], MaxLatency(us), 70719
> [CLEANUP], 95thPercentileLatency(us), 36
> [CLEANUP], 99thPercentileLatency(us), 80
> [INSERT], Operations, 1248183
> [INSERT], AverageLatency(us), 14334.938754974231
> [INSERT], MinLatency(us), 390
> [INSERT], MaxLatency(us), 2828287
> [INSERT], 95thPercentileLatency(us), 30271
> [INSERT], 99thPercentileLatency(us), 41919
> [INSERT], Return=OK, 1248183
> [UPDATE], Operations, 1250212
> [UPDATE], AverageLatency(us), 14283.836318960304
> [UPDATE], MinLatency(us), 337
> [UPDATE], MaxLatency(us), 2828287
> [UPDATE], 95thPercentileLatency(us), 30255
> [UPDATE], 99thPercentileLatency(us), 41855
> [UPDATE], Return=OK, 1250212
> [SCAN], Operations, 1250644
> [SCAN], AverageLatency(us), 

[jira] [Resolved] (HBASE-26325) Backport HBASE-26305 to branch-1

2021-11-22 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-26325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-26325.
---
Fix Version/s: 1.7.2
 Hadoop Flags: Reviewed
   Resolution: Fixed

> Backport HBASE-26305 to branch-1
> 
>
> Key: HBASE-26325
> URL: https://issues.apache.org/jira/browse/HBASE-26325
> Project: HBase
>  Issue Type: Improvement
>Reporter: Yutong Xiao
>Assignee: Yutong Xiao
>Priority: Minor
> Fix For: 1.7.2
>
>
> Backport the HBASE-26305 to branch-1. Move NavigableSet add operation to 
> writer thread in BucketCache



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Resolved] (HBASE-26094) In branch-1 L2 BC should not be the victimhandler of L1 BC when using combined BC

2021-07-22 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-26094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-26094.
---
Fix Version/s: 1.7.2
 Hadoop Flags: Reviewed
   Resolution: Fixed

> In branch-1 L2 BC should not be the victimhandler of L1 BC when using 
> combined BC
> -
>
> Key: HBASE-26094
> URL: https://issues.apache.org/jira/browse/HBASE-26094
> Project: HBase
>  Issue Type: Bug
>  Components: BlockCache
>Affects Versions: 1.7.0
>Reporter: Yutong Xiao
>Assignee: Yutong Xiao
>Priority: Major
> Fix For: 1.7.2
>
>
> Currently in branch-1, the block cache initialisation is:
> {code:java}
>   LruBlockCache l1 = getL1(conf);
> // blockCacheDisabled is set as a side-effect of getL1Internal(), so 
> check it again after the call.
> if (blockCacheDisabled) return null;
> BlockCache l2 = getL2(conf);
> if (l2 == null) {
>   GLOBAL_BLOCK_CACHE_INSTANCE = l1;
> } else {
>   boolean useExternal = conf.getBoolean(EXTERNAL_BLOCKCACHE_KEY, 
> EXTERNAL_BLOCKCACHE_DEFAULT);
>   boolean combinedWithLru = conf.getBoolean(BUCKET_CACHE_COMBINED_KEY,
> DEFAULT_BUCKET_CACHE_COMBINED);
>   if (useExternal) {
> GLOBAL_BLOCK_CACHE_INSTANCE = new InclusiveCombinedBlockCache(l1, l2);
>   } else {
> if (combinedWithLru) {
>   GLOBAL_BLOCK_CACHE_INSTANCE = new CombinedBlockCache(l1, l2);
> } else {
>   // L1 and L2 are not 'combined'.  They are connected via the 
> LruBlockCache victimhandler
>   // mechanism.  It is a little ugly but works according to the 
> following: when the
>   // background eviction thread runs, blocks evicted from L1 will go 
> to L2 AND when we get
>   // a block from the L1 cache, if not in L1, we will search L2.
>   GLOBAL_BLOCK_CACHE_INSTANCE = l1;
> }
>   }
>   l1.setVictimCache(l2);
> }
> {code}
> As the code above, L2 will always be the victimhandler of L1, no matter if we 
> use combined blockcache or not. But as logic (in master & branch-2) L2 should 
> not be the victimhandler of L1 when using combined BC. We should set the 
> victimhandler only when we use InclusiveConbinedBC or we do not use 
> CombinedBC.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-26083) L1 miss metric is incorrect when using CombinedBlockCache

2021-07-15 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-26083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-26083.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> L1 miss metric is incorrect when using CombinedBlockCache
> -
>
> Key: HBASE-26083
> URL: https://issues.apache.org/jira/browse/HBASE-26083
> Project: HBase
>  Issue Type: Bug
>  Components: BlockCache
>Reporter: Yutong Xiao
>Assignee: Yutong Xiao
>Priority: Minor
> Fix For: 2.3.6, 3.0.0-alpha-2, 2.4.5, 1.7.2
>
>
> In CombinedBlockCache getBlock method
> {code:java}
> public Cacheable getBlock(BlockCacheKey cacheKey, boolean caching,
>   boolean repeat, boolean updateCacheMetrics) {
> // TODO: is there a hole here, or just awkwardness since in the lruCache 
> getBlock
> // we end up calling l2Cache.getBlock.
> // We are not in a position to exactly look at LRU cache or BC as 
> BlockType may not be getting
> // passed always.
> return l1Cache.containsBlock(cacheKey)?
> l1Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics):
> l2Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics);
>   }
> {code}
> If L1 does not contains cacheKey, it will never check it in L1, so that L1 
> miss metrics is always 0.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-26033) Complement admin operations in Thrift2 after HBASE-21674

2021-07-04 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-26033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-26033.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> Complement admin operations in Thrift2 after HBASE-21674
> 
>
> Key: HBASE-26033
> URL: https://issues.apache.org/jira/browse/HBASE-26033
> Project: HBase
>  Issue Type: Task
>Reporter: Yutong Xiao
>Assignee: Yutong Xiao
>Priority: Major
>  Labels: thrift
> Fix For: 1.7.1
>
>
> Thrift2 Admin operations were not finished in HBASE-21674. Finished them this 
> time.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-26025) Add a flag to mark if the IOError can be solved by retry in thrift IOError

2021-06-27 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-26025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-26025.
---
Hadoop Flags: Reviewed
  Resolution: Resolved

> Add a flag to mark if the IOError can be solved by retry in thrift IOError
> --
>
> Key: HBASE-26025
> URL: https://issues.apache.org/jira/browse/HBASE-26025
> Project: HBase
>  Issue Type: Improvement
>  Components: Thrift
>Reporter: Yutong Xiao
>Assignee: Yutong Xiao
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.3.6, 1.7.1, 2.4.5
>
>
> Currently, if an HBaseIOException occurs, the thrift client can only get the 
> error message. This is inconvenient for the client constructing a retry 
> mechanism to handle the exception. So I added a canRetry mark in IOError to 
> make the client side exception handling smarter.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-26013) Get operations readRows metrics becomes zero after HBASE-25677

2021-06-24 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-26013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-26013.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> Get operations readRows metrics becomes zero after HBASE-25677
> --
>
> Key: HBASE-26013
> URL: https://issues.apache.org/jira/browse/HBASE-26013
> Project: HBase
>  Issue Type: Bug
>  Components: metrics
>Reporter: Yutong Xiao
>Assignee: Yutong Xiao
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.3.6, 1.7.1, 2.4.5
>
>
> After HBASE-25677, Server+table counters on each scan are extracted from 
> #nextRaw to rsServices scan. In this case, the get operation will not count 
> the read rows. So that the readRows metrics becomes zero. Should add counter 
> in metricsUpdateForGet.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-21674) Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-06-21 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-21674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-21674.
---
Hadoop Flags: Reviewed
  Resolution: Resolved

> Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from 
> thrift1 server) to branch-1
> 
>
> Key: HBASE-21674
> URL: https://issues.apache.org/jira/browse/HBASE-21674
> Project: HBase
>  Issue Type: Sub-task
>  Components: Thrift
>Reporter: Andrew Kyle Purtell
>Assignee: Yutong Xiao
>Priority: Major
> Fix For: 1.7.1
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-26001) When turn on access control, the cell level TTL of Increment and Append operations is invalid.

2021-06-21 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-26001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-26001.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> When turn on access control, the cell level TTL of Increment and Append 
> operations is invalid.
> --
>
> Key: HBASE-26001
> URL: https://issues.apache.org/jira/browse/HBASE-26001
> Project: HBase
>  Issue Type: Bug
>  Components: Coprocessors
>Reporter: Yutong Xiao
>Assignee: Yutong Xiao
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.6.7, 2.5.0, 2.3.6, 2.4.5
>
>
> AccessController postIncrementBeforeWAL() and postAppendBeforeWAL() methods 
> will rewrite the new cell's tags by the old cell's. This will makes the other 
> kinds of tag in new cell invisible (such as TTL tag) after this. As in 
> Increment and Append operations, the new cell has already catch forward all 
> tags of the old cell and TTL tag from mutation operation, here in 
> AccessController we do not need to rewrite the tags once again. Also, the TTL 
> tag of newCell will be invisible in the new created cell. Actually, in 
> Increment and Append operations, the newCell has already copied all tags of 
> the oldCell. So the oldCell is useless here.
> {code:java}
> private Cell createNewCellWithTags(Mutation mutation, Cell oldCell, Cell 
> newCell) {
> // Collect any ACLs from the old cell
> List tags = Lists.newArrayList();
> List aclTags = Lists.newArrayList();
> ListMultimap perms = ArrayListMultimap.create();
> if (oldCell != null) {
>   Iterator tagIterator = PrivateCellUtil.tagsIterator(oldCell);
>   while (tagIterator.hasNext()) {
> Tag tag = tagIterator.next();
> if (tag.getType() != PermissionStorage.ACL_TAG_TYPE) {
>   // Not an ACL tag, just carry it through
>   if (LOG.isTraceEnabled()) {
> LOG.trace("Carrying forward tag from " + oldCell + ": type " + 
> tag.getType()
> + " length " + tag.getValueLength());
>   }
>   tags.add(tag);
> } else {
>   aclTags.add(tag);
> }
>   }
> }
> // Do we have an ACL on the operation?
> byte[] aclBytes = mutation.getACL();
> if (aclBytes != null) {
>   // Yes, use it
>   tags.add(new ArrayBackedTag(PermissionStorage.ACL_TAG_TYPE, aclBytes));
> } else {
>   // No, use what we carried forward
>   if (perms != null) {
> // TODO: If we collected ACLs from more than one tag we may have a
> // List of size > 1, this can be collapsed into a single
> // Permission
> if (LOG.isTraceEnabled()) {
>   LOG.trace("Carrying forward ACLs from " + oldCell + ": " + perms);
> }
> tags.addAll(aclTags);
>   }
> }
> // If we have no tags to add, just return
> if (tags.isEmpty()) {
>   return newCell;
> }
> // Here the new cell's tags will be in visible.
> return PrivateCellUtil.createCell(newCell, tags);
>   }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-26004) Port HBASE-26001 (cell level tags invisible in atomic operations when access control is on) to branch-1

2021-06-21 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-26004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-26004.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> Port HBASE-26001 (cell level tags invisible in atomic operations when access 
> control is on) to branch-1
> ---
>
> Key: HBASE-26004
> URL: https://issues.apache.org/jira/browse/HBASE-26004
> Project: HBase
>  Issue Type: Bug
>Reporter: Yutong Xiao
>Assignee: Yutong Xiao
>Priority: Minor
> Fix For: 1.7.1
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-25999) Add 1.7.0 to download page

2021-06-12 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-25999.
---
Fix Version/s: 1.7.0
 Hadoop Flags: Reviewed
   Resolution: Resolved

> Add 1.7.0 to download page
> --
>
> Key: HBASE-25999
> URL: https://issues.apache.org/jira/browse/HBASE-25999
> Project: HBase
>  Issue Type: Task
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 1.7.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25999) Add 1.7.0 to download page

2021-06-12 Thread Reid Chan (Jira)
Reid Chan created HBASE-25999:
-

 Summary: Add 1.7.0 to download page
 Key: HBASE-25999
 URL: https://issues.apache.org/jira/browse/HBASE-25999
 Project: HBase
  Issue Type: Task
Reporter: Reid Chan
Assignee: Reid Chan






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-25890) [branch-1] add -U for maven build to force a check for updated releases and snapshots on remote repositories

2021-05-25 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-25890.
---
Resolution: Fixed

> [branch-1] add -U for maven build to force a check for updated releases and 
> snapshots on remote repositories
> 
>
> Key: HBASE-25890
> URL: https://issues.apache.org/jira/browse/HBASE-25890
> Project: HBase
>  Issue Type: Task
>  Components: build
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Blocker
> Fix For: 1.7.0
>
>
> {code}
> [ERROR] Failed to execute goal on project hbase-assembly: Could not resolve 
> dependencies for project org.apache.hbase:hbase-assembly:pom:1.7.0: Could not 
> find artifact org.apache.hbase:hbase-thrift:jar:1.7.0 in apache release 
> (https://repository.apache.org/content/repositories/releases/) -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
> [ERROR] 
> [ERROR] After correcting the problems, you can resume the build with the 
> command
> [ERROR]   mvn  -rf :hbase-assembly
> {code}
> {code}
> [ERROR] Failed to execute goal on project hbase-assembly: Could not resolve 
> dependencies for project org.apache.hbase:hbase-assembly:pom:1.7.0: Failure 
> to find org.apache.hbase:hbase-thrift:jar:1.7.0 in 
> https://repository.apache.org/content/repositories/releases/ was cached in 
> the local repository, resolution will not be reattempted until the update 
> interval of apache release has elapsed or updates are forced -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
> [ERROR] 
> [ERROR] After correcting the problems, you can resume the build with the 
> command
> [ERROR]   mvn  -rf :hbase-assembly
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-25887) Corrupt wal while region server is aborting.

2021-05-25 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-25887.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> Corrupt wal while region server is aborting.
> 
>
> Key: HBASE-25887
> URL: https://issues.apache.org/jira/browse/HBASE-25887
> Project: HBase
>  Issue Type: Improvement
>  Components: regionserver, wal
>Affects Versions: 1.6.0
>Reporter: Rushabh Shah
>Assignee: Rushabh Shah
>Priority: Major
> Fix For: 1.7.0
>
>
> We have seen a case in our production cluster where we ended up in corrupt 
> wal. WALSplitter logged the below error
> {noformat}
> 2021-05-12 00:42:46,786 FATAL [:60020-1] regionserver.HRegionServer - 
> ABORTING region server HOST-B,60020,16207794418
> 88: Caught throwable while processing event RS_LOG_REPLAY
> java.lang.NullPointerException
> at org.apache.hadoop.hbase.CellUtil.matchingFamily(CellUtil.java:411)
> at 
> org.apache.hadoop.hbase.regionserver.wal.WALEdit.isMetaEditFamily(WALEdit.java:145)
> at 
> org.apache.hadoop.hbase.regionserver.wal.WALEdit.isMetaEdit(WALEdit.java:150)
> at 
> org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:408)
> at 
> org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:261)
> at 
> org.apache.hadoop.hbase.regionserver.SplitLogWorker$1.exec(SplitLogWorker.java:105)
> at 
> org.apache.hadoop.hbase.regionserver.handler.WALSplitterHandler.process(WALSplitterHandler.java:72)
> at 
> org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:129)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
> Looking at the raw wal file, we could see that the last WALEdit contains the 
> region id, tablename and sequence number but cells were not persisted.
>  Looking at the logs of the RS that generated that corrupt wal file,
> {noformat}
> 2021-05-11 23:29:22,114 DEBUG [/HOST-A:60020] wal.FSHLog - Closing WAL writer 
> in /hbase/WALs/HOST-A,60020,1620774393046
> 2021-05-11 23:29:22,196 DEBUG [/HOST-A:60020] ipc.AbstractRpcClient - 
> Stopping rpc client
> 2021-05-11 23:29:22,198 INFO  [/HOST-A:60020] regionserver.Leases - 
> regionserver/HOST-A/:60020 closing leases
> 2021-05-11 23:29:22,198 INFO  [/HOST-A:60020] regionserver.Leases - 
> regionserver/HOST-A:/HOST-A:60020 closed leases
> 2021-05-11 23:29:22,198 WARN  [0020.append-pool8-t1] wal.FSHLog - Append 
> sequenceId=7147823, requesting roll of WAL
> java.nio.channels.ClosedChannelException
> at 
> org.apache.hadoop.hdfs.DataStreamer$LastExceptionInStreamer.throwException4Close(DataStreamer.java:331)
> at 
> org.apache.hadoop.hdfs.DFSOutputStream.checkClosed(DFSOutputStream.java:151)
> at org.apache.hadoop.fs.FSOutputSummer.write(FSOutputSummer.java:105)
> at 
> org.apache.hadoop.fs.FSDataOutputStream$PositionCache.write(FSDataOutputStream.java:58)
> at java.io.DataOutputStream.write(DataOutputStream.java:107)
> at org.apache.hadoop.hbase.KeyValue.write(KeyValue.java:2543)
> at 
> org.apache.phoenix.hbase.index.wal.KeyValueCodec.write(KeyValueCodec.java:104)
> at 
> org.apache.hadoop.hbase.regionserver.wal.IndexedWALEditCodec$IndexKeyValueEncoder.write(IndexedWALEditCodec.java:218)
> at 
> org.apache.hadoop.hbase.regionserver.wal.ProtobufLogWriter.append(ProtobufLogWriter.java:128)
> at 
> org.apache.hadoop.hbase.regionserver.wal.FSHLog$RingBufferEventHandler.append(FSHLog.java:2083)
> at 
> org.apache.hadoop.hbase.regionserver.wal.FSHLog$RingBufferEventHandler.onEvent(FSHLog.java:1941)
> at 
> org.apache.hadoop.hbase.regionserver.wal.FSHLog$RingBufferEventHandler.onEvent(FSHLog.java:1857)
> at 
> com.lmax.disruptor.BatchEventProcessor.run(BatchEventProcessor.java:129)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
> These 2 lines are interesting.
> {quote}2021-05-11 23:29:22,114 DEBUG [/HOST-A:60020] wal.FSHLog - Closing WAL 
> writer in /hbase/WALs/HOST-A,60020,1620774393046
>  
>  
>  2021-05-11 23:29:22,198 WARN [0020.append-pool8-t1] wal.FSHLog - Append 
> sequenceId=7147823, requesting roll of WAL
>  java.nio.channels.ClosedChannelException
> {quote}
> The append thread encountered java.nio.channels.ClosedChannelException while 
> writing to wal file because the wal file was already 

[jira] [Created] (HBASE-25890) [branch-1] add -U for maven build to force a check for updated releases and snapshots on remote repositories

2021-05-14 Thread Reid Chan (Jira)
Reid Chan created HBASE-25890:
-

 Summary: [branch-1] add -U for maven build to force a check for 
updated releases and snapshots on remote repositories
 Key: HBASE-25890
 URL: https://issues.apache.org/jira/browse/HBASE-25890
 Project: HBase
  Issue Type: Task
Reporter: Reid Chan
Assignee: Reid Chan


{code}
[ERROR] Failed to execute goal on project hbase-assembly: Could not resolve 
dependencies for project org.apache.hbase:hbase-assembly:pom:1.7.0: Could not 
find artifact org.apache.hbase:hbase-thrift:jar:1.7.0 in apache release 
(https://repository.apache.org/content/repositories/releases/) -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn  -rf :hbase-assembly
{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-25804) [branch-1] Make hbase-thrift module build with jdk8

2021-05-11 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-25804.
---
Resolution: Fixed

> [branch-1] Make hbase-thrift module build with jdk8
> ---
>
> Key: HBASE-25804
> URL: https://issues.apache.org/jira/browse/HBASE-25804
> Project: HBase
>  Issue Type: Task
>  Components: build
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Blocker
> Fix For: 1.7.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25879) [branch-1] Update CHANGES.txt and the 1.7.0RC0 the most recent commit

2021-05-11 Thread Reid Chan (Jira)
Reid Chan created HBASE-25879:
-

 Summary: [branch-1] Update CHANGES.txt and the 1.7.0RC0 the most 
recent commit
 Key: HBASE-25879
 URL: https://issues.apache.org/jira/browse/HBASE-25879
 Project: HBase
  Issue Type: Task
Reporter: Reid Chan
Assignee: Reid Chan






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-25856) sorry for my mistake, could someone delete it.

2021-05-06 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-25856.
---
Resolution: Invalid

> sorry for my mistake, could someone delete it.
> --
>
> Key: HBASE-25856
> URL: https://issues.apache.org/jira/browse/HBASE-25856
> Project: HBase
>  Issue Type: Improvement
>Reporter: junwen yang
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (HBASE-25856) sorry for my mistake, could someone delete it.

2021-05-06 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan reopened HBASE-25856:
---

> sorry for my mistake, could someone delete it.
> --
>
> Key: HBASE-25856
> URL: https://issues.apache.org/jira/browse/HBASE-25856
> Project: HBase
>  Issue Type: Improvement
>Reporter: junwen yang
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25858) [branch-1] hbase-assembly module includes hbase-thrift only when using jdk8

2021-05-06 Thread Reid Chan (Jira)
Reid Chan created HBASE-25858:
-

 Summary: [branch-1] hbase-assembly module includes hbase-thrift 
only when using jdk8
 Key: HBASE-25858
 URL: https://issues.apache.org/jira/browse/HBASE-25858
 Project: HBase
  Issue Type: Task
Reporter: Reid Chan
Assignee: Reid Chan






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-25831) [branch-1] remove thrift examples out of hbase-examples module for bypassing the thrift version check

2021-05-06 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-25831.
---
Fix Version/s: 1.7.0
 Hadoop Flags: Reviewed
   Resolution: Fixed

> [branch-1] remove thrift examples out of hbase-examples module for bypassing 
> the thrift version check
> -
>
> Key: HBASE-25831
> URL: https://issues.apache.org/jira/browse/HBASE-25831
> Project: HBase
>  Issue Type: Task
>  Components: Thrift
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Blocker
> Fix For: 1.7.0
>
>
> [ERROR] Failed to execute goal on project hbase-examples: Could not resolve 
> dependencies for project org.apache.hbase:hbase-examples:jar:1.7.0: Could not 
> find artifact org.apache.hbase:hbase-thrift:jar:1.7.0 in apache release 
> (https://repository.apache.org/content/repositories/releases/) -> [Help 1]
> This is the msg when I tried to run make_rc.sh, we need to remove thrift 
> related codes from hbase-examples for making release successfully.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-25846) Backport 'HBASE-25825 RSGroupBasedLoadBalancer.onConfigurationChange should chain the request to internal balancer' to branch-1

2021-05-05 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-25846.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> Backport 'HBASE-25825 RSGroupBasedLoadBalancer.onConfigurationChange should 
> chain the request to internal balancer' to branch-1
> ---
>
> Key: HBASE-25846
> URL: https://issues.apache.org/jira/browse/HBASE-25846
> Project: HBase
>  Issue Type: Improvement
>Reporter: Caroline Zhou
>Assignee: Caroline Zhou
>Priority: Minor
> Fix For: 1.7.0
>
>
> In branch-1, 
> [RSGroupBasedLoadBalancer#onConfigurationChange|https://github.com/apache/hbase/blob/branch-1/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java#L452]
>  doesn't do anything – it should call the internal balancer's 
> onConfigurationChange().



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-25845) [branch-1] Precommit fails to build docker due to python-dateutil

2021-05-04 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-25845.
---
Fix Version/s: 1.7.0
   Resolution: Fixed

> [branch-1] Precommit fails to build docker due to python-dateutil
> -
>
> Key: HBASE-25845
> URL: https://issues.apache.org/jira/browse/HBASE-25845
> Project: HBase
>  Issue Type: Task
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 1.7.0
>
>
> 02:34:22  Downloading/unpacking python-dateutil
> 02:34:22Cannot fetch index base URL https://pypi.python.org/simple/
> 02:34:22Could not find any downloads that satisfy the requirement 
> python-dateutil
> 02:34:22  Cleaning up...
> 02:34:22  No distributions at all found for python-dateutil
> 02:34:22  Storing debug log for failure in /root/.pip/pip.log
> 02:34:22  The command '/bin/sh -c pip install python-dateutil' returned a 
> non-zero code: 1
> 02:34:22  ERROR: Docker failed to build yetus/hbase:edccfe439a.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25845) [branch-1] Precommit fails to build docker due to python-dateutil

2021-05-03 Thread Reid Chan (Jira)
Reid Chan created HBASE-25845:
-

 Summary: [branch-1] Precommit fails to build docker due to 
python-dateutil
 Key: HBASE-25845
 URL: https://issues.apache.org/jira/browse/HBASE-25845
 Project: HBase
  Issue Type: Task
Reporter: Reid Chan
Assignee: Reid Chan


02:34:22  Downloading/unpacking python-dateutil
02:34:22Cannot fetch index base URL https://pypi.python.org/simple/
02:34:22Could not find any downloads that satisfy the requirement 
python-dateutil
02:34:22  Cleaning up...
02:34:22  No distributions at all found for python-dateutil
02:34:22  Storing debug log for failure in /root/.pip/pip.log
02:34:22  The command '/bin/sh -c pip install python-dateutil' returned a 
non-zero code: 1
02:34:22  ERROR: Docker failed to build yetus/hbase:edccfe439a.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25831) [branch-1] remove thrift examples out of hbaes-examples module for bypassing the thrift version check

2021-04-30 Thread Reid Chan (Jira)
Reid Chan created HBASE-25831:
-

 Summary: [branch-1] remove thrift examples out of hbaes-examples 
module for bypassing the thrift version check
 Key: HBASE-25831
 URL: https://issues.apache.org/jira/browse/HBASE-25831
 Project: HBase
  Issue Type: Task
  Components: Thrift
Reporter: Reid Chan
Assignee: Reid Chan






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25804) [branch-1] Make hbase-thrift module build with jdk8

2021-04-22 Thread Reid Chan (Jira)
Reid Chan created HBASE-25804:
-

 Summary: [branch-1] Make hbase-thrift module build with jdk8
 Key: HBASE-25804
 URL: https://issues.apache.org/jira/browse/HBASE-25804
 Project: HBase
  Issue Type: Task
  Components: build
Reporter: Reid Chan
Assignee: Reid Chan
 Fix For: 1.7.0






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-25748) [Flake Test][branch-1] TestAdmin2

2021-04-13 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-25748.
---
Resolution: Fixed

> [Flake Test][branch-1] TestAdmin2
> -
>
> Key: HBASE-25748
> URL: https://issues.apache.org/jira/browse/HBASE-25748
> Project: HBase
>  Issue Type: Test
>  Components: test
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 1.7.0
>
>
> Attempt to improve the stability.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (HBASE-25748) [Flake Test][branch-1] TestAdmin2

2021-04-12 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan reopened HBASE-25748:
---

Spotted a bug in testCreateTableRPCTimeOut, let me try to fix it.

> [Flake Test][branch-1] TestAdmin2
> -
>
> Key: HBASE-25748
> URL: https://issues.apache.org/jira/browse/HBASE-25748
> Project: HBase
>  Issue Type: Test
>  Components: test
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 1.7.0
>
>
> Attempt to improve the stability.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-25753) [Flake Test][branch-1] TestSnapshotCloneIndependence's teardown() is always timeout

2021-04-09 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-25753.
---
Resolution: Fixed

> [Flake Test][branch-1] TestSnapshotCloneIndependence's teardown() is always 
> timeout
> ---
>
> Key: HBASE-25753
> URL: https://issues.apache.org/jira/browse/HBASE-25753
> Project: HBase
>  Issue Type: Test
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 1.7.0
>
>
> The tearDown method after each test is always timeout.
> So the fix is to
> 1. make the tearDown method without After annotation and make it private
> 2. move it under each test
> 3. Increase timeout to 3 for each test, as for it is MediumTests.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25753) [Flake Test][branch-1] TestSnapshotCloneIndependence's teardown() is always timeout

2021-04-08 Thread Reid Chan (Jira)
Reid Chan created HBASE-25753:
-

 Summary: [Flake Test][branch-1] TestSnapshotCloneIndependence's 
teardown() is always timeout
 Key: HBASE-25753
 URL: https://issues.apache.org/jira/browse/HBASE-25753
 Project: HBase
  Issue Type: Test
Reporter: Reid Chan
Assignee: Reid Chan
 Fix For: 1.7.0


The tearDown method after each test is always timeout.

So the fix is to
1. make the tearDown method without After annotation and make it private
2. move it under each test
3. Increase timeout to 3 for each test, as for it is MediumTests.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-25748) [Flake Test][branch-1] TestAdmin2

2021-04-08 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-25748.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> [Flake Test][branch-1] TestAdmin2
> -
>
> Key: HBASE-25748
> URL: https://issues.apache.org/jira/browse/HBASE-25748
> Project: HBase
>  Issue Type: Test
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 1.7.0
>
>
> Attempt to improve the stability.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25748) [Flake Test][branch-1] TestAdmin2

2021-04-08 Thread Reid Chan (Jira)
Reid Chan created HBASE-25748:
-

 Summary: [Flake Test][branch-1] TestAdmin2
 Key: HBASE-25748
 URL: https://issues.apache.org/jira/browse/HBASE-25748
 Project: HBase
  Issue Type: Test
Reporter: Reid Chan
Assignee: Reid Chan
 Fix For: 1.7.0


Attempt to improve the stability.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-25740) Backport HBASE-25629 to branch-1

2021-04-07 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-25740.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> Backport HBASE-25629 to branch-1
> 
>
> Key: HBASE-25740
> URL: https://issues.apache.org/jira/browse/HBASE-25740
> Project: HBase
>  Issue Type: Test
>Affects Versions: 1.7.0
>Reporter: Geoffrey Jacoby
>Assignee: Geoffrey Jacoby
>Priority: Major
> Fix For: 1.7.0
>
>
> HBASE-25629 recently fixed an issue where TestCurrentHourProvider 
> consistently failed on certain OSes due to quirks in time zone 
> implementations. This test is also failing in branch-1, so in order to 
> expedite a potential 1.7.0 release we should backport to branch-1 as well. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-25731) TestConnectionImplementation BadHostname tests fail in branch-1

2021-04-05 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-25731.
---
Fix Version/s: 1.7.0
 Hadoop Flags: Reviewed
   Resolution: Fixed

> TestConnectionImplementation BadHostname tests fail in branch-1
> ---
>
> Key: HBASE-25731
> URL: https://issues.apache.org/jira/browse/HBASE-25731
> Project: HBase
>  Issue Type: Test
>Affects Versions: 1.7.0
>Reporter: Geoffrey Jacoby
>Assignee: Geoffrey Jacoby
>Priority: Major
> Fix For: 1.7.0
>
>
> TestConnectionImplementation.testGetAdminBadHostname and 
> testGetClientBadHostname are consistently failing in branch-1. 
> This is because they're assuming that the validity of the host is checked 
> immediately upon getting the protobuf service object, when instead the 
> service code purposefully waits until the first service call to check. 
> I'll revise the tests to make service calls and verify that they return the 
> correct exceptions (ServiceException wrapping an UnknownHostException).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-24893) TestLogLevel failing on hadoop-ci (branch-1)

2021-04-04 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-24893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-24893.
---
Resolution: Fixed

> TestLogLevel failing on hadoop-ci (branch-1)
> 
>
> Key: HBASE-24893
> URL: https://issues.apache.org/jira/browse/HBASE-24893
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: Andrew Kyle Purtell
>Assignee: Abhey Rana
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.7.0
>
>
> TestLogLevel is failing the branch-1 builds on hadoop-ci.
> The test needs some improvement. The code seems to be doing the right thing 
> but the error condition the test is expecting varies by JVM or JVM version:
> {noformat}
> Expected to find 'Unrecognized SSL message' but got unexpected exception:
> javax.net.ssl.SSLException: Unsupported or unrecognized SSL message
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-25303) Nightly build setup failure with Ruby version

2021-04-04 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-25303.
---
Resolution: Resolved

> Nightly build setup failure with Ruby version
> -
>
> Key: HBASE-25303
> URL: https://issues.apache.org/jira/browse/HBASE-25303
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.7.0, 2.2.7
>Reporter: Peter Somogyi
>Priority: Critical
> Fix For: 1.7.0
>
>
> Nightly builds are failing on branch-2.2 and branch-1 in Docker setup phase.
> {noformat}
> Step 28/33 : RUN gem install rubocop:'<= 0.81'
>  ---> Running in ca2c6ed8ee8a
> Building native extensions.  This could take a while...
> ERROR:  Error installing rubocop:
>   parallel requires Ruby version >= 2.5.
> Successfully installed jaro_winkler-1.5.4
> The command '/bin/sh -c gem install rubocop:'<= 0.81'' returned a non-zero 
> code: 1
> ERROR: Docker failed to build yetus/hbase:e5c0a9422c.
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25725) Release 1.7.0

2021-04-01 Thread Reid Chan (Jira)
Reid Chan created HBASE-25725:
-

 Summary: Release 1.7.0
 Key: HBASE-25725
 URL: https://issues.apache.org/jira/browse/HBASE-25725
 Project: HBase
  Issue Type: Task
Reporter: Reid Chan
Assignee: Reid Chan


Discussion is 
[here|https://lists.apache.org/thread.html/r34d3fb86d667f8b3e58cbba78655733ac76e10f5883650f4910adc5c%40%3Cuser.hbase.apache.org%3E],
 this may or may not be the last release of branch-1.

But please allow me to go through the whole process before making any words. 

I'll spend the upcoming next whole week to do this release, having said to my 
employer.

cc [~andrew.purt...@gmail.com]

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-25285) [branch-1] Fix two methods removed problems reported by compat-check

2020-11-24 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-25285.
---
Fix Version/s: 1.7.0
 Hadoop Flags: Reviewed
   Resolution: Fixed

> [branch-1] Fix two methods removed problems reported by compat-check
> 
>
> Key: HBASE-25285
> URL: https://issues.apache.org/jira/browse/HBASE-25285
> Project: HBase
>  Issue Type: Bug
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 1.7.0
>
>
> {code}
> hbase-server-1.6.0.jar, RpcServerInterface.class
> package org.apache.hadoop.hbase.ipc
> RpcServerInterface.refreshAuthManager ( PolicyProvider p1 ) [abstract]  :  
> void
> hbase-server-1.6.0.jar, Store.class
> package org.apache.hadoop.hbase.regionserver
> Store.createWriterInTmp ( long p1, Compression.Algorithm p2, boolean p3, 
> boolean p4, boolean p5, boolean p6 ) [abstract]  :  StoreFile.Writer
> Store.createWriterInTmp ( long p1, Compression.Algorithm p2, boolean p3, 
> boolean p4, boolean p5, boolean p6, TimeRangeTracker p7 ) [abstract]  :  
> StoreFile.Writer
> {code}
> These two removed methods may be problematic, let's review them again.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25313) [branch-1] Fix the broken pre-commit

2020-11-20 Thread Reid Chan (Jira)
Reid Chan created HBASE-25313:
-

 Summary: [branch-1] Fix the broken pre-commit
 Key: HBASE-25313
 URL: https://issues.apache.org/jira/browse/HBASE-25313
 Project: HBase
  Issue Type: Bug
Reporter: Reid Chan
Assignee: Reid Chan






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25285) [branch-1] Fix problems from compat-check reports=

2020-11-15 Thread Reid Chan (Jira)
Reid Chan created HBASE-25285:
-

 Summary: [branch-1] Fix problems from compat-check reports=
 Key: HBASE-25285
 URL: https://issues.apache.org/jira/browse/HBASE-25285
 Project: HBase
  Issue Type: Bug
Reporter: Reid Chan
Assignee: Reid Chan


{code}
hbase-server-1.6.0.jar, RpcServerInterface.class
package org.apache.hadoop.hbase.ipc
RpcServerInterface.refreshAuthManager ( PolicyProvider p1 ) [abstract]  :  void

hbase-server-1.6.0.jar, Store.class
package org.apache.hadoop.hbase.regionserver
Store.createWriterInTmp ( long p1, Compression.Algorithm p2, boolean p3, 
boolean p4, boolean p5, boolean p6 ) [abstract]  :  StoreFile.Writer
Store.createWriterInTmp ( long p1, Compression.Algorithm p2, boolean p3, 
boolean p4, boolean p5, boolean p6, TimeRangeTracker p7 ) [abstract]  :  
StoreFile.Writer
{code}

These two removed methods may be problematic, let's review them again.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25217) [Metrics] Add metrics for Call in IPC response queue

2020-10-25 Thread Reid Chan (Jira)
Reid Chan created HBASE-25217:
-

 Summary: [Metrics] Add metrics for Call in IPC response queue
 Key: HBASE-25217
 URL: https://issues.apache.org/jira/browse/HBASE-25217
 Project: HBase
  Issue Type: Improvement
  Components: metrics
Reporter: Reid Chan
Assignee: Reid Chan


Add metrics for response queue.
E.g., number of Call/RpcResponse in queue, size of Call/RpcResponse in queue.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-25189) [Metrics] Add checkAndPut and checkAndDelete latency metrics at table level

2020-10-25 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-25189.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> [Metrics] Add checkAndPut and checkAndDelete latency metrics at table level
> ---
>
> Key: HBASE-25189
> URL: https://issues.apache.org/jira/browse/HBASE-25189
> Project: HBase
>  Issue Type: Improvement
>  Components: metrics
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.3.3, 1.7.0, 2.2.7
>
>
> Add *checkAndPut* and *checkAndDelete* table latency metrics.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-25195) [branch-1] getNumOpenConnections is not effective

2020-10-18 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-25195.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> [branch-1] getNumOpenConnections is not effective
> -
>
> Key: HBASE-25195
> URL: https://issues.apache.org/jira/browse/HBASE-25195
> Project: HBase
>  Issue Type: Improvement
>  Components: metrics
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
> Fix For: 1.7.0
>
>
> In MetricsHBaseServerWrapperImpl
> {code}
>   @Override
>   public int getNumOpenConnections() {
> if (!isServerStarted() || this.server.connectionList == null) {
>   return 0;
> }
> return server.connectionList.size();
>   }
> {code}
> But connectionList is created by Collections.synchronizedList(new 
> LinkedList());
> So each connectionList.size() will compete for the mutex, we can easily 
> replace it with another parameter *numConnections*, as for metrics, it is 
> enough.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25195) [branch-1] getNumOpenConnections is not effective

2020-10-18 Thread Reid Chan (Jira)
Reid Chan created HBASE-25195:
-

 Summary: [branch-1] getNumOpenConnections is not effective
 Key: HBASE-25195
 URL: https://issues.apache.org/jira/browse/HBASE-25195
 Project: HBase
  Issue Type: Improvement
  Components: metrics
 Environment: In MetricsHBaseServerWrapperImpl
{code}
  @Override
  public int getNumOpenConnections() {
if (!isServerStarted() || this.server.connectionList == null) {
  return 0;
}
return server.connectionList.size();
  }
{code}
But connectionList is created by Collections.synchronizedList(new 
LinkedList());
So each connectionList.size() will compete for the mutex, we can easily replace 
it with another parameter *numConnections*, as for metrics, it is enough.
Reporter: Reid Chan
Assignee: Reid Chan
 Fix For: 1.7.0






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-24849) Branch-1 Backport : HBASE-24665 MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll

2020-10-16 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-24849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-24849.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> Branch-1 Backport : HBASE-24665 MultiWAL :  Avoid rolling of ALL WALs when 
> one of the WAL needs a roll
> --
>
> Key: HBASE-24849
> URL: https://issues.apache.org/jira/browse/HBASE-24849
> Project: HBase
>  Issue Type: Bug
>Reporter: Anoop Sam John
>Assignee: wenfeiyi666
>Priority: Major
> Fix For: 1.7.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25189) [Metrics] Add checkAndPut and checkAndDelete latency metrics

2020-10-15 Thread Reid Chan (Jira)
Reid Chan created HBASE-25189:
-

 Summary: [Metrics] Add checkAndPut and checkAndDelete latency 
metrics
 Key: HBASE-25189
 URL: https://issues.apache.org/jira/browse/HBASE-25189
 Project: HBase
  Issue Type: Improvement
Reporter: Reid Chan
Assignee: Reid Chan






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-25122) [Flake Test][branch-1] TestExportSnapshotWithTemporaryDirectory

2020-09-30 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-25122.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> [Flake Test][branch-1] TestExportSnapshotWithTemporaryDirectory
> ---
>
> Key: HBASE-25122
> URL: https://issues.apache.org/jira/browse/HBASE-25122
> Project: HBase
>  Issue Type: Improvement
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
> Fix For: 1.7.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25122) [Flake Test][branch-1] TestExportSnapshotWithTemporaryDirectory

2020-09-29 Thread Reid Chan (Jira)
Reid Chan created HBASE-25122:
-

 Summary: [Flake Test][branch-1] 
TestExportSnapshotWithTemporaryDirectory
 Key: HBASE-25122
 URL: https://issues.apache.org/jira/browse/HBASE-25122
 Project: HBase
  Issue Type: Improvement
Reporter: Reid Chan
Assignee: Reid Chan






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-25114) [Flake Test][branch-1] TestFromClientSide#testCacheOnWriteEvictOnClose

2020-09-29 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-25114.
---
Fix Version/s: 1.7.0
 Hadoop Flags: Reviewed
   Resolution: Fixed

> [Flake Test][branch-1] TestFromClientSide#testCacheOnWriteEvictOnClose
> --
>
> Key: HBASE-25114
> URL: https://issues.apache.org/jira/browse/HBASE-25114
> Project: HBase
>  Issue Type: Improvement
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
> Fix For: 1.7.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25114) [Flake Test][branch-1] TestFromClientSide#testCacheOnWriteEvictOnClose

2020-09-29 Thread Reid Chan (Jira)
Reid Chan created HBASE-25114:
-

 Summary: [Flake Test][branch-1] 
TestFromClientSide#testCacheOnWriteEvictOnClose
 Key: HBASE-25114
 URL: https://issues.apache.org/jira/browse/HBASE-25114
 Project: HBase
  Issue Type: Improvement
Reporter: Reid Chan
Assignee: Reid Chan






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-25025) [Flaky Test][branch-1] TestFromClientSide#testCheckAndDeleteWithCompareOp

2020-09-29 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-25025.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> [Flaky Test][branch-1] TestFromClientSide#testCheckAndDeleteWithCompareOp
> -
>
> Key: HBASE-25025
> URL: https://issues.apache.org/jira/browse/HBASE-25025
> Project: HBase
>  Issue Type: Improvement
>  Components: test
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
> Fix For: 1.7.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-24665) MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll

2020-09-28 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-24665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-24665.
---
Resolution: Fixed

> MultiWAL :  Avoid rolling of ALL WALs when one of the WAL needs a roll
> --
>
> Key: HBASE-24665
> URL: https://issues.apache.org/jira/browse/HBASE-24665
> Project: HBase
>  Issue Type: Bug
>  Components: wal
>Affects Versions: 2.3.0, 2.1.10, 1.4.14, 2.2.6
>Reporter: wenfeiyi666
>Assignee: wenfeiyi666
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.4.0, 2.2.6, 2.3.1
>
>
> when use multiwal, any a wal request roll, all wal will be together roll.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (HBASE-24665) MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll

2020-09-28 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-24665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan reopened HBASE-24665:
---

I didn't see any back-porting JIRA filed but there's a branch-1 PR, so i just 
reopened it for finishing the back-porting


> MultiWAL :  Avoid rolling of ALL WALs when one of the WAL needs a roll
> --
>
> Key: HBASE-24665
> URL: https://issues.apache.org/jira/browse/HBASE-24665
> Project: HBase
>  Issue Type: Bug
>  Components: wal
>Affects Versions: 2.3.0, 2.1.10, 1.4.14, 2.2.6
>Reporter: wenfeiyi666
>Assignee: wenfeiyi666
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.1, 2.4.0, 2.2.6
>
>
> when use multiwal, any a wal request roll, all wal will be together roll.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-25030) [Flaky Test] TestRestartCluster#testClusterRestart

2020-09-28 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-25030.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> [Flaky Test] TestRestartCluster#testClusterRestart
> --
>
> Key: HBASE-25030
> URL: https://issues.apache.org/jira/browse/HBASE-25030
> Project: HBase
>  Issue Type: Improvement
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
> Fix For: 1.7.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-25031) [Flaky Test] TestReplicationDisableInactivePeer#testDisableInactivePeer

2020-09-27 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-25031.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> [Flaky Test] TestReplicationDisableInactivePeer#testDisableInactivePeer
> ---
>
> Key: HBASE-25031
> URL: https://issues.apache.org/jira/browse/HBASE-25031
> Project: HBase
>  Issue Type: Improvement
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
> Fix For: 1.7.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25031) [Flaky Test] TestReplicationDisableInactivePeer#testDisableInactivePeer

2020-09-15 Thread Reid Chan (Jira)
Reid Chan created HBASE-25031:
-

 Summary: [Flaky Test] 
TestReplicationDisableInactivePeer#testDisableInactivePeer
 Key: HBASE-25031
 URL: https://issues.apache.org/jira/browse/HBASE-25031
 Project: HBase
  Issue Type: Improvement
Reporter: Reid Chan
Assignee: Reid Chan






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25030) [Flaky Test] TestRestartCluster#testClusterRestart

2020-09-15 Thread Reid Chan (Jira)
Reid Chan created HBASE-25030:
-

 Summary: [Flaky Test] TestRestartCluster#testClusterRestart
 Key: HBASE-25030
 URL: https://issues.apache.org/jira/browse/HBASE-25030
 Project: HBase
  Issue Type: Improvement
Reporter: Reid Chan
Assignee: Reid Chan






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25025) [Flaky Test][branch-1] TestFromClientSide#testCheckAndDeleteWithCompareOp

2020-09-14 Thread Reid Chan (Jira)
Reid Chan created HBASE-25025:
-

 Summary: [Flaky Test][branch-1] 
TestFromClientSide#testCheckAndDeleteWithCompareOp
 Key: HBASE-25025
 URL: https://issues.apache.org/jira/browse/HBASE-25025
 Project: HBase
  Issue Type: Improvement
Reporter: Reid Chan






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25024) [Flake Test][branch-1] TestClientOperationInterrupt#testInterrupt50Percent

2020-09-14 Thread Reid Chan (Jira)
Reid Chan created HBASE-25024:
-

 Summary: [Flake Test][branch-1] 
TestClientOperationInterrupt#testInterrupt50Percent
 Key: HBASE-25024
 URL: https://issues.apache.org/jira/browse/HBASE-25024
 Project: HBase
  Issue Type: Improvement
Reporter: Reid Chan
 Fix For: 1.7.0


Sometimes threads could finish faster than interrupt() gets called. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (HBASE-22740) [RSGroup] Forward-port HBASE-22658 to master branch

2020-08-10 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan reopened HBASE-22740:
---

> [RSGroup] Forward-port HBASE-22658 to master branch
> ---
>
> Key: HBASE-22740
> URL: https://issues.apache.org/jira/browse/HBASE-22740
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.6, 2.2.3, 2.1.9
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 3.0.0-alpha-1
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-22740) [RSGroup] Forward-port HBASE-22658 to master branch

2020-08-10 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-22740.
---
Resolution: Fixed

> [RSGroup] Forward-port HBASE-22658 to master branch
> ---
>
> Key: HBASE-22740
> URL: https://issues.apache.org/jira/browse/HBASE-22740
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.6, 2.2.3, 2.1.9
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 3.0.0-alpha-1
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-22740) [RSGroup] Forward-port HBASE-22658 to master branch and branch-2.x

2020-08-10 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-22740.
---
Resolution: Later

> [RSGroup] Forward-port HBASE-22658 to master branch and branch-2.x
> --
>
> Key: HBASE-22740
> URL: https://issues.apache.org/jira/browse/HBASE-22740
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.6, 2.2.3, 2.1.9
>Reporter: Reid Chan
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (HBASE-22740) [RSGroup] Forward-port HBASE-22658 to master branch and branch-2.x

2020-08-10 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan reopened HBASE-22740:
---

> [RSGroup] Forward-port HBASE-22658 to master branch and branch-2.x
> --
>
> Key: HBASE-22740
> URL: https://issues.apache.org/jira/browse/HBASE-22740
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.6, 2.2.3, 2.1.9
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-24814) [CCSMap] ChunkPool and Chunk data structure

2020-08-03 Thread Reid Chan (Jira)
Reid Chan created HBASE-24814:
-

 Summary: [CCSMap] ChunkPool and Chunk data structure
 Key: HBASE-24814
 URL: https://issues.apache.org/jira/browse/HBASE-24814
 Project: HBase
  Issue Type: Sub-task
Reporter: Reid Chan
Assignee: Reid Chan






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-24756) Backport HBASE-24336 to branch-2.2

2020-07-29 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-24756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-24756.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> Backport HBASE-24336 to branch-2.2
> --
>
> Key: HBASE-24756
> URL: https://issues.apache.org/jira/browse/HBASE-24756
> Project: HBase
>  Issue Type: Sub-task
>  Components: metrics
>Affects Versions: 2.2.5
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Minor
> Fix For: 2.2.7
>
>
> HBASE-24336 is applicable to branch-2.2 also.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-24578) [WAL] Add a parameter to config RingBufferEventHandler's SyncFuture count

2020-07-16 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-24578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-24578.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> [WAL] Add a parameter to config RingBufferEventHandler's SyncFuture count
> -
>
> Key: HBASE-24578
> URL: https://issues.apache.org/jira/browse/HBASE-24578
> Project: HBase
>  Issue Type: Improvement
>  Components: wal
>Affects Versions: 1.4.13, 2.2.5
>Reporter: Reid Chan
>Assignee: wenfeiyi666
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.1, 1.7.0, 2.2.6
>
>
> The current value of RingBufferEventHandler's handler is the value of 
> {{hbase.regionserver.handler.count}}, which works good in default wal 
> provider --- one WAL per regionserver.
> When trying to use WAL group provider, either by group or wal per region, the 
> default value is bad. If rs has 100 regions and wal per region strategy is 
> used, then rs will allocate 100 * 
> SyncFuture[$hbase.regionserver.handler.count] array
> {code}
> int maxHandlersCount = conf.getInt(HConstants.REGION_SERVER_HANDLER_COUNT, 
> 200);
> this.ringBufferEventHandler = new RingBufferEventHandler(
> conf.getInt("hbase.regionserver.hlog.syncer.count", 5), 
> maxHandlersCount); 
> ...
> 
> RingBufferEventHandler(final int syncRunnerCount, final int maxHandlersCount) 
> {
>   this.syncFutures = new SyncFuture[maxHandlersCount];
>   ...
>  }
> {code} 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-24739) [Build] branch-1's build seems broken because of pylint

2020-07-16 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-24739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-24739.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> [Build] branch-1's build seems broken because of pylint
> ---
>
> Key: HBASE-24739
> URL: https://issues.apache.org/jira/browse/HBASE-24739
> Project: HBase
>  Issue Type: Bug
>  Components: build
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Blocker
> Fix For: 1.7.0, 1.4.14
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-24739) [Build] branch-1's build seems broken because of pylint

2020-07-14 Thread Reid Chan (Jira)
Reid Chan created HBASE-24739:
-

 Summary: [Build] branch-1's build seems broken because of pylint
 Key: HBASE-24739
 URL: https://issues.apache.org/jira/browse/HBASE-24739
 Project: HBase
  Issue Type: Bug
Reporter: Reid Chan
Assignee: Reid Chan






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-24578) [WAL] Add a parameter to config RingBufferEventHandler's SyncFuture count

2020-06-16 Thread Reid Chan (Jira)
Reid Chan created HBASE-24578:
-

 Summary: [WAL] Add a parameter to config RingBufferEventHandler's 
SyncFuture count
 Key: HBASE-24578
 URL: https://issues.apache.org/jira/browse/HBASE-24578
 Project: HBase
  Issue Type: Improvement
Reporter: Reid Chan


The current value is the value of {{hbase.regionserver.handler.count}}, which 
works good in default wal provider --- one WAL per regionserver.

When I tried to use WAL group provider, either by group or wal per region, the 
default value was bad. If rs has 100 regions I use wal per region strategy, 
then rs will allocate 100 * SyncFuture[$hbase.regionserver.handler.count] array
{code}
int maxHandlersCount = conf.getInt(HConstants.REGION_SERVER_HANDLER_COUNT, 200);
this.ringBufferEventHandler = new RingBufferEventHandler(
conf.getInt("hbase.regionserver.hlog.syncer.count", 5), 
maxHandlersCount); 
...



RingBufferEventHandler(final int syncRunnerCount, final int maxHandlersCount) {
  this.syncFutures = new SyncFuture[maxHandlersCount];
  ...
 }
{code} 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-24453) BackPort HBASE-20220 to branch-1

2020-05-28 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-24453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-24453.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> BackPort HBASE-20220 to branch-1
> 
>
> Key: HBASE-24453
> URL: https://issues.apache.org/jira/browse/HBASE-24453
> Project: HBase
>  Issue Type: Bug
>Reporter: wenbang
>Assignee: wenbang
>Priority: Minor
> Fix For: 1.7.0
>
>
> Backport Jira : HBASE-20220 to branch-1



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-24435) Bring back hedged reads metrics to branch-1

2020-05-27 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-24435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-24435.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> Bring back hedged reads metrics to branch-1
> ---
>
> Key: HBASE-24435
> URL: https://issues.apache.org/jira/browse/HBASE-24435
> Project: HBase
>  Issue Type: Improvement
>  Components: metrics
>Affects Versions: 1.4.13
>Reporter: Javier Akira Luca de Tena
>Priority: Minor
> Fix For: 1.7.0
>
>
> Seems at some point, the hedged metrics were added to 
> MetricsRegionServerWrapperImpl (they were added without mentioning Jira 
> ticket, but may be it was https://issues.apache.org/jira/browse/HBASE-12220 ?)
>  
> However, because of compilation issue, it was reverted: 
> https://issues.apache.org/jira/browse/HBASE-12246
>  
> And never re-applied for branch-1: 
> https://issues.apache.org/jira/browse/HBASE-12246?focusedCommentId=16425102=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16425102



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-24448) Flaky tests for region server in branch-1

2020-05-27 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-24448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-24448.
---
Resolution: Not A Bug

> Flaky tests for region server in branch-1
> -
>
> Key: HBASE-24448
> URL: https://issues.apache.org/jira/browse/HBASE-24448
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver, test
>Affects Versions: 1.7.0
>Reporter: Clara Xiong
>Priority: Minor
>
> [https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1781/4/testReport/]
> Tests failed after unrelated code style changes for metrics for branch-1. 
> Rerun passed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-24345) [ACL] renameRSGroup should require Admin level permission

2020-05-11 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-24345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-24345.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> [ACL] renameRSGroup should require Admin level permission
> -
>
> Key: HBASE-24345
> URL: https://issues.apache.org/jira/browse/HBASE-24345
> Project: HBase
>  Issue Type: Improvement
>  Components: acl, rsgroup
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0, 1.7.0, 2.2.5
>
>
> Currently renameRSgroup can be called by anyone without permission



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-24345) [ACL] renameRSGroup should require Admin level permission

2020-05-07 Thread Reid Chan (Jira)
Reid Chan created HBASE-24345:
-

 Summary: [ACL] renameRSGroup should require Admin level permission
 Key: HBASE-24345
 URL: https://issues.apache.org/jira/browse/HBASE-24345
 Project: HBase
  Issue Type: Improvement
  Components: acl, rsgroup
Reporter: Reid Chan
Assignee: Reid Chan






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-24336) [Metrics] FSDataInputStream's localBytesRead is wrong

2020-05-06 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-24336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-24336.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

Pushed to master, branch-2, branch-2.3, branch-1.

> [Metrics] FSDataInputStream's localBytesRead is wrong
> -
>
> Key: HBASE-24336
> URL: https://issues.apache.org/jira/browse/HBASE-24336
> Project: HBase
>  Issue Type: Bug
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-24336) [Metrics] FSDataInputStream's localBytesRead is wrong

2020-05-06 Thread Reid Chan (Jira)
Reid Chan created HBASE-24336:
-

 Summary: [Metrics] FSDataInputStream's localBytesRead is wrong
 Key: HBASE-24336
 URL: https://issues.apache.org/jira/browse/HBASE-24336
 Project: HBase
  Issue Type: Bug
Reporter: Reid Chan
Assignee: Reid Chan






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-24196) [Shell] Add rename rsgroup command in hbase shell

2020-04-22 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-24196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-24196.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> [Shell] Add rename rsgroup command in hbase shell
> -
>
> Key: HBASE-24196
> URL: https://issues.apache.org/jira/browse/HBASE-24196
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup, shell
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 1.7.0, 2.2.5
>
>
> HBASE-24112 supports renaming rsgroup. So here we add shell command support.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-24229) [Build] Pin rubocop version <= 0.81

2020-04-21 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-24229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-24229.
---
Hadoop Flags: Reviewed
Assignee: Reid Chan
  Resolution: Fixed

> [Build] Pin rubocop version <= 0.81
> ---
>
> Key: HBASE-24229
> URL: https://issues.apache.org/jira/browse/HBASE-24229
> Project: HBase
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 1.4.13
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 1.7.0, 1.4.14
>
>
> rubocop 0.82 has been released, which drops Ruby 2.3 support. 
> We are still using Ruby 2.3 in the Docker, and the docker build will fail (at 
> least in branch-1).
> Similar to AVRO-2807



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-24232) hbase

2020-04-21 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-24232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-24232.
---
Resolution: Invalid

> hbase
> -
>
> Key: HBASE-24232
> URL: https://issues.apache.org/jira/browse/HBASE-24232
> Project: HBase
>  Issue Type: Bug
>Reporter: Rhett.Wang
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-24229) [Build] Pin rubocop version <= 0.81

2020-04-21 Thread Reid Chan (Jira)
Reid Chan created HBASE-24229:
-

 Summary: [Build] Pin rubocop version <= 0.81
 Key: HBASE-24229
 URL: https://issues.apache.org/jira/browse/HBASE-24229
 Project: HBase
  Issue Type: Improvement
Reporter: Reid Chan


rubocop 0.82 has been released, which drops Ruby 2.3 support. 

We are still using Ruby 2.3 in the Docker, and the docker build will fail (at 
least in branch-1).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-24174) Fix findbugs warning on ServiceAuthorizationManager

2020-04-18 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-24174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-24174.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> Fix findbugs warning on ServiceAuthorizationManager
> ---
>
> Key: HBASE-24174
> URL: https://issues.apache.org/jira/browse/HBASE-24174
> Project: HBase
>  Issue Type: Bug
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 1.7.0, 1.4.14, 2.2.5
>
>
> Inconsistent synchronization of 
> org.apache.hadoop.hbase.ipc.RpcServer.authManager; locked 66% of time.
> It is introduced by HBASE-24121, let me fix it. It haven't got released yet. 
> Looks affect branch-1 so far.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-24193) BackPort HBASE-18651 to branch-1

2020-04-15 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-24193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-24193.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> BackPort HBASE-18651 to branch-1
> 
>
> Key: HBASE-24193
> URL: https://issues.apache.org/jira/browse/HBASE-24193
> Project: HBase
>  Issue Type: Improvement
>Reporter: Lokesh Khurana
>Assignee: Lokesh Khurana
>Priority: Major
> Fix For: 1.7.0
>
>
> Backport Jira : 
> [HBASE-18651|https://issues.apache.org/jira/browse/HBASE-18651] to branch-1
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-24196) [Shell] Add rsgroup command in hbase shell

2020-04-15 Thread Reid Chan (Jira)
Reid Chan created HBASE-24196:
-

 Summary: [Shell] Add rsgroup command in hbase shell
 Key: HBASE-24196
 URL: https://issues.apache.org/jira/browse/HBASE-24196
 Project: HBase
  Issue Type: Improvement
  Components: rsgroup, shell
Reporter: Reid Chan
Assignee: Reid Chan






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-24112) [RSGroup] Support renaming rsgroup

2020-04-15 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-24112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-24112.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> [RSGroup] Support renaming rsgroup
> --
>
> Key: HBASE-24112
> URL: https://issues.apache.org/jira/browse/HBASE-24112
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 1.7.0, 2.2.5
>
>
> Rsgroup name once is decided at the beginning, it is difficult to rename it.
> Current approach is removing all tables and servers back to default rsgroup, 
> then delete it and add a rsgroup with the new name, after that moving regions 
> and servers back. Or without moving back, if machine resources is ample. 
> Anyway, it is an expensive operation:  moving regions, breaking region's 
> locality.
> And given that rsgroup is one kind of managements in cluster, and management 
> sometimes changes, renaming is necessary.
> It is simple in implementation. I'm working on it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-24174) Fix findbugs warning in branch-1

2020-04-11 Thread Reid Chan (Jira)
Reid Chan created HBASE-24174:
-

 Summary: Fix findbugs warning in branch-1
 Key: HBASE-24174
 URL: https://issues.apache.org/jira/browse/HBASE-24174
 Project: HBase
  Issue Type: Bug
Reporter: Reid Chan
Assignee: Reid Chan


Inconsistent synchronization of 
org.apache.hadoop.hbase.ipc.RpcServer.authManager; locked 66% of time.

It is introduced by HBASE-24121, let me fix it. It haven't got released yet. 
Looks affect branch-1 so far.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-24121) [Authorization] ServiceAuthorizationManager isn't dynamically updatable. And it should be.

2020-04-09 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-24121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-24121.
---
Resolution: Fixed

> [Authorization] ServiceAuthorizationManager isn't dynamically updatable. And 
> it should be.
> --
>
> Key: HBASE-24121
> URL: https://issues.apache.org/jira/browse/HBASE-24121
> Project: HBase
>  Issue Type: Bug
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 1.7.0, 1.4.14, 2.2.5
>
>
> Some more background information.
> ServiceAuthorizationManager is responsible for the Services access rights 
> defined in hbase-policy.xml which locates under $hbase_home/conf directory.
> Currently, since it doesn't support update dynamically, we need to restart 
> master/regionservers to make configurations take effect. It is an expensive 
> and low efficient admin operation.
> HDFS has the refreshPolicy to do that, HBase also has update_config command, 
> we can make use of that.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-24121) [Authorization] ServiceAuthorizationManager isn't dynamically updatable. And it should be.

2020-04-06 Thread Reid Chan (Jira)
Reid Chan created HBASE-24121:
-

 Summary: [Authorization] ServiceAuthorizationManager isn't 
dynamically updatable. And it should be.
 Key: HBASE-24121
 URL: https://issues.apache.org/jira/browse/HBASE-24121
 Project: HBase
  Issue Type: Bug
Reporter: Reid Chan
Assignee: Reid Chan
 Fix For: 3.0.0, 2.3.0, 1.7.0, 1.4.14, 2.2.5






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-24112) [RSGroup] Support renaming rsgroup

2020-04-03 Thread Reid Chan (Jira)
Reid Chan created HBASE-24112:
-

 Summary: [RSGroup] Support renaming rsgroup
 Key: HBASE-24112
 URL: https://issues.apache.org/jira/browse/HBASE-24112
 Project: HBase
  Issue Type: Improvement
  Components: rsgroup
Reporter: Reid Chan
Assignee: Reid Chan
 Fix For: 3.0.0, 2.3.0, 1.7.0, 1.4.14, 2.2.5


Rsgroup name once is decided at the beginning, it is difficult to rename it.

Current approach is removing all tables and servers back to default rsgroup, 
then delete it and add a rsgroup with the new name, after that moving regions 
and servers back. Or without moving back, if machine resources is ample. 
Anyway, it is an expensive operation:  moving regions, breaking region's 
locality.

And given that rsgroup is one kind of managements in cluster, and management 
sometimes changes, renaming is necessary.

It is simple in implementation. I'm working on it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-24032) [RSGroup] Assign created tables to respective rsgroup automatically instead of manual operations

2020-03-24 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-24032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-24032.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> [RSGroup] Assign created tables to respective rsgroup automatically instead 
> of manual operations 
> -
>
> Key: HBASE-24032
> URL: https://issues.apache.org/jira/browse/HBASE-24032
> Project: HBase
>  Issue Type: Improvement
>  Components: master, rsgroup
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 2.3.0, master, 1.7.0, 2.2.4, 1.4.14
>
>
> In prod practise, it's time consuming and tiring to assign tables to their 
> rsgroups for HBase admin by shell, especially in 1.x rsgroup client is 
> IA.private, we could not even write some programs to do that.
> And I'm here proposing a solution to do the automated rsgroup assignment by 
> allowing running a shell in postCreateTable to determine which table should 
> go to which rsgroup (way in branch-1 not master). The benefit is obvious, 
> admin can determine or change at any time the mapping rule in script without 
> restarting or re-config anything. It's flexible, convenience and time saving.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-22740) [RSGroup] Forward-port HBASE-22658 to master branch and branch-2.x

2020-03-24 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-22740.
---
Resolution: Fixed

> [RSGroup] Forward-port HBASE-22658 to master branch and branch-2.x
> --
>
> Key: HBASE-22740
> URL: https://issues.apache.org/jira/browse/HBASE-22740
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.6, 2.2.3, 2.1.9
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: master
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (HBASE-22740) [RSGroup] Forward-port HBASE-22658 to master branch and branch-2.x

2020-03-24 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan reopened HBASE-22740:
---

Some conflicts in branch-2x, all are reverted and needed some more works.

> [RSGroup] Forward-port HBASE-22658 to master branch and branch-2.x
> --
>
> Key: HBASE-22740
> URL: https://issues.apache.org/jira/browse/HBASE-22740
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 2.3.0, master, 2.2.5
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


  1   2   >