Liu Shaohui created HBASE-10627: ----------------------------------- Summary: A logic mistake in HRegionServer isHealthy Key: HBASE-10627 URL: https://issues.apache.org/jira/browse/HBASE-10627 Project: HBase Issue Type: Bug Reporter: Liu Shaohui Priority: Minor
After visiting the isHealthy in HRegionServer, I think there is a logic mistake. {code} // Verify that all threads are alive if (!(leases.isAlive() && cacheFlusher.isAlive() && hlogRoller.isAlive() && this.compactionChecker.isAlive()) <---- logic wrong here && this.periodicFlusher.isAlive()) { stop("One or more threads are no longer alive -- stop"); return false; } {code} which should be {code} // Verify that all threads are alive if (!(leases.isAlive() && cacheFlusher.isAlive() && hlogRoller.isAlive() && this.compactionChecker.isAlive() && this.periodicFlusher.isAlive())) { stop("One or more threads are no longer alive -- stop"); return false; } {code} Please finger out if i am wrong. Thx -- This message was sent by Atlassian JIRA (v6.1.5#6160)