[jira] [Commented] (HTTPCLIENT-1563) HttpClient OSGi bundle is missing some javax.naming package imports
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14163921#comment-14163921
]
Jason Lemay commented on HTTPCLIENT-1563:
-
Linking HTTPLIENT-1547 as a related issue.
> HttpClient OSGi bundle is missing some javax.naming package imports
> ---
>
> Key: HTTPCLIENT-1563
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1563
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient
>Affects Versions: 4.3.5
>Reporter: Jason Lemay
>
> A bug was created to resolve the missing javax.naming package import
> (HTTPCLIENT-1547), but the httpclient imports more than just javax.naming.
> The class org.apache.http.conn.ssl.AbstractVerifier.java imports the
> following javax.naming classes.
> {code}
> import javax.naming.InvalidNameException;
> import javax.naming.NamingException;
> import javax.naming.directory.Attribute;
> import javax.naming.directory.Attributes;
> import javax.naming.ldap.LdapName;
> import javax.naming.ldap.Rdn;
> {code}
> To resolve these other packages the OSGi pom needs the following package
> imports added to it.
> {code}
> javax.naming.directory
> javax.naming.ldap
> {code}
> In addition to the javax.naming import already added in HTTPCLIENT-1547
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Created] (HTTPCLIENT-1563) HttpClient OSGi bundle is missing some javax.naming package imports
Jason Lemay created HTTPCLIENT-1563:
---
Summary: HttpClient OSGi bundle is missing some javax.naming
package imports
Key: HTTPCLIENT-1563
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1563
Project: HttpComponents HttpClient
Issue Type: Bug
Components: HttpClient
Affects Versions: 4.3.5
Reporter: Jason Lemay
A bug was created to resolve the missing javax.naming package import
(HTTPCLIENT-1547), but the httpclient imports more than just javax.naming.
The class org.apache.http.conn.ssl.AbstractVerifier.java imports the following
javax.naming classes.
{code}
import javax.naming.InvalidNameException;
import javax.naming.NamingException;
import javax.naming.directory.Attribute;
import javax.naming.directory.Attributes;
import javax.naming.ldap.LdapName;
import javax.naming.ldap.Rdn;
{code}
To resolve these other packages the OSGi pom needs the following package
imports added to it.
{code}
javax.naming.directory
javax.naming.ldap
{code}
In addition to the javax.naming import already added in HTTPCLIENT-1547
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-1515) Caching responses to HEAD requests
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14163573#comment-14163573 ] Oleg Kalnichevski commented on HTTPCLIENT-1515: --- My personal preference would still be to add an extra instance variable (and an overloaded constructor) even at the expense of incompatibility with the existing caches. The final decision is up to you and Jon, though. Oleg > Caching responses to HEAD requests > -- > > Key: HTTPCLIENT-1515 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1515 > Project: HttpComponents HttpClient > Issue Type: Improvement > Components: HttpCache >Reporter: Tyrone Cutajar > Fix For: 4.4 Final > > > Our system retrieves metadata via HEAD requests using HTTP Client 4.x and > would benefit immensely from having the headers in the response cached. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] httpcore pull request: Fix HttpContext loss on exception in reques...
Github user hirthwork closed the pull request at: https://github.com/apache/httpcore/pull/4 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Resolved] (HTTPCLIENT-1562) Typo in WindowsNegotiateScheme
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oleg Kalnichevski resolved HTTPCLIENT-1562.
---
Resolution: Fixed
Fix Version/s: 4.4 Beta2
> Typo in WindowsNegotiateScheme
> --
>
> Key: HTTPCLIENT-1562
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1562
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpAuth
>Affects Versions: 4.4 Beta1
>Reporter: Michael Osipov
>Priority: Trivial
> Fix For: 4.4 Beta2
>
>
> {{WindowsNegotiateScheme}} declares {{private CtxtHandle sppicontext}} but it
> should read {{private CtxtHandle sspiContext}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-1562) Typo in WindowsNegotiateScheme
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14163560#comment-14163560
]
ASF GitHub Bot commented on HTTPCLIENT-1562:
Github user ok2c commented on the pull request:
https://github.com/apache/httpclient/pull/19#issuecomment-58368959
Committed to SVN trunk
http://svn.apache.org/r1630126
Oleg
> Typo in WindowsNegotiateScheme
> --
>
> Key: HTTPCLIENT-1562
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1562
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpAuth
>Affects Versions: 4.4 Beta1
>Reporter: Michael Osipov
>Priority: Trivial
>
> {{WindowsNegotiateScheme}} declares {{private CtxtHandle sppicontext}} but it
> should read {{private CtxtHandle sspiContext}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] httpclient pull request: HTTPCLIENT-1562: Typo in WindowsNegotiate...
Github user ok2c commented on the pull request: https://github.com/apache/httpclient/pull/19#issuecomment-58368959 Committed to SVN trunk http://svn.apache.org/r1630126 Oleg --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Resolved] (HTTPCLIENT-1560) Request mutual auth in WinHttpClient
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oleg Kalnichevski resolved HTTPCLIENT-1560.
---
Resolution: Fixed
Fix Version/s: 4.4 Beta2
> Request mutual auth in WinHttpClient
>
>
> Key: HTTPCLIENT-1560
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1560
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpAuth
>Affects Versions: 4.4 Beta1
>Reporter: Michael Osipov
> Fix For: 4.4 Beta2
>
>
> {{WindowsNegotiateScheme}} shall request in [line
> 278|https://github.com/apache/httpclient/blob/trunk/httpclient-win/src/main/java/org/apache/http/impl/auth/win/WindowsNegotiateScheme.java#L278]
> mutual auth ({{ISC_REQ_MUTUAL_AUTH}}) by the server. This adds another layer
> of security when Kerberos is selected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-1560) Request mutual auth in WinHttpClient
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14163559#comment-14163559
]
ASF GitHub Bot commented on HTTPCLIENT-1560:
Github user ok2c commented on the pull request:
https://github.com/apache/httpclient/pull/20#issuecomment-58368575
Committed to SVN trunk
http://svn.apache.org/r1630125
Oleg
> Request mutual auth in WinHttpClient
>
>
> Key: HTTPCLIENT-1560
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1560
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpAuth
>Affects Versions: 4.4 Beta1
>Reporter: Michael Osipov
>
> {{WindowsNegotiateScheme}} shall request in [line
> 278|https://github.com/apache/httpclient/blob/trunk/httpclient-win/src/main/java/org/apache/http/impl/auth/win/WindowsNegotiateScheme.java#L278]
> mutual auth ({{ISC_REQ_MUTUAL_AUTH}}) by the server. This adds another layer
> of security when Kerberos is selected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] httpclient pull request: HTTPCLIENT-1560: Request mutual auth in W...
Github user ok2c commented on the pull request: https://github.com/apache/httpclient/pull/20#issuecomment-58368575 Committed to SVN trunk http://svn.apache.org/r1630125 Oleg --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Updated] (HTTPCLIENT-1561) InitializeSecurityContext in WinHttpClient ignores return codes
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated HTTPCLIENT-1561:
---
Description:
In {{WinHttpClient}} {{InitializeSecurityContext}} might not only return
{{SEC_I_CONTINUE_NEEDED}} and {{SEC_E_OK}} but also
{{SEC_I_COMPLETE_AND_CONTINUE}} and {{SEC_I_COMPLETE_NEEDED}}. The switch case
needs to be extended. See
[reference|http://msdn.microsoft.com/en-us/library/windows/desktop/aa375509%28v=vs.85%29.aspx].
As far as I can see, necessary functions aren't even mapped in JNA, so one
would need to spawn a ticket with JNA first.
was:In {{WinHttpClient}} {{InitializeSecurityContext}} might not only return
{{SEC_I_CONTINUE_NEEDED}} and {{SEC_E_OK}} but also
{{SEC_I_COMPLETE_AND_CONTINUE}} and {{SEC_I_COMPLETE_NEEDED}}. The switch case
needs to be extended. See
[reference|http://msdn.microsoft.com/en-us/library/windows/desktop/aa375509%28v=vs.85%29.aspx].
> InitializeSecurityContext in WinHttpClient ignores return codes
> ---
>
> Key: HTTPCLIENT-1561
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1561
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpAuth
>Affects Versions: 4.4 Beta1
>Reporter: Michael Osipov
>Priority: Critical
>
> In {{WinHttpClient}} {{InitializeSecurityContext}} might not only return
> {{SEC_I_CONTINUE_NEEDED}} and {{SEC_E_OK}} but also
> {{SEC_I_COMPLETE_AND_CONTINUE}} and {{SEC_I_COMPLETE_NEEDED}}. The switch
> case needs to be extended. See
> [reference|http://msdn.microsoft.com/en-us/library/windows/desktop/aa375509%28v=vs.85%29.aspx].
> As far as I can see, necessary functions aren't even mapped in JNA, so one
> would need to spawn a ticket with JNA first.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Updated] (HTTPCLIENT-1561) InitializeSecurityContext in WinHttpClient ignores return codes
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated HTTPCLIENT-1561:
---
Priority: Critical (was: Major)
> InitializeSecurityContext in WinHttpClient ignores return codes
> ---
>
> Key: HTTPCLIENT-1561
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1561
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpAuth
>Affects Versions: 4.4 Beta1
>Reporter: Michael Osipov
>Priority: Critical
>
> In {{WinHttpClient}} {{InitializeSecurityContext}} might not only return
> {{SEC_I_CONTINUE_NEEDED}} and {{SEC_E_OK}} but also
> {{SEC_I_COMPLETE_AND_CONTINUE}} and {{SEC_I_COMPLETE_NEEDED}}. The switch
> case needs to be extended. See
> [reference|http://msdn.microsoft.com/en-us/library/windows/desktop/aa375509%28v=vs.85%29.aspx].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-1560) Request mutual auth in WinHttpClient
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14163454#comment-14163454
]
ASF GitHub Bot commented on HTTPCLIENT-1560:
GitHub user michael-o opened a pull request:
https://github.com/apache/httpclient/pull/20
HTTPCLIENT-1560: Request mutual auth in WinHttpClient
Removed ISC_REQ_CONNECTION because it is already set
by default. Added ISC_REQ_MUTUAL_AUTH which is also
required by ISC_REQ_DELEGATE.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michael-o/httpclient HTTPCLIENT-1560
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/httpclient/pull/20.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20
commit f7916b5d7d5335fd03743041dc3dd3421f52dec4
Author: Michael Osipov
Date: 2014-10-08T13:03:04Z
HTTPCLIENT-1560: Request mutual auth in WinHttpClient
Removed ISC_REQ_CONNECTION because it is already set
by default. Added ISC_REQ_MUTUAL_AUTH which is also
required by ISC_REQ_DELEGATE.
> Request mutual auth in WinHttpClient
>
>
> Key: HTTPCLIENT-1560
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1560
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpAuth
>Affects Versions: 4.4 Beta1
>Reporter: Michael Osipov
>
> {{WindowsNegotiateScheme}} shall request in [line
> 278|https://github.com/apache/httpclient/blob/trunk/httpclient-win/src/main/java/org/apache/http/impl/auth/win/WindowsNegotiateScheme.java#L278]
> mutual auth ({{ISC_REQ_MUTUAL_AUTH}}) by the server. This adds another layer
> of security when Kerberos is selected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] httpclient pull request: HTTPCLIENT-1560: Request mutual auth in W...
GitHub user michael-o opened a pull request: https://github.com/apache/httpclient/pull/20 HTTPCLIENT-1560: Request mutual auth in WinHttpClient Removed ISC_REQ_CONNECTION because it is already set by default. Added ISC_REQ_MUTUAL_AUTH which is also required by ISC_REQ_DELEGATE. You can merge this pull request into a Git repository by running: $ git pull https://github.com/michael-o/httpclient HTTPCLIENT-1560 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/httpclient/pull/20.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #20 commit f7916b5d7d5335fd03743041dc3dd3421f52dec4 Author: Michael Osipov Date: 2014-10-08T13:03:04Z HTTPCLIENT-1560: Request mutual auth in WinHttpClient Removed ISC_REQ_CONNECTION because it is already set by default. Added ISC_REQ_MUTUAL_AUTH which is also required by ISC_REQ_DELEGATE. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Updated] (HTTPCLIENT-1560) Request mutual auth in WinHttpClient
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated HTTPCLIENT-1560:
---
Summary: Request mutual auth in WinHttpClient (was: Request mutual authin
WinHttpClient)
> Request mutual auth in WinHttpClient
>
>
> Key: HTTPCLIENT-1560
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1560
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpAuth
>Affects Versions: 4.4 Beta1
>Reporter: Michael Osipov
>
> {{WindowsNegotiateScheme}} shall request in [line
> 278|https://github.com/apache/httpclient/blob/trunk/httpclient-win/src/main/java/org/apache/http/impl/auth/win/WindowsNegotiateScheme.java#L278]
> mutual auth ({{ISC_REQ_MUTUAL_AUTH}}) by the server. This adds another layer
> of security when Kerberos is selected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-1562) Typo in WindowsNegotiateScheme
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14163440#comment-14163440
]
ASF GitHub Bot commented on HTTPCLIENT-1562:
GitHub user michael-o opened a pull request:
https://github.com/apache/httpclient/pull/19
HTTPCLIENT-1562: Typo in WindowsNegotiateScheme
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michael-o/httpclient HTTPCLIENT-1562
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/httpclient/pull/19.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19
commit f5dd2018861747fa56a65bd8be18a4e251057b3a
Author: Michael Osipov
Date: 2014-10-08T12:43:10Z
HTTPCLIENT-1562: Typo in WindowsNegotiateScheme
> Typo in WindowsNegotiateScheme
> --
>
> Key: HTTPCLIENT-1562
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1562
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpAuth
>Affects Versions: 4.4 Beta1
>Reporter: Michael Osipov
>Priority: Trivial
>
> {{WindowsNegotiateScheme}} declares {{private CtxtHandle sppicontext}} but it
> should read {{private CtxtHandle sspiContext}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-1562) Typo in WindowsNegotiateScheme
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14163441#comment-14163441
]
Michael Osipov commented on HTTPCLIENT-1562:
https://github.com/apache/httpclient/pull/19
> Typo in WindowsNegotiateScheme
> --
>
> Key: HTTPCLIENT-1562
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1562
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpAuth
>Affects Versions: 4.4 Beta1
>Reporter: Michael Osipov
>Priority: Trivial
>
> {{WindowsNegotiateScheme}} declares {{private CtxtHandle sppicontext}} but it
> should read {{private CtxtHandle sspiContext}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] httpclient pull request: HTTPCLIENT-1562: Typo in WindowsNegotiate...
GitHub user michael-o opened a pull request: https://github.com/apache/httpclient/pull/19 HTTPCLIENT-1562: Typo in WindowsNegotiateScheme You can merge this pull request into a Git repository by running: $ git pull https://github.com/michael-o/httpclient HTTPCLIENT-1562 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/httpclient/pull/19.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #19 commit f5dd2018861747fa56a65bd8be18a4e251057b3a Author: Michael Osipov Date: 2014-10-08T12:43:10Z HTTPCLIENT-1562: Typo in WindowsNegotiateScheme --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-1515) Caching responses to HEAD requests
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14163425#comment-14163425 ] Francois-Xavier Bonnet commented on HTTPCLIENT-1515: This would avoid adding a new constructor in our API. Also we would keep compatibility with existing serialized cache entries and we wouldn't have to introduce a new configuration parameter. > Caching responses to HEAD requests > -- > > Key: HTTPCLIENT-1515 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1515 > Project: HttpComponents HttpClient > Issue Type: Improvement > Components: HttpCache >Reporter: Tyrone Cutajar > Fix For: 4.4 Final > > > Our system retrieves metadata via HEAD requests using HTTP Client 4.x and > would benefit immensely from having the headers in the response cached. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Comment Edited] (HTTPCLIENT-1545) Possible infinite loop when WindowsNegotiateScheme authentication fails
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14163422#comment-14163422
]
Michael Osipov edited comment on HTTPCLIENT-1545 at 10/8/14 12:33 PM:
--
I am having trouble to pass that test:
{noformat}
---
T E S T S
---
Running org.apache.http.impl.auth.win.TestWindowsNegotiateScheme
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 5.516 sec <<<
FAILURE! - in org.apache.http.impl.auth.wi
n.TestWindowsNegotiateScheme
testNoInfiniteLoopOnSPNOutsideDomain(org.apache.http.impl.auth.win.TestWindowsNegotiateScheme)
Time elapsed: 5.297 sec
<<< ERROR!
com.sun.jna.LastErrorException: GetLastError() returned 317
at
com.sun.jna.platform.win32.Kernel32Util.formatMessage(Kernel32Util.java:68)
at
com.sun.jna.platform.win32.Kernel32Util.formatMessage(Kernel32Util.java:83)
at
com.sun.jna.platform.win32.Win32Exception.(Win32Exception.java:42)
at
com.sun.jna.platform.win32.Win32Exception.(Win32Exception.java:52)
at
org.apache.http.impl.auth.win.TestWindowsNegotiateScheme$WindowsNegotiateSchemeGetTokenFail.getToken(TestWind
owsNegotiateScheme.java:132)
at
org.apache.http.impl.auth.win.WindowsNegotiateScheme.authenticate(WindowsNegotiateScheme.java:190)
at
org.apache.http.impl.auth.HttpAuthenticator.doAuth(HttpAuthenticator.java:239)
at
org.apache.http.impl.auth.HttpAuthenticator.generateAuthResponse(HttpAuthenticator.java:202)
at
org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:262)
at
org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:184)
at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:88)
at
org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:110)
at
org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:184)
at
org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:119)
at
org.apache.http.impl.auth.win.TestWindowsNegotiateScheme.testNoInfiniteLoopOnSPNOutsideDomain(TestWindowsNego
tiateScheme.java:115)
{noformat}
Performed on my Windows XP box at home. No domain, just a local machine.
Is that a JNA bug? See {{ERROR_MR_MID_NOT_FOUND: 317}} from
http://msdn.microsoft.com/en-us/library/windows/desktop/ms681382%28v=vs.85%29.aspx
was (Author: michael-o):
I am having trouble to pass that test:
{noformat}
---
T E S T S
---
Running org.apache.http.impl.auth.win.TestWindowsNegotiateScheme
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 5.516 sec <<<
FAILURE! - in org.apache.http.impl.auth.wi
n.TestWindowsNegotiateScheme
testNoInfiniteLoopOnSPNOutsideDomain(org.apache.http.impl.auth.win.TestWindowsNegotiateScheme)
Time elapsed: 5.297 sec
<<< ERROR!
com.sun.jna.LastErrorException: GetLastError() returned 317
at
com.sun.jna.platform.win32.Kernel32Util.formatMessage(Kernel32Util.java:68)
at
com.sun.jna.platform.win32.Kernel32Util.formatMessage(Kernel32Util.java:83)
at
com.sun.jna.platform.win32.Win32Exception.(Win32Exception.java:42)
at
com.sun.jna.platform.win32.Win32Exception.(Win32Exception.java:52)
at
org.apache.http.impl.auth.win.TestWindowsNegotiateScheme$WindowsNegotiateSchemeGetTokenFail.getToken(TestWind
owsNegotiateScheme.java:132)
at
org.apache.http.impl.auth.win.WindowsNegotiateScheme.authenticate(WindowsNegotiateScheme.java:190)
at
org.apache.http.impl.auth.HttpAuthenticator.doAuth(HttpAuthenticator.java:239)
at
org.apache.http.impl.auth.HttpAuthenticator.generateAuthResponse(HttpAuthenticator.java:202)
at
org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:262)
at
org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:184)
at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:88)
at
org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:110)
at
org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:184)
at
org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:119)
at
org.apache.http.impl.auth.win.TestWindowsNegotiateScheme.testNoInfiniteLoopOnSPNOutsideDomain(TestWindowsNego
tiateScheme.java:115)
{noformat}
Performed on my Windows XP box at home. No domain, just a local machine.
> Possible infinite loop when WindowsNegotiateScheme authentication fails
> ---
>
> Key: HTTPCLIENT-1545
> URL: http
[jira] [Commented] (HTTPCLIENT-1545) Possible infinite loop when WindowsNegotiateScheme authentication fails
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14163422#comment-14163422
]
Michael Osipov commented on HTTPCLIENT-1545:
I am having trouble to pass that test:
{noformat}
---
T E S T S
---
Running org.apache.http.impl.auth.win.TestWindowsNegotiateScheme
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 5.516 sec <<<
FAILURE! - in org.apache.http.impl.auth.wi
n.TestWindowsNegotiateScheme
testNoInfiniteLoopOnSPNOutsideDomain(org.apache.http.impl.auth.win.TestWindowsNegotiateScheme)
Time elapsed: 5.297 sec
<<< ERROR!
com.sun.jna.LastErrorException: GetLastError() returned 317
at
com.sun.jna.platform.win32.Kernel32Util.formatMessage(Kernel32Util.java:68)
at
com.sun.jna.platform.win32.Kernel32Util.formatMessage(Kernel32Util.java:83)
at
com.sun.jna.platform.win32.Win32Exception.(Win32Exception.java:42)
at
com.sun.jna.platform.win32.Win32Exception.(Win32Exception.java:52)
at
org.apache.http.impl.auth.win.TestWindowsNegotiateScheme$WindowsNegotiateSchemeGetTokenFail.getToken(TestWind
owsNegotiateScheme.java:132)
at
org.apache.http.impl.auth.win.WindowsNegotiateScheme.authenticate(WindowsNegotiateScheme.java:190)
at
org.apache.http.impl.auth.HttpAuthenticator.doAuth(HttpAuthenticator.java:239)
at
org.apache.http.impl.auth.HttpAuthenticator.generateAuthResponse(HttpAuthenticator.java:202)
at
org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:262)
at
org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:184)
at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:88)
at
org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:110)
at
org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:184)
at
org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:119)
at
org.apache.http.impl.auth.win.TestWindowsNegotiateScheme.testNoInfiniteLoopOnSPNOutsideDomain(TestWindowsNego
tiateScheme.java:115)
{noformat}
Performed on my Windows XP box at home. No domain, just a local machine.
> Possible infinite loop when WindowsNegotiateScheme authentication fails
> ---
>
> Key: HTTPCLIENT-1545
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1545
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient
>Affects Versions: 4.4 Alpha1
> Environment: Windows
>Reporter: Ka-Lok Fung
> Fix For: 4.4 Beta1
>
> Attachments: HTTPCLIENT-1545.patch.diff, HTTPCLIENT-1545.v2.patch.diff
>
>
> When {{WindowsNegotiateScheme}} authentication fails, it's possible for
> HttpClient to retry the authentication in an endless loop because the
> {{continueNeeded}} flag is not set to {{false}} when authentication fails.
> One possible way of causing authentication to fail is to use a service
> principle name that is outside your Windows domain (e.g., HTTP/EXAMPLE.COM).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Comment Edited] (HTTPCLIENT-1562) Typo in WindowsNegotiateScheme
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14163396#comment-14163396
]
Michael Osipov edited comment on HTTPCLIENT-1562 at 10/8/14 11:58 AM:
--
No problem, I will create a PR for that.
was (Author: michael-o):
Not a problem, I will create a PR for that.
> Typo in WindowsNegotiateScheme
> --
>
> Key: HTTPCLIENT-1562
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1562
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpAuth
>Affects Versions: 4.4 Beta1
>Reporter: Michael Osipov
>Priority: Trivial
>
> {{WindowsNegotiateScheme}} declares {{private CtxtHandle sppicontext}} but it
> should read {{private CtxtHandle sspiContext}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-1562) Typo in WindowsNegotiateScheme
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14163396#comment-14163396
]
Michael Osipov commented on HTTPCLIENT-1562:
Not a problem, I will create a PR for that.
> Typo in WindowsNegotiateScheme
> --
>
> Key: HTTPCLIENT-1562
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1562
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpAuth
>Affects Versions: 4.4 Beta1
>Reporter: Michael Osipov
>Priority: Trivial
>
> {{WindowsNegotiateScheme}} declares {{private CtxtHandle sppicontext}} but it
> should read {{private CtxtHandle sspiContext}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-1562) Typo in WindowsNegotiateScheme
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14163383#comment-14163383
]
Oleg Kalnichevski commented on HTTPCLIENT-1562:
---
Generally things happen much faster if they come with patches or pull requests
at GitHub.
Oleg
> Typo in WindowsNegotiateScheme
> --
>
> Key: HTTPCLIENT-1562
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1562
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpAuth
>Affects Versions: 4.4 Beta1
>Reporter: Michael Osipov
>Priority: Trivial
>
> {{WindowsNegotiateScheme}} declares {{private CtxtHandle sppicontext}} but it
> should read {{private CtxtHandle sspiContext}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Created] (HTTPCLIENT-1562) Typo in WindowsNegotiateScheme
Michael Osipov created HTTPCLIENT-1562:
--
Summary: Typo in WindowsNegotiateScheme
Key: HTTPCLIENT-1562
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1562
Project: HttpComponents HttpClient
Issue Type: Improvement
Components: HttpAuth
Affects Versions: 4.4 Beta1
Reporter: Michael Osipov
Priority: Trivial
{{WindowsNegotiateScheme}} declares {{private CtxtHandle sppicontext}} but it
should read {{private CtxtHandle sspiContext}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Created] (HTTPCLIENT-1561) InitializeSecurityContext in WinHttpClient ignores return codes
Michael Osipov created HTTPCLIENT-1561:
--
Summary: InitializeSecurityContext in WinHttpClient ignores return
codes
Key: HTTPCLIENT-1561
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1561
Project: HttpComponents HttpClient
Issue Type: Bug
Components: HttpAuth
Affects Versions: 4.4 Beta1
Reporter: Michael Osipov
In {{WinHttpClient}} {{InitializeSecurityContext}} might not only return
{{SEC_I_CONTINUE_NEEDED}} and {{SEC_E_OK}} but also
{{SEC_I_COMPLETE_AND_CONTINUE}} and {{SEC_I_COMPLETE_NEEDED}}. The switch case
needs to be extended. See
[reference|http://msdn.microsoft.com/en-us/library/windows/desktop/aa375509%28v=vs.85%29.aspx].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Created] (HTTPCLIENT-1560) Request mutual authin WinHttpClient
Michael Osipov created HTTPCLIENT-1560:
--
Summary: Request mutual authin WinHttpClient
Key: HTTPCLIENT-1560
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1560
Project: HttpComponents HttpClient
Issue Type: Improvement
Components: HttpAuth
Affects Versions: 4.4 Beta1
Reporter: Michael Osipov
{{WindowsNegotiateScheme}} shall request in [line
278|https://github.com/apache/httpclient/blob/trunk/httpclient-win/src/main/java/org/apache/http/impl/auth/win/WindowsNegotiateScheme.java#L278]
mutual auth ({{ISC_REQ_MUTUAL_AUTH}}) by the server. This adds another layer
of security when Kerberos is selected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-1515) Caching responses to HEAD requests
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14163275#comment-14163275 ] Oleg Kalnichevski commented on HTTPCLIENT-1515: --- Francois-Xavier Why not just add an overloaded constructor with the same argument signature as before? Oleg > Caching responses to HEAD requests > -- > > Key: HTTPCLIENT-1515 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1515 > Project: HttpComponents HttpClient > Issue Type: Improvement > Components: HttpCache >Reporter: Tyrone Cutajar > Fix For: 4.4 Final > > > Our system retrieves metadata via HEAD requests using HTTP Client 4.x and > would benefit immensely from having the headers in the response cached. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-1515) Caching responses to HEAD requests
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14163243#comment-14163243 ] Francois-Xavier Bonnet commented on HTTPCLIENT-1515: I have been testing this change. It works fine, however it does not pass the clirr:check due to the changes to the signatures of the constructors of org.apache.http.client.cache.HttpCacheEntry I have been thinking about some solutions that would not require to store the request method in the cache entry so that we don't have to change the signatures: 1) put an empty entity in the cache if the request method is GET and there is no entity, null if the method is HEAD 2) before reusing a cache entry for a GET request, check if the content-length is consistent with the cached entity Your opinion? > Caching responses to HEAD requests > -- > > Key: HTTPCLIENT-1515 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1515 > Project: HttpComponents HttpClient > Issue Type: Improvement > Components: HttpCache >Reporter: Tyrone Cutajar > Fix For: 4.4 Final > > > Our system retrieves metadata via HEAD requests using HTTP Client 4.x and > would benefit immensely from having the headers in the response cached. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] httpcore pull request: Fix HttpContext loss on exception in reques...
Github user ok2c commented on the pull request: https://github.com/apache/httpcore/pull/4#issuecomment-58321892 Committed to SVN trunk http://svn.apache.org/r1630023 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
