[GitHub] [httpcomponents-core] ok2c commented on pull request #331: HTTPCORE-698 - Migrate Test to Unit 5.
ok2c commented on pull request #331: URL: https://github.com/apache/httpcomponents-core/pull/331#issuecomment-974652865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #331: HTTPCORE-698 - Migrate Test to Unit 5.
ok2c commented on pull request #331: URL: https://github.com/apache/httpcomponents-core/pull/331#issuecomment-974657699 > can I help you? @arturobernalg No immediate help is needed. But if you really want to help, please spend less time changing code style based on personal taste or preferences and spend more time improving functionality. For instance, migrating HttpClient APIs from `java.util.Date` to `java.time.Instant` would make a very good contribution.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #331: HTTPCORE-698 - Migrate Test to Unit 5.
ok2c commented on pull request #331: URL: https://github.com/apache/httpcomponents-core/pull/331#issuecomment-974652865 @arturobernalg Looks good to me. > Guys, I am still not sure whether this is the right decision for now since we are likely going to maintain 5.1.x on Java 7 for some time... This change will make backports harder. WDYT? @michael-o We already started using lambdas in tests, so automatic merging between branches is going to be difficult anyway. so, I do not see this as a deal breaker. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
