[GitHub] cstamas commented on issue #136: HTTPCLIENT-1968
cstamas commented on issue #136: HTTPCLIENT-1968 URL: https://github.com/apache/httpcomponents-client/pull/136#issuecomment-464349249 Ouch! Yes, i forgot to provide subst/old signature method for this.. Tx This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] cstamas commented on issue #136: HTTPCLIENT-1968
cstamas commented on issue #136: HTTPCLIENT-1968 URL: https://github.com/apache/httpcomponents-client/pull/136#issuecomment-464335865 @ok2c done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] cstamas commented on issue #136: HTTPCLIENT-1968
cstamas commented on issue #136: HTTPCLIENT-1968 URL: https://github.com/apache/httpcomponents-client/pull/136#issuecomment-463617176 @ok2c Seems Travis build failed but it is still OK for me (and was OK Travis last two builds before squash), is there some concurrency problem in UTs? ``` [INFO] --- maven-bundle-plugin:3.5.1:install (default-install) @ httpclient-osgi --- [INFO] Installing org/apache/httpcomponents/httpclient-osgi/4.5.8-SNAPSHOT/httpclient-osgi-4.5.8-SNAPSHOT.jar [INFO] Writing OBR metadata [INFO] [INFO] Reactor Summary for Apache HttpComponents Client 4.5.8-SNAPSHOT: [INFO] [INFO] Apache HttpComponents Client ... SUCCESS [ 2.315 s] [INFO] Apache HttpClient .. SUCCESS [ 31.340 s] [INFO] Apache HttpClient Mime . SUCCESS [ 2.958 s] [INFO] Apache HttpClient Fluent API ... SUCCESS [ 3.021 s] [INFO] Apache HttpClient Cache SUCCESS [ 12.242 s] [INFO] Apache HttpClient Windows features . SUCCESS [ 2.831 s] [INFO] Apache HttpClient OSGi bundle .. SUCCESS [ 4.976 s] [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 01:00 min [INFO] Finished at: 2019-02-14T13:55:32+01:00 [INFO] cstamas@Urnebes ~/Worx/apache-httpcomponents/httpcomponents-client (HTTPCLIENT-1968)$ ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] cstamas commented on issue #136: HTTPCLIENT-1968
cstamas commented on issue #136: HTTPCLIENT-1968 URL: https://github.com/apache/httpcomponents-client/pull/136#issuecomment-463614970 @ok2c Done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] cstamas commented on issue #136: HTTPCLIENT-1968
cstamas commented on issue #136: HTTPCLIENT-1968 URL: https://github.com/apache/httpcomponents-client/pull/136#issuecomment-463594991 @ok2c Sure, but that would mean that we need to reimplement `java.net.URI#resolve(java.net.URI)` in body of `org.apache.http.client.utils.URIUtils#resolve(java.net.URI, java.net.URI)` method, something I see out of the scope of this PR. IMO, for now this PR is ok, and allows people to step over and upgrade their client. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] cstamas commented on issue #136: HTTPCLIENT-1968
cstamas commented on issue #136: HTTPCLIENT-1968 URL: https://github.com/apache/httpcomponents-client/pull/136#issuecomment-463586677 Not a complete solution: IF relative redirects happens (and are allowed), `java.net.URI#resolve(java.net.URI)` is being used that WILL normalize, despite the setting in `RequestConfig` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
