[GitHub] garydgregory commented on a change in pull request #105: [HTTPCORE-572] Move examples to the src/test folders for each module.
garydgregory commented on a change in pull request #105: [HTTPCORE-572] Move
examples to the src/test folders for each module.
URL:
https://github.com/apache/httpcomponents-core/pull/105#discussion_r256826050
##
File path: pom.xml
##
@@ -185,7 +185,15 @@
${basedir}/target/site/examples
- src/examples
+
src/test/java/org/apache/hc/core5/http/examples
Review comment:
I must have messed up the squashing. I think it is easier to squash in GH
when you merge. Can we do it that way?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] garydgregory commented on a change in pull request #105: [HTTPCORE-572] Move examples to the src/test folders for each module.
garydgregory commented on a change in pull request #105: [HTTPCORE-572] Move
examples to the src/test folders for each module.
URL:
https://github.com/apache/httpcomponents-core/pull/105#discussion_r256618310
##
File path: pom.xml
##
@@ -185,7 +185,15 @@
${basedir}/target/site/examples
- src/examples
+
src/test/java/org/apache/hc/core5/http/examples
Review comment:
@ok2c ,
Thank you for the review. I committed your requested changes.
Gary
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
