[GitHub] httpclient issue #75: Add Brotli support

[garydgregory]

Github user garydgregory commented on the issue:

https://github.com/apache/httpclient/pull/75
  
Tracking through a new ticket here: 
https://issues.apache.org/jira/browse/HTTPCLIENT-1843


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

[GitHub] httpclient issue #75: Add Brotli support

[pmouawad]

Github user pmouawad commented on the issue:

https://github.com/apache/httpclient/pull/75
  
Hello,
As advised by Oleg and Gary, I opened a PR towards commons-compress.

Regards


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

Re: [GitHub] httpclient issue #75: Add Brotli support

[Gary Gregory]

In general, we do not want to create additional dependencies. I think it
would be nice to have an optional dependency on Apache Commons Compress to
deflate/compress whatever Apache Commons Compress supports.

On Mon, May 1, 2017 at 1:37 PM, pmouawad  wrote:

> Github user pmouawad commented on the issue:
>
> https://github.com/apache/httpclient/pull/75
>
> Hi Gary,
> Oleg mentioned commons-codec.
>
> By the way, why does HC not rely on deflate decompressor in
> commons-compress?
>
> Thanks
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
> For additional commands, e-mail: dev-h...@hc.apache.org
>
>


-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition



JUnit in Action, Second Edition



Spring Batch in Action


Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

[GitHub] httpclient issue #75: Add Brotli support

[pmouawad]

Github user pmouawad commented on the issue:

https://github.com/apache/httpclient/pull/75
  
Hi Gary,
Oleg mentioned commons-codec.

By the way, why does HC not rely on deflate decompressor in 
commons-compress?

Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

[GitHub] httpclient issue #75: Add Brotli support

[garydgregory]

Github user garydgregory commented on the issue:

https://github.com/apache/httpclient/pull/75
  
Oops, wrong project, can you please patch against Apache Commons Compress? 
https://github.com/apache/commons-compress

Thank you,
Gary


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

[GitHub] httpclient issue #75: Add Brotli support

[pmouawad]

Github user pmouawad commented on the issue:

https://github.com/apache/httpclient/pull/75
  
Hi @garydgregory ,
See https://github.com/apache/commons-codec/pull/6

Regards


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

[GitHub] httpclient issue #75: Add Brotli support

[garydgregory]

Github user garydgregory commented on the issue:

https://github.com/apache/httpclient/pull/75
  
We're all good :-) I only intended to mention the project is alive and well 
:-) And I meant to say Apache Commons Compress 
(https://commons.apache.org/proper/commons-compress/), not Codec. Doh!

WRT PR, the process is the same as here. 

You can create a JIRA here 
https://issues.apache.org/jira/browse/COMPRESS/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel

And push PRs here https://github.com/apache/commons-compress

The difference with HC is that Commons Compress has made the move to Git 
within the Apache infrastructure.

Gary


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

[GitHub] httpclient issue #75: Add Brotli support

[pmouawad]

Github user pmouawad commented on the issue:

https://github.com/apache/httpclient/pull/75
  
Hi @garydgregory ,
Don't get me wrong, I never intended to say commons-codec was not alive :-)

If you give me some tips on how I should proceed to integrate feature in 
commons-codec, I'll be happy to submit a PR.

Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

[GitHub] httpclient issue #75: Add Brotli support

[garydgregory]

Github user garydgregory commented on the issue:

https://github.com/apache/httpclient/pull/75
  
Commons Codec is alive and well and released fairly regularly. Disclosure: 
I am the project chair over at Apache Commons. Feel free to create a Jira or PR 
in Common Compress ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

[GitHub] httpclient issue #75: Add Brotli support

[ok2c]

Github user ok2c commented on the issue:

https://github.com/apache/httpclient/pull/75
  
What we can do is to add org.brotli:dec as an optional dependency 
(mandatory at compile and optional at runtime) and wire it up _only_ if it is 
actually on the classpath. Users would need to explicitly add the library to 
the POM in order to enable it. This technique is widely used, for instance, by 
Spring to reduce its runtime footprint. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

[GitHub] httpclient issue #75: Add Brotli support

[pmouawad]

Github user pmouawad commented on the issue:

https://github.com/apache/httpclient/pull/75
  
Hello @ok2c ,
It appears to me gzip, deflate are standards and as such included in HC, as 
brotli will soon become the 3rd standard (I notice main browsers send it in 
Accept-Encoding) , if we follow current policy brotli should be included.

I doubt commons-compress will contain it alone soon, it will be a bridge as 
Gary suggested, so dec will be a dependency anyway.

I think the most built-in behaviour you provide the better it is for users 
, but as you like.

Regards
Philippe M.
@philmdot


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

[GitHub] httpclient issue #75: Add Brotli support

[ok2c]

Github user ok2c commented on the issue:

https://github.com/apache/httpclient/pull/75
  
@pmouawad I am not sure it is a good idea to introduce a hard dependency on 
an external library for a single decompression codec, especially given it is 
quite easy to plug it in with HttpClientBuilder. If the brotli codec were 
supported by Commons Codec it would be easier to add it to the default 
configuration. 

```
LinkedHashMap contentDecoderMap = new 
LinkedHashMap<>();
contentDecoderMap.put("gzip", new InputStreamFactory() {

@Override
public InputStream create(final InputStream instream) throws 
IOException {
return new GZIPInputStream(instream);
}

});
contentDecoderMap.put("br", new InputStreamFactory() {

@Override
public InputStream create(final InputStream instream) throws 
IOException {
return new BrotliInputStream(instream);
}

});
CloseableHttpClient httpclient = HttpClients.custom()
.setContentDecoderRegistry(contentDecoderMap)
.build();
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org