[jira] [Commented] (HTTPCLIENT-1952) Allow default User Agent to be disabled

2018-12-05 Thread Michael Osipov (JIRA)


[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709727#comment-16709727
 ] 

Michael Osipov commented on HTTPCLIENT-1952:


My proposal would be to add {{HttpClientBuilder#disableDefaultUserAgent()}} and 
test for that boolean in line 1045 where the default user agent is rertrieved 
in the case where {{userAgentCopy}} is null.

> Allow default User Agent to be disabled
> ---
>
> Key: HTTPCLIENT-1952
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1952
> Project: HttpComponents HttpClient
>  Issue Type: Improvement
>  Components: HttpCache
>Affects Versions: 4.5.6
>Reporter: Antony Bowesman
>Priority: Minor
>
> There is no way to disable the User-Agent header. In any kind of micro 
> service architecture, where UA header is irrelevant, the header cannot be 
> removed.
> This has been seen as an issue using JMeter, see link
> [https://bz.apache.org/bugzilla/show_bug.cgi?id=62977#c1]
> See comment #1 there from [~michael-o] 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



[jira] [Commented] (HTTPCLIENT-1952) Allow default User Agent to be disabled

2018-12-05 Thread Oleg Kalnichevski (JIRA)


[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710043#comment-16710043
 ] 

Oleg Kalnichevski commented on HTTPCLIENT-1952:
---

{quote} There is no way to disable the User-Agent header. 
{quote}

This is not quite correct

{code:java}
CloseableHttpClient client = HttpClients.custom()
.addInterceptorLast((HttpRequestInterceptor) (request, context) -> {
request.removeHeaders(HttpHeaders.USER_AGENT);
}).build();
{code}

One can also define their own custom {{HttpProcessor}} without 
{{RequestUserAgent}} interceptor if need be.

Oleg

> Allow default User Agent to be disabled
> ---
>
> Key: HTTPCLIENT-1952
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1952
> Project: HttpComponents HttpClient
>  Issue Type: Improvement
>  Components: HttpCache
>Affects Versions: 4.5.6
>Reporter: Antony Bowesman
>Priority: Minor
>
> There is no way to disable the User-Agent header. In any kind of micro 
> service architecture, where UA header is irrelevant, the header cannot be 
> removed.
> This has been seen as an issue using JMeter, see link
> [https://bz.apache.org/bugzilla/show_bug.cgi?id=62977#c1]
> See comment #1 there from [~michael-o] 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



[jira] [Commented] (HTTPCLIENT-1952) Allow default User Agent to be disabled

2018-12-05 Thread Michael Osipov (JIRA)


[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710225#comment-16710225
 ] 

Michael Osipov commented on HTTPCLIENT-1952:


This is what I recommended in the upstream ticket. But I still think that a 
setter is easier and cleaner.

> Allow default User Agent to be disabled
> ---
>
> Key: HTTPCLIENT-1952
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1952
> Project: HttpComponents HttpClient
>  Issue Type: Improvement
>  Components: HttpCache
>Affects Versions: 4.5.6
>Reporter: Antony Bowesman
>Priority: Minor
>
> There is no way to disable the User-Agent header. In any kind of micro 
> service architecture, where UA header is irrelevant, the header cannot be 
> removed.
> This has been seen as an issue using JMeter, see link
> [https://bz.apache.org/bugzilla/show_bug.cgi?id=62977#c1]
> See comment #1 there from [~michael-o] 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



[jira] [Commented] (HTTPCLIENT-1952) Allow default User Agent to be disabled

2018-12-05 Thread Gary Gregory (JIRA)


[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710351#comment-16710351
 ] 

Gary Gregory commented on HTTPCLIENT-1952:
--

Or we could redefine what it means to pass {{null}} to {{setUserAgent()}}, it 
seems OK to me to say "null means ignore".

Gary

> Allow default User Agent to be disabled
> ---
>
> Key: HTTPCLIENT-1952
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1952
> Project: HttpComponents HttpClient
>  Issue Type: Improvement
>  Components: HttpCache
>Affects Versions: 4.5.6
>Reporter: Antony Bowesman
>Priority: Minor
>
> There is no way to disable the User-Agent header. In any kind of micro 
> service architecture, where UA header is irrelevant, the header cannot be 
> removed.
> This has been seen as an issue using JMeter, see link
> [https://bz.apache.org/bugzilla/show_bug.cgi?id=62977#c1]
> See comment #1 there from [~michael-o] 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



[jira] [Commented] (HTTPCLIENT-1952) Allow default User Agent to be disabled

2018-12-05 Thread Michael Osipov (JIRA)


[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710436#comment-16710436
 ] 

Michael Osipov commented on HTTPCLIENT-1952:


[~garydgregory], having {{Header: }} is a valid case. I'd really would expect 
the client to tell explicitly that he/she doesn't want the user agent.

> Allow default User Agent to be disabled
> ---
>
> Key: HTTPCLIENT-1952
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1952
> Project: HttpComponents HttpClient
>  Issue Type: Improvement
>  Components: HttpCache
>Affects Versions: 4.5.6
>Reporter: Antony Bowesman
>Priority: Minor
>
> There is no way to disable the User-Agent header. In any kind of micro 
> service architecture, where UA header is irrelevant, the header cannot be 
> removed.
> This has been seen as an issue using JMeter, see link
> [https://bz.apache.org/bugzilla/show_bug.cgi?id=62977#c1]
> See comment #1 there from [~michael-o] 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



[jira] [Commented] (HTTPCLIENT-1952) Allow default User Agent to be disabled

2018-12-05 Thread Michael Osipov (JIRA)


[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710443#comment-16710443
 ] 

Michael Osipov commented on HTTPCLIENT-1952:


Related to https://bz.apache.org/bugzilla/show_bug.cgi?id=62279.

> Allow default User Agent to be disabled
> ---
>
> Key: HTTPCLIENT-1952
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1952
> Project: HttpComponents HttpClient
>  Issue Type: Improvement
>  Components: HttpCache
>Affects Versions: 4.5.6
>Reporter: Antony Bowesman
>Priority: Minor
>
> There is no way to disable the User-Agent header. In any kind of micro 
> service architecture, where UA header is irrelevant, the header cannot be 
> removed.
> This has been seen as an issue using JMeter, see link
> [https://bz.apache.org/bugzilla/show_bug.cgi?id=62977#c1]
> See comment #1 there from [~michael-o] 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



[jira] [Commented] (HTTPCLIENT-1952) Allow default User Agent to be disabled

2018-12-05 Thread Gary Gregory (JIRA)


[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710464#comment-16710464
 ] 

Gary Gregory commented on HTTPCLIENT-1952:
--

That brings up the general case: Should we have a more general setting like 
{{enableHeader(String headerName, boolean enable)}}, so you could say 
{{enableHeader("User-Agent", false)}} where there is a suitable String constant 
someplace in HttpCore or Client.

Gary

> Allow default User Agent to be disabled
> ---
>
> Key: HTTPCLIENT-1952
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1952
> Project: HttpComponents HttpClient
>  Issue Type: Improvement
>  Components: HttpCache
>Affects Versions: 4.5.6
>Reporter: Antony Bowesman
>Priority: Minor
>
> There is no way to disable the User-Agent header. In any kind of micro 
> service architecture, where UA header is irrelevant, the header cannot be 
> removed.
> This has been seen as an issue using JMeter, see link
> [https://bz.apache.org/bugzilla/show_bug.cgi?id=62977#c1]
> See comment #1 there from [~michael-o] 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



[jira] [Commented] (HTTPCLIENT-1952) Allow default User Agent to be disabled

2018-12-05 Thread Antony Bowesman (JIRA)


[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710571#comment-16710571
 ] 

Antony Bowesman commented on HTTPCLIENT-1952:
-

I agree with Michael, that having an empty header is a valid use case. I've 
dealt with projects where they used headers as flags. In one library I used, I 
had to make that header a single space, as it removed headers that had no value.

The ABNF in RFC7230 also defines the field value as
field-value= *( field-content / obs-fold )
which would indicate that empty values are valid.

> Allow default User Agent to be disabled
> ---
>
> Key: HTTPCLIENT-1952
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1952
> Project: HttpComponents HttpClient
>  Issue Type: Improvement
>  Components: HttpCache
>Affects Versions: 4.5.6
>Reporter: Antony Bowesman
>Priority: Minor
>
> There is no way to disable the User-Agent header. In any kind of micro 
> service architecture, where UA header is irrelevant, the header cannot be 
> removed.
> This has been seen as an issue using JMeter, see link
> [https://bz.apache.org/bugzilla/show_bug.cgi?id=62977#c1]
> See comment #1 there from [~michael-o] 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



[jira] [Commented] (HTTPCLIENT-1952) Allow default User Agent to be disabled

2018-12-05 Thread Michael Osipov (JIRA)


[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710576#comment-16710576
 ] 

Michael Osipov commented on HTTPCLIENT-1952:


I'd say no because there is only a limited amounts of headers added by the 
httpclient. The rest is added deliberately by client code. This is a special 
default header.

> Allow default User Agent to be disabled
> ---
>
> Key: HTTPCLIENT-1952
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1952
> Project: HttpComponents HttpClient
>  Issue Type: Improvement
>  Components: HttpCache
>Affects Versions: 4.5.6
>Reporter: Antony Bowesman
>Priority: Minor
>
> There is no way to disable the User-Agent header. In any kind of micro 
> service architecture, where UA header is irrelevant, the header cannot be 
> removed.
> This has been seen as an issue using JMeter, see link
> [https://bz.apache.org/bugzilla/show_bug.cgi?id=62977#c1]
> See comment #1 there from [~michael-o] 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



[jira] [Commented] (HTTPCLIENT-1952) Allow default User Agent to be disabled

2018-12-05 Thread Gary Gregory (JIRA)


[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710624#comment-16710624
 ] 

Gary Gregory commented on HTTPCLIENT-1952:
--

Well, can someone propose a PR? ;-) With tests double ;-)

> Allow default User Agent to be disabled
> ---
>
> Key: HTTPCLIENT-1952
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1952
> Project: HttpComponents HttpClient
>  Issue Type: Improvement
>  Components: HttpCache
>Affects Versions: 4.5.6
>Reporter: Antony Bowesman
>Priority: Minor
>
> There is no way to disable the User-Agent header. In any kind of micro 
> service architecture, where UA header is irrelevant, the header cannot be 
> removed.
> This has been seen as an issue using JMeter, see link
> [https://bz.apache.org/bugzilla/show_bug.cgi?id=62977#c1]
> See comment #1 there from [~michael-o] 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



[jira] [Commented] (HTTPCLIENT-1952) Allow default User Agent to be disabled

2018-12-05 Thread Michael Osipov (JIRA)


[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710635#comment-16710635
 ] 

Michael Osipov commented on HTTPCLIENT-1952:


Will do tomorrow

> Allow default User Agent to be disabled
> ---
>
> Key: HTTPCLIENT-1952
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1952
> Project: HttpComponents HttpClient
>  Issue Type: Improvement
>  Components: HttpCache
>Affects Versions: 4.5.6
>Reporter: Antony Bowesman
>Priority: Minor
>
> There is no way to disable the User-Agent header. In any kind of micro 
> service architecture, where UA header is irrelevant, the header cannot be 
> removed.
> This has been seen as an issue using JMeter, see link
> [https://bz.apache.org/bugzilla/show_bug.cgi?id=62977#c1]
> See comment #1 there from [~michael-o] 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



[jira] [Commented] (HTTPCLIENT-1952) Allow default User Agent to be disabled

2018-12-23 Thread Michael Osipov (JIRA)


[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728044#comment-16728044
 ] 

Michael Osipov commented on HTTPCLIENT-1952:


I have now opened a PR for 5.0. No tests yet since I am not familiar where is 
the best place to test that.

> Allow default User Agent to be disabled
> ---
>
> Key: HTTPCLIENT-1952
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1952
> Project: HttpComponents HttpClient
>  Issue Type: Improvement
>  Components: HttpCache
>Affects Versions: 4.5.6
>Reporter: Antony Bowesman
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 4.5.7, 5.0 Beta4
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> There is no way to disable the User-Agent header. In any kind of micro 
> service architecture, where UA header is irrelevant, the header cannot be 
> removed.
> This has been seen as an issue using JMeter, see link
> [https://bz.apache.org/bugzilla/show_bug.cgi?id=62977#c1]
> See comment #1 there from [~michael-o] 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



[jira] [Commented] (HTTPCLIENT-1952) Allow default User Agent to be disabled

2018-12-23 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728043#comment-16728043
 ] 

ASF subversion and git services commented on HTTPCLIENT-1952:
-

Commit d252500411d7568e4453242c6db95e4d07444703 in httpcomponents-client's 
branch refs/heads/HTTPCLIENT-1952_5.0 from Michael Osipov
[ https://gitbox.apache.org/repos/asf?p=httpcomponents-client.git;h=d252500 ]

[HTTPCLIENT-1952] Allow default User Agent to be disabled


> Allow default User Agent to be disabled
> ---
>
> Key: HTTPCLIENT-1952
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1952
> Project: HttpComponents HttpClient
>  Issue Type: Improvement
>  Components: HttpCache
>Affects Versions: 4.5.6
>Reporter: Antony Bowesman
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 4.5.7, 5.0 Beta4
>
>
> There is no way to disable the User-Agent header. In any kind of micro 
> service architecture, where UA header is irrelevant, the header cannot be 
> removed.
> This has been seen as an issue using JMeter, see link
> [https://bz.apache.org/bugzilla/show_bug.cgi?id=62977#c1]
> See comment #1 there from [~michael-o] 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



[jira] [Commented] (HTTPCLIENT-1952) Allow default User Agent to be disabled

2018-12-23 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728053#comment-16728053
 ] 

ASF subversion and git services commented on HTTPCLIENT-1952:
-

Commit 2017fc74e4a5df67083886ecdb553564e5747f8f in httpcomponents-client's 
branch refs/heads/HTTPCLIENT-1952_5.0 from Michael Osipov
[ https://gitbox.apache.org/repos/asf?p=httpcomponents-client.git;h=2017fc7 ]

[HTTPCLIENT-1952] Allow default User Agent to be disabled


> Allow default User Agent to be disabled
> ---
>
> Key: HTTPCLIENT-1952
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1952
> Project: HttpComponents HttpClient
>  Issue Type: Improvement
>  Components: HttpCache
>Affects Versions: 4.5.6
>Reporter: Antony Bowesman
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 4.5.7, 5.0 Beta4
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> There is no way to disable the User-Agent header. In any kind of micro 
> service architecture, where UA header is irrelevant, the header cannot be 
> removed.
> This has been seen as an issue using JMeter, see link
> [https://bz.apache.org/bugzilla/show_bug.cgi?id=62977#c1]
> See comment #1 there from [~michael-o] 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



[jira] [Commented] (HTTPCLIENT-1952) Allow default User Agent to be disabled

2018-12-23 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728067#comment-16728067
 ] 

ASF subversion and git services commented on HTTPCLIENT-1952:
-

Commit 354ae3586ebb2557fece463c322cf2d1cc128baa in httpcomponents-client's 
branch refs/heads/master from Michael Osipov
[ https://gitbox.apache.org/repos/asf?p=httpcomponents-client.git;h=354ae35 ]

[HTTPCLIENT-1952] Allow default User Agent to be disabled

This closes #128


> Allow default User Agent to be disabled
> ---
>
> Key: HTTPCLIENT-1952
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1952
> Project: HttpComponents HttpClient
>  Issue Type: Improvement
>  Components: HttpCache
>Affects Versions: 4.5.6
>Reporter: Antony Bowesman
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 4.5.7, 5.0 Beta4
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> There is no way to disable the User-Agent header. In any kind of micro 
> service architecture, where UA header is irrelevant, the header cannot be 
> removed.
> This has been seen as an issue using JMeter, see link
> [https://bz.apache.org/bugzilla/show_bug.cgi?id=62977#c1]
> See comment #1 there from [~michael-o] 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



[jira] [Commented] (HTTPCLIENT-1952) Allow default User Agent to be disabled

2018-12-23 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728064#comment-16728064
 ] 

ASF subversion and git services commented on HTTPCLIENT-1952:
-

Commit eba3b9eda4a50182617ee24e8ef4ca63cd0011be in httpcomponents-client's 
branch refs/heads/HTTPCLIENT-1952_5.0 from Michael Osipov
[ https://gitbox.apache.org/repos/asf?p=httpcomponents-client.git;h=eba3b9e ]

[HTTPCLIENT-1952] Allow default User Agent to be disabled

This closes #128


> Allow default User Agent to be disabled
> ---
>
> Key: HTTPCLIENT-1952
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1952
> Project: HttpComponents HttpClient
>  Issue Type: Improvement
>  Components: HttpCache
>Affects Versions: 4.5.6
>Reporter: Antony Bowesman
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 4.5.7, 5.0 Beta4
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> There is no way to disable the User-Agent header. In any kind of micro 
> service architecture, where UA header is irrelevant, the header cannot be 
> removed.
> This has been seen as an issue using JMeter, see link
> [https://bz.apache.org/bugzilla/show_bug.cgi?id=62977#c1]
> See comment #1 there from [~michael-o] 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



[jira] [Commented] (HTTPCLIENT-1952) Allow default User Agent to be disabled

2018-12-23 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728065#comment-16728065
 ] 

ASF subversion and git services commented on HTTPCLIENT-1952:
-

Commit 354ae3586ebb2557fece463c322cf2d1cc128baa in httpcomponents-client's 
branch refs/heads/HTTPCLIENT-1952_5.0 from Michael Osipov
[ https://gitbox.apache.org/repos/asf?p=httpcomponents-client.git;h=354ae35 ]

[HTTPCLIENT-1952] Allow default User Agent to be disabled

This closes #128


> Allow default User Agent to be disabled
> ---
>
> Key: HTTPCLIENT-1952
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1952
> Project: HttpComponents HttpClient
>  Issue Type: Improvement
>  Components: HttpCache
>Affects Versions: 4.5.6
>Reporter: Antony Bowesman
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 4.5.7, 5.0 Beta4
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> There is no way to disable the User-Agent header. In any kind of micro 
> service architecture, where UA header is irrelevant, the header cannot be 
> removed.
> This has been seen as an issue using JMeter, see link
> [https://bz.apache.org/bugzilla/show_bug.cgi?id=62977#c1]
> See comment #1 there from [~michael-o] 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



[jira] [Commented] (HTTPCLIENT-1952) Allow default User Agent to be disabled

2018-12-23 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728071#comment-16728071
 ] 

ASF subversion and git services commented on HTTPCLIENT-1952:
-

Commit f04d81e3026c143f2764b10c2f83f85f5c1b3d3c in httpcomponents-client's 
branch refs/heads/HTTPCLIENT-1952_4.5 from Michael Osipov
[ https://gitbox.apache.org/repos/asf?p=httpcomponents-client.git;h=f04d81e ]

[HTTPCLIENT-1952] Allow default User Agent to be disabled


> Allow default User Agent to be disabled
> ---
>
> Key: HTTPCLIENT-1952
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1952
> Project: HttpComponents HttpClient
>  Issue Type: Improvement
>  Components: HttpCache
>Affects Versions: 4.5.6
>Reporter: Antony Bowesman
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 4.5.7, 5.0 Beta4
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> There is no way to disable the User-Agent header. In any kind of micro 
> service architecture, where UA header is irrelevant, the header cannot be 
> removed.
> This has been seen as an issue using JMeter, see link
> [https://bz.apache.org/bugzilla/show_bug.cgi?id=62977#c1]
> See comment #1 there from [~michael-o] 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



[jira] [Commented] (HTTPCLIENT-1952) Allow default User Agent to be disabled

2018-12-23 Thread Michael Osipov (JIRA)


[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728073#comment-16728073
 ] 

Michael Osipov commented on HTTPCLIENT-1952:


Implemented in master and 4.5.x.

> Allow default User Agent to be disabled
> ---
>
> Key: HTTPCLIENT-1952
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1952
> Project: HttpComponents HttpClient
>  Issue Type: Improvement
>  Components: HttpCache
>Affects Versions: 4.5.6
>Reporter: Antony Bowesman
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 4.5.7, 5.0 Beta4
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> There is no way to disable the User-Agent header. In any kind of micro 
> service architecture, where UA header is irrelevant, the header cannot be 
> removed.
> This has been seen as an issue using JMeter, see link
> [https://bz.apache.org/bugzilla/show_bug.cgi?id=62977#c1]
> See comment #1 there from [~michael-o] 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



[jira] [Commented] (HTTPCLIENT-1952) Allow default User Agent to be disabled

2018-12-23 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728072#comment-16728072
 ] 

ASF subversion and git services commented on HTTPCLIENT-1952:
-

Commit f04d81e3026c143f2764b10c2f83f85f5c1b3d3c in httpcomponents-client's 
branch refs/heads/4.5.x from Michael Osipov
[ https://gitbox.apache.org/repos/asf?p=httpcomponents-client.git;h=f04d81e ]

[HTTPCLIENT-1952] Allow default User Agent to be disabled


> Allow default User Agent to be disabled
> ---
>
> Key: HTTPCLIENT-1952
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1952
> Project: HttpComponents HttpClient
>  Issue Type: Improvement
>  Components: HttpCache
>Affects Versions: 4.5.6
>Reporter: Antony Bowesman
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 4.5.7, 5.0 Beta4
>
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> There is no way to disable the User-Agent header. In any kind of micro 
> service architecture, where UA header is irrelevant, the header cannot be 
> removed.
> This has been seen as an issue using JMeter, see link
> [https://bz.apache.org/bugzilla/show_bug.cgi?id=62977#c1]
> See comment #1 there from [~michael-o] 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org