[jira] [Commented] (HTTPCORE-511) Do not cache result of Runtime.getRuntime().availableProcessors() in IOReactorConfig
[ https://issues.apache.org/jira/browse/HTTPCORE-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355617#comment-16355617 ] ASF subversion and git services commented on HTTPCORE-511: -- Commit 07f436a5a5ec0bc87e7213531076be461848d2e2 in httpcomponents-core's branch refs/heads/master from [~garydgregory] [ https://git-wip-us.apache.org/repos/asf?p=httpcomponents-core.git;h=07f436a ] [HTTPCORE-510] Avoid an ArithmeticException in AbstractMultiworkerIOReactor by failing earlier by checking ioThreadCount in IOReactorConfig constructor. [HTTPCORE-511] Do not cache result of Runtime.getRuntime().availableProcessors() in IOReactorConfig. > Do not cache result of Runtime.getRuntime().availableProcessors() in > IOReactorConfig > > > Key: HTTPCORE-511 > URL: https://issues.apache.org/jira/browse/HTTPCORE-511 > Project: HttpComponents HttpCore > Issue Type: Improvement > Components: HttpCore NIO >Reporter: Gary Gregory >Assignee: Gary Gregory >Priority: Major > Fix For: 4.4.10, 5.0-beta3 > > > Do not cache the result of {{Runtime.getRuntime().availableProcessors()}} in > {{IOReactorConfig}} since the result value can change. For example, some > virtualization software let you change the number of virtual CPUs while the > VM is running. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCORE-511) Do not cache result of Runtime.getRuntime().availableProcessors() in IOReactorConfig
[ https://issues.apache.org/jira/browse/HTTPCORE-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16354458#comment-16354458 ] Gary Gregory commented on HTTPCORE-511: --- Thanks for the heads up [~s...@apache.org]. Not that this change is only effective when a new {{IOReactorConfig}} object is created. I do _not_ propose in this ticket to dynamically resize our pools based on some metric relative to the number of CPUs available. > Do not cache result of Runtime.getRuntime().availableProcessors() in > IOReactorConfig > > > Key: HTTPCORE-511 > URL: https://issues.apache.org/jira/browse/HTTPCORE-511 > Project: HttpComponents HttpCore > Issue Type: Improvement > Components: HttpCore NIO >Reporter: Gary Gregory >Assignee: Gary Gregory >Priority: Major > Fix For: 4.4.10, 5.0-beta3 > > > Do not cache the result of {{Runtime.getRuntime().availableProcessors()}} in > {{IOReactorConfig}} since the result value can change. For example, some > virtualization software let you change the number of virtual CPUs while the > VM is running. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCORE-511) Do not cache result of Runtime.getRuntime().availableProcessors() in IOReactorConfig
[ https://issues.apache.org/jira/browse/HTTPCORE-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16354441#comment-16354441 ] Sebb commented on HTTPCORE-511: --- FTR: many physical multi-cpu systems also allow CPUs to be added to or removed from the available pool. > Do not cache result of Runtime.getRuntime().availableProcessors() in > IOReactorConfig > > > Key: HTTPCORE-511 > URL: https://issues.apache.org/jira/browse/HTTPCORE-511 > Project: HttpComponents HttpCore > Issue Type: Improvement > Components: HttpCore NIO >Reporter: Gary Gregory >Assignee: Gary Gregory >Priority: Major > Fix For: 4.4.10, 5.0-beta3 > > > Do not cache the result of {{Runtime.getRuntime().availableProcessors()}} in > {{IOReactorConfig}} since the result value can change. For example, some > virtualization software let you change the number of virtual CPUs while the > VM is running. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCORE-511) Do not cache result of Runtime.getRuntime().availableProcessors() in IOReactorConfig
[ https://issues.apache.org/jira/browse/HTTPCORE-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16354436#comment-16354436 ] ASF subversion and git services commented on HTTPCORE-511: -- Commit 8d938a656f0db340b255112f0e97ae71e06e7886 in httpcomponents-core's branch refs/heads/master from [~garydgregory] [ https://git-wip-us.apache.org/repos/asf?p=httpcomponents-core.git;h=8d938a6 ] [HTTPCORE-511] Do not cache result of Runtime.getRuntime().availableProcessors() in IOReactorConfig. > Do not cache result of Runtime.getRuntime().availableProcessors() in > IOReactorConfig > > > Key: HTTPCORE-511 > URL: https://issues.apache.org/jira/browse/HTTPCORE-511 > Project: HttpComponents HttpCore > Issue Type: Improvement > Components: HttpCore NIO >Reporter: Gary Gregory >Assignee: Gary Gregory >Priority: Major > Fix For: 4.4.10, 5.0-beta3 > > > Do not cache the result of {{Runtime.getRuntime().availableProcessors()}} in > {{IOReactorConfig}} since the result value can change. For example, some > virtualization software let you change the number of virtual CPUs while the > VM is running. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCORE-511) Do not cache result of Runtime.getRuntime().availableProcessors() in IOReactorConfig
[ https://issues.apache.org/jira/browse/HTTPCORE-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16354435#comment-16354435 ] ASF subversion and git services commented on HTTPCORE-511: -- Commit b1b71bf0cc819e6690cf0a26e8d78027bd1f24a3 in httpcomponents-core's branch refs/heads/4.4.x from [~garydgregory] [ https://git-wip-us.apache.org/repos/asf?p=httpcomponents-core.git;h=b1b71bf ] [HTTPCORE-511] Do not cache result of Runtime.getRuntime().availableProcessors() in IOReactorConfig. > Do not cache result of Runtime.getRuntime().availableProcessors() in > IOReactorConfig > > > Key: HTTPCORE-511 > URL: https://issues.apache.org/jira/browse/HTTPCORE-511 > Project: HttpComponents HttpCore > Issue Type: Improvement > Components: HttpCore NIO >Reporter: Gary Gregory >Assignee: Gary Gregory >Priority: Major > > Do not cache the result of {{Runtime.getRuntime().availableProcessors()}} in > {{IOReactorConfig}} since the result value can change. For example, some > virtualization software let you change the number of virtual CPUs while the > VM is running. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org