Tim te Beek created HTTPCLIENT-2187:
---------------------------------------
Summary: Classic proxy handling for HTTPS seems broken as of 5.1.1+
Key: HTTPCLIENT-2187
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2187
Project: HttpComponents HttpClient
Issue Type: Bug
Components: HttpClient (classic)
Affects Versions: 5.2-alpha1, 5.1.2, 5.1.1
Reporter: Tim te Beek
Classic proxy handling for HTTPS seems to have broken as of 5.1.1+, as seen
here: https://github.com/wiremock/wiremock/pull/1698
To give just one sample, we now see a failure stacktrace such as this:
```
java.lang.IllegalStateException: Endpoint is not connected
at org.apache.hc.core5.util.Asserts.check(Asserts.java:38)
at
org.apache.hc.client5.http.impl.io.PoolingHttpClientConnectionManager$InternalConnectionEndpoint.getValidatedPoolEntry(PoolingHttpClientConnectionManager.java:637)
at
org.apache.hc.client5.http.impl.io.PoolingHttpClientConnectionManager.upgrade(PoolingHttpClientConnectionManager.java:454)
at
org.apache.hc.client5.http.impl.classic.InternalExecRuntime.upgradeTls(InternalExecRuntime.java:190)
at
org.apache.hc.client5.http.impl.classic.ConnectExec.execute(ConnectExec.java:172)
at
org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
at
org.apache.hc.client5.http.impl.classic.ProtocolExec.execute(ProtocolExec.java:197)
at
org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
at
org.apache.hc.client5.http.impl.classic.InternalHttpClient.doExecute(InternalHttpClient.java:170)
at
org.apache.hc.client5.http.impl.classic.CloseableHttpClient.execute(CloseableHttpClient.java:75)
at
org.apache.hc.client5.http.impl.classic.CloseableHttpClient.execute(CloseableHttpClient.java:89)
at
com.github.tomakehurst.wiremock.junit5.JUnitJupiterExtensionJvmProxyNonStaticProgrammaticTest.getContent(JUnitJupiterExtensionJvmProxyNonStaticProgrammaticTest.java:67)
at
com.github.tomakehurst.wiremock.junit5.JUnitJupiterExtensionJvmProxyNonStaticProgrammaticTest.configures_jvm_proxy_and_enables_browser_proxying_https(JUnitJupiterExtensionJvmProxyNonStaticProgrammaticTest.java:63)
```
That test basically calls this class to set the System proxy properties:
[https://github.com/wiremock/wiremock/blob/master/src/main/java/com/github/tomakehurst/wiremock/http/JvmProxyConfigurer.java#L48]
For HTTP that still works fine, for HTTPS it now fails.
There were some recent changes in 5.1.1 related to proxy handling & keep alive
for async:
[https://issues.apache.org/jira/projects/HTTPCLIENT/issues/HTTPCLIENT-2177]
[https://github.com/apache/httpcomponents-client/compare/50f93ec18be8d6f49138825356051c4c0b60dce4...90f69c87b27b721ea8f0e23bdb4baf92bd7cde06]
However, we're using classic still, and seeing the error above, so not sure
it's related.
Could anyone look into why we are now having these issues with only a patch
version bump?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
