[jira] [Updated] (HTTPCLIENT-1725) Heuristic caching does not work for URIs with a query string
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski updated HTTPCLIENT-1725: -- Labels: stuck volunteers-wanted (was: ) Fix Version/s: Stuck > Heuristic caching does not work for URIs with a query string > > > Key: HTTPCLIENT-1725 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1725 > Project: HttpComponents HttpClient > Issue Type: Bug > Components: HttpCache >Affects Versions: 4.5.1 >Reporter: Charlie Halford > Labels: stuck, volunteers-wanted > Fix For: Stuck > > Attachments: HTTPCLIENT-1725_add_query_string_caching.diff > > > When enabling heuristic caching and setting a default lifetime, the responses > from the server I am requesting from are not being stored in the cache. > In org.apache.http.impl.client.cache.ResponseCachingPolicy, line 250 > determines if the URI contains a query string: > {code} > request.getRequestLine().getUri().contains("?") > {code} > A few lines below, it then checks to see if the response contains cache > headers: > {code} > else if (!isExplicitlyCacheable(response)) > {code} > As I am attempting to cache a response that I know does not contain cache > headers, the response should succeed in being cached. However, it fails the > isExplictlyCachable() check, and thus returns false to the overall > isResponseCachable() method. The isExplicitlyCachable() method is checked > later on in the stack, so perhaps it can be safely removed here? -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Updated] (HTTPCLIENT-1725) Heuristic caching does not work for URIs with a query string
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charlie Halford updated HTTPCLIENT-1725: Attachment: HTTPCLIENT-1725_add_query_string_caching.diff I had a chance to take a brief look at this, and I've attached a patch against httpclient 4.5.1, and it could do with a review. > Heuristic caching does not work for URIs with a query string > > > Key: HTTPCLIENT-1725 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1725 > Project: HttpComponents HttpClient > Issue Type: Bug > Components: HttpCache >Affects Versions: 4.5.1 >Reporter: Charlie Halford > Attachments: HTTPCLIENT-1725_add_query_string_caching.diff > > > When enabling heuristic caching and setting a default lifetime, the responses > from the server I am requesting from are not being stored in the cache. > In org.apache.http.impl.client.cache.ResponseCachingPolicy, line 250 > determines if the URI contains a query string: > {code} > request.getRequestLine().getUri().contains("?") > {code} > A few lines below, it then checks to see if the response contains cache > headers: > {code} > else if (!isExplicitlyCacheable(response)) > {code} > As I am attempting to cache a response that I know does not contain cache > headers, the response should succeed in being cached. However, it fails the > isExplictlyCachable() check, and thus returns false to the overall > isResponseCachable() method. The isExplicitlyCachable() method is checked > later on in the stack, so perhaps it can be safely removed here? -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org