Re: 4.0 does not retry when connect drop?

2008-01-17 Thread Oleg Kalnichevski

On Thu, 2008-01-17 at 15:16 -0800, Jiang Qian wrote:
 Hi,
 My last email was wrong
 it actually try to re open in above the
 if (!managedConn.isOpen()) {
 managedConn.open(route, context, params);
 }
 
 Thanks
 

Jiang,

What kind of behavior do you expect? Feel free to open an issue in JIRA
if you think HttpClient does not do what it is supposed to.

I am tied up preparing the release of HttpCore. I'll look into the
problem as soon as the release has been taken care of.

Cheers

Oleg


 On Jan 17, 2008 3:00 PM, Jiang Qian [EMAIL PROTECTED] wrote:
  Hi,
 Here is what I found:
  in DefaultClientRequestDirector execute method line 348
if connection drop by server, it will throw NoHttpResponseException,
   then managedConn.close();
and this is allow to retry, so it rerun response =
  requestExec.execute(request, managedConn, context);
 
  goes to HttpRequestExecutor line 201, conn.sendRequestHeader(request);
 
  however, it seems no place to reopen the conn in side sendRequestHeader
  the AbstractHttpClientConnection which implements this method
  is
  public void sendRequestHeader(final HttpRequest request)
  throws HttpException, IOException {
  if (request == null) {
  throw new IllegalArgumentException(HTTP request may not be 
  null);
  }
  assertOpen();
  this.requestWriter.write(request);
  this.metrics.incrementRequestCount();
  }
 
  seems no where it does the re-open,
 
  Is it a bug?
 
  --
  Thanks
  http://www.youtube.com/watch?v=yCM_wQy4YVg
 
 
 
 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: 4.0 does not retry when connect drop?

2008-01-17 Thread Jiang Qian
Hi Oleg
  thanks!
  I am debugging a NoHttpResponseException issue, and my initial
thoughts was wrong, it is not related to retry.

On Jan 17, 2008 4:10 PM, Oleg Kalnichevski [EMAIL PROTECTED] wrote:

 On Thu, 2008-01-17 at 15:16 -0800, Jiang Qian wrote:
  Hi,
  My last email was wrong
  it actually try to re open in above the
  if (!managedConn.isOpen()) {
  managedConn.open(route, context, params);
  }
 
  Thanks
 

 Jiang,

 What kind of behavior do you expect? Feel free to open an issue in JIRA
 if you think HttpClient does not do what it is supposed to.

 I am tied up preparing the release of HttpCore. I'll look into the
 problem as soon as the release has been taken care of.

 Cheers

 Oleg


  On Jan 17, 2008 3:00 PM, Jiang Qian [EMAIL PROTECTED] wrote:
   Hi,
  Here is what I found:
   in DefaultClientRequestDirector execute method line 348
 if connection drop by server, it will throw NoHttpResponseException,
then managedConn.close();
 and this is allow to retry, so it rerun response =
   requestExec.execute(request, managedConn, context);
  
   goes to HttpRequestExecutor line 201, conn.sendRequestHeader(request);
  
   however, it seems no place to reopen the conn in side sendRequestHeader
   the AbstractHttpClientConnection which implements this method
   is
   public void sendRequestHeader(final HttpRequest request)
   throws HttpException, IOException {
   if (request == null) {
   throw new IllegalArgumentException(HTTP request may not be 
   null);
   }
   assertOpen();
   this.requestWriter.write(request);
   this.metrics.incrementRequestCount();
   }
  
   seems no where it does the re-open,
  
   Is it a bug?
  
   --
   Thanks
   http://www.youtube.com/watch?v=yCM_wQy4YVg
  
 
 
 


 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]





-- 
Thanks
http://www.youtube.com/watch?v=yCM_wQy4YVg

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]