Re: Parsing RFC2231 or newer spec'd data

2023-05-03 Thread Oleg Kalnichevski
On Tue, 2023-05-02 at 17:16 +, Gary D. Gregory wrote:
> On 2023/05/01 21:19:35 Michael Osipov wrote:
> > Am 2023-05-01 um 22:46 schrieb Gary Gregory:
> > > Well, that puts a nail in that coffin. Thank you for the details.
> > 
> > BUT, you have to look into Apache James which has a decent MIME
> > parser 
> > which we are using at work. I would say that it is enough to have
> > one 
> > decent lib in ASF land than multiple mediocre ones.
> 
> You're talking about Apache Mime4J [1] right?
> 
> TY,
> Gary
> [1] https://james.apache.org/download.cgi#Apache_Mime4J
> 
> 

Many, many years ago (approximately around the year 2006) the
possibility of building a full-fledged MIME support including a parser
and a message builder for HttpClient was discussed and a decision was
made to not pursue this development within HC but to collaborate with
JAMES instead

This is the earliest reference to that particular discussion I was able
to find in the archives. 


https://hc.markmail.org/search/?q=mime4j#query:mime4j%20order%3Adate-forward+page:1+mid:khybidxfseljrmr3+state:results

As a result I have contributed substantial chunks of our code to
mime4j. One can still see a lot of similarities between Mime4j and
HttpCore, by the way.

Unfortunately all these years JAMES developers were not willing to
freeze the APIs and release 1.0 version, so around HttpClient 4.0
release we had to drop the optional dependency on mime4j and replace it
with much simpler MIME code, still hoping that one day we might be able
to deprecate it in favor of mime4j.

I can only suggest that FileUpload in Commons be re-designed as a
facade to mime4j but it is just a mere suggestion.

Cheers

Oleg

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



Re: Parsing RFC2231 or newer spec'd data

2023-05-02 Thread Gary D. Gregory
On 2023/05/01 21:19:35 Michael Osipov wrote:
> Am 2023-05-01 um 22:46 schrieb Gary Gregory:
> > Well, that puts a nail in that coffin. Thank you for the details.
> 
> BUT, you have to look into Apache James which has a decent MIME parser 
> which we are using at work. I would say that it is enough to have one 
> decent lib in ASF land than multiple mediocre ones.

You're talking about Apache Mime4J [1] right?

TY,
Gary
[1] https://james.apache.org/download.cgi#Apache_Mime4J



> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
> For additional commands, e-mail: dev-h...@hc.apache.org
> 
> 

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



Re: Parsing RFC2231 or newer spec'd data

2023-05-01 Thread Michael Osipov

Am 2023-05-01 um 22:46 schrieb Gary Gregory:

Well, that puts a nail in that coffin. Thank you for the details.


BUT, you have to look into Apache James which has a decent MIME parser 
which we are using at work. I would say that it is enough to have one 
decent lib in ASF land than multiple mediocre ones.



-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



Re: Parsing RFC2231 or newer spec'd data

2023-05-01 Thread Gary Gregory
Well, that puts a nail in that coffin. Thank you for the details.

Gary


On Mon, May 1, 2023, 16:19 Michael Osipov  wrote:

> Am 2023-05-01 um 22:14 schrieb Gary D. Gregory:
> > Hi All,
> >
> > Over at Apache Commons FileUpload, I am helping to rework the code base
> for our upcoming 2.0 release. We have a whole package [1] of gnarly
> HTTP-related parsing for RFC2231 which I was hoping to replace with a
> dependency HC. (I want HC to be the reference for all things HTTP.) I see
> that we can generate forms with fields but I did not find any parsing. Did
> I miss it?
>
> There is none, since this is a client library and also a low level
> server library. Please also be aware some of the code is logically
> flawed. See: https://issues.apache.org/jira/browse/HTTPCLIENT-2159
>
> This code needs serious review. Many spots are based on wrong
> understandings.
>
> Consider that File Upload comons on top of HttpCore.
>
> M
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
> For additional commands, e-mail: dev-h...@hc.apache.org
>
>


Re: Parsing RFC2231 or newer spec'd data

2023-05-01 Thread Michael Osipov

Am 2023-05-01 um 22:14 schrieb Gary D. Gregory:

Hi All,

Over at Apache Commons FileUpload, I am helping to rework the code base for our 
upcoming 2.0 release. We have a whole package [1] of gnarly HTTP-related 
parsing for RFC2231 which I was hoping to replace with a dependency HC. (I want 
HC to be the reference for all things HTTP.) I see that we can generate forms 
with fields but I did not find any parsing. Did I miss it?


There is none, since this is a client library and also a low level 
server library. Please also be aware some of the code is logically 
flawed. See: https://issues.apache.org/jira/browse/HTTPCLIENT-2159


This code needs serious review. Many spots are based on wrong 
understandings.


Consider that File Upload comons on top of HttpCore.

M

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org